René's URL Explorer Experiment


Title: http: only destroy socket once error is sent by yannh · Pull Request #26356 · nodejs/node · GitHub

Open Graph Title: http: only destroy socket once error is sent by yannh · Pull Request #26356 · nodejs/node

X Title: http: only destroy socket once error is sent by yannh · Pull Request #26356 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This patch fixes the race condition: sometimes the socket is destroyed before the data is sent. If node is proxied by, for example, an AWS ELB, a 504 error would be returned instead of the expected...

X Description: This patch fixes the race condition: sometimes the socket is destroyed before the data is sent. If node is proxied by, for example, an AWS ELB, a 504 error would be returned instead of the expected...

Opengraph URL: https://github.com/nodejs/node/pull/26356

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3040ad83-6425-0345-82be-55139c7f5598
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5DC:F83DC:B9D41:F0C32:6990AA0F
html-safe-nonce48d0209900c6f15149d09585047f19f6d6c6791802e7e0fdee26dc9f25fa24c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENURDOkY4M0RDOkI5RDQxOkYwQzMyOjY5OTBBQTBGIiwidmlzaXRvcl9pZCI6Ijg0NzI5Mzk3NDM1MTc1MTY5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacacf7fc28796fa13f2b3e5d7acda4f99e69d86f97267f2da05a9c42dd5b165dcb
hovercard-subject-tagpull_request:257156044
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26356/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9ddfff6976713698e941d2444458a454dbe106c602edc32857823987a999b0ba/nodejs/node/pull/26356
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9ddfff6976713698e941d2444458a454dbe106c602edc32857823987a999b0ba/nodejs/node/pull/26356
og:image:altThis patch fixes the race condition: sometimes the socket is destroyed before the data is sent. If node is proxied by, for example, an AWS ELB, a 504 error would be returned instead of the expected...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyannh
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26356#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26356
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26356
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26356
Reloadhttps://github.com/nodejs/node/pull/26356
Reloadhttps://github.com/nodejs/node/pull/26356
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26356
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 704 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
yannhhttps://github.com/yannh
nodejs:masterhttps://github.com/nodejs/node/tree/master
yannh:clean_conn_close_on_client_errorhttps://github.com/yannh/node/tree/clean_conn_close_on_client_error
Conversationhttps://github.com/nodejs/node/pull/26356
Commits1 (1)https://github.com/nodejs/node/pull/26356/commits
Checkshttps://github.com/nodejs/node/pull/26356/checks
Files changedhttps://github.com/nodejs/node/pull/26356/files
http: only destroy socket once error is senthttps://github.com/nodejs/node/pull/26356#top
yannhhttps://github.com/yannh
nodejs:masterhttps://github.com/nodejs/node/tree/master
yannh:clean_conn_close_on_client_errorhttps://github.com/yannh/node/tree/clean_conn_close_on_client_error
https://github.com/yannh
yannhhttps://github.com/yannh
Feb 28, 2019https://github.com/nodejs/node/pull/26356#issue-415732068
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26356
https://github.com/yannh
http: only destroy socket once error is senthttps://github.com/nodejs/node/pull/26356/commits/1d397423ef0c12becb9f6f0e8e23728081270053
1d39742https://github.com/nodejs/node/pull/26356/commits/1d397423ef0c12becb9f6f0e8e23728081270053
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Feb 28, 2019https://github.com/nodejs/node/pull/26356#event-2171732395
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Feb 28, 2019 https://github.com/nodejs/node/pull/26356#pullrequestreview-209203067
View reviewed changes https://github.com/nodejs/node/pull/26356/files/1d397423ef0c12becb9f6f0e8e23728081270053
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/26356#pullrequestreview-209203067
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26356
https://github.com/lpinca
lpincahttps://github.com/lpinca
Feb 28, 2019https://github.com/nodejs/node/pull/26356#issuecomment-468432854
#24757https://github.com/nodejs/node/pull/24757
Please reload this pagehttps://github.com/nodejs/node/pull/26356
https://github.com/lpinca
lpincahttps://github.com/lpinca
Feb 28, 2019https://github.com/nodejs/node/pull/26356#issuecomment-468439898
#24757https://github.com/nodejs/node/pull/24757
Please reload this pagehttps://github.com/nodejs/node/pull/26356
https://github.com/yannh
yannhhttps://github.com/yannh
Mar 1, 2019https://github.com/nodejs/node/pull/26356#issuecomment-468493290
Please reload this pagehttps://github.com/nodejs/node/pull/26356
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
mcollinahttps://github.com/mcollina
March 7, 2019 09:11https://github.com/nodejs/node/pull/26356#event-2186550814
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 7, 2019 https://github.com/nodejs/node/pull/26356#pullrequestreview-211675903
View reviewed changes https://github.com/nodejs/node/pull/26356/files/1d397423ef0c12becb9f6f0e8e23728081270053
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/26356#pullrequestreview-211675903
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26356
lib/_http_server.jshttps://github.com/nodejs/node/pull/26356/files/1d397423ef0c12becb9f6f0e8e23728081270053#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
mcollinahttps://github.com/mcollina
Mar 7, 2019https://github.com/nodejs/node/pull/26356#discussion_r263298874
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26356
https://github.com/dosentmatter
dosentmatterhttps://github.com/dosentmatter
Mar 7, 2019https://github.com/nodejs/node/pull/26356#issuecomment-470711373
Please reload this pagehttps://github.com/nodejs/node/pull/26356
@yannhhttps://github.com/yannh
http-echo-serverhttps://www.npmjs.com/package/http-echo-server
net module directlyhttps://github.com/watson/http-echo-server/blob/e413158b3de9bcb6e09b2996f35bb257f75afed3/index.js#L5
https://user-images.githubusercontent.com/5732253/53992024-af55d280-40e0-11e9-9d8d-9226f7b9f184.png
Please reload this pagehttps://github.com/nodejs/node/pull/26356
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 8, 2019https://github.com/nodejs/node/pull/26356#issuecomment-470913781
@dosentmatterhttps://github.com/dosentmatter
Please reload this pagehttps://github.com/nodejs/node/pull/26356
https://github.com/yannh
yannhhttps://github.com/yannh
Mar 8, 2019https://github.com/nodejs/node/pull/26356#issuecomment-471030855
@dosentmatterhttps://github.com/dosentmatter
https://medium.com/@liquidgecka/a-tale-of-unexpected-elb-behavior-5281db9e5cb4https://medium.com/@liquidgecka/a-tale-of-unexpected-elb-behavior-5281db9e5cb4
Please reload this pagehttps://github.com/nodejs/node/pull/26356
https://github.com/yannh
yannhhttps://github.com/yannh
Mar 8, 2019https://github.com/nodejs/node/pull/26356#event-2190843306
https://github.com/dosentmatter
dosentmatterhttps://github.com/dosentmatter
Mar 8, 2019https://github.com/nodejs/node/pull/26356#issuecomment-471039889
@yannhhttps://github.com/yannh
server.setTimeout(msecs)https://github.com/expressjs/express/issues/3330
ELB 504 pagehttps://docs.aws.amazon.com/elasticloadbalancing/latest/classic/ts-elb-error-message.html
#13391https://github.com/nodejs/node/issues/13391
@mcollinahttps://github.com/mcollina
clientErrorhttps://nodejs.org/api/http.html#http_event_clienterror
HTTP header size for node was 80KB and is currently 8KBhttps://stackoverflow.com/questions/24167656/nodejs-max-header-size-in-http-request
@yannhhttps://github.com/yannh
Please reload this pagehttps://github.com/nodejs/node/pull/26356
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26356
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/26356/files/1d397423ef0c12becb9f6f0e8e23728081270053
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/26356/files/1d397423ef0c12becb9f6f0e8e23728081270053
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/26356
https://github.com/yannh
https://github.com/lpinca
https://github.com/dosentmatter
https://github.com/mcollina
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.