| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7bcb64fe-d26a-963b-bae7-658487aa1a1e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CFC0:26C5EC:CE05F0:120C40A:6A4E8617 |
| html-safe-nonce | c55e8d9b126480579ac28948351a599e2b917d5a31d13ebbfe33dd0158d89d8e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkMwOjI2QzVFQzpDRTA1RjA6MTIwQzQwQTo2QTRFODYxNyIsInZpc2l0b3JfaWQiOiIzNTI1NjcxNTcxOTc1NzM0ODA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | eceaf62dacffb889befe6ea1d3f9bacd5f13fad2e0249cb03ed2c292de123820 |
| hovercard-subject-tag | pull_request:255647394 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26280/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e90d1a574dd5a2d3ba5ceddab2695b9937633d07efd198bcbe8e3929d15770c2/nodejs/node/pull/26280 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e90d1a574dd5a2d3ba5ceddab2695b9937633d07efd198bcbe8e3929d15770c2/nodejs/node/pull/26280 |
| og:image:alt | Simplify node_options API, so the compiler bug should not manifest.
Should fix current master
Fixes: #25593
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message foll... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | refack |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/26280#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26280 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26280 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/26280 |
| Reload | https://github.com/nodejs/node/pull/26280 |
| Reload | https://github.com/nodejs/node/pull/26280 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| refack:mitigate-msvc-compiler-issue | https://github.com/refack/node/tree/mitigate-msvc-compiler-issue |
| Conversation | https://github.com/nodejs/node/pull/26280 |
| Commits2 (2) | https://github.com/nodejs/node/pull/26280/commits |
| Checks | https://github.com/nodejs/node/pull/26280/checks |
| Files changed | https://github.com/nodejs/node/pull/26280/files |
| src: refactor node options parsers to mitigate MSVC bug | https://github.com/nodejs/node/pull/26280#top |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| refack:mitigate-msvc-compiler-issue | https://github.com/refack/node/tree/mitigate-msvc-compiler-issue |
|
| https://github.com/refack |
| refack | https://github.com/refack |
| Feb 23, 2019 | https://github.com/nodejs/node/pull/26280#issue-413755768 |
| #25593 | https://github.com/nodejs/node/issues/25593 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 23, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-466711347 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Feb 23, 2019 | https://github.com/nodejs/node/pull/26280#event-2159838915 |
| https://github.com/refack |
| refack | https://github.com/refack |
| addaleax | https://github.com/addaleax |
| bnoordhuis | https://github.com/bnoordhuis |
| joyeecheung | https://github.com/joyeecheung |
| February 23, 2019 23:29 | https://github.com/nodejs/node/pull/26280#event-2159839504 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Feb 23, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-466711513 |
| https://ci.nodejs.org/job/node-test-pull-request/20988/ | https://ci.nodejs.org/job/node-test-pull-request/20988/ |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 23, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-466712149 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Feb 23, 2019 | https://github.com/nodejs/node/pull/26280#event-2159843853 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Feb 23, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-466712870 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Feb 24, 2019 | https://github.com/nodejs/node/pull/26280#event-2159853445 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Feb 24, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-466717637 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://ci.nodejs.org/job/node-test-pull-request/20989/ | https://ci.nodejs.org/job/node-test-pull-request/20989/ |
| https://ci.nodejs.org/job/node-test-commit/26103/ | https://ci.nodejs.org/job/node-test-commit/26103/ |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Feb 24, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-466729112 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://ci.nodejs.org/job/node-test-commit/26104/ | https://ci.nodejs.org/job/node-test-commit/26104/ |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Feb 24, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-466757914 |
| #25593 | https://github.com/nodejs/node/issues/25593 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Feb 24, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-466781231 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| #25593 | https://github.com/nodejs/node/issues/25593 |
| #25596 | https://github.com/nodejs/node/pull/25596 |
| https://nodejs.org/download/nightly/v12.0.0-nightly201902247e0ddf66b9/win-x86/ | https://nodejs.org/download/nightly/v12.0.0-nightly201902247e0ddf66b9/win-x86/ |
| https://user-images.githubusercontent.com/96947/53300430-22c03000-3815-11e9-96bd-c99f6526c9b3.png |
| https://ci.nodejs.org/job/node-test-commit/26108/ | https://ci.nodejs.org/job/node-test-commit/26108/ |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Feb 25, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-466834577 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/6b149689942f73d4cee4e128e9bae5ceabc421d6..5cf7ba6b7bec265b680dab757b8b9e5e722fc501 |
| 6b14968 | https://github.com/nodejs/node/commit/6b149689942f73d4cee4e128e9bae5ceabc421d6 |
| 5cf7ba6 | https://github.com/nodejs/node/commit/5cf7ba6b7bec265b680dab757b8b9e5e722fc501 |
|
Compare
| https://github.com/nodejs/node/compare/6b149689942f73d4cee4e128e9bae5ceabc421d6..5cf7ba6b7bec265b680dab757b8b9e5e722fc501 |
| February 25, 2019 02:22 | https://github.com/nodejs/node/pull/26280#event-2160529071 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Feb 25, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-466849614 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://ci.nodejs.org/job/node-test-pull-request/20991/ | https://ci.nodejs.org/job/node-test-pull-request/20991/ |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Feb 25, 2019
| https://github.com/nodejs/node/pull/26280#pullrequestreview-207256414 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26280/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/26280#pullrequestreview-207256414 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| src/node_options.cc | https://github.com/nodejs/node/pull/26280/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| src/node_options.h | https://github.com/nodejs/node/pull/26280/files#diff-a6dd6c44925932d3134081da80ed07216f5f66449f540442835557616bcd14f9 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| src/node_options.cc | https://github.com/nodejs/node/pull/26280/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/dc3899650b6e3d75d52637d7a44fc90b72dc4de6..f3a4e2bf8e6503533b31eef882f46a6c5d690e0b |
| dc38996 | https://github.com/nodejs/node/commit/dc3899650b6e3d75d52637d7a44fc90b72dc4de6 |
| f3a4e2b | https://github.com/nodejs/node/commit/f3a4e2bf8e6503533b31eef882f46a6c5d690e0b |
|
Compare
| https://github.com/nodejs/node/compare/dc3899650b6e3d75d52637d7a44fc90b72dc4de6..f3a4e2bf8e6503533b31eef882f46a6c5d690e0b |
| February 25, 2019 16:44 | https://github.com/nodejs/node/pull/26280#event-2162330071 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Feb 25, 2019 | https://github.com/nodejs/node/pull/26280#event-2162432116 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Feb 25, 2019
| https://github.com/nodejs/node/pull/26280#pullrequestreview-207583198 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26280/files |
| src/node_options.cc | https://github.com/nodejs/node/pull/26280/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| src/node_worker.cc | https://github.com/nodejs/node/pull/26280/files#diff-b06b65a7f7e33816a1986d731765d732ab23f585bece6b23c5e83ca3682dba62 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Feb 25, 2019 | https://github.com/nodejs/node/pull/26280#event-2162922682 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/f3a4e2bf8e6503533b31eef882f46a6c5d690e0b..f98b845e0bf9b0a5cfa7831b80a2034787d2023f |
| f3a4e2b | https://github.com/nodejs/node/commit/f3a4e2bf8e6503533b31eef882f46a6c5d690e0b |
| f98b845 | https://github.com/nodejs/node/commit/f98b845e0bf9b0a5cfa7831b80a2034787d2023f |
|
Compare
| https://github.com/nodejs/node/compare/f3a4e2bf8e6503533b31eef882f46a6c5d690e0b..f98b845e0bf9b0a5cfa7831b80a2034787d2023f |
| February 25, 2019 20:44 | https://github.com/nodejs/node/pull/26280#event-2162960616 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Feb 25, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-467176112 |
| https://ci.nodejs.org/job/node-test-pull-request/20993/ | https://ci.nodejs.org/job/node-test-pull-request/20993/ |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/251a80bc4db42528aaad5dece0195f0786f02f94..57e2c03a991e7383fd90961aeba60079e7ad334d |
| 251a80b | https://github.com/nodejs/node/commit/251a80bc4db42528aaad5dece0195f0786f02f94 |
| 57e2c03 | https://github.com/nodejs/node/commit/57e2c03a991e7383fd90961aeba60079e7ad334d |
|
Compare
| https://github.com/nodejs/node/compare/251a80bc4db42528aaad5dece0195f0786f02f94..57e2c03a991e7383fd90961aeba60079e7ad334d |
| March 3, 2019 16:33 | https://github.com/nodejs/node/pull/26280#event-2176376093 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Mar 3, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-469039271 |
| https://ci.nodejs.org/job/node-test-pull-request/21167/ | https://ci.nodejs.org/job/node-test-pull-request/21167/ |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| refack | https://github.com/refack |
| March 3, 2019 20:03 | https://github.com/nodejs/node/pull/26280#commits-pushed-af8b92c |
|
| https://github.com/refack |
| src: refactor node options parsers to mitigate MSVC bug | https://github.com/nodejs/node/pull/26280/commits/af8b92c0731603e5337cca3202603402d345c0a9 |
| af8b92c | https://github.com/nodejs/node/pull/26280/commits/af8b92c0731603e5337cca3202603402d345c0a9 |
| nodejs#26280 | https://github.com/nodejs/node/pull/26280 |
| nodejs#25593 | https://github.com/nodejs/node/issues/25593 |
|
| https://github.com/refack |
| src: fix warnings around node_options | https://github.com/nodejs/node/pull/26280/commits/2c6d94f3db89ed4dfa3e68e7e945c10e3662ea41 |
| 2c6d94f | https://github.com/nodejs/node/pull/26280/commits/2c6d94f3db89ed4dfa3e68e7e945c10e3662ea41 |
| nodejs#26280 | https://github.com/nodejs/node/pull/26280 |
| nodejs#25593 | https://github.com/nodejs/node/issues/25593 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/57e2c03a991e7383fd90961aeba60079e7ad334d..2c6d94f3db89ed4dfa3e68e7e945c10e3662ea41 |
| 57e2c03 | https://github.com/nodejs/node/commit/57e2c03a991e7383fd90961aeba60079e7ad334d |
| 2c6d94f | https://github.com/nodejs/node/commit/2c6d94f3db89ed4dfa3e68e7e945c10e3662ea41 |
|
Compare
| https://github.com/nodejs/node/compare/57e2c03a991e7383fd90961aeba60079e7ad334d..2c6d94f3db89ed4dfa3e68e7e945c10e3662ea41 |
| March 4, 2019 01:03 | https://github.com/nodejs/node/pull/26280#event-2176634772 |
| https://github.com/refack |
| refack | https://github.com/refack |
| bnoordhuis | https://github.com/bnoordhuis |
| March 4, 2019 01:06 | https://github.com/nodejs/node/pull/26280#event-2176636377 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Mar 4, 2019 | https://github.com/nodejs/node/pull/26280#event-2176636435 |
| https://github.com/refack |
| refack | https://github.com/refack |
| 2c6d94f | https://github.com/nodejs/node/commit/2c6d94f3db89ed4dfa3e68e7e945c10e3662ea41 |
| Mar 4, 2019 | https://github.com/nodejs/node/pull/26280#event-2176636669 |
| https://github.com/refack |
| refack | https://github.com/refack |
| March 4, 2019 01:06 | https://github.com/nodejs/node/pull/26280#event-2176636843 |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 4, 2019
| https://github.com/nodejs/node/pull/26280#ref-commit-64a0b11 |
|
| https://github.com/refack |
|
| https://github.com/BridgeAR |
| src: refactor node options parsers to mitigate MSVC bug | https://github.com/nodejs/node/commit/64a0b118d67674d90eb72430c9c45fbb3cb13fa4 |
| 64a0b11 | https://github.com/nodejs/node/commit/64a0b118d67674d90eb72430c9c45fbb3cb13fa4 |
| #26280 | https://github.com/nodejs/node/pull/26280 |
| #25593 | https://github.com/nodejs/node/issues/25593 |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 4, 2019
| https://github.com/nodejs/node/pull/26280#ref-commit-668ca36 |
|
| https://github.com/refack |
|
| https://github.com/BridgeAR |
| src: fix warnings around node_options | https://github.com/nodejs/node/commit/668ca360a00c5435b0a40e09fde57228808d8be2 |
| 668ca36 | https://github.com/nodejs/node/commit/668ca360a00c5435b0a40e09fde57228808d8be2 |
| #26280 | https://github.com/nodejs/node/pull/26280 |
| #25593 | https://github.com/nodejs/node/issues/25593 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 4, 2019
| https://github.com/nodejs/node/pull/26280#ref-pullrequest-414627371 |
|
v11.11.0 proposal
#26322
| https://github.com/nodejs/node/pull/26322 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
backport-requested-v11.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v11.x |
| Mar 5, 2019 | https://github.com/nodejs/node/pull/26280#event-2182442107 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Mar 5, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-469877297 |
| #26322 (comment) | https://github.com/nodejs/node/pull/26322#issuecomment-469874790 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Mar 11, 2019 | https://github.com/nodejs/node/pull/26280#event-2192631678 |
| https://github.com/refack |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26280 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Mar 14, 2019 | https://github.com/nodejs/node/pull/26280#issuecomment-472682981 |
| #26649 | https://github.com/nodejs/node/pull/26649 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Mar 14, 2019 | https://github.com/nodejs/node/pull/26280#event-2202164801 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Mar 14, 2019
| https://github.com/nodejs/node/pull/26280#ref-pullrequest-420803191 |
|
[v11.x backport] src: refactor node options parsers to mitigate MSVC bug
#26649
| https://github.com/nodejs/node/pull/26649 |
| refack | https://github.com/refack |
|
Mar 14, 2019
| https://github.com/nodejs/node/pull/26280#ref-commit-4c02851 |
|
| https://github.com/refack |
| src: refactor node options parsers to mitigate MSVC bug | https://github.com/refack/node/commit/4c02851db53834914db1958e9fb156b1a308d4bf |
| 4c02851 | https://github.com/refack/node/commit/4c02851db53834914db1958e9fb156b1a308d4bf |
| nodejs#26280 | https://github.com/nodejs/node/pull/26280 |
| nodejs#25593 | https://github.com/nodejs/node/issues/25593 |
| refack | https://github.com/refack |
|
Mar 14, 2019
| https://github.com/nodejs/node/pull/26280#ref-commit-1ad23f6 |
|
| https://github.com/refack |
| src: fix warnings around node_options | https://github.com/refack/node/commit/1ad23f6b9e9c1c2553e4237436e7a5076aedf577 |
| 1ad23f6 | https://github.com/refack/node/commit/1ad23f6b9e9c1c2553e4237436e7a5076aedf577 |
| nodejs#26280 | https://github.com/nodejs/node/pull/26280 |
| nodejs#25593 | https://github.com/nodejs/node/issues/25593 |
| targos | https://github.com/targos |
|
Mar 28, 2019
| https://github.com/nodejs/node/pull/26280#ref-commit-62f9049 |
|
| https://github.com/refack |
|
| https://github.com/targos |
| src: refactor node options parsers to mitigate MSVC bug | https://github.com/nodejs/node/commit/62f904974d5c36c9f0d44d0928f23bb3a752398d |
| 62f9049 | https://github.com/nodejs/node/commit/62f904974d5c36c9f0d44d0928f23bb3a752398d |
| #26649 | https://github.com/nodejs/node/pull/26649 |
| #26280 | https://github.com/nodejs/node/pull/26280 |
| #25593 | https://github.com/nodejs/node/issues/25593 |
| targos | https://github.com/targos |
|
Mar 28, 2019
| https://github.com/nodejs/node/pull/26280#ref-commit-361025f |
|
| https://github.com/refack |
|
| https://github.com/targos |
| src: fix warnings around node_options | https://github.com/nodejs/node/commit/361025f7f45c5ae47c5fbda1702cc986eaa7cc25 |
| 361025f | https://github.com/nodejs/node/commit/361025f7f45c5ae47c5fbda1702cc986eaa7cc25 |
| #26649 | https://github.com/nodejs/node/pull/26649 |
| #26280 | https://github.com/nodejs/node/pull/26280 |
| #25593 | https://github.com/nodejs/node/issues/25593 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backported-to-v11.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v11.x |
|
backport-requested-v11.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v11.x |
| Mar 28, 2019 | https://github.com/nodejs/node/pull/26280#event-2237440412 |
| targos | https://github.com/targos |
|
Mar 30, 2019
| https://github.com/nodejs/node/pull/26280#ref-commit-e6c1ad5 |
|
| https://github.com/refack |
|
| https://github.com/targos |
| src: fix warnings around node_options | https://github.com/nodejs/node/commit/e6c1ad59015e46e1ede23f1f9e4e3f57d5bf51e2 |
| e6c1ad5 | https://github.com/nodejs/node/commit/e6c1ad59015e46e1ede23f1f9e4e3f57d5bf51e2 |
| #26649 | https://github.com/nodejs/node/pull/26649 |
| #26280 | https://github.com/nodejs/node/pull/26280 |
| #25593 | https://github.com/nodejs/node/issues/25593 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 9, 2019
| https://github.com/nodejs/node/pull/26280#ref-pullrequest-431232386 |
|
v11.14.0 proposal
#27163
| https://github.com/nodejs/node/pull/27163 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Apr 14, 2019 | https://github.com/nodejs/node/pull/26280#event-2274487107 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26280 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/26280/files/f3a4e2bf8e6503533b31eef882f46a6c5d690e0b |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/26280/files/c54d579464ba6e6e986e091ff5cc31abfb78adab |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
Debug build doesn't work on Windows
| https://github.com/nodejs/node/issues/25593 |
| Please reload this page | https://github.com/nodejs/node/pull/26280 |
|
| https://github.com/refack |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/seishun |
|
| https://github.com/addaleax |
|
| https://github.com/BridgeAR |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |