René's URL Explorer Experiment


Title: .msi related cherry picks for v3.x by rvagg · Pull Request #2608 · nodejs/node · GitHub

Open Graph Title: .msi related cherry picks for v3.x by rvagg · Pull Request #2608 · nodejs/node

X Title: .msi related cherry picks for v3.x by rvagg · Pull Request #2608 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is for @joaocgreis to review, it's my attempt to cherry-pick 4cfe5eb and c6a54d0 but the differences are quite large and the conflicts non trivial.

X Description: This is for @joaocgreis to review, it's my attempt to cherry-pick 4cfe5eb and c6a54d0 but the differences are quite large and the conflicts non trivial.

Opengraph URL: https://github.com/nodejs/node/pull/2608

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1bbdd167-c3e1-087d-fabc-764ab7203886
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC298:C3948:47A3CC1:646A5C2:6A4F7C3A
html-safe-nonce419dc7ea8bee0a288738f232bc2d729af4f27c6e69ad8987d18033d389297517
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjk4OkMzOTQ4OjQ3QTNDQzE6NjQ2QTVDMjo2QTRGN0MzQSIsInZpc2l0b3JfaWQiOiI4MTE2ODA4MzEzOTUyOTgzNjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9136bbeac6bcb682661c2a92c1d459f8f6eb8cc80ca9023a716200cfebc6eabe
hovercard-subject-tagpull_request:43684314
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2608/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/31af3034a8b940b97f0db0e9719b17d3442a69f92e7d1b7085ef7cb1b66f1ea8/nodejs/node/pull/2608
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/31af3034a8b940b97f0db0e9719b17d3442a69f92e7d1b7085ef7cb1b66f1ea8/nodejs/node/pull/2608
og:image:altThis is for @joaocgreis to review, it's my attempt to cherry-pick 4cfe5eb and c6a54d0 but the differences are quite large and the conflicts non trivial.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamervagg
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/2608#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2608
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2608
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/2608
Reloadhttps://github.com/nodejs/node/pull/2608
Reloadhttps://github.com/nodejs/node/pull/2608
Please reload this pagehttps://github.com/nodejs/node/pull/2608
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/2608
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
rvagghttps://github.com/rvagg
nodejs:v3.xhttps://github.com/nodejs/node/tree/v3.x
rvagg:msi-cherry-pickshttps://github.com/rvagg/io.js/tree/msi-cherry-picks
Conversationhttps://github.com/nodejs/node/pull/2608
Commits2 (2)https://github.com/nodejs/node/pull/2608/commits
Checkshttps://github.com/nodejs/node/pull/2608/checks
Files changedhttps://github.com/nodejs/node/pull/2608/files
.msi related cherry picks for v3.xhttps://github.com/nodejs/node/pull/2608#top
rvagghttps://github.com/rvagg
nodejs:v3.xhttps://github.com/nodejs/node/tree/v3.x
rvagg:msi-cherry-pickshttps://github.com/rvagg/io.js/tree/msi-cherry-picks
https://github.com/rvagg
rvagghttps://github.com/rvagg
Aug 29, 2015https://github.com/nodejs/node/pull/2608#issue-103816800
@joaocgreishttps://github.com/joaocgreis
4cfe5ebhttps://github.com/nodejs/node/commit/4cfe5eb9af9d0a46ab6bfe3a4a49c4b1e43513b0
c6a54d0https://github.com/nodejs/node/commit/c6a54d09642ffe7fcf2c467a6e4ef95d86d2d3fa
Please reload this pagehttps://github.com/nodejs/node/pull/2608
joaocgreishttps://github.com/joaocgreis
August 29, 2015 10:28https://github.com/nodejs/node/pull/2608#commits-pushed-752977b
https://github.com/joaocgreis
https://github.com/rvagg
win,msi: change InstallScope to perMachinehttps://github.com/nodejs/node/pull/2608/commits/752977b8880be27403bf7a960b3839a57640ef02
752977bhttps://github.com/nodejs/node/pull/2608/commits/752977b8880be27403bf7a960b3839a57640ef02
8e80528https://github.com/rvagg/io.js/commit/8e80528453aca0354422162e09c7c9f4700ddb1e
nodejs/node-v0.x-archive#5849https://github.com/nodejs/node-v0.x-archive/issues/5849
nodejs/node-v0.x-archive#7629https://github.com/nodejs/node-v0.x-archive/issues/7629
nodejs/node-v0.x-archive#25640https://github.com/nodejs/node-v0.x-archive/pull/25640
nodejs#2565https://github.com/nodejs/node/pull/2565
https://github.com/joaocgreis
https://github.com/rvagg
win,msi: correct installation path registry keyshttps://github.com/nodejs/node/pull/2608/commits/4f07cab9df06f026ba354ed25ff0b2f50ec5e1aa
4f07cabhttps://github.com/nodejs/node/pull/2608/commits/4f07cab9df06f026ba354ed25ff0b2f50ec5e1aa
14db629https://github.com/rvagg/io.js/commit/14db629497d0eb97a5f0fbb70cf3e534e460deec
nodejs/node-v0.x-archive#5592https://github.com/nodejs/node-v0.x-archive/issues/5592
nodejs/node-v0.x-archive#25087https://github.com/nodejs/node-v0.x-archive/issues/25087
nodejs/node-v0.x-archive#25640https://github.com/nodejs/node-v0.x-archive/pull/25640
nodejs#2565https://github.com/nodejs/node/pull/2565
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
land-on-v3.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v3.x
Aug 29, 2015https://github.com/nodejs/node/pull/2608#event-395595200
https://github.com/rvagg
rvagghttps://github.com/rvagg
Aug 29, 2015 https://github.com/nodejs/node/pull/2608#ref-issue-103815442
Release proposal: v3.3.0 #2607 https://github.com/nodejs/node/issues/2607
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Aug 29, 2015https://github.com/nodejs/node/pull/2608#event-395598235
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Aug 29, 2015https://github.com/nodejs/node/pull/2608#issuecomment-135997379
@rvagghttps://github.com/rvagg
752977bhttps://github.com/nodejs/node/commit/752977b8880be27403bf7a960b3839a57640ef02
Please reload this pagehttps://github.com/nodejs/node/pull/2608
joaocgreishttps://github.com/joaocgreis
Aug 30, 2015 https://github.com/nodejs/node/pull/2608#ref-commit-bb24c4a
https://github.com/joaocgreis
https://github.com/rvagg
win,msi: correct installation path registry keyshttps://github.com/nodejs/node/commit/bb24c4a418d08c0db5b1250953099bab5da41259
bb24c4ahttps://github.com/nodejs/node/commit/bb24c4a418d08c0db5b1250953099bab5da41259
14db629https://github.com/nodejs/node/commit/14db629497d0eb97a5f0fbb70cf3e534e460deec
nodejs/node-v0.x-archive#5592https://github.com/nodejs/node-v0.x-archive/issues/5592
nodejs/node-v0.x-archive#25087https://github.com/nodejs/node-v0.x-archive/issues/25087
nodejs/node-v0.x-archive#25640https://github.com/nodejs/node-v0.x-archive/pull/25640
#2565https://github.com/nodejs/node/pull/2565
@rvagghttps://github.com/rvagg
#2608https://github.com/nodejs/node/pull/2608
https://github.com/rvagg
rvagghttps://github.com/rvagg
Aug 30, 2015https://github.com/nodejs/node/pull/2608#event-395959122
https://github.com/rvagg
rvagghttps://github.com/rvagg
August 30, 2015 07:16https://github.com/nodejs/node/pull/2608#event-395959129
https://github.com/rvagg
rvagghttps://github.com/rvagg
Aug 30, 2015https://github.com/nodejs/node/pull/2608#issuecomment-136094403
bb24c4ahttps://github.com/nodejs/node/commit/bb24c4a418d08c0db5b1250953099bab5da41259
@joaocgreishttps://github.com/joaocgreis
Please reload this pagehttps://github.com/nodejs/node/pull/2608
https://github.com/rvagg
rvagghttps://github.com/rvagg
Sep 3, 2015 https://github.com/nodejs/node/pull/2608#ref-issue-104434936
Jenkins merge jobs always overwrites PR-URL and Reviewed-By nodejs/build#179 https://github.com/nodejs/build/issues/179
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2608
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Please reload this pagehttps://github.com/nodejs/node/pull/2608
https://github.com/rvagg
https://github.com/joaocgreis
https://github.com/Fishrock123
https://github.com/brendanashworth
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.