René's URL Explorer Experiment


Title: [v10.x] n-api: finalize during second-pass callback by gabrielschulhof · Pull Request #26058 · nodejs/node · GitHub

Open Graph Title: [v10.x] n-api: finalize during second-pass callback by gabrielschulhof · Pull Request #26058 · nodejs/node

X Title: [v10.x] n-api: finalize during second-pass callback by gabrielschulhof · Pull Request #26058 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Calling into the engine from a weak callback is unsafe, however, the engine offers a way to attach a second-pass weak callback which gets called when it is safe to call into JavaScript. This moves ...

X Description: Calling into the engine from a weak callback is unsafe, however, the engine offers a way to attach a second-pass weak callback which gets called when it is safe to call into JavaScript. This moves ...

Opengraph URL: https://github.com/nodejs/node/pull/26058

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cda41251-952c-6d8e-7ff8-2b74f4907490
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA32:1FD988:283D7E6:3342A3F:6991C328
html-safe-nonceeffe2a216603cdd01c3b590c856ecc85380edc0c6223c7b3fc78e2acfdd7b2b6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTMyOjFGRDk4ODoyODNEN0U2OjMzNDJBM0Y6Njk5MUMzMjgiLCJ2aXNpdG9yX2lkIjoiMzgyMjY1NzYzNDA4NDk2MzExMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf0bad8e28a128dd59cc2fa408cc64cc4835f95259da5bb9ef1d6b9418748586b
hovercard-subject-tagpull_request:252444282
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26058/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8f1c2495213781d26e6f567ed58313bc949f955a4a58afd466e1541beacbef4c/nodejs/node/pull/26058
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8f1c2495213781d26e6f567ed58313bc949f955a4a58afd466e1541beacbef4c/nodejs/node/pull/26058
og:image:altCalling into the engine from a weak callback is unsafe, however, the engine offers a way to attach a second-pass weak callback which gets called when it is safe to call into JavaScript. This moves ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/26058#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26058
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26058
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/26058
Reloadhttps://github.com/nodejs/node/pull/26058
Reloadhttps://github.com/nodejs/node/pull/26058
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/26058
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
gabrielschulhof:25927-finalize-during-second-pass-callback-v10.xhttps://github.com/gabrielschulhof/node/tree/25927-finalize-during-second-pass-callback-v10.x
Conversationhttps://github.com/nodejs/node/pull/26058
Commits1 (1)https://github.com/nodejs/node/pull/26058/commits
Checkshttps://github.com/nodejs/node/pull/26058/checks
Files changedhttps://github.com/nodejs/node/pull/26058/files
[v10.x] n-api: finalize during second-pass callbackhttps://github.com/nodejs/node/pull/26058#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:v10.x-staginghttps://github.com/nodejs/node/tree/v10.x-staging
gabrielschulhof:25927-finalize-during-second-pass-callback-v10.xhttps://github.com/gabrielschulhof/node/tree/25927-finalize-during-second-pass-callback-v10.x
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Feb 12, 2019https://github.com/nodejs/node/pull/26058#issue-409465826
#25927https://github.com/nodejs/node/issues/25927
#25992https://github.com/nodejs/node/pull/25992
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/26058
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 12, 2019https://github.com/nodejs/node/pull/26058#issuecomment-462902953
@gabrielschulhofhttps://github.com/gabrielschulhof
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2579/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2579/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/26058
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x
Feb 12, 2019https://github.com/nodejs/node/pull/26058#event-2134740969
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/4b7d59cdb1a67da4d51a596186443ad219d596d2..b79bdb84d558bde1bd1f62bd83699a78958c6e1d
4b7d59chttps://github.com/nodejs/node/commit/4b7d59cdb1a67da4d51a596186443ad219d596d2
b79bdb8https://github.com/nodejs/node/commit/b79bdb84d558bde1bd1f62bd83699a78958c6e1d
Compare https://github.com/nodejs/node/compare/4b7d59cdb1a67da4d51a596186443ad219d596d2..b79bdb84d558bde1bd1f62bd83699a78958c6e1d
February 12, 2019 19:36https://github.com/nodejs/node/pull/26058#event-2134742528
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Feb 12, 2019 https://github.com/nodejs/node/pull/26058#ref-pullrequest-409523921
[v8.x] n-api: finalize during second-pass callback #26060 https://github.com/nodejs/node/pull/26060
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
force-pushedhttps://github.com/nodejs/node/compare/13f9356b046c0015843f21338eaa22b2bcdb57e2..5711238b4e2e96d98011823ad1f19fb5a7a67463
13f9356https://github.com/nodejs/node/commit/13f9356b046c0015843f21338eaa22b2bcdb57e2
5711238https://github.com/nodejs/node/commit/5711238b4e2e96d98011823ad1f19fb5a7a67463
Compare https://github.com/nodejs/node/compare/13f9356b046c0015843f21338eaa22b2bcdb57e2..5711238b4e2e96d98011823ad1f19fb5a7a67463
February 20, 2019 16:06https://github.com/nodejs/node/pull/26058#event-2152393459
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Feb 20, 2019https://github.com/nodejs/node/pull/26058#issuecomment-465730632
Please reload this pagehttps://github.com/nodejs/node/pull/26058
https://github.com/rvagg
rvagghttps://github.com/rvagg
force-pushedhttps://github.com/nodejs/node/compare/5711238b4e2e96d98011823ad1f19fb5a7a67463..156e4c8e89616a3f128453ff43cac5103a8226fa
5711238https://github.com/nodejs/node/commit/5711238b4e2e96d98011823ad1f19fb5a7a67463
156e4c8https://github.com/nodejs/node/commit/156e4c8e89616a3f128453ff43cac5103a8226fa
Compare https://github.com/nodejs/node/compare/5711238b4e2e96d98011823ad1f19fb5a7a67463..156e4c8e89616a3f128453ff43cac5103a8226fa
February 28, 2019 12:38https://github.com/nodejs/node/pull/26058#event-2170923309
n-api: finalize during second-pass callbackhttps://github.com/nodejs/node/pull/26058/commits/e66b09c659d2186eb11a265a3256ccb6026ee129
e66b09chttps://github.com/nodejs/node/pull/26058/commits/e66b09c659d2186eb11a265a3256ccb6026ee129
nodejs#25927https://github.com/nodejs/node/issues/25927
nodejs#25992https://github.com/nodejs/node/pull/25992
nodejs#26058https://github.com/nodejs/node/pull/26058
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/b79bdb84d558bde1bd1f62bd83699a78958c6e1d..e66b09c659d2186eb11a265a3256ccb6026ee129
b79bdb8https://github.com/nodejs/node/commit/b79bdb84d558bde1bd1f62bd83699a78958c6e1d
e66b09chttps://github.com/nodejs/node/commit/e66b09c659d2186eb11a265a3256ccb6026ee129
Compare https://github.com/nodejs/node/compare/b79bdb84d558bde1bd1f62bd83699a78958c6e1d..e66b09c659d2186eb11a265a3256ccb6026ee129
March 4, 2019 18:33https://github.com/nodejs/node/pull/26058#event-2178746706
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 4, 2019https://github.com/nodejs/node/pull/26058#issuecomment-469364950
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/26058
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Mar 5, 2019 https://github.com/nodejs/node/pull/26058#pullrequestreview-210767516
View reviewed changes https://github.com/nodejs/node/pull/26058/files/e66b09c659d2186eb11a265a3256ccb6026ee129
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/26058#pullrequestreview-210767516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/26058
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 8, 2019https://github.com/nodejs/node/pull/26058#issuecomment-471009360
https://ci.nodejs.org/job/node-test-pull-request/21343/https://ci.nodejs.org/job/node-test-pull-request/21343/
Please reload this pagehttps://github.com/nodejs/node/pull/26058
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Mar 12, 2019 https://github.com/nodejs/node/pull/26058#pullrequestreview-213684011
View reviewed changes https://github.com/nodejs/node/pull/26058/files/e66b09c659d2186eb11a265a3256ccb6026ee129
BethGriggshttps://github.com/BethGriggs
Mar 12, 2019 https://github.com/nodejs/node/pull/26058#ref-commit-b5588da
https://github.com/BethGriggs
n-api: finalize during second-pass callbackhttps://github.com/nodejs/node/commit/b5588daef08c1be1c2edad11bc80c85631452943
b5588dahttps://github.com/nodejs/node/commit/b5588daef08c1be1c2edad11bc80c85631452943
#25927https://github.com/nodejs/node/issues/25927
#25992https://github.com/nodejs/node/pull/25992
#26058https://github.com/nodejs/node/pull/26058
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Mar 12, 2019https://github.com/nodejs/node/pull/26058#issuecomment-472214153
b5588dahttps://github.com/nodejs/node/commit/b5588daef08c1be1c2edad11bc80c85631452943
Please reload this pagehttps://github.com/nodejs/node/pull/26058
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Mar 12, 2019https://github.com/nodejs/node/pull/26058#event-2198721956
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
June 14, 2019 23:51https://github.com/nodejs/node/pull/26058#event-2415099445
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26058
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/26058/files/e66b09c659d2186eb11a265a3256ccb6026ee129
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/26058/files/e66b09c659d2186eb11a265a3256ccb6026ee129
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/26058
https://github.com/gabrielschulhof
https://github.com/nodejs-github-bot
https://github.com/mhdawson
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.