| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d7d4fd84-0dd2-c1da-467b-69f40557fef9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B114:3D2C0A:667F7E:93A2B7:6A4FABD5 |
| html-safe-nonce | 9870e5cd37e76f8a8fce0d5c879af603c6f1603b8a8d73f3a17f7575e4a13f7d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTE0OjNEMkMwQTo2NjdGN0U6OTNBMkI3OjZBNEZBQkQ1IiwidmlzaXRvcl9pZCI6IjQ3OTAxMzk1MDE4ODMxNDEwNzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ee84af745377a559a3037a57a05628473cc325f1f33a68a9a6b3863ce1de0b62 |
| hovercard-subject-tag | pull_request:252303208 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/26054/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c354e3871638146b20578448c3ccb72524569f78da31724e7a957be2a0275ecd/nodejs/node/pull/26054 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c354e3871638146b20578448c3ccb72524569f78da31724e7a957be2a0275ecd/nodejs/node/pull/26054 |
| og:image:alt | This is subtask of #25908.
Main Changes made
delete all tools/node_modules/eslint, tools/node_modules/babel-eslint
create package.json with lint task
rewrite Makefile and vcbuild.bat
related chang... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gengjiawen |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/26054#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26054 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26054 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/26054 |
| Reload | https://github.com/nodejs/node/pull/26054 |
| Reload | https://github.com/nodejs/node/pull/26054 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
972
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gengjiawen | https://github.com/gengjiawen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gengjiawen:feature/simple | https://github.com/gengjiawen/node/tree/feature/simple |
| Conversation | https://github.com/nodejs/node/pull/26054 |
| Commits2 (2) | https://github.com/nodejs/node/pull/26054/commits |
| Checks | https://github.com/nodejs/node/pull/26054/checks |
| Files changed | https://github.com/nodejs/node/pull/26054/files |
| [WIP]tools: simply eslint tasks | https://github.com/nodejs/node/pull/26054#top |
| gengjiawen | https://github.com/gengjiawen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gengjiawen:feature/simple | https://github.com/gengjiawen/node/tree/feature/simple |
|
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issue-409282739 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| #25908 | https://github.com/nodejs/node/issues/25908 |
| https://travis-ci.org/gengjiawen/node/jobs/492161168 | https://travis-ci.org/gengjiawen/node/jobs/492161168 |
| @Trott | https://github.com/Trott |
| @refack | https://github.com/refack |
| @joyeecheung | https://github.com/joyeecheung |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#event-2133601428 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#event-2133621646 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| force-pushed | https://github.com/nodejs/node/compare/fc4d3e4e986616227a453568be191d556dedce6f..c0ca7f43a2a1ac3518038c10d890dd43dc89c1d2 |
| fc4d3e4 | https://github.com/nodejs/node/commit/fc4d3e4e986616227a453568be191d556dedce6f |
| c0ca7f4 | https://github.com/nodejs/node/commit/c0ca7f43a2a1ac3518038c10d890dd43dc89c1d2 |
|
Compare
| https://github.com/nodejs/node/compare/fc4d3e4e986616227a453568be191d556dedce6f..c0ca7f43a2a1ac3518038c10d890dd43dc89c1d2 |
| February 12, 2019 13:20 | https://github.com/nodejs/node/pull/26054#event-2133670420 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#event-2133760667 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462767977 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462771075 |
| @gengjiawen | https://github.com/gengjiawen |
| #24813 | https://github.com/nodejs/node/pull/24813 |
| node/Makefile | https://github.com/nodejs/node/blob/43dd49c9782848c25e5b03448c8a0f923f13c158/Makefile#L1300-L1312 |
| 43dd49c | https://github.com/nodejs/node/commit/43dd49c9782848c25e5b03448c8a0f923f13c158 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| force-pushed | https://github.com/nodejs/node/compare/c0ca7f43a2a1ac3518038c10d890dd43dc89c1d2..3b68cc5d5d3db556e99d688dba3cd8901e722a61 |
| c0ca7f4 | https://github.com/nodejs/node/commit/c0ca7f43a2a1ac3518038c10d890dd43dc89c1d2 |
| 3b68cc5 | https://github.com/nodejs/node/commit/3b68cc5d5d3db556e99d688dba3cd8901e722a61 |
|
Compare
| https://github.com/nodejs/node/compare/c0ca7f43a2a1ac3518038c10d890dd43dc89c1d2..3b68cc5d5d3db556e99d688dba3cd8901e722a61 |
| February 12, 2019 14:10 | https://github.com/nodejs/node/pull/26054#event-2133808399 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462774423 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| @Trott | https://github.com/Trott |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462774711 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| #25908 | https://github.com/nodejs/node/issues/25908 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462778108 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462778156 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462778432 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462778531 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462779741 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462780099 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/26054#pullrequestreview-202695735 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26054/files |
| Makefile | https://github.com/nodejs/node/pull/26054/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/26054#pullrequestreview-202698238 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26054/files |
| Makefile | https://github.com/nodejs/node/pull/26054/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462783263 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| force-pushed | https://github.com/nodejs/node/compare/f81b4430082680e1c88979cc9c4e1ed966df3bf6..1f4c3396d5e1c23d3f0b4fae5b6363d2835e5b02 |
| f81b443 | https://github.com/nodejs/node/commit/f81b4430082680e1c88979cc9c4e1ed966df3bf6 |
| 1f4c339 | https://github.com/nodejs/node/commit/1f4c3396d5e1c23d3f0b4fae5b6363d2835e5b02 |
|
Compare
| https://github.com/nodejs/node/compare/f81b4430082680e1c88979cc9c4e1ed966df3bf6..1f4c3396d5e1c23d3f0b4fae5b6363d2835e5b02 |
| February 12, 2019 14:49 | https://github.com/nodejs/node/pull/26054#event-2133921279 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/26054#pullrequestreview-202709585 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26054/files |
| package.json | https://github.com/nodejs/node/pull/26054/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
| gengjiawen | https://github.com/gengjiawen |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#discussion_r255988024 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Feb 12, 2019
| https://github.com/nodejs/node/pull/26054#pullrequestreview-202710484 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/26054/files |
| .eslintrc.js | https://github.com/nodejs/node/pull/26054/files#diff-e2954b558f2aa82baff0e30964490d12942e0e251c1aa56c3294de6ec67b7cf5 |
| gengjiawen | https://github.com/gengjiawen |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#discussion_r255988719 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| joyeecheung | https://github.com/joyeecheung |
| Feb 17, 2019 | https://github.com/nodejs/node/pull/26054#discussion_r257489030 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://www.npmjs.com/package/eslint-plugin-node-core | https://www.npmjs.com/package/eslint-plugin-node-core |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| gengjiawen | https://github.com/gengjiawen |
| Feb 17, 2019 | https://github.com/nodejs/node/pull/26054#discussion_r257500468 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462791886 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| @refack | https://github.com/refack |
| #24813 | https://github.com/nodejs/node/pull/24813 |
| #26054 (comment) | https://github.com/nodejs/node/pull/26054#issuecomment-462778432 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462793116 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462793156 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| @richardlau | https://github.com/richardlau |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462794221 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| force-pushed | https://github.com/nodejs/node/compare/1f4c3396d5e1c23d3f0b4fae5b6363d2835e5b02..5dc33afcc1ac37079deb39afe91b7cee02d77848 |
| 1f4c339 | https://github.com/nodejs/node/commit/1f4c3396d5e1c23d3f0b4fae5b6363d2835e5b02 |
| 5dc33af | https://github.com/nodejs/node/commit/5dc33afcc1ac37079deb39afe91b7cee02d77848 |
|
Compare
| https://github.com/nodejs/node/compare/1f4c3396d5e1c23d3f0b4fae5b6363d2835e5b02..5dc33afcc1ac37079deb39afe91b7cee02d77848 |
| February 12, 2019 15:11 | https://github.com/nodejs/node/pull/26054#event-2133989651 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Feb 12, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-462799459 |
| @richardlau | https://github.com/richardlau |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Feb 13, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-463197307 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/nodejs/node/pulls?q=is%3Apr+eslint+is%3Aclosed | https://github.com/nodejs/node/pulls?q=is%3Apr+eslint+is%3Aclosed |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Feb 17, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-464417906 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://user-images.githubusercontent.com/3759816/52908660-2acc1d00-32b5-11e9-85fe-6e460f4c3a8d.png |
| https://travis-ci.com/nodejs/node/jobs/177139705 | https://travis-ci.com/nodejs/node/jobs/177139705 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Feb 17, 2019 | https://github.com/nodejs/node/pull/26054#issuecomment-464445069 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://npm.community/t/npm-install-failed-on-node-core/5438 | https://npm.community/t/npm-install-failed-on-node-core/5438 |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| force-pushed | https://github.com/nodejs/node/compare/f04884e52fcbf43b5dcbfdbd5f7a958af421d13e..bd085b9a6754452eabe44ee78255455d88eaca68 |
| f04884e | https://github.com/nodejs/node/commit/f04884e52fcbf43b5dcbfdbd5f7a958af421d13e |
| bd085b9 | https://github.com/nodejs/node/commit/bd085b9a6754452eabe44ee78255455d88eaca68 |
|
Compare
| https://github.com/nodejs/node/compare/f04884e52fcbf43b5dcbfdbd5f7a958af421d13e..bd085b9a6754452eabe44ee78255455d88eaca68 |
| February 17, 2019 12:15 | https://github.com/nodejs/node/pull/26054#event-2144658137 |
| gengjiawen | https://github.com/gengjiawen |
| February 19, 2019 23:12 | https://github.com/nodejs/node/pull/26054#commits-pushed-0fecaca |
|
| https://github.com/gengjiawen |
| tools: remove eslint in tools | https://github.com/nodejs/node/pull/26054/commits/0fecaca4bcddc71a37f04a0ae6a61577d0a8a408 |
| 0fecaca | https://github.com/nodejs/node/pull/26054/commits/0fecaca4bcddc71a37f04a0ae6a61577d0a8a408 |
|
| https://github.com/gengjiawen |
| tools: remove eslint in tools | https://github.com/nodejs/node/pull/26054/commits/be9743da86a0c954e96918c0306cd04cc1f63fbd |
| be9743d | https://github.com/nodejs/node/pull/26054/commits/be9743da86a0c954e96918c0306cd04cc1f63fbd |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| force-pushed | https://github.com/nodejs/node/compare/bd085b9a6754452eabe44ee78255455d88eaca68..be9743da86a0c954e96918c0306cd04cc1f63fbd |
| bd085b9 | https://github.com/nodejs/node/commit/bd085b9a6754452eabe44ee78255455d88eaca68 |
| be9743d | https://github.com/nodejs/node/commit/be9743da86a0c954e96918c0306cd04cc1f63fbd |
|
Compare
| https://github.com/nodejs/node/compare/bd085b9a6754452eabe44ee78255455d88eaca68..be9743da86a0c954e96918c0306cd04cc1f63fbd |
| February 19, 2019 16:00 | https://github.com/nodejs/node/pull/26054#event-2149319562 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
| 1ecc406 | https://github.com/nodejs/node/commit/1ecc406b77ba7573ed0b982a7e6654514c71a7a2 |
| 49cf67e | https://github.com/nodejs/node/commit/49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
|
Compare
| https://github.com/nodejs/node/compare/1ecc406b77ba7573ed0b982a7e6654514c71a7a2..49cf67efd66a94a93f4c91be6c39125e7f896ee7 |
| September 17, 2019 16:51 | https://github.com/nodejs/node/pull/26054#event-2640606991 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
| force-pushed | https://github.com/nodejs/node/compare/e8a45686c7512211f96c0fe8153b5253cf5923a6..5289f80eadafcc508b24d5817f0ec416eccf8404 |
| e8a4568 | https://github.com/nodejs/node/commit/e8a45686c7512211f96c0fe8153b5253cf5923a6 |
| 5289f80 | https://github.com/nodejs/node/commit/5289f80eadafcc508b24d5817f0ec416eccf8404 |
|
Compare
| https://github.com/nodejs/node/compare/e8a45686c7512211f96c0fe8153b5253cf5923a6..5289f80eadafcc508b24d5817f0ec416eccf8404 |
| December 26, 2019 19:46 | https://github.com/nodejs/node/pull/26054#event-2909598551 |
| https://github.com/HarshithaKP |
| HarshithaKP | https://github.com/HarshithaKP |
| Apr 12, 2020 | https://github.com/nodejs/node/pull/26054#issuecomment-612615020 |
| @gengjiawen | https://github.com/gengjiawen |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| force-pushed | https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5 |
| 8ae28ff | https://github.com/nodejs/node/commit/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda |
| 2935f72 | https://github.com/nodejs/node/commit/2935f72ae1b991c64118031dec12e7d7db7714a5 |
|
Compare
| https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5 |
| May 31, 2020 12:19 | https://github.com/nodejs/node/pull/26054#event-3390559792 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Jun 25, 2020 | https://github.com/nodejs/node/pull/26054#event-3484423185 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 25, 2020 | https://github.com/nodejs/node/pull/26054#issuecomment-649856510 |
| @gengjiawen | https://github.com/gengjiawen |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| June 25, 2020 22:51 | https://github.com/nodejs/node/pull/26054#event-3484423829 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Jun 29, 2020 | https://github.com/nodejs/node/pull/26054#issuecomment-650876639 |
| @gengjiawen | https://github.com/gengjiawen |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Jun 29, 2020 | https://github.com/nodejs/node/pull/26054#event-3491087493 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F26054 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/26054/files/3b68cc5d5d3db556e99d688dba3cd8901e722a61 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/26054/files/5dc33afcc1ac37079deb39afe91b7cee02d77848 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Please reload this page | https://github.com/nodejs/node/pull/26054 |
|
| https://github.com/gengjiawen |
|
| https://github.com/Trott |
|
| https://github.com/refack |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com/devsnek |
|
| https://github.com/HarshithaKP |
|
| https://github.com/jasnell |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |