René's URL Explorer Experiment


Title: n-api: finalize during second-pass callback by gabrielschulhof · Pull Request #25992 · nodejs/node · GitHub

Open Graph Title: n-api: finalize during second-pass callback by gabrielschulhof · Pull Request #25992 · nodejs/node

X Title: n-api: finalize during second-pass callback by gabrielschulhof · Pull Request #25992 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Calling into the engine from a weak callback is unsafe, however, the engine offers a way to attach a second-pass weak callback which gets called when it is safe to call into JavaScript. This moves ...

X Description: Calling into the engine from a weak callback is unsafe, however, the engine offers a way to attach a second-pass weak callback which gets called when it is safe to call into JavaScript. This moves ...

Opengraph URL: https://github.com/nodejs/node/pull/25992

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2f09f7de-e6e8-d214-8924-902faf8061ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8122:6C0D0:201DFAA:28DB016:6991A38D
html-safe-noncead38e0c4a0c46ac85e3c9250238a9312323f5e6cea3f1f136aa5ba36fab0e985
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTIyOjZDMEQwOjIwMURGQUE6MjhEQjAxNjo2OTkxQTM4RCIsInZpc2l0b3JfaWQiOiIxNjk4MTIwNzU5Mzk2OTAxNzczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb256fac5b6b3ab9af12dbcc9d0a70c5a48f0f44d3acff43d6501ba64887750cc
hovercard-subject-tagpull_request:251255240
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25992/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b7f4dcb7134a321eb9c7149b31b6c6cc659daa6ec5f24be31ff9c53c353fc0b8/nodejs/node/pull/25992
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b7f4dcb7134a321eb9c7149b31b6c6cc659daa6ec5f24be31ff9c53c353fc0b8/nodejs/node/pull/25992
og:image:altCalling into the engine from a weak callback is unsafe, however, the engine offers a way to attach a second-pass weak callback which gets called when it is safe to call into JavaScript. This moves ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25992#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25992
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25992
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25992
Reloadhttps://github.com/nodejs/node/pull/25992
Reloadhttps://github.com/nodejs/node/pull/25992
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25992
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:25927-finalize-during-second-pass-callbackhttps://github.com/gabrielschulhof/node/tree/25927-finalize-during-second-pass-callback
Conversationhttps://github.com/nodejs/node/pull/25992
Commits1 (1)https://github.com/nodejs/node/pull/25992/commits
Checkshttps://github.com/nodejs/node/pull/25992/checks
Files changedhttps://github.com/nodejs/node/pull/25992/files
n-api: finalize during second-pass callbackhttps://github.com/nodejs/node/pull/25992#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:25927-finalize-during-second-pass-callbackhttps://github.com/gabrielschulhof/node/tree/25927-finalize-during-second-pass-callback
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Feb 7, 2019https://github.com/nodejs/node/pull/25992#issue-407880148
#25927https://github.com/nodejs/node/issues/25927
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25992
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 7, 2019https://github.com/nodejs/node/pull/25992#issuecomment-461580852
@gabrielschulhofhttps://github.com/gabrielschulhof
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2538/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2538/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25992
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Feb 7, 2019https://github.com/nodejs/node/pull/25992#event-2125162258
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
addaleaxhttps://github.com/addaleax
hashseedhttps://github.com/hashseed
February 7, 2019 20:19https://github.com/nodejs/node/pull/25992#event-2125162344
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Feb 7, 2019https://github.com/nodejs/node/pull/25992#event-2125162968
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 7, 2019 https://github.com/nodejs/node/pull/25992#pullrequestreview-201303809
View reviewed changes https://github.com/nodejs/node/pull/25992/files
n-api: finalize during second-pass callbackhttps://github.com/nodejs/node/pull/25992/commits/cf043b3821dae559832b4ae43b2df8a0ed524072
cf043b3https://github.com/nodejs/node/pull/25992/commits/cf043b3821dae559832b4ae43b2df8a0ed524072
nodejs#25927https://github.com/nodejs/node/issues/25927
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/2fba9c8fe6a5c345450e38094144d2e9498f7baf..cf043b3821dae559832b4ae43b2df8a0ed524072
2fba9c8https://github.com/nodejs/node/commit/2fba9c8fe6a5c345450e38094144d2e9498f7baf
cf043b3https://github.com/nodejs/node/commit/cf043b3821dae559832b4ae43b2df8a0ed524072
Compare https://github.com/nodejs/node/compare/2fba9c8fe6a5c345450e38094144d2e9498f7baf..cf043b3821dae559832b4ae43b2df8a0ed524072
February 7, 2019 20:24https://github.com/nodejs/node/pull/25992#event-2125174258
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
mhdawsonhttps://github.com/mhdawson
February 7, 2019 21:48https://github.com/nodejs/node/pull/25992#event-2125647728
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Feb 7, 2019 https://github.com/nodejs/node/pull/25992#pullrequestreview-201350850
View reviewed changes https://github.com/nodejs/node/pull/25992/files/cf043b3821dae559832b4ae43b2df8a0ed524072
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/25992#pullrequestreview-201350850
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25992
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Feb 7, 2019https://github.com/nodejs/node/pull/25992#issuecomment-461620990
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/25992
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 8, 2019 https://github.com/nodejs/node/pull/25992#pullrequestreview-201604685
View reviewed changes https://github.com/nodejs/node/pull/25992/files/cf043b3821dae559832b4ae43b2df8a0ed524072
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Feb 10, 2019https://github.com/nodejs/node/pull/25992#issuecomment-462182399
https://ci.nodejs.org/job/node-test-pull-request/20717/https://ci.nodejs.org/job/node-test-pull-request/20717/
Please reload this pagehttps://github.com/nodejs/node/pull/25992
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Feb 11, 2019https://github.com/nodejs/node/pull/25992#issuecomment-462206687
https://ci.nodejs.org/job/node-test-pull-request/20719/https://ci.nodejs.org/job/node-test-pull-request/20719/
Please reload this pagehttps://github.com/nodejs/node/pull/25992
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Feb 11, 2019https://github.com/nodejs/node/pull/25992#issuecomment-462418692
https://ci.nodejs.org/job/node-test-pull-request/20731/https://ci.nodejs.org/job/node-test-pull-request/20731/
Please reload this pagehttps://github.com/nodejs/node/pull/25992
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Feb 11, 2019https://github.com/nodejs/node/pull/25992#issuecomment-462543793
6edf882https://github.com/nodejs/node/commit/6edf88284b2ef522d2f073e66fa32e9cbe6fafd2
Please reload this pagehttps://github.com/nodejs/node/pull/25992
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Feb 11, 2019https://github.com/nodejs/node/pull/25992#event-2132150861
gabrielschulhofhttps://github.com/gabrielschulhof
Feb 11, 2019 https://github.com/nodejs/node/pull/25992#ref-commit-6edf882
n-api: finalize during second-pass callbackhttps://github.com/nodejs/node/commit/6edf88284b2ef522d2f073e66fa32e9cbe6fafd2
6edf882https://github.com/nodejs/node/commit/6edf88284b2ef522d2f073e66fa32e9cbe6fafd2
#25927https://github.com/nodejs/node/issues/25927
#25992https://github.com/nodejs/node/pull/25992
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Feb 12, 2019 https://github.com/nodejs/node/pull/25992#ref-pullrequest-409465826
[v10.x] n-api: finalize during second-pass callback #26058 https://github.com/nodejs/node/pull/26058
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
February 12, 2019 19:36https://github.com/nodejs/node/pull/25992#event-2134741054
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Feb 12, 2019 https://github.com/nodejs/node/pull/25992#ref-pullrequest-409523921
[v8.x] n-api: finalize during second-pass callback #26060 https://github.com/nodejs/node/pull/26060
addaleaxhttps://github.com/addaleax
Feb 13, 2019 https://github.com/nodejs/node/pull/25992#ref-commit-03ffcf7
https://github.com/addaleax
n-api: finalize during second-pass callbackhttps://github.com/nodejs/node/commit/03ffcf76b7cdee745bb53d4b2144f037f0c3017a
03ffcf7https://github.com/nodejs/node/commit/03ffcf76b7cdee745bb53d4b2144f037f0c3017a
#25927https://github.com/nodejs/node/issues/25927
#25992https://github.com/nodejs/node/pull/25992
https://github.com/targos
targoshttps://github.com/targos
Feb 14, 2019 https://github.com/nodejs/node/pull/25992#ref-pullrequest-410304430
v11.10.0 proposal #26098 https://github.com/nodejs/node/pull/26098
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-nodejs#263 https://github.com/beevelop/docker-nodejs/issues/263
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#286 https://github.com/beevelop/docker-android-nodejs/issues/286
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#287 https://github.com/beevelop/docker-android-nodejs/issues/287
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#288 https://github.com/beevelop/docker-android-nodejs/issues/288
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#289 https://github.com/beevelop/docker-android-nodejs/issues/289
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#290 https://github.com/beevelop/docker-android-nodejs/issues/290
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 4, 2019 https://github.com/nodejs/node/pull/25992#ref-commit-e66b09c
n-api: finalize during second-pass callbackhttps://github.com/gabrielschulhof/node/commit/e66b09c659d2186eb11a265a3256ccb6026ee129
e66b09chttps://github.com/gabrielschulhof/node/commit/e66b09c659d2186eb11a265a3256ccb6026ee129
nodejs#25927https://github.com/nodejs/node/issues/25927
nodejs#25992https://github.com/nodejs/node/pull/25992
nodejs#26058https://github.com/nodejs/node/pull/26058
gabrielschulhofhttps://github.com/gabrielschulhof
Mar 4, 2019 https://github.com/nodejs/node/pull/25992#ref-commit-c1a1ea1
n-api: finalize during second-pass callbackhttps://github.com/gabrielschulhof/node/commit/c1a1ea1e099c51fc9a51d74faec1b7fe25d44cba
c1a1ea1https://github.com/gabrielschulhof/node/commit/c1a1ea1e099c51fc9a51d74faec1b7fe25d44cba
nodejs#25927https://github.com/nodejs/node/issues/25927
nodejs#25992https://github.com/nodejs/node/pull/25992
nodejs#26060https://github.com/nodejs/node/pull/26060
BethGriggshttps://github.com/BethGriggs
Mar 12, 2019 https://github.com/nodejs/node/pull/25992#ref-commit-b5588da
https://github.com/BethGriggs
n-api: finalize during second-pass callbackhttps://github.com/nodejs/node/commit/b5588daef08c1be1c2edad11bc80c85631452943
b5588dahttps://github.com/nodejs/node/commit/b5588daef08c1be1c2edad11bc80c85631452943
#25927https://github.com/nodejs/node/issues/25927
#25992https://github.com/nodejs/node/pull/25992
#26058https://github.com/nodejs/node/pull/26058
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 18, 2019 https://github.com/nodejs/node/pull/25992#ref-issue-422393650
node-api/test_exception fails in debug mode #26754 https://github.com/nodejs/node/issues/26754
BethGriggshttps://github.com/BethGriggs
Mar 20, 2019 https://github.com/nodejs/node/pull/25992#ref-commit-2b2ad96
https://github.com/BethGriggs
n-api: finalize during second-pass callbackhttps://github.com/nodejs/node/commit/2b2ad96ef284be7370ddf535b39fa05cf1d77fb1
2b2ad96https://github.com/nodejs/node/commit/2b2ad96ef284be7370ddf535b39fa05cf1d77fb1
#25927https://github.com/nodejs/node/issues/25927
#25992https://github.com/nodejs/node/pull/25992
#26060https://github.com/nodejs/node/pull/26060
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 26, 2019 https://github.com/nodejs/node/pull/25992#ref-pullrequest-425612104
v8.16.0 proposal #26933 https://github.com/nodejs/node/pull/26933
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
May 1, 2019 https://github.com/nodejs/node/pull/25992#ref-pullrequest-439147711
v10.16.0 proposal #27514 https://github.com/nodejs/node/pull/27514
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 6, 2019 https://github.com/nodejs/node/pull/25992#ref-issue-440644226
second pass phantom callback leads to infinite recursion #27577 https://github.com/nodejs/node/issues/27577
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#315 https://github.com/beevelop/docker-android-nodejs/issues/315
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#316 https://github.com/beevelop/docker-android-nodejs/issues/316
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#317 https://github.com/beevelop/docker-android-nodejs/issues/317
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#318 https://github.com/beevelop/docker-android-nodejs/issues/318
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#319 https://github.com/beevelop/docker-android-nodejs/issues/319
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25992
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/25992/files/2fba9c8fe6a5c345450e38094144d2e9498f7baf
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/25992/files/cf043b3821dae559832b4ae43b2df8a0ed524072
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/25992/files/cf043b3821dae559832b4ae43b2df8a0ed524072
https://github.com/hashseed
hashseed https://github.com/hashseed
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
n-api: test for finalizer calls JS from first round phantom callback https://github.com/nodejs/node/issues/25927
Please reload this pagehttps://github.com/nodejs/node/pull/25992
https://github.com/gabrielschulhof
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.