| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b486fd29-4bad-e02e-38f5-70c43e2f2198 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E1F6:358448:F6631:15D77C:696A3E1C |
| html-safe-nonce | 3917a203f409c7959b46b7639b1e1560a07d5b6b3f9b6d8a18f1a98deb1a4a04 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUY2OjM1ODQ0ODpGNjYzMToxNUQ3N0M6Njk2QTNFMUMiLCJ2aXNpdG9yX2lkIjoiNzY2MTM0NzgwODA4MTQ5MzUzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e3bd3ed9d26892d83592b60de7fbcdbe9b6c1c001cb709a8c5cebb13df2bb2e1 |
| hovercard-subject-tag | pull_request:250890784 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25968/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0b8b6de34b1867f483d88f26b19e51b2ea04dde8b356d689a25fe48cddab606b/nodejs/node/pull/25968 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0b8b6de34b1867f483d88f26b19e51b2ea04dde8b356d689a25fe48cddab606b/nodejs/node/pull/25968 |
| og:image:alt | Backport of #25861 and #25929
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sam-github |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 13581a31d51edf4a3aca179e10890a4d4f9b6d76 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25968#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25968 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25968 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25968 |
| Reload | https://github.com/nodejs/node/pull/25968 |
| Reload | https://github.com/nodejs/node/pull/25968 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/25968#issue-comment-box |
| sam-github | https://github.com/sam-github |
| nodejs:v11.x-staging | https://github.com/nodejs/node/tree/v11.x-staging |
| sam-github:backport-25861-to-v11.x | https://github.com/sam-github/node/tree/backport-25861-to-v11.x |
|
[v11.x backport] tls cleanups
| https://github.com/nodejs/node/pull/25968#top |
| sam-github | https://github.com/sam-github |
| nodejs:v11.x-staging | https://github.com/nodejs/node/tree/v11.x-staging |
| sam-github:backport-25861-to-v11.x | https://github.com/sam-github/node/tree/backport-25861-to-v11.x |
|
Conversation
7
| https://github.com/nodejs/node/pull/25968 |
|
Commits
2
| https://github.com/nodejs/node/pull/25968/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/25968/checks |
|
Files changed
| https://github.com/nodejs/node/pull/25968/files |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Feb 6, 2019 | https://github.com/nodejs/node/pull/25968#issue-407409599 |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
| #25861 | https://github.com/nodejs/node/pull/25861 |
| #25929 | https://github.com/nodejs/node/pull/25929 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 6, 2019 | https://github.com/nodejs/node/pull/25968#issuecomment-461169103 |
| @sam-github | https://github.com/sam-github |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2530/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2530/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
v11.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av11.x |
| Feb 6, 2019 | https://github.com/nodejs/node/pull/25968#event-2122311714 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Feb 6, 2019
| https://github.com/nodejs/node/pull/25968#pullrequestreview-200781403 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25968/files |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/3a80599c5f23d5d4d7f2e3d027fa735855ee6c47..7fa600f9fa295ca76fce0722bc7514f7b19e0df0 |
| 3a80599 | https://github.com/nodejs/node/commit/3a80599c5f23d5d4d7f2e3d027fa735855ee6c47 |
| 7fa600f | https://github.com/nodejs/node/commit/7fa600f9fa295ca76fce0722bc7514f7b19e0df0 |
|
Compare
| https://github.com/nodejs/node/compare/3a80599c5f23d5d4d7f2e3d027fa735855ee6c47..7fa600f9fa295ca76fce0722bc7514f7b19e0df0 |
| February 6, 2019 20:11 | https://github.com/nodejs/node/pull/25968#event-2122316333 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Feb 6, 2019
| https://github.com/nodejs/node/pull/25968#ref-pullrequest-405495752 |
|
TLS cleanups
#25861
| https://github.com/nodejs/node/pull/25861 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Feb 6, 2019 | https://github.com/nodejs/node/pull/25968#issuecomment-461195965 |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Feb 6, 2019
| https://github.com/nodejs/node/pull/25968#pullrequestreview-200818786 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25968/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/25968#pullrequestreview-200818786 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
| sam-github | https://github.com/sam-github |
| February 7, 2019 14:14 | https://github.com/nodejs/node/pull/25968#commits-pushed-22f6d4d |
|
| https://github.com/sam-github |
| src: refactor SSLError case statement | https://github.com/nodejs/node/pull/25968/commits/22f6d4df0a05ed199de2dd7da2f710d9cb39cc8f |
| 22f6d4d | https://github.com/nodejs/node/pull/25968/commits/22f6d4df0a05ed199de2dd7da2f710d9cb39cc8f |
| nodejs#25968 | https://github.com/nodejs/node/pull/25968 |
| nodejs#25861 | https://github.com/nodejs/node/pull/25861 |
|
| https://github.com/sam-github |
| tls: in-line comments and other cleanups | https://github.com/nodejs/node/pull/25968/commits/29f040a769bdcd7dd0c4f895ccb93f4c2492dbda |
| 29f040a | https://github.com/nodejs/node/pull/25968/commits/29f040a769bdcd7dd0c4f895ccb93f4c2492dbda |
| nodejs#25861 | https://github.com/nodejs/node/pull/25861 |
| nodejs#25968 | https://github.com/nodejs/node/pull/25968 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Feb 7, 2019 | https://github.com/nodejs/node/pull/25968#issuecomment-461615342 |
| #25876 | https://github.com/nodejs/node/pull/25876 |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/7fa600f9fa295ca76fce0722bc7514f7b19e0df0..29f040a769bdcd7dd0c4f895ccb93f4c2492dbda |
| 7fa600f | https://github.com/nodejs/node/commit/7fa600f9fa295ca76fce0722bc7514f7b19e0df0 |
| 29f040a | https://github.com/nodejs/node/commit/29f040a769bdcd7dd0c4f895ccb93f4c2492dbda |
|
Compare
| https://github.com/nodejs/node/compare/7fa600f9fa295ca76fce0722bc7514f7b19e0df0..29f040a769bdcd7dd0c4f895ccb93f4c2492dbda |
| February 7, 2019 22:16 | https://github.com/nodejs/node/pull/25968#event-2125713597 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Feb 8, 2019 | https://github.com/nodejs/node/pull/25968#issuecomment-461782907 |
| https://ci.nodejs.org/job/node-test-pull-request/20664/ | https://ci.nodejs.org/job/node-test-pull-request/20664/ |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Feb 8, 2019 | https://github.com/nodejs/node/pull/25968#issuecomment-461802507 |
| https://ci.nodejs.org/job/node-test-pull-request/20667/ | https://ci.nodejs.org/job/node-test-pull-request/20667/ |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Feb 8, 2019 | https://github.com/nodejs/node/pull/25968#issuecomment-461984642 |
| 7cf484c | https://github.com/nodejs/node/commit/7cf484c656c7f54e84b824365f794e254800f4d8 |
| fb83f84 | https://github.com/nodejs/node/commit/fb83f842a8c6284f1d38f131f6e7f2f9acc26f3c |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Feb 8, 2019 | https://github.com/nodejs/node/pull/25968#event-2128405970 |
| addaleax | https://github.com/addaleax |
|
Feb 8, 2019
| https://github.com/nodejs/node/pull/25968#ref-commit-7cf484c |
|
| https://github.com/sam-github |
|
| https://github.com/addaleax |
| src: refactor SSLError case statement | https://github.com/nodejs/node/commit/7cf484c656c7f54e84b824365f794e254800f4d8 |
| 7cf484c | https://github.com/nodejs/node/commit/7cf484c656c7f54e84b824365f794e254800f4d8 |
| #25968 | https://github.com/nodejs/node/pull/25968 |
| #25861 | https://github.com/nodejs/node/pull/25861 |
| addaleax | https://github.com/addaleax |
|
Feb 8, 2019
| https://github.com/nodejs/node/pull/25968#ref-commit-fb83f84 |
|
| https://github.com/sam-github |
|
| https://github.com/addaleax |
| tls: in-line comments and other cleanups | https://github.com/nodejs/node/commit/fb83f842a8c6284f1d38f131f6e7f2f9acc26f3c |
| fb83f84 | https://github.com/nodejs/node/commit/fb83f842a8c6284f1d38f131f6e7f2f9acc26f3c |
| #25861 | https://github.com/nodejs/node/pull/25861 |
| #25968 | https://github.com/nodejs/node/pull/25968 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| February 9, 2019 01:29 | https://github.com/nodejs/node/pull/25968#event-2128500138 |
| sam-github | https://github.com/sam-github |
|
Apr 29, 2019
| https://github.com/nodejs/node/pull/25968#ref-commit-5febe41 |
|
| https://github.com/sam-github |
| src: refactor SSLError case statement | https://github.com/sam-github/node/commit/5febe416469cb0a7a330c1313a9b4d34fad333dc |
| 5febe41 | https://github.com/sam-github/node/commit/5febe416469cb0a7a330c1313a9b4d34fad333dc |
| nodejs#25968 | https://github.com/nodejs/node/pull/25968 |
| nodejs#25861 | https://github.com/nodejs/node/pull/25861 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25968 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/25968/files/3a80599c5f23d5d4d7f2e3d027fa735855ee6c47 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/25968/files/7fa600f9fa295ca76fce0722bc7514f7b19e0df0 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/25968 |
|
| https://github.com/sam-github |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
|
| https://github.com/mhdawson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |