René's URL Explorer Experiment


Title: [v11.x backport] src: simplify NativeModule caching and remove redundant data by antsmartian · Pull Request #25964 · nodejs/node · GitHub

Open Graph Title: [v11.x backport] src: simplify NativeModule caching and remove redundant data by antsmartian · Pull Request #25964 · nodejs/node

X Title: [v11.x backport] src: simplify NativeModule caching and remove redundant data by antsmartian · Pull Request #25964 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Backport: #25352 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

X Description: Backport: #25352 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/25964

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4b012e81-d797-9244-1b86-6c9b77b4afe5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD906:1CD42A:AFFE6:F3027:6A4FBA24
html-safe-noncef2733ee52b7ca2409af5e49080b53cc8da3db4dc64444d0469453e04eee0aa8a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTA2OjFDRDQyQTpBRkZFNjpGMzAyNzo2QTRGQkEyNCIsInZpc2l0b3JfaWQiOiI4MTI2OTc3NTI2MzI3MTMwNjYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac13171182082096b322a12791170a67cc300fdd39046ea04245b0ea2c5b5d8925
hovercard-subject-tagpull_request:250827101
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25964/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2be5cfa62e50c5879b5163953a9743dc7cd50ce529e7ee59cd10bd3294e40ab1/nodejs/node/pull/25964
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2be5cfa62e50c5879b5163953a9743dc7cd50ce529e7ee59cd10bd3294e40ab1/nodejs/node/pull/25964
og:image:altBackport: #25352 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameantsmartian
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25964#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25964
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25964
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25964
Reloadhttps://github.com/nodejs/node/pull/25964
Reloadhttps://github.com/nodejs/node/pull/25964
Please reload this pagehttps://github.com/nodejs/node/pull/25964
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25964
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
antsmartianhttps://github.com/antsmartian
nodejs:v11.x-staginghttps://github.com/nodejs/node/tree/v11.x-staging
antsmartian:backport-25352-11xhttps://github.com/antsmartian/node/tree/backport-25352-11x
Conversationhttps://github.com/nodejs/node/pull/25964
Commits2 (2)https://github.com/nodejs/node/pull/25964/commits
Checkshttps://github.com/nodejs/node/pull/25964/checks
Files changedhttps://github.com/nodejs/node/pull/25964/files
[v11.x backport] src: simplify NativeModule caching and remove redundant datahttps://github.com/nodejs/node/pull/25964#top
antsmartianhttps://github.com/antsmartian
nodejs:v11.x-staginghttps://github.com/nodejs/node/tree/v11.x-staging
antsmartian:backport-25352-11xhttps://github.com/antsmartian/node/tree/backport-25352-11x
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Feb 6, 2019https://github.com/nodejs/node/pull/25964#issue-407327565
#25352https://github.com/nodejs/node/pull/25352
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/joyeecheung
https://github.com/antsmartian
src: simplify NativeModule caching and remove redundant datahttps://github.com/nodejs/node/pull/25964/commits/7dd4e41fe52b9d340a4cfc63ea07d965e2c4864b
7dd4e41https://github.com/nodejs/node/pull/25964/commits/7dd4e41fe52b9d340a4cfc63ea07d965e2c4864b
nodejs#25352https://github.com/nodejs/node/pull/25352
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 6, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461095170
@antsmartianhttps://github.com/antsmartian
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2528/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2528/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
v11.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av11.x
Feb 6, 2019https://github.com/nodejs/node/pull/25964#event-2121785963
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 6, 2019 https://github.com/nodejs/node/pull/25964#pullrequestreview-200683748
View reviewed changes https://github.com/nodejs/node/pull/25964/files/7dd4e41fe52b9d340a4cfc63ea07d965e2c4864b
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 6, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461096354
https://ci.nodejs.org/job/node-test-pull-request/20615/https://ci.nodejs.org/job/node-test-pull-request/20615/
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/addaleax
fixup! src: simplify NativeModule caching and remove redundant datahttps://github.com/nodejs/node/pull/25964/commits/c5a7fedc730b48e88b9a955563bb0fa63abcec8d
c5a7fedhttps://github.com/nodejs/node/pull/25964/commits/c5a7fedc730b48e88b9a955563bb0fa63abcec8d
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 6, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461133739
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/job/node-test-pull-request/20619/https://ci.nodejs.org/job/node-test-pull-request/20619/
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Feb 7, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461289570
Please reload this pagehttps://github.com/nodejs/node/pull/25964
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/job/node-test-pull-request/20634/https://ci.nodejs.org/job/node-test-pull-request/20634/
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 7, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461301084
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Feb 7, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461305642
node/Makefilehttps://github.com/nodejs/node/blob/c5a7fedc730b48e88b9a955563bb0fa63abcec8d/Makefile#L447-L454
c5a7fedhttps://github.com/nodejs/node/commit/c5a7fedc730b48e88b9a955563bb0fa63abcec8d
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Feb 7, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461495641
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/refack
refackhttps://github.com/refack
Feb 7, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461503307
https://ci.nodejs.org/job/node-test-commit/25689/https://ci.nodejs.org/job/node-test-commit/25689/
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/refack
refackhttps://github.com/refack
Feb 7, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461503707
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 7, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461528551
https://ci.nodejs.org/job/node-test-commit/25690/https://ci.nodejs.org/job/node-test-commit/25690/
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 7, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461530473
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 8, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461802187
https://ci.nodejs.org/job/node-test-commit/25723/https://ci.nodejs.org/job/node-test-commit/25723/
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 8, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461983893
https://ci.nodejs.org/job/node-test-commit/25738/https://ci.nodejs.org/job/node-test-commit/25738/
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 9, 2019https://github.com/nodejs/node/pull/25964#issuecomment-461992240
b280d90https://github.com/nodejs/node/commit/b280d9027990c9618dba45c50bb829da158a3db0
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 9, 2019https://github.com/nodejs/node/pull/25964#event-2128453083
addaleaxhttps://github.com/addaleax
Feb 9, 2019 https://github.com/nodejs/node/pull/25964#ref-commit-b280d90
https://github.com/joyeecheung
https://github.com/addaleax
src: simplify NativeModule caching and remove redundant datahttps://github.com/nodejs/node/commit/b280d9027990c9618dba45c50bb829da158a3db0
b280d90https://github.com/nodejs/node/commit/b280d9027990c9618dba45c50bb829da158a3db0
#25964https://github.com/nodejs/node/pull/25964
#25352https://github.com/nodejs/node/pull/25352
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
February 10, 2019 06:14https://github.com/nodejs/node/pull/25964#event-2129067650
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25964
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/25964/files/7dd4e41fe52b9d340a4cfc63ea07d965e2c4864b
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/25964
https://github.com/antsmartian
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/richardlau
https://github.com/joyeecheung
https://github.com/refack
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.