René's URL Explorer Experiment


Title: tls: null not valid as a renegotiate callback by sam-github · Pull Request #25929 · nodejs/node · GitHub

Open Graph Title: tls: null not valid as a renegotiate callback by sam-github · Pull Request #25929 · nodejs/node

X Title: tls: null not valid as a renegotiate callback by sam-github · Pull Request #25929 · nodejs/node

Description: Allow undefined as a callback, but do not allow null. Belatedly respond to #25876 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are include...

Open Graph Description: Allow undefined as a callback, but do not allow null. Belatedly respond to #25876 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are include...

X Description: Allow undefined as a callback, but do not allow null. Belatedly respond to #25876 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are include...

Opengraph URL: https://github.com/nodejs/node/pull/25929

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a8fab331-cbac-7de3-b17a-e2ca6b992d74
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCFDC:7E20E:FC54F3:15A93DA:696A9230
html-safe-noncecf23fb354b03ffc8ffd26cac6e95578f41d342897d1d7f0686728c1a7dc9b530
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkRDOjdFMjBFOkZDNTRGMzoxNUE5M0RBOjY5NkE5MjMwIiwidmlzaXRvcl9pZCI6Ijc5Nzg3NzE2Njk2NDk2MjU2NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4142b59411ab635861b74f27533e281c42b53f050d395e039ceb0b4f3df245af
hovercard-subject-tagpull_request:250151198
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25929/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f36e690001e369c1947f7479e0fc338d514c7b5e8ccd4b2099a8aea659156fc5/nodejs/node/pull/25929
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f36e690001e369c1947f7479e0fc338d514c7b5e8ccd4b2099a8aea659156fc5/nodejs/node/pull/25929
og:image:altAllow undefined as a callback, but do not allow null. Belatedly respond to #25876 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are include...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesam-github
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25929#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25929
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25929
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25929
Reloadhttps://github.com/nodejs/node/pull/25929
Reloadhttps://github.com/nodejs/node/pull/25929
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25929
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/25929
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/25929#issue-comment-box
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:only-undef-or-fn-for-reneghttps://github.com/sam-github/node/tree/only-undef-or-fn-for-reneg
tls: null not valid as a renegotiate callback https://github.com/nodejs/node/pull/25929#top
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:only-undef-or-fn-for-reneghttps://github.com/sam-github/node/tree/only-undef-or-fn-for-reneg
Conversation 4 https://github.com/nodejs/node/pull/25929
Commits 1 https://github.com/nodejs/node/pull/25929/commits
Checks 0 https://github.com/nodejs/node/pull/25929/checks
Files changed https://github.com/nodejs/node/pull/25929/files
Please reload this pagehttps://github.com/nodejs/node/pull/25929
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Feb 4, 2019https://github.com/nodejs/node/pull/25929#issue-406457666
Please reload this pagehttps://github.com/nodejs/node/pull/25929
#25876 (comment)https://github.com/nodejs/node/pull/25876#discussion_r253266806
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25929
https://github.com/sam-github
tls: null not valid as a renegotiate callbackhttps://github.com/nodejs/node/pull/25929/commits/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
ce0fcdchttps://github.com/nodejs/node/pull/25929/commits/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
cjihrighttps://github.com/cjihrig
February 4, 2019 18:22https://github.com/nodejs/node/pull/25929#event-2116475969
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 4, 2019https://github.com/nodejs/node/pull/25929#issuecomment-460356278
@sam-githubhttps://github.com/sam-github
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2508/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2508/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25929
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Feb 4, 2019https://github.com/nodejs/node/pull/25929#event-2116476073
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 4, 2019 https://github.com/nodejs/node/pull/25929#pullrequestreview-199734458
View reviewed changes https://github.com/nodejs/node/pull/25929/files/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Feb 5, 2019 https://github.com/nodejs/node/pull/25929#pullrequestreview-199895569
View reviewed changes https://github.com/nodejs/node/pull/25929/files/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Feb 5, 2019 https://github.com/nodejs/node/pull/25929#pullrequestreview-199904616
View reviewed changes https://github.com/nodejs/node/pull/25929/files/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
https://github.com/lpinca
lpincahttps://github.com/lpinca
Feb 5, 2019 https://github.com/nodejs/node/pull/25929#pullrequestreview-199972875
View reviewed changes https://github.com/nodejs/node/pull/25929/files/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
https://github.com/JungMinu
JungMinuhttps://github.com/JungMinu
Feb 5, 2019 https://github.com/nodejs/node/pull/25929#pullrequestreview-200009087
View reviewed changes https://github.com/nodejs/node/pull/25929/files/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 5, 2019 https://github.com/nodejs/node/pull/25929#pullrequestreview-200147987
View reviewed changes https://github.com/nodejs/node/pull/25929/files/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Feb 5, 2019https://github.com/nodejs/node/pull/25929#issuecomment-460850569
https://ci.nodejs.org/job/node-test-commit/25593/https://ci.nodejs.org/job/node-test-commit/25593/
Please reload this pagehttps://github.com/nodejs/node/pull/25929
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 6, 2019https://github.com/nodejs/node/pull/25929#issuecomment-461136777
00d49adhttps://github.com/nodejs/node/commit/00d49ad673b0c4851298ef00522af60186210cfd
Please reload this pagehttps://github.com/nodejs/node/pull/25929
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 6, 2019https://github.com/nodejs/node/pull/25929#event-2122083396
addaleaxhttps://github.com/addaleax
Feb 6, 2019 https://github.com/nodejs/node/pull/25929#ref-commit-00d49ad
https://github.com/sam-github
https://github.com/addaleax
tls: null not valid as a renegotiate callbackhttps://github.com/nodejs/node/commit/00d49ad673b0c4851298ef00522af60186210cfd
00d49adhttps://github.com/nodejs/node/commit/00d49ad673b0c4851298ef00522af60186210cfd
#25929https://github.com/nodejs/node/pull/25929
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backported-to-v11.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v11.x
Feb 6, 2019https://github.com/nodejs/node/pull/25929#event-2122494851
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Feb 6, 2019 https://github.com/nodejs/node/pull/25929#ref-pullrequest-407409599
[v11.x backport] tls cleanups #25968 https://github.com/nodejs/node/pull/25968
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
February 6, 2019 23:11https://github.com/nodejs/node/pull/25929#event-2122703484
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v11.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v11.x
backported-to-v11.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v11.x
Feb 8, 2019https://github.com/nodejs/node/pull/25929#event-2127071242
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 8, 2019https://github.com/nodejs/node/pull/25929#issuecomment-461802843
@sam-githubhttps://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/25929
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#302 https://github.com/beevelop/docker-android-nodejs/issues/302
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#275 https://github.com/beevelop/docker-nodejs/issues/275
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#276 https://github.com/beevelop/docker-nodejs/issues/276
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#303 https://github.com/beevelop/docker-android-nodejs/issues/303
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#277 https://github.com/beevelop/docker-nodejs/issues/277
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#304 https://github.com/beevelop/docker-android-nodejs/issues/304
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#278 https://github.com/beevelop/docker-nodejs/issues/278
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#305 https://github.com/beevelop/docker-android-nodejs/issues/305
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#279 https://github.com/beevelop/docker-nodejs/issues/279
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#306 https://github.com/beevelop/docker-android-nodejs/issues/306
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25929
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/25929/files/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/25929/files/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/25929/files/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
https://github.com/JungMinu
JungMinu https://github.com/JungMinu
https://github.com/nodejs/node/pull/25929/files/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/25929/files/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/25929/files/ce0fcdc78e061c3f411f365f36c5f64c8cec0c12
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/25929
https://github.com/sam-github
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/apapirovski
https://github.com/jasnell
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/JungMinu
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.