| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a9887ca1-155e-efb7-8b8e-e5e0b14ee1b4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BAAC:37E3D3:2417917:31F65B4:6A4F569A |
| html-safe-nonce | 5947ab8aeee1f9954389db3b90d6b47ceae113eafdca2628d9e0ab83831ac71f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUFDOjM3RTNEMzoyNDE3OTE3OjMxRjY1QjQ6NkE0RjU2OUEiLCJ2aXNpdG9yX2lkIjoiMzk1MTE0MTU1NDk4NzQyMzM4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 439e682a19b789723ce8c4016eeceaead09a444b9e325ac9a6fed0a5f29755b8 |
| hovercard-subject-tag | pull_request:250112986 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25925/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/20c217b3012c341a2828712c2b8052935cbd73ad373d190e9e365e625d8df8b5/nodejs/node/pull/25925 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/20c217b3012c341a2828712c2b8052935cbd73ad373d190e9e365e625d8df8b5/nodejs/node/pull/25925 |
| og:image:alt | fs with writev allow many buffers to be pushed to underlying OS
APIs in one batch, so this should improve write speed to files.
I have tried to follow the old fs.write() function signature
and make... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AnasAboreeda |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25925#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25925 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25925 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25925 |
| Reload | https://github.com/nodejs/node/pull/25925 |
| Reload | https://github.com/nodejs/node/pull/25925 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
970
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| AnasAboreeda | https://github.com/AnasAboreeda |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| AnasAboreeda:expose-syscall-writev-to-fs | https://github.com/AnasAboreeda/node/tree/expose-syscall-writev-to-fs |
| Conversation | https://github.com/nodejs/node/pull/25925 |
| Commits3 (3) | https://github.com/nodejs/node/pull/25925/commits |
| Checks | https://github.com/nodejs/node/pull/25925/checks |
| Files changed | https://github.com/nodejs/node/pull/25925/files |
| fs: added fs.writev() which exposes syscalls writev() | https://github.com/nodejs/node/pull/25925#top |
| AnasAboreeda | https://github.com/AnasAboreeda |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| AnasAboreeda:expose-syscall-writev-to-fs | https://github.com/AnasAboreeda/node/tree/expose-syscall-writev-to-fs |
|
| https://github.com/AnasAboreeda |
| AnasAboreeda | https://github.com/AnasAboreeda |
| Feb 4, 2019 | https://github.com/nodejs/node/pull/25925#issue-406408329 |
| #2298 | https://github.com/nodejs/node/issues/2298 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Feb 4, 2019 | https://github.com/nodejs/node/pull/25925#event-2116155546 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 4, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-199676877 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| lib/fs.js | https://github.com/nodejs/node/pull/25925/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 4, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-199677327 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/25925/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 4, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-199678333 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/25925/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Feb 4, 2019 | https://github.com/nodejs/node/pull/25925#issuecomment-460316594 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/AnasAboreeda |
| AnasAboreeda | https://github.com/AnasAboreeda |
| Feb 4, 2019 | https://github.com/nodejs/node/pull/25925#issuecomment-460317996 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Feb 4, 2019 | https://github.com/nodejs/node/pull/25925#issuecomment-460324805 |
| we do for socket writev | https://github.com/nodejs/node/blob/6b7c402518d4b77687584eba2a9284674962f343/src/stream_base.cc#L60 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Feb 4, 2019 | https://github.com/nodejs/node/pull/25925#event-2116356308 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Feb 4, 2019 | https://github.com/nodejs/node/pull/25925#issuecomment-460339782 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Feb 5, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-199983721 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| lib/fs.js | https://github.com/nodejs/node/pull/25925/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| lib/fs.js | https://github.com/nodejs/node/pull/25925/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| lib/fs.js | https://github.com/nodejs/node/pull/25925/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| lib/fs.js | https://github.com/nodejs/node/pull/25925/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| test/parallel/test-fs-writev.js | https://github.com/nodejs/node/pull/25925/files#diff-2b0550ef0a31f6cf6f9a4c3b0c829f4520b192fbc5887ba809cb11071a3a4659 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/AnasAboreeda |
| AnasAboreeda | https://github.com/AnasAboreeda |
| Feb 6, 2019 | https://github.com/nodejs/node/pull/25925#issuecomment-461003142 |
| @addaleax | https://github.com/addaleax |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Feb 6, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200571930 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200571930 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| lib/fs.js | https://github.com/nodejs/node/pull/25925/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| lib/fs.js | https://github.com/nodejs/node/pull/25925/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| test/parallel/test-fs-writev.js | https://github.com/nodejs/node/pull/25925/files#diff-2b0550ef0a31f6cf6f9a4c3b0c829f4520b192fbc5887ba809cb11071a3a4659 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| tools/doc/type-parser.js | https://github.com/nodejs/node/pull/25925/files#diff-6f9e0de8f289dd61ff2ae22d25ce80c7f9cc79887ac213df51dc8072a47341f7 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/AnasAboreeda |
| AnasAboreeda | https://github.com/AnasAboreeda |
| force-pushed | https://github.com/nodejs/node/compare/1519909888132d5ac23522fa529934dbb68de160..9a39133ecfebfc64a308e37ad6461b19091fe1af |
| 1519909 | https://github.com/nodejs/node/commit/1519909888132d5ac23522fa529934dbb68de160 |
| 9a39133 | https://github.com/nodejs/node/commit/9a39133ecfebfc64a308e37ad6461b19091fe1af |
|
Compare
| https://github.com/nodejs/node/compare/1519909888132d5ac23522fa529934dbb68de160..9a39133ecfebfc64a308e37ad6461b19091fe1af |
| February 6, 2019 15:31 | https://github.com/nodejs/node/pull/25925#event-2121560595 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 6, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200678976 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/25925/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 6, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200679296 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/25925/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 6, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200680058 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| lib/fs.js | https://github.com/nodejs/node/pull/25925/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| jasnell | https://github.com/jasnell |
| Feb 6, 2019 | https://github.com/nodejs/node/pull/25925#discussion_r254351645 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| mscdex | https://github.com/mscdex |
| Feb 6, 2019 | https://github.com/nodejs/node/pull/25925#discussion_r254381846 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 6, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200721577 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| test/parallel/test-fs-writev.js | https://github.com/nodejs/node/pull/25925/files#diff-2b0550ef0a31f6cf6f9a4c3b0c829f4520b192fbc5887ba809cb11071a3a4659 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 6, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200726060 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| test/parallel/test-fs-writev.js | https://github.com/nodejs/node/pull/25925/files#diff-2b0550ef0a31f6cf6f9a4c3b0c829f4520b192fbc5887ba809cb11071a3a4659 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/AnasAboreeda |
| AnasAboreeda | https://github.com/AnasAboreeda |
| force-pushed | https://github.com/nodejs/node/compare/2e3f8954d96ba2b5fe49b8bbc3b9f738ed28faa2..137dbcb18e243f4f79e0e4239900294ab6aee62e |
| 2e3f895 | https://github.com/nodejs/node/commit/2e3f8954d96ba2b5fe49b8bbc3b9f738ed28faa2 |
| 137dbcb | https://github.com/nodejs/node/commit/137dbcb18e243f4f79e0e4239900294ab6aee62e |
|
Compare
| https://github.com/nodejs/node/compare/2e3f8954d96ba2b5fe49b8bbc3b9f738ed28faa2..137dbcb18e243f4f79e0e4239900294ab6aee62e |
| February 6, 2019 20:07 | https://github.com/nodejs/node/pull/25925#event-2122304691 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 7, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200909066 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/25925/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 7, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200909105 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/25925/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 7, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200909206 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/25925/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 7, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200909290 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| test/parallel/test-fs-writev.js | https://github.com/nodejs/node/pull/25925/files#diff-2b0550ef0a31f6cf6f9a4c3b0c829f4520b192fbc5887ba809cb11071a3a4659 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/AnasAboreeda |
| AnasAboreeda | https://github.com/AnasAboreeda |
| force-pushed | https://github.com/nodejs/node/compare/137dbcb18e243f4f79e0e4239900294ab6aee62e..35e8aa843a91a7a61f8019e1de3fe49476cda47d |
| 137dbcb | https://github.com/nodejs/node/commit/137dbcb18e243f4f79e0e4239900294ab6aee62e |
| 35e8aa8 | https://github.com/nodejs/node/commit/35e8aa843a91a7a61f8019e1de3fe49476cda47d |
|
Compare
| https://github.com/nodejs/node/compare/137dbcb18e243f4f79e0e4239900294ab6aee62e..35e8aa843a91a7a61f8019e1de3fe49476cda47d |
| February 7, 2019 06:37 | https://github.com/nodejs/node/pull/25925#event-2123206857 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 7, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200942997 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| test/parallel/test-fs-writev.js | https://github.com/nodejs/node/pull/25925/files#diff-2b0550ef0a31f6cf6f9a4c3b0c829f4520b192fbc5887ba809cb11071a3a4659 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 7, 2019
| https://github.com/nodejs/node/pull/25925#pullrequestreview-200943581 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25925/files |
| test/parallel/test-fs-writev.js | https://github.com/nodejs/node/pull/25925/files#diff-2b0550ef0a31f6cf6f9a4c3b0c829f4520b192fbc5887ba809cb11071a3a4659 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Feb 7, 2019 | https://github.com/nodejs/node/pull/25925#issuecomment-461311064 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
| targos | https://github.com/targos |
|
Aug 19, 2019
| https://github.com/nodejs/node/pull/25925#ref-commit-bb19d82 |
|
| https://github.com/AnasAboreeda |
|
| https://github.com/targos |
| fs: add fs.writev() which exposes syscall writev() | https://github.com/nodejs/node/commit/bb19d8212a977298d23cb7f7206e3972a64407fe |
| bb19d82 | https://github.com/nodejs/node/commit/bb19d8212a977298d23cb7f7206e3972a64407fe |
| #2298 | https://github.com/nodejs/node/issues/2298 |
| #25925 | https://github.com/nodejs/node/pull/25925 |
| #2298 | https://github.com/nodejs/node/issues/2298 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Aug 19, 2019
| https://github.com/nodejs/node/pull/25925#ref-pullrequest-482485175 |
|
v12.9.0 release proposal
#29210
| https://github.com/nodejs/node/pull/29210 |
| targos | https://github.com/targos |
|
Aug 19, 2019
| https://github.com/nodejs/node/pull/25925#ref-commit-a87f0e1 |
|
| https://github.com/targos |
| 2019-08-20, Version 12.9.0 (Current) | https://github.com/nodejs/node/commit/a87f0e1df6db04886ef84fc49259c4a0c198c489 |
| a87f0e1 | https://github.com/nodejs/node/commit/a87f0e1df6db04886ef84fc49259c4a0c198c489 |
| #28335 | https://github.com/nodejs/node/pull/28335 |
| #28335 | https://github.com/nodejs/node/pull/28335 |
| #28955 | https://github.com/nodejs/node/pull/28955 |
| #28955 | https://github.com/nodejs/node/pull/28955 |
| https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled | https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled |
| https://v8.dev/blog/v8-release-76 | https://v8.dev/blog/v8-release-76 |
| #29070 | https://github.com/nodejs/node/pull/29070 |
| #29070 | https://github.com/nodejs/node/pull/29070 |
| #25925 | https://github.com/nodejs/node/pull/25925 |
| #25925 | https://github.com/nodejs/node/pull/25925 |
| #29018 | https://github.com/nodejs/node/pull/29018 |
| #29018 | https://github.com/nodejs/node/pull/29018 |
| #28934 | https://github.com/nodejs/node/pull/28934 |
| #28934 | https://github.com/nodejs/node/pull/28934 |
| #29210 | https://github.com/nodejs/node/pull/29210 |
| cjihrig | https://github.com/cjihrig |
|
Aug 19, 2019
| https://github.com/nodejs/node/pull/25925#ref-commit-3273d0e |
|
| https://github.com/cjihrig |
| fs: add writev() promises version | https://github.com/cjihrig/node/commit/3273d0e9514da750405cc2e3662d72dcbb489380 |
| 3273d0e | https://github.com/cjihrig/node/commit/3273d0e9514da750405cc2e3662d72dcbb489380 |
| nodejs#25925 | https://github.com/nodejs/node/pull/25925 |
| nodejs#25925 | https://github.com/nodejs/node/pull/25925 |
| nodejs#29186 | https://github.com/nodejs/node/pull/29186 |
| targos | https://github.com/targos |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/25925#ref-commit-4356836 |
|
| https://github.com/cjihrig |
|
| https://github.com/targos |
| fs: validate writev fds consistently | https://github.com/nodejs/node/commit/435683610b8559755f424c7714336b364d95c1b5 |
| 4356836 | https://github.com/nodejs/node/commit/435683610b8559755f424c7714336b364d95c1b5 |
| #29185 | https://github.com/nodejs/node/pull/29185 |
| #25925 | https://github.com/nodejs/node/pull/25925 |
| targos | https://github.com/targos |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/25925#ref-commit-81f3eb5 |
|
| https://github.com/cjihrig |
|
| https://github.com/targos |
| fs: add writev() promises version | https://github.com/nodejs/node/commit/81f3eb5bb1899fbc0f0418440b0ba0cc1a70ae6a |
| 81f3eb5 | https://github.com/nodejs/node/commit/81f3eb5bb1899fbc0f0418440b0ba0cc1a70ae6a |
| #25925 | https://github.com/nodejs/node/pull/25925 |
| #25925 | https://github.com/nodejs/node/pull/25925 |
| #29186 | https://github.com/nodejs/node/pull/29186 |
| targos | https://github.com/targos |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/25925#ref-commit-43d6619 |
|
| https://github.com/targos |
| 2019-08-20, Version 12.9.0 (Current) | https://github.com/nodejs/node/commit/43d66196fa9cd28d6bdecd99247cf3d64aec1309 |
| 43d6619 | https://github.com/nodejs/node/commit/43d66196fa9cd28d6bdecd99247cf3d64aec1309 |
| #28335 | https://github.com/nodejs/node/pull/28335 |
| #28955 | https://github.com/nodejs/node/pull/28955 |
| https://v8.dev/blog/v8-release-76 | https://v8.dev/blog/v8-release-76 |
| #29070 | https://github.com/nodejs/node/pull/29070 |
| #25925 | https://github.com/nodejs/node/pull/25925 |
| https://github.com/nodejs/node/pull/29186/files | https://github.com/nodejs/node/pull/29186/files |
| #29018 | https://github.com/nodejs/node/pull/29018 |
| #28814 | https://github.com/nodejs/node/pull/28814 |
| #28934 | https://github.com/nodejs/node/pull/28934 |
| #29210 | https://github.com/nodejs/node/pull/29210 |
| targos | https://github.com/targos |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/25925#ref-commit-a9adfdb |
|
| https://github.com/targos |
| 2019-08-20, Version 12.9.0 (Current) | https://github.com/targos/node/commit/a9adfdb1f9b99ba47690acfd458318a0c777787b |
| a9adfdb | https://github.com/targos/node/commit/a9adfdb1f9b99ba47690acfd458318a0c777787b |
| nodejs#28335 | https://github.com/nodejs/node/pull/28335 |
| nodejs#28955 | https://github.com/nodejs/node/pull/28955 |
| https://v8.dev/blog/v8-release-76 | https://v8.dev/blog/v8-release-76 |
| nodejs#29070 | https://github.com/nodejs/node/pull/29070 |
| nodejs#25925 | https://github.com/nodejs/node/pull/25925 |
| https://github.com/nodejs/node/pull/29186/files | https://github.com/nodejs/node/pull/29186/files |
| nodejs#29018 | https://github.com/nodejs/node/pull/29018 |
| nodejs#28814 | https://github.com/nodejs/node/pull/28814 |
| nodejs#28934 | https://github.com/nodejs/node/pull/28934 |
| nodejs#29210 | https://github.com/nodejs/node/pull/29210 |
| targos | https://github.com/targos |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/25925#ref-commit-e6872f5 |
|
| https://github.com/targos |
| 2019-08-20, Version 12.9.0 (Current) | https://github.com/nodejs/node/commit/e6872f5f4bf7dc418bd77a3f2a911fb2c48e3df1 |
| e6872f5 | https://github.com/nodejs/node/commit/e6872f5f4bf7dc418bd77a3f2a911fb2c48e3df1 |
| #28335 | https://github.com/nodejs/node/pull/28335 |
| #28955 | https://github.com/nodejs/node/pull/28955 |
| https://v8.dev/blog/v8-release-76 | https://v8.dev/blog/v8-release-76 |
| #29070 | https://github.com/nodejs/node/pull/29070 |
| #25925 | https://github.com/nodejs/node/pull/25925 |
| #29186 | https://github.com/nodejs/node/pull/29186 |
| #29018 | https://github.com/nodejs/node/pull/29018 |
| #28814 | https://github.com/nodejs/node/pull/28814 |
| #28934 | https://github.com/nodejs/node/pull/28934 |
| #29210 | https://github.com/nodejs/node/pull/29210 |
| targos | https://github.com/targos |
|
Aug 20, 2019
| https://github.com/nodejs/node/pull/25925#ref-commit-edc83a9 |
|
| https://github.com/targos |
| 2019-08-20, Version 12.9.0 (Current) | https://github.com/nodejs/node/commit/edc83a9203c2a8d0fd219aac95fd1615e001c484 |
| edc83a9 | https://github.com/nodejs/node/commit/edc83a9203c2a8d0fd219aac95fd1615e001c484 |
| #28335 | https://github.com/nodejs/node/pull/28335 |
| #28955 | https://github.com/nodejs/node/pull/28955 |
| https://v8.dev/blog/v8-release-76 | https://v8.dev/blog/v8-release-76 |
| #29070 | https://github.com/nodejs/node/pull/29070 |
| #25925 | https://github.com/nodejs/node/pull/25925 |
| #29186 | https://github.com/nodejs/node/pull/29186 |
| #29018 | https://github.com/nodejs/node/pull/29018 |
| #28814 | https://github.com/nodejs/node/pull/28814 |
| #28934 | https://github.com/nodejs/node/pull/28934 |
| #29210 | https://github.com/nodejs/node/pull/29210 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-android-nodejs#328
| https://github.com/beevelop/docker-android-nodejs/issues/328 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-android-nodejs#329
| https://github.com/beevelop/docker-android-nodejs/issues/329 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-android-nodejs#330
| https://github.com/beevelop/docker-android-nodejs/issues/330 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-nodejs#295
| https://github.com/beevelop/docker-nodejs/issues/295 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-nodejs#296
| https://github.com/beevelop/docker-nodejs/issues/296 |
|
2019-08-20 Version 12.9.0 (Current) @targos
beevelop/docker-nodejs#297
| https://github.com/beevelop/docker-nodejs/issues/297 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25925 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/25925/files/53930c2d936e8271bd4188fd19112b5e35ec4bca |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/25925/files/a006db98db7a1a0b9b5b2e6eb56ebc236d0d7632 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/25925/files/a006db98db7a1a0b9b5b2e6eb56ebc236d0d7632 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/25925/files/e5c7f8d584e8815e7d601964f5324b55aca75004 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/25925/files/c9f8a076df91d033c89f2e3520225ee217322a7e |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/25925/files/35e8aa843a91a7a61f8019e1de3fe49476cda47d |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/25925/files/4c5c901ba27fd2f5af568b074e144b1ea5e114ac |
|
| https://github.com/reqshark |
|
reqshark
| https://github.com/reqshark |
|
| https://github.com/nodejs/node/pull/25925/files/35e8aa843a91a7a61f8019e1de3fe49476cda47d |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/25925/files/c9f8a076df91d033c89f2e3520225ee217322a7e |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
fs: expose scatter/gather syscalls writev() and readv()
| https://github.com/nodejs/node/issues/2298 |
| Please reload this page | https://github.com/nodejs/node/pull/25925 |
|
| https://github.com/AnasAboreeda |
|
| https://github.com/mscdex |
|
| https://github.com/addaleax |
|
| https://github.com/reqshark |
|
| https://github.com/joe9111 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/thefourtheye |
|
| https://github.com/targos |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |