René's URL Explorer Experiment


Title: test: do not fail SLOW tests if they are not slow by hashseed · Pull Request #25868 · nodejs/node · GitHub

Open Graph Title: test: do not fail SLOW tests if they are not slow by hashseed · Pull Request #25868 · nodejs/node

X Title: test: do not fail SLOW tests if they are not slow by hashseed · Pull Request #25868 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Make SLOW imply PASS. Refs: #25867 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Make SLOW imply PASS. Refs: #25867 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/25868

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:48617001-a0d8-83f3-d529-22f163257530
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id82D6:CE000:1DEBE96:2AAAB25:6A50DCE6
html-safe-nonce49c2c6c2932b89d442df8654a57867a1d20e3b1ee0ef1b5b49a12e4ba304cfbc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkQ2OkNFMDAwOjFERUJFOTY6MkFBQUIyNTo2QTUwRENFNiIsInZpc2l0b3JfaWQiOiI4MDYwMjk0NDk1NDQ5NzAxNjA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3e92f2c2b6786bf63e11a71b089dde8c005e695e312b4a5501f0ad424e0b8718
hovercard-subject-tagpull_request:249588443
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25868/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/44d1aa3787c53f01439059bc65f1f57bc4303c7768743a213a38679162e623d9/nodejs/node/pull/25868
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/44d1aa3787c53f01439059bc65f1f57bc4303c7768743a213a38679162e623d9/nodejs/node/pull/25868
og:image:altMake SLOW imply PASS. Refs: #25867 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehashseed
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release17290b65caabb92b271e0949d1bf147b63deab41
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25868#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25868
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25868
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25868
Reloadhttps://github.com/nodejs/node/pull/25868
Reloadhttps://github.com/nodejs/node/pull/25868
Please reload this pagehttps://github.com/nodejs/node/pull/25868
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25868
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
hashseedhttps://github.com/hashseed
nodejs:masterhttps://github.com/nodejs/node/tree/master
hashseed:slowtestshttps://github.com/hashseed/node/tree/slowtests
Conversationhttps://github.com/nodejs/node/pull/25868
Commits1 (1)https://github.com/nodejs/node/pull/25868/commits
Checkshttps://github.com/nodejs/node/pull/25868/checks
Files changedhttps://github.com/nodejs/node/pull/25868/files
test: do not fail SLOW tests if they are not slowhttps://github.com/nodejs/node/pull/25868#top
hashseedhttps://github.com/hashseed
nodejs:masterhttps://github.com/nodejs/node/tree/master
hashseed:slowtestshttps://github.com/hashseed/node/tree/slowtests
https://github.com/hashseed
hashseedhttps://github.com/hashseed
Feb 1, 2019https://github.com/nodejs/node/pull/25868#issue-405683281
#25867https://github.com/nodejs/node/issues/25867
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25868
https://github.com/hashseed
test: do not fail SLOW tests if they are not slowhttps://github.com/nodejs/node/pull/25868/commits/4df1ab720fc14a66fc3559aa7b5bc1e4fddc02b7
4df1ab7https://github.com/nodejs/node/pull/25868/commits/4df1ab720fc14a66fc3559aa7b5bc1e4fddc02b7
https://github.com/hashseed
hashseedhttps://github.com/hashseed
addaleaxhttps://github.com/addaleax
refackhttps://github.com/refack
February 1, 2019 12:33https://github.com/nodejs/node/pull/25868#event-2112066475
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 1, 2019https://github.com/nodejs/node/pull/25868#issuecomment-459708593
@hashseedhttps://github.com/hashseed
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2481/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2481/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25868
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Feb 1, 2019https://github.com/nodejs/node/pull/25868#event-2112066551
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Feb 1, 2019 https://github.com/nodejs/node/pull/25868#pullrequestreview-199053906
View reviewed changes https://github.com/nodejs/node/pull/25868/files/4df1ab720fc14a66fc3559aa7b5bc1e4fddc02b7
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Feb 1, 2019 https://github.com/nodejs/node/pull/25868#ref-pullrequest-403152420
test: add PASS to outcomes in debug mode #25698 https://github.com/nodejs/node/pull/25698
https://github.com/danbev
danbevhttps://github.com/danbev
Feb 1, 2019 https://github.com/nodejs/node/pull/25868#pullrequestreview-199056076
View reviewed changes https://github.com/nodejs/node/pull/25868/files/4df1ab720fc14a66fc3559aa7b5bc1e4fddc02b7
https://github.com/refack
refackhttps://github.com/refack
Feb 1, 2019 https://github.com/nodejs/node/pull/25868#pullrequestreview-199079246
View reviewed changes https://github.com/nodejs/node/pull/25868/files/4df1ab720fc14a66fc3559aa7b5bc1e4fddc02b7
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 2, 2019 https://github.com/nodejs/node/pull/25868#pullrequestreview-199363142
View reviewed changes https://github.com/nodejs/node/pull/25868/files/4df1ab720fc14a66fc3559aa7b5bc1e4fddc02b7
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 2, 2019https://github.com/nodejs/node/pull/25868#issuecomment-460000499
https://ci.nodejs.org/job/node-test-pull-request/20546/https://ci.nodejs.org/job/node-test-pull-request/20546/
Please reload this pagehttps://github.com/nodejs/node/pull/25868
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Feb 2, 2019https://github.com/nodejs/node/pull/25868#event-2114027214
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Feb 2, 2019 https://github.com/nodejs/node/pull/25868#pullrequestreview-199363235
View reviewed changes https://github.com/nodejs/node/pull/25868/files/4df1ab720fc14a66fc3559aa7b5bc1e4fddc02b7
https://github.com/hashseed
hashseedhttps://github.com/hashseed
Feb 4, 2019https://github.com/nodejs/node/pull/25868#issuecomment-460143737
Jenkins related issuehttps://ci.nodejs.org/job/node-test-commit-linux/nodes=alpine-latest-x64/25091/console
Please reload this pagehttps://github.com/nodejs/node/pull/25868
https://github.com/refack
refackhttps://github.com/refack
Feb 4, 2019https://github.com/nodejs/node/pull/25868#issuecomment-460287394
Please reload this pagehttps://github.com/nodejs/node/pull/25868
Jenkins related issuehttps://ci.nodejs.org/job/node-test-commit-linux/nodes=alpine-latest-x64/25091/console
https://ci.nodejs.org/job/node-test-pull-request/20562/https://ci.nodejs.org/job/node-test-pull-request/20562/
Please reload this pagehttps://github.com/nodejs/node/pull/25868
https://github.com/refack
refackhttps://github.com/refack
landed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alanded
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Feb 4, 2019https://github.com/nodejs/node/pull/25868#event-2116228059
https://github.com/refack
refackhttps://github.com/refack
Feb 4, 2019https://github.com/nodejs/node/pull/25868#issuecomment-460321701
dfe5f8fhttps://github.com/nodejs/node/commit/dfe5f8f288329ed1e92e46cc2507c16db8ae249e
Please reload this pagehttps://github.com/nodejs/node/pull/25868
https://github.com/refack
refackhttps://github.com/refack
Feb 4, 2019https://github.com/nodejs/node/pull/25868#event-2116228170
refackhttps://github.com/refack
Feb 4, 2019 https://github.com/nodejs/node/pull/25868#ref-commit-dfe5f8f
https://github.com/hashseed
https://github.com/refack
test: do not fail SLOW tests if they are not slowhttps://github.com/nodejs/node/commit/dfe5f8f288329ed1e92e46cc2507c16db8ae249e
dfe5f8fhttps://github.com/nodejs/node/commit/dfe5f8f288329ed1e92e46cc2507c16db8ae249e
#25868https://github.com/nodejs/node/pull/25868
#25867https://github.com/nodejs/node/issues/25867
addaleaxhttps://github.com/addaleax
Feb 6, 2019 https://github.com/nodejs/node/pull/25868#ref-commit-025a7c3
https://github.com/hashseed
https://github.com/addaleax
test: do not fail SLOW tests if they are not slowhttps://github.com/nodejs/node/commit/025a7c3e31c5c3f684b167e8d668effe89dfbc64
025a7c3https://github.com/nodejs/node/commit/025a7c3e31c5c3f684b167e8d668effe89dfbc64
#25868https://github.com/nodejs/node/pull/25868
#25867https://github.com/nodejs/node/issues/25867
https://github.com/targos
targoshttps://github.com/targos
Feb 14, 2019 https://github.com/nodejs/node/pull/25868#ref-pullrequest-410304430
v11.10.0 proposal #26098 https://github.com/nodejs/node/pull/26098
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-nodejs#263 https://github.com/beevelop/docker-nodejs/issues/263
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#286 https://github.com/beevelop/docker-android-nodejs/issues/286
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#287 https://github.com/beevelop/docker-android-nodejs/issues/287
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#288 https://github.com/beevelop/docker-android-nodejs/issues/288
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#289 https://github.com/beevelop/docker-android-nodejs/issues/289
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#290 https://github.com/beevelop/docker-android-nodejs/issues/290
https://github.com/hashseed
hashseedhttps://github.com/hashseed
February 15, 2019 12:49https://github.com/nodejs/node/pull/25868#event-2142390515
https://github.com/richardlau
richardlauhttps://github.com/richardlau
lts-watch-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x
Dec 2, 2019https://github.com/nodejs/node/pull/25868#event-2846734866
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Dec 2, 2019 https://github.com/nodejs/node/pull/25868#ref-issue-530567516
Changes to ubuntu1804 sharedlibs containers? nodejs/build#2072 https://github.com/nodejs/build/issues/2072
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
lts-watch-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v10.x
Dec 4, 2019https://github.com/nodejs/node/pull/25868#event-2855539652
BethGriggshttps://github.com/BethGriggs
Dec 4, 2019 https://github.com/nodejs/node/pull/25868#ref-commit-fabbc76
https://github.com/hashseed
https://github.com/BethGriggs
test: do not fail SLOW tests if they are not slowhttps://github.com/nodejs/node/commit/fabbc76928009f1d29b54850aa5bf3406774d7b1
fabbc76https://github.com/nodejs/node/commit/fabbc76928009f1d29b54850aa5bf3406774d7b1
#25868https://github.com/nodejs/node/pull/25868
#25867https://github.com/nodejs/node/issues/25867
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 4, 2019 https://github.com/nodejs/node/pull/25868#ref-pullrequest-532977448
v10.18.1 proposal #30796 https://github.com/nodejs/node/pull/30796
MylesBorinshttps://github.com/MylesBorins
Dec 17, 2019 https://github.com/nodejs/node/pull/25868#ref-commit-7e941eb
https://github.com/hashseed
https://github.com/MylesBorins
test: do not fail SLOW tests if they are not slowhttps://github.com/nodejs/node/commit/7e941eb17db2f11c01062fbd09262c2a6a03ec80
7e941ebhttps://github.com/nodejs/node/commit/7e941eb17db2f11c01062fbd09262c2a6a03ec80
#25868https://github.com/nodejs/node/pull/25868
#25867https://github.com/nodejs/node/issues/25867
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jan 7, 2020 https://github.com/nodejs/node/pull/25868#ref-pullrequest-546358744
v10.18.1 proposal #31248 https://github.com/nodejs/node/pull/31248
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25868
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/25868/files/4df1ab720fc14a66fc3559aa7b5bc1e4fddc02b7
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/25868/files/4df1ab720fc14a66fc3559aa7b5bc1e4fddc02b7
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/25868/files/4df1ab720fc14a66fc3559aa7b5bc1e4fddc02b7
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/25868/files/4df1ab720fc14a66fc3559aa7b5bc1e4fddc02b7
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/25868/files/4df1ab720fc14a66fc3559aa7b5bc1e4fddc02b7
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/25868
https://github.com/hashseed
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/refack
https://github.com/danbev
https://github.com/richardlau
https://github.com/devsnek
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.