René's URL Explorer Experiment


Title: Revert "lib,src: add unix socket getsockname/getpeername" by bnoordhuis · Pull Request #2584 · nodejs/node · GitHub

Open Graph Title: Revert "lib,src: add unix socket getsockname/getpeername" by bnoordhuis · Pull Request #2584 · nodejs/node

X Title: Revert "lib,src: add unix socket getsockname/getpeername" by bnoordhuis · Pull Request #2584 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit 6cd0e26. This reverts commit 7a999a1. This reverts commit f337595. It turns out that on Windows, uv_pipe_getsockname() is a no-op for client sockets. It slipped through testing...

X Description: This reverts commit 6cd0e26. This reverts commit 7a999a1. This reverts commit f337595. It turns out that on Windows, uv_pipe_getsockname() is a no-op for client sockets. It slipped through testing...

Opengraph URL: https://github.com/nodejs/node/pull/2584

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:081a7e88-cc54-acda-8593-1e4423739ff9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA62:B5089:11B71E9:1898F7A:6A4E9510
html-safe-noncea82526daa022f74b5480a9d2946f1178f73e22c2dbacd792584517dae7bde6cd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTYyOkI1MDg5OjExQjcxRTk6MTg5OEY3QTo2QTRFOTUxMCIsInZpc2l0b3JfaWQiOiI4NDE5MDUxMjc5NzMzMzk2NzUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac93ebf2f51512124b2fb65b9936f52fe92d969fb6a06bc209676542e1e8315610
hovercard-subject-tagpull_request:43565501
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2584/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c553568b4f689440edd942d742173ed5b24b5e780af7fcaa097be4a235393d05/nodejs/node/pull/2584
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c553568b4f689440edd942d742173ed5b24b5e780af7fcaa097be4a235393d05/nodejs/node/pull/2584
og:image:altThis reverts commit 6cd0e26. This reverts commit 7a999a1. This reverts commit f337595. It turns out that on Windows, uv_pipe_getsockname() is a no-op for client sockets. It slipped through testing...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/2584#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2584
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2584
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/2584
Reloadhttps://github.com/nodejs/node/pull/2584
Reloadhttps://github.com/nodejs/node/pull/2584
Please reload this pagehttps://github.com/nodejs/node/pull/2584
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/2584
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:revert-pipe-getsocknamehttps://github.com/bnoordhuis/io.js/tree/revert-pipe-getsockname
Conversationhttps://github.com/nodejs/node/pull/2584
Commits1 (1)https://github.com/nodejs/node/pull/2584/commits
Checkshttps://github.com/nodejs/node/pull/2584/checks
Files changedhttps://github.com/nodejs/node/pull/2584/files
Revert "lib,src: add unix socket getsockname/getpeername"https://github.com/nodejs/node/pull/2584#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:revert-pipe-getsocknamehttps://github.com/bnoordhuis/io.js/tree/revert-pipe-getsockname
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 27, 2015https://github.com/nodejs/node/pull/2584#issue-103593089
6cd0e26https://github.com/nodejs/node/commit/6cd0e2664b1ce944e5e461457d160be83f70d379
7a999a1https://github.com/nodejs/node/commit/7a999a13766ac68049812fedbdfd15a0250f0f07
f337595https://github.com/nodejs/node/commit/f337595441641ad36f6ab8ae770e56c1673ef692
@thefourtheyehttps://github.com/thefourtheye
https://jenkins-iojs.nodesource.com/job/node-test-pull-request/193/https://jenkins-iojs.nodesource.com/job/node-test-pull-request/193/
Please reload this pagehttps://github.com/nodejs/node/pull/2584
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 27, 2015 https://github.com/nodejs/node/pull/2584#ref-pullrequest-58931677
lib,src: add unix socket getsockname/getpeername #956 https://github.com/nodejs/node/pull/956
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Aug 27, 2015https://github.com/nodejs/node/pull/2584#issuecomment-135553756
a43af39https://github.com/nodejs/node/commit/a43af39ffc369776f776c69e5287c9632349fc2b
Please reload this pagehttps://github.com/nodejs/node/pull/2584
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 27, 2015https://github.com/nodejs/node/pull/2584#issuecomment-135555252
Please reload this pagehttps://github.com/nodejs/node/pull/2584
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Aug 27, 2015https://github.com/nodejs/node/pull/2584#issuecomment-135555319
Please reload this pagehttps://github.com/nodejs/node/pull/2584
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Aug 27, 2015https://github.com/nodejs/node/pull/2584#issuecomment-135556705
Please reload this pagehttps://github.com/nodejs/node/pull/2584
https://github.com/bnoordhuis
Revert "lib,src: add unix socket getsockname/getpeername"https://github.com/nodejs/node/pull/2584/commits/de88255b0fb8c74e27cd5616f54d614b4e46b48d
de88255https://github.com/nodejs/node/pull/2584/commits/de88255b0fb8c74e27cd5616f54d614b4e46b48d
6cd0e26https://github.com/bnoordhuis/io.js/commit/6cd0e2664b1ce944e5e461457d160be83f70d379
7a999a1https://github.com/bnoordhuis/io.js/commit/7a999a13766ac68049812fedbdfd15a0250f0f07
f337595https://github.com/bnoordhuis/io.js/commit/f337595441641ad36f6ab8ae770e56c1673ef692
nodejs#2584https://github.com/nodejs/node/pull/2584
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/bba472c60a7e31e25d7093f4e98eae983488b955..de88255b0fb8c74e27cd5616f54d614b4e46b48d
bba472chttps://github.com/nodejs/node/commit/bba472c60a7e31e25d7093f4e98eae983488b955
de88255https://github.com/nodejs/node/commit/de88255b0fb8c74e27cd5616f54d614b4e46b48d
Compare https://github.com/nodejs/node/compare/bba472c60a7e31e25d7093f4e98eae983488b955..de88255b0fb8c74e27cd5616f54d614b4e46b48d
August 27, 2015 22:15https://github.com/nodejs/node/pull/2584#event-394527702
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 27, 2015https://github.com/nodejs/node/pull/2584#event-394527752
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
August 27, 2015 22:15https://github.com/nodejs/node/pull/2584#event-394527754
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
de88255https://github.com/nodejs/node/commit/de88255b0fb8c74e27cd5616f54d614b4e46b48d
Aug 27, 2015https://github.com/nodejs/node/pull/2584#event-394527836
https://github.com/rvagg
rvagghttps://github.com/rvagg
Aug 29, 2015 https://github.com/nodejs/node/pull/2584#ref-issue-103815442
Release proposal: v3.3.0 #2607 https://github.com/nodejs/node/issues/2607
https://github.com/rvagg
rvagghttps://github.com/rvagg
Sep 7, 2015 https://github.com/nodejs/node/pull/2584#ref-pullrequest-105142249
Release proposal: v4.0.0 #2715 https://github.com/nodejs/node/pull/2715
jsonnhttps://github.com/jsonn
Sep 9, 2015 https://github.com/nodejs/node/pull/2584#ref-commit-33b3766
Update to 4.0.0https://github.com/jsonn/pkgsrc/commit/33b3766530c9de4a54b95c97cc3f1c4dfc57c845
33b3766https://github.com/jsonn/pkgsrc/commit/33b3766530c9de4a54b95c97cc3f1c4dfc57c845
https://github.com/rvagg
rvagghttps://github.com/rvagg
Sep 15, 2015 https://github.com/nodejs/node/pull/2584#ref-pullrequest-104996474
Release proposal: v3.3.1 #2698 https://github.com/nodejs/node/pull/2698
mskhttps://github.com/msk
May 11, 2026 https://github.com/nodejs/node/pull/2584#ref-commit-e40913a
https://github.com/ryoon
Update to 4.0.0https://github.com/msk/pkgsrc/commit/e40913a84d8a2f34a1cfb92bd22db143bc1e0c52
e40913ahttps://github.com/msk/pkgsrc/commit/e40913a84d8a2f34a1cfb92bd22db143bc1e0c52
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2584
Please reload this pagehttps://github.com/nodejs/node/pull/2584
https://github.com/bnoordhuis
https://github.com/thefourtheye
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.