René's URL Explorer Experiment


Title: build: PYTHON ?= python3 by cclauss · Pull Request #25759 · nodejs/node · GitHub

Open Graph Title: build: PYTHON ?= python3 by cclauss · Pull Request #25759 · nodejs/node

X Title: build: PYTHON ?= python3 by cclauss · Pull Request #25759 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Blocked by nodejs/build#1674 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows co...

X Description: Blocked by nodejs/build#1674 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows co...

Opengraph URL: https://github.com/nodejs/node/pull/25759

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f375c519-8a63-44d2-17d7-39f246d4450d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC96:33952:28C6898:387F048:6A4F563A
html-safe-nonce9f528387d7382cd9e326f5aa72157074bbc167234cde0da55718b6e6228ccbc9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzk2OjMzOTUyOjI4QzY4OTg6Mzg3RjA0ODo2QTRGNTYzQSIsInZpc2l0b3JfaWQiOiI1MDM0ODY4MDc0MTQ0MDI4MjE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1cc3038c61f8bbedf510c0798ffc0b362a032f756272b74fd9d3c86d5f204038
hovercard-subject-tagpull_request:248114162
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25759/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/52369ee6f6406567b10845596e59378ef02ef981abb783a1a57a22a5b9473d29/nodejs/node/pull/25759
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/52369ee6f6406567b10845596e59378ef02ef981abb783a1a57a22a5b9473d29/nodejs/node/pull/25759
og:image:altBlocked by nodejs/build#1674 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows co...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecclauss
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25759#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25759
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25759
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25759
Reloadhttps://github.com/nodejs/node/pull/25759
Reloadhttps://github.com/nodejs/node/pull/25759
Please reload this pagehttps://github.com/nodejs/node/pull/25759
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25759
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 970 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cclausshttps://github.com/cclauss
nodejs:masterhttps://github.com/nodejs/node/tree/master
cclauss:patch-1https://github.com/cclauss/node/tree/patch-1
Conversationhttps://github.com/nodejs/node/pull/25759
Commits1 (1)https://github.com/nodejs/node/pull/25759/commits
Checkshttps://github.com/nodejs/node/pull/25759/checks
Files changedhttps://github.com/nodejs/node/pull/25759/files
build: PYTHON ?= python3https://github.com/nodejs/node/pull/25759#top
cclausshttps://github.com/cclauss
nodejs:masterhttps://github.com/nodejs/node/tree/master
cclauss:patch-1https://github.com/cclauss/node/tree/patch-1
https://github.com/cclauss
cclausshttps://github.com/cclauss
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issue-403780473
Please reload this pagehttps://github.com/nodejs/node/pull/25759
nodejs/build#1674https://github.com/nodejs/build/issues/1674
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Jan 28, 2019https://github.com/nodejs/node/pull/25759#event-2100563919
https://github.com/cclauss
cclausshttps://github.com/cclauss
Jan 28, 2019 https://github.com/nodejs/node/pull/25759#ref-issue-403787145
tools: need to upgrade tools/cpp_lint.py to be Python 3 compatible #25760 https://github.com/nodejs/node/issues/25760
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458111723
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458139766
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/cclauss
cclausshttps://github.com/cclauss
force-pushedhttps://github.com/nodejs/node/compare/84aafbb2a520b386ac1bfd15dbbf67803bc34462..243eff055e6922f504b5a3e7999ad1a0a75dcb95
84aafbbhttps://github.com/nodejs/node/commit/84aafbb2a520b386ac1bfd15dbbf67803bc34462
243eff0https://github.com/nodejs/node/commit/243eff055e6922f504b5a3e7999ad1a0a75dcb95
Compare https://github.com/nodejs/node/compare/84aafbb2a520b386ac1bfd15dbbf67803bc34462..243eff055e6922f504b5a3e7999ad1a0a75dcb95
January 28, 2019 13:58https://github.com/nodejs/node/pull/25759#event-2100827661
https://github.com/cclauss
cclausshttps://github.com/cclauss
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458142470
Please reload this pagehttps://github.com/nodejs/node/pull/25759
#25766https://github.com/nodejs/node/pull/25766
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 28, 2019 https://github.com/nodejs/node/pull/25759#pullrequestreview-197050664
View reviewed changes https://github.com/nodejs/node/pull/25759/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/25759#pullrequestreview-197050664
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
python https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython
Jan 28, 2019https://github.com/nodejs/node/pull/25759#event-2100841934
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458146087
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/25759
cclausshttps://github.com/cclauss
Jan 28, 2019 https://github.com/nodejs/node/pull/25759#ref-commit-2401b0d
https://github.com/cclauss
build: update prerequisites on progress towards Python 3https://github.com/cclauss/node/commit/2401b0d5a250febf5e648f712c962b0b6c665e20
2401b0dhttps://github.com/cclauss/node/commit/2401b0d5a250febf5e648f712c962b0b6c665e20
nodejs#25759 (comment)https://github.com/nodejs/node/pull/25759#issuecomment-458139766
https://www.python.org/dev/peps/pep-0361/#release-lifespanhttps://www.python.org/dev/peps/pep-0361/#release-lifespan
https://www.python.org/dev/peps/pep-0373/#updatehttps://www.python.org/dev/peps/pep-0373/#update
https://devguide.python.org/#branchstatushttps://devguide.python.org/#branchstatus
https://github.com/cclauss
cclausshttps://github.com/cclauss
Jan 28, 2019 https://github.com/nodejs/node/pull/25759#ref-pullrequest-403834561
build: update prerequisites on progress towards Python 3 #25766 https://github.com/nodejs/node/pull/25766
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458147942
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458150136
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458151818
@gengjiawenhttps://github.com/gengjiawen
#25767https://github.com/nodejs/node/pull/25767
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458153923
@cclausshttps://github.com/cclauss
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/cclauss
cclausshttps://github.com/cclauss
force-pushedhttps://github.com/nodejs/node/compare/243eff055e6922f504b5a3e7999ad1a0a75dcb95..24e260f289f85f5c4a2a16ad11f3aedd4a57a6b5
243eff0https://github.com/nodejs/node/commit/243eff055e6922f504b5a3e7999ad1a0a75dcb95
24e260fhttps://github.com/nodejs/node/commit/24e260f289f85f5c4a2a16ad11f3aedd4a57a6b5
Compare https://github.com/nodejs/node/compare/243eff055e6922f504b5a3e7999ad1a0a75dcb95..24e260f289f85f5c4a2a16ad11f3aedd4a57a6b5
January 28, 2019 15:10https://github.com/nodejs/node/pull/25759#event-2101029762
https://github.com/cclauss
cclausshttps://github.com/cclauss
Jan 28, 2019https://github.com/nodejs/node/pull/25759#event-2101030156
https://github.com/refack
refackhttps://github.com/refack
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458208937
node/Makefilehttps://github.com/nodejs/node/blob/48149876dd195bb2bb072a1d8b1cb3ef0b9ae15d/Makefile#L1
4814987https://github.com/nodejs/node/commit/48149876dd195bb2bb072a1d8b1cb3ef0b9ae15d
node/configurehttps://github.com/nodejs/node/blob/48149876dd195bb2bb072a1d8b1cb3ef0b9ae15d/configure#L16-L17
4814987https://github.com/nodejs/node/commit/48149876dd195bb2bb072a1d8b1cb3ef0b9ae15d
node/configure.pyhttps://github.com/nodejs/node/blob/48149876dd195bb2bb072a1d8b1cb3ef0b9ae15d/configure.py#L1658-L1662
4814987https://github.com/nodejs/node/commit/48149876dd195bb2bb072a1d8b1cb3ef0b9ae15d
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/cclauss
cclausshttps://github.com/cclauss
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458234626
Please reload this pagehttps://github.com/nodejs/node/pull/25759
@refackhttps://github.com/refack
tools/cpp_lint.py complaininghttps://travis-ci.com/nodejs/node/jobs/173450726#L498-L504
#25760https://github.com/nodejs/node/issues/25760
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/refack
refackhttps://github.com/refack
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458237593
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/cclauss
cclausshttps://github.com/cclauss
Jan 28, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458286540
Please reload this pagehttps://github.com/nodejs/node/pull/25759
#25771https://github.com/nodejs/node/pull/25771
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/refack
refackhttps://github.com/refack
Jan 29, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458352454
#25771https://github.com/nodejs/node/pull/25771
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Jan 29, 2019https://github.com/nodejs/node/pull/25759#issuecomment-458374298
https://github.com/nodejs/node/blob/master/tools/msvs/find_python.cmdhttps://github.com/nodejs/node/blob/master/tools/msvs/find_python.cmd
@refackhttps://github.com/refack
@cclausshttps://github.com/cclauss
Please reload this pagehttps://github.com/nodejs/node/pull/25759
build: ongoing list of actions for Python 3 compatibility #25789 https://github.com/nodejs/node/issues/25789
Add Python 3 to more build machines nodejs/build#1674 https://github.com/nodejs/build/issues/1674
addaleaxhttps://github.com/addaleax
Jan 30, 2019 https://github.com/nodejs/node/pull/25759#ref-commit-bb564a3
https://github.com/cclauss
https://github.com/addaleax
build: update prerequisites on progress towards Python 3https://github.com/nodejs/node/commit/bb564a36882102ba8cd46878db7ea886334cac20
bb564a3https://github.com/nodejs/node/commit/bb564a36882102ba8cd46878db7ea886334cac20
#25759 (comment)https://github.com/nodejs/node/pull/25759#issuecomment-458139766
https://www.python.org/dev/peps/pep-0361/#release-lifespanhttps://www.python.org/dev/peps/pep-0361/#release-lifespan
https://www.python.org/dev/peps/pep-0373/#updatehttps://www.python.org/dev/peps/pep-0373/#update
https://devguide.python.org/#branchstatushttps://devguide.python.org/#branchstatus
#25766https://github.com/nodejs/node/pull/25766
https://github.com/refack
refackhttps://github.com/refack
Feb 1, 2019https://github.com/nodejs/node/pull/25759#issuecomment-459732453
https://ci.nodejs.org/job/node-test-pull-request/20509/https://ci.nodejs.org/job/node-test-pull-request/20509/
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/refack
refackhttps://github.com/refack
Feb 1, 2019https://github.com/nodejs/node/pull/25759#issuecomment-459732808
/tools/msvs/find_python.cmd@masterhttps://github.com/nodejs/node/blob/master/tools/msvs/find_python.cmd
#25789https://github.com/nodejs/node/issues/25789
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/cclauss
build: change PYTHON ?= python ---> PYTHON ?= python3https://github.com/nodejs/node/pull/25759/commits/df16943367f353acc24d1b447d8d0a2f86bc0319
df16943https://github.com/nodejs/node/pull/25759/commits/df16943367f353acc24d1b447d8d0a2f86bc0319
https://github.com/cclauss
cclausshttps://github.com/cclauss
force-pushedhttps://github.com/nodejs/node/compare/2a5f6979f485004929d4b2ed5b082d38142b88b0..df16943367f353acc24d1b447d8d0a2f86bc0319
2a5f697https://github.com/nodejs/node/commit/2a5f6979f485004929d4b2ed5b082d38142b88b0
df16943https://github.com/nodejs/node/commit/df16943367f353acc24d1b447d8d0a2f86bc0319
Compare https://github.com/nodejs/node/compare/2a5f6979f485004929d4b2ed5b082d38142b88b0..df16943367f353acc24d1b447d8d0a2f86bc0319
February 1, 2019 17:17https://github.com/nodejs/node/pull/25759#event-2112757099
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 9, 2019https://github.com/nodejs/node/pull/25759#issuecomment-462058040
https://ci.nodejs.org/job/node-test-pull-request/20691/https://ci.nodejs.org/job/node-test-pull-request/20691/
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Feb 9, 2019https://github.com/nodejs/node/pull/25759#event-2128801432
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Feb 11, 2019 https://github.com/nodejs/node/pull/25759#pullrequestreview-202084819
View reviewed changes https://github.com/nodejs/node/pull/25759/files/df16943367f353acc24d1b447d8d0a2f86bc0319
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 17, 2019https://github.com/nodejs/node/pull/25759#issuecomment-464487393
https://ci.nodejs.org/job/node-test-pull-request/20837/https://ci.nodejs.org/job/node-test-pull-request/20837/
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 17, 2019https://github.com/nodejs/node/pull/25759#issuecomment-464489632
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Feb 17, 2019https://github.com/nodejs/node/pull/25759#event-2144817386
https://github.com/cclauss
cclausshttps://github.com/cclauss
Feb 17, 2019https://github.com/nodejs/node/pull/25759#issuecomment-464490824
nodejs/build#1674https://github.com/nodejs/build/issues/1674
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/richardlau
richardlauhttps://github.com/richardlau
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Feb 17, 2019https://github.com/nodejs/node/pull/25759#event-2144828351
https://github.com/cclauss
cclausshttps://github.com/cclauss
Jul 5, 2019https://github.com/nodejs/node/pull/25759#issuecomment-508709964
#28537https://github.com/nodejs/node/pull/28537
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/cclauss
cclausshttps://github.com/cclauss
Jul 5, 2019https://github.com/nodejs/node/pull/25759#event-2462334599
https://github.com/cclauss
cclausshttps://github.com/cclauss
July 5, 2019 10:16https://github.com/nodejs/node/pull/25759#event-2462334733
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25759
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/25759/files/243eff055e6922f504b5a3e7999ad1a0a75dcb95
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/25759/files/df16943367f353acc24d1b447d8d0a2f86bc0319
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
python https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython
Please reload this pagehttps://github.com/nodejs/node/pull/25759
https://github.com/cclauss
https://github.com/gengjiawen
https://github.com/thefourtheye
https://github.com/addaleax
https://github.com/refack
https://github.com/richardlau
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.