René's URL Explorer Experiment


Title: test: replace s_client in test-https-ci-reneg-attack by Trott · Pull Request #25720 · nodejs/node · GitHub

Open Graph Title: test: replace s_client in test-https-ci-reneg-attack by Trott · Pull Request #25720 · nodejs/node

X Title: test: replace s_client in test-https-ci-reneg-attack by Trott · Pull Request #25720 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Replace s_client in test-https-ci-reneg-attack with built-in client calling tls.renegotiate(). This also fixes the currently-broken test. (It is broken due to a change in behavior in a recently-upd...

X Description: Replace s_client in test-https-ci-reneg-attack with built-in client calling tls.renegotiate(). This also fixes the currently-broken test. (It is broken due to a change in behavior in a recently-upd...

Opengraph URL: https://github.com/nodejs/node/pull/25720

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:83bf0e42-436f-40a4-ed5e-ce2b5c5ccc55
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCA2:15C049:335E08:434B8E:6991D80D
html-safe-nonce51eaea9efb38cb1d0563902a959ca550f90d139310172a808992b1eba1b9e498
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0EyOjE1QzA0OTozMzVFMDg6NDM0QjhFOjY5OTFEODBEIiwidmlzaXRvcl9pZCI6IjMxNDQ1ODIwNTYwMTI1NzQ4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceeb36dd03c1024761d9a9b7a5b42ad57d5e51243a844c70fc2af5f06b44da6fa
hovercard-subject-tagpull_request:247871710
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25720/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9e017c3fbc587d7b3e8b32d04a40312a7092ef593124535a5231b4f0c55e1ebc/nodejs/node/pull/25720
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9e017c3fbc587d7b3e8b32d04a40312a7092ef593124535a5231b4f0c55e1ebc/nodejs/node/pull/25720
og:image:altReplace s_client in test-https-ci-reneg-attack with built-in client calling tls.renegotiate(). This also fixes the currently-broken test. (It is broken due to a change in behavior in a recently-upd...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25720#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25720
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25720
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25720
Reloadhttps://github.com/nodejs/node/pull/25720
Reloadhttps://github.com/nodejs/node/pull/25720
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25720
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:rm-client-httpshttps://github.com/Trott/io.js/tree/rm-client-https
Conversationhttps://github.com/nodejs/node/pull/25720
Commits1 (1)https://github.com/nodejs/node/pull/25720/commits
Checkshttps://github.com/nodejs/node/pull/25720/checks
Files changedhttps://github.com/nodejs/node/pull/25720/files
test: replace s_client in test-https-ci-reneg-attackhttps://github.com/nodejs/node/pull/25720#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:rm-client-httpshttps://github.com/Trott/io.js/tree/rm-client-https
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 26, 2019https://github.com/nodejs/node/pull/25720#issue-403412847
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25720
https://github.com/Trott
test: replace s_client in test-https-ci-reneg-attackhttps://github.com/nodejs/node/pull/25720/commits/b2ad1797bde3da028813b073e68dc5ae2d3c9541
b2ad179https://github.com/nodejs/node/pull/25720/commits/b2ad1797bde3da028813b073e68dc5ae2d3c9541
https://github.com/Trott
Trotthttps://github.com/Trott
bnoordhuishttps://github.com/bnoordhuis
sam-githubhttps://github.com/sam-github
shigekihttps://github.com/shigeki
January 26, 2019 06:32https://github.com/nodejs/node/pull/25720#event-2098716107
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 26, 2019https://github.com/nodejs/node/pull/25720#issuecomment-457807042
@Trotthttps://github.com/Trott
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2398/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2398/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25720
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jan 26, 2019https://github.com/nodejs/node/pull/25720#event-2098716126
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 26, 2019https://github.com/nodejs/node/pull/25720#issuecomment-457807169
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2398/https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2398/
https://ci.nodejs.org/job/node-test-commit-custom-suites/841/https://ci.nodejs.org/job/node-test-commit-custom-suites/841/
Please reload this pagehttps://github.com/nodejs/node/pull/25720
https://github.com/Trott
Trotthttps://github.com/Trott
flaky-test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test
Jan 26, 2019https://github.com/nodejs/node/pull/25720#event-2098716952
test: refactor test-*-ci-reneg-attack.js #25660 https://github.com/nodejs/node/pull/25660
test: fix renegotiation tests in pummel #25668 https://github.com/nodejs/node/pull/25668
test: fix test-https-ci-reneg-attack #25676 https://github.com/nodejs/node/pull/25676
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 26, 2019 https://github.com/nodejs/node/pull/25720#pullrequestreview-196781297
View reviewed changes https://github.com/nodejs/node/pull/25720/files/b2ad1797bde3da028813b073e68dc5ae2d3c9541
test/pummel/test-https-ci-reneg-attack.jshttps://github.com/nodejs/node/pull/25720/files/b2ad1797bde3da028813b073e68dc5ae2d3c9541#diff-7a35916c16fd83c932dba13a3de529fc888b6972672b2b7698abc7d557fc9d41
bnoordhuishttps://github.com/bnoordhuis
Jan 26, 2019https://github.com/nodejs/node/pull/25720#discussion_r251192839
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25720
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 26, 2019https://github.com/nodejs/node/pull/25720#event-2099021747
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 27, 2019 https://github.com/nodejs/node/pull/25720#pullrequestreview-196844546
View reviewed changes https://github.com/nodejs/node/pull/25720/files/b2ad1797bde3da028813b073e68dc5ae2d3c9541
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 27, 2019 https://github.com/nodejs/node/pull/25720#pullrequestreview-196844831
View reviewed changes https://github.com/nodejs/node/pull/25720/files/b2ad1797bde3da028813b073e68dc5ae2d3c9541
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 28, 2019https://github.com/nodejs/node/pull/25720#issuecomment-458064644
43c2a13https://github.com/nodejs/node/commit/43c2a13c9334dad4b1f911dfcb455e8f8a9e4611
Please reload this pagehttps://github.com/nodejs/node/pull/25720
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 28, 2019https://github.com/nodejs/node/pull/25720#event-2100276551
Trotthttps://github.com/Trott
Jan 28, 2019 https://github.com/nodejs/node/pull/25720#ref-commit-43c2a13
https://github.com/Trott
test: replace s_client in test-https-ci-reneg-attackhttps://github.com/Trott/io.js/commit/43c2a13c9334dad4b1f911dfcb455e8f8a9e4611
43c2a13https://github.com/Trott/io.js/commit/43c2a13c9334dad4b1f911dfcb455e8f8a9e4611
nodejs#25720https://github.com/nodejs/node/pull/25720
https://github.com/refack
refackhttps://github.com/refack
Jan 28, 2019https://github.com/nodejs/node/pull/25720#issuecomment-458204490
https://ci.nodejs.org/job/node-test-commit-custom-suites/846/defaulthttps://ci.nodejs.org/job/node-test-commit-custom-suites/846/default
Please reload this pagehttps://github.com/nodejs/node/pull/25720
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 28, 2019https://github.com/nodejs/node/pull/25720#issuecomment-458222173
Please reload this pagehttps://github.com/nodejs/node/pull/25720
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 28, 2019https://github.com/nodejs/node/pull/25720#issuecomment-458223200
Please reload this pagehttps://github.com/nodejs/node/pull/25720
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/25720
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 28, 2019https://github.com/nodejs/node/pull/25720#issuecomment-458225032
c421619https://github.com/nodejs/node/commit/c4216194be1b6856b9d02999ea0adc25cc036804
Please reload this pagehttps://github.com/nodejs/node/pull/25720
https://github.com/refack
refackhttps://github.com/refack
Jan 28, 2019https://github.com/nodejs/node/pull/25720#issuecomment-458231256
b2ad179https://github.com/nodejs/node/commit/b2ad1797bde3da028813b073e68dc5ae2d3c9541
Please reload this pagehttps://github.com/nodejs/node/pull/25720
addaleaxhttps://github.com/addaleax
Jan 28, 2019 https://github.com/nodejs/node/pull/25720#ref-commit-4b2a1ea
https://github.com/Trott
https://github.com/addaleax
test: replace s_client in test-https-ci-reneg-attackhttps://github.com/nodejs/node/commit/4b2a1eadbd0b574a2983de752fb6553e4dd63695
4b2a1eahttps://github.com/nodejs/node/commit/4b2a1eadbd0b574a2983de752fb6553e4dd63695
#25720https://github.com/nodejs/node/pull/25720
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 28, 2019https://github.com/nodejs/node/pull/25720#issuecomment-458234144
b2ad179https://github.com/nodejs/node/commit/b2ad1797bde3da028813b073e68dc5ae2d3c9541
Please reload this pagehttps://github.com/nodejs/node/pull/25720
https://github.com/targos
targoshttps://github.com/targos
Jan 29, 2019 https://github.com/nodejs/node/pull/25720#ref-pullrequest-404502468
v11.9.0 proposal #25802 https://github.com/nodejs/node/pull/25802
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:51https://github.com/nodejs/node/pull/25720#event-5890971947
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25720
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/25720/files/b2ad1797bde3da028813b073e68dc5ae2d3c9541
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/25720/files/b2ad1797bde3da028813b073e68dc5ae2d3c9541
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/25720/files/b2ad1797bde3da028813b073e68dc5ae2d3c9541
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/shigeki
shigeki https://github.com/shigeki
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
flaky-test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/25720
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/refack
https://github.com/bnoordhuis
https://github.com/lpinca
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.