René's URL Explorer Experiment


Title: src: in-source comments and minor TLS cleanups by sam-github · Pull Request #25713 · nodejs/node · GitHub

Open Graph Title: src: in-source comments and minor TLS cleanups by sam-github · Pull Request #25713 · nodejs/node

X Title: src: in-source comments and minor TLS cleanups by sam-github · Pull Request #25713 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Renamed some internal C++ methods and properties for consistency, and commented SSL I/O. Rename waiting_new_session_ after is_waiting_new_session(), instead of using reverse naming (new_session_wa...

X Description: Renamed some internal C++ methods and properties for consistency, and commented SSL I/O. Rename waiting_new_session_ after is_waiting_new_session(), instead of using reverse naming (new_session_wa...

Opengraph URL: https://github.com/nodejs/node/pull/25713

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:30f3f97b-1ce4-2efb-5278-5b677de9d624
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id907E:2180B4:337DA7:437A93:6991D7F9
html-safe-nonce451196c996bcce0b93b4ad5acd0304253dd6735947344b62283070ea5f2e0e1c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDdFOjIxODBCNDozMzdEQTc6NDM3QTkzOjY5OTFEN0Y5IiwidmlzaXRvcl9pZCI6IjU1Nzk2NjgwNjI2OTU3MDg2NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1f43675ba0b097c0fd0ecb34507faa13c5619660cf154836411ed7cdd209c6eb
hovercard-subject-tagpull_request:247797487
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25713/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/af01603e53d4b64aad0434b1afc73a42c750077abad30c46f9cc568dae18de3d/nodejs/node/pull/25713
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/af01603e53d4b64aad0434b1afc73a42c750077abad30c46f9cc568dae18de3d/nodejs/node/pull/25713
og:image:altRenamed some internal C++ methods and properties for consistency, and commented SSL I/O. Rename waiting_new_session_ after is_waiting_new_session(), instead of using reverse naming (new_session_wa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesam-github
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25713#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25713
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25713
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25713
Reloadhttps://github.com/nodejs/node/pull/25713
Reloadhttps://github.com/nodejs/node/pull/25713
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25713
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:tls-cleanupshttps://github.com/sam-github/node/tree/tls-cleanups
Conversationhttps://github.com/nodejs/node/pull/25713
Commits1 (1)https://github.com/nodejs/node/pull/25713/commits
Checkshttps://github.com/nodejs/node/pull/25713/checks
Files changedhttps://github.com/nodejs/node/pull/25713/files
src: in-source comments and minor TLS cleanupshttps://github.com/nodejs/node/pull/25713#top
sam-githubhttps://github.com/sam-github
nodejs:masterhttps://github.com/nodejs/node/tree/master
sam-github:tls-cleanupshttps://github.com/sam-github/node/tree/tls-cleanups
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jan 25, 2019https://github.com/nodejs/node/pull/25713#issue-403312312
Please reload this pagehttps://github.com/nodejs/node/pull/25713
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25713
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 25, 2019https://github.com/nodejs/node/pull/25713#issuecomment-457707140
@sam-githubhttps://github.com/sam-github
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2392/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2392/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25713
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jan 25, 2019https://github.com/nodejs/node/pull/25713#event-2098142417
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 25, 2019 https://github.com/nodejs/node/pull/25713#pullrequestreview-196689198
View reviewed changes https://github.com/nodejs/node/pull/25713/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/25713#pullrequestreview-196689198
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25713
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
force-pushedhttps://github.com/nodejs/node/compare/0c4bb447d516c1ad37cb1a2e01479238133c3014..1a506384f237a6c9a30ce4b60888a93dc37a692a
0c4bb44https://github.com/nodejs/node/commit/0c4bb447d516c1ad37cb1a2e01479238133c3014
1a50638https://github.com/nodejs/node/commit/1a506384f237a6c9a30ce4b60888a93dc37a692a
Compare https://github.com/nodejs/node/compare/0c4bb447d516c1ad37cb1a2e01479238133c3014..1a506384f237a6c9a30ce4b60888a93dc37a692a
January 25, 2019 20:21https://github.com/nodejs/node/pull/25713#event-2098183093
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jan 25, 2019https://github.com/nodejs/node/pull/25713#issuecomment-457714181
Please reload this pagehttps://github.com/nodejs/node/pull/25713
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 25, 2019 https://github.com/nodejs/node/pull/25713#pullrequestreview-196699596
View reviewed changes https://github.com/nodejs/node/pull/25713/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/25713#pullrequestreview-196699596
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25713
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
force-pushedhttps://github.com/nodejs/node/compare/1a506384f237a6c9a30ce4b60888a93dc37a692a..99e558df27301fcf08cc46fcafcca7b958e3db9a
1a50638https://github.com/nodejs/node/commit/1a506384f237a6c9a30ce4b60888a93dc37a692a
99e558dhttps://github.com/nodejs/node/commit/99e558df27301fcf08cc46fcafcca7b958e3db9a
Compare https://github.com/nodejs/node/compare/1a506384f237a6c9a30ce4b60888a93dc37a692a..99e558df27301fcf08cc46fcafcca7b958e3db9a
January 25, 2019 20:38https://github.com/nodejs/node/pull/25713#event-2098214933
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 25, 2019 https://github.com/nodejs/node/pull/25713#ref-pullrequest-369830787
tls: support changing credentials dynamically #23644 https://github.com/nodejs/node/pull/23644
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 28, 2019 https://github.com/nodejs/node/pull/25713#pullrequestreview-196945506
View reviewed changes https://github.com/nodejs/node/pull/25713/files
src/node_crypto.cchttps://github.com/nodejs/node/pull/25713/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
Please reload this pagehttps://github.com/nodejs/node/pull/25713
src/tls_wrap.cchttps://github.com/nodejs/node/pull/25713/files#diff-9a26c15dbc849b7d50bca401da5a640629db383c5ec6b7d3668af529afd1383d
Please reload this pagehttps://github.com/nodejs/node/pull/25713
src/tls_wrap.hhttps://github.com/nodejs/node/pull/25713/files#diff-37559a0d50377058c1baa4c64f00db15ae8d9fb37380f16b6248231841bdd4a2
Please reload this pagehttps://github.com/nodejs/node/pull/25713
https://github.com/sam-github
src: in-source comments and minor TLS cleanupshttps://github.com/nodejs/node/pull/25713/commits/cbdcaea87a67ccbbb4ddbc70550187a80ea2bada
cbdcaeahttps://github.com/nodejs/node/pull/25713/commits/cbdcaea87a67ccbbb4ddbc70550187a80ea2bada
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
force-pushedhttps://github.com/nodejs/node/compare/cdf9d7158f5bf88b468f40629cdbda509f5a8ac0..cbdcaea87a67ccbbb4ddbc70550187a80ea2bada
cdf9d71https://github.com/nodejs/node/commit/cdf9d7158f5bf88b468f40629cdbda509f5a8ac0
cbdcaeahttps://github.com/nodejs/node/commit/cbdcaea87a67ccbbb4ddbc70550187a80ea2bada
Compare https://github.com/nodejs/node/compare/cdf9d7158f5bf88b468f40629cdbda509f5a8ac0..cbdcaea87a67ccbbb4ddbc70550187a80ea2bada
January 28, 2019 19:33https://github.com/nodejs/node/pull/25713#event-2101744313
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 28, 2019https://github.com/nodejs/node/pull/25713#issuecomment-458344296
46c5c33https://github.com/nodejs/node/commit/46c5c3388d24615d8bcd887bb366d4171e99fdee
https://ci.nodejs.org/job/node-test-pull-request/20382/https://ci.nodejs.org/job/node-test-pull-request/20382/
Please reload this pagehttps://github.com/nodejs/node/pull/25713
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 28, 2019https://github.com/nodejs/node/pull/25713#event-2102239945
pullhttps://github.com/apps/pull
Jan 28, 2019 https://github.com/nodejs/node/pull/25713#ref-commit-46c5c33
https://github.com/sam-github
https://github.com/addaleax
src: in-source comments and minor TLS cleanupshttps://github.com/SimenB/node/commit/46c5c3388d24615d8bcd887bb366d4171e99fdee
46c5c33https://github.com/SimenB/node/commit/46c5c3388d24615d8bcd887bb366d4171e99fdee
nodejs#25713https://github.com/nodejs/node/pull/25713
addaleaxhttps://github.com/addaleax
Jan 28, 2019 https://github.com/nodejs/node/pull/25713#ref-commit-6d9af41
https://github.com/sam-github
https://github.com/addaleax
src: in-source comments and minor TLS cleanupshttps://github.com/nodejs/node/commit/6d9af41aef7ed554cb68eb5a4b96bec441ca2e7b
6d9af41https://github.com/nodejs/node/commit/6d9af41aef7ed554cb68eb5a4b96bec441ca2e7b
#25713https://github.com/nodejs/node/pull/25713
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
January 29, 2019 16:26https://github.com/nodejs/node/pull/25713#event-2104149353
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jan 29, 2019https://github.com/nodejs/node/pull/25713#issuecomment-458606745
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/25713
https://github.com/targos
targoshttps://github.com/targos
Jan 29, 2019 https://github.com/nodejs/node/pull/25713#ref-pullrequest-404502468
v11.9.0 proposal #25802 https://github.com/nodejs/node/pull/25802
sam-githubhttps://github.com/sam-github
Apr 29, 2019 https://github.com/nodejs/node/pull/25713#ref-commit-6b327e5
https://github.com/sam-github
src: in-source comments and minor TLS cleanupshttps://github.com/sam-github/node/commit/6b327e51e83bdf6e83c6715bf012a1856d94de86
6b327e5https://github.com/sam-github/node/commit/6b327e51e83bdf6e83c6715bf012a1856d94de86
nodejs#25713https://github.com/nodejs/node/pull/25713
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 29, 2019 https://github.com/nodejs/node/pull/25713#ref-pullrequest-448354393
tls: group chunks into TLS segments #27861 https://github.com/nodejs/node/pull/27861
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
May 29, 2019https://github.com/nodejs/node/pull/25713#event-2376474755
addaleaxhttps://github.com/addaleax
May 30, 2019 https://github.com/nodejs/node/pull/25713#ref-commit-b800d29
https://github.com/sam-github
https://github.com/addaleax
src: in-source comments and minor TLS cleanupshttps://github.com/addaleax/node/commit/b800d297e17253f21bb0b2dce95e72e56f68a4b8
b800d29https://github.com/addaleax/node/commit/b800d297e17253f21bb0b2dce95e72e56f68a4b8
nodejs#25713https://github.com/nodejs/node/pull/25713
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 30, 2019 https://github.com/nodejs/node/pull/25713#ref-pullrequest-450198135
[v10.x] backport more TLS changes #27967 https://github.com/nodejs/node/pull/27967
BethGriggshttps://github.com/BethGriggs
Jul 16, 2019 https://github.com/nodejs/node/pull/25713#ref-commit-6b0d202
https://github.com/sam-github
https://github.com/BethGriggs
src: in-source comments and minor TLS cleanupshttps://github.com/nodejs/node/commit/6b0d20285a3b2f4d4ec454c97e8c3740dc70f892
6b0d202https://github.com/nodejs/node/commit/6b0d20285a3b2f4d4ec454c97e8c3740dc70f892
#27967https://github.com/nodejs/node/pull/27967
#25713https://github.com/nodejs/node/pull/25713
BethGriggshttps://github.com/BethGriggs
Jul 17, 2019 https://github.com/nodejs/node/pull/25713#ref-commit-b689008
https://github.com/sam-github
https://github.com/BethGriggs
src: in-source comments and minor TLS cleanupshttps://github.com/nodejs/node/commit/b689008deadd1f1b323c2fe808829dcc9a795291
b689008https://github.com/nodejs/node/commit/b689008deadd1f1b323c2fe808829dcc9a795291
#27967https://github.com/nodejs/node/pull/27967
#25713https://github.com/nodejs/node/pull/25713
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jul 17, 2019 https://github.com/nodejs/node/pull/25713#ref-pullrequest-469131218
v10.16.1 proposal #28731 https://github.com/nodejs/node/pull/28731
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25713
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/25713/files/99e558df27301fcf08cc46fcafcca7b958e3db9a
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/25713/files/0c4bb447d516c1ad37cb1a2e01479238133c3014
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/25713/files/1a506384f237a6c9a30ce4b60888a93dc37a692a
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/25713
https://github.com/sam-github
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/bnoordhuis
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.