René's URL Explorer Experiment


Title: tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp call by davidben · Pull Request #25706 · nodejs/node · GitHub

Open Graph Title: tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp call by davidben · Pull Request #25706 · nodejs/node

X Title: tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp call by davidben · Pull Request #25706 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: SSL_set_tlsext_status_ocsp_resp expects the data to be allocated with OPENSSL_malloc, not libc malloc, so use OpenSSLMalloc. Additionally, though OpenSSL doesn't type-check due to it being a ma...

X Description: SSL_set_tlsext_status_ocsp_resp expects the data to be allocated with OPENSSL_malloc, not libc malloc, so use OpenSSLMalloc. Additionally, though OpenSSL doesn't type-check due to it being ...

Opengraph URL: https://github.com/nodejs/node/pull/25706

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4b91c2a4-a98c-458e-9ec3-0be2ea2ae421
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9E2:161538:2F630B:3D0922:6991E181
html-safe-nonce38bf10f5640cd980f666819c03d7eac7b3ca43a376ac6a61ea5a430b033f48b0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUUyOjE2MTUzODoyRjYzMEI6M0QwOTIyOjY5OTFFMTgxIiwidmlzaXRvcl9pZCI6IjgzNjI4MTIwNDE2NDQzMzU0ODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc382ecdac2b28dc71c18edc3012e708046ab236012d6a64e2b062ae9f1d97f5d
hovercard-subject-tagpull_request:247722720
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25706/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/151d2ad1655e93bbf286f1334af4cbe2243de0b050c66b32e95f4781ee2f6095/nodejs/node/pull/25706
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/151d2ad1655e93bbf286f1334af4cbe2243de0b050c66b32e95f4781ee2f6095/nodejs/node/pull/25706
og:image:altSSL_set_tlsext_status_ocsp_resp expects the data to be allocated with OPENSSL_malloc, not libc malloc, so use OpenSSLMalloc. Additionally, though OpenSSL doesn't type-check due to it being a ma...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedavidben
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25706#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25706
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25706
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25706
Reloadhttps://github.com/nodejs/node/pull/25706
Reloadhttps://github.com/nodejs/node/pull/25706
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25706
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
davidbenhttps://github.com/davidben
nodejs:masterhttps://github.com/nodejs/node/tree/master
davidben:ocsp-mallochttps://github.com/davidben/node/tree/ocsp-malloc
Conversationhttps://github.com/nodejs/node/pull/25706
Commits1 (1)https://github.com/nodejs/node/pull/25706/commits
Checkshttps://github.com/nodejs/node/pull/25706/checks
Files changedhttps://github.com/nodejs/node/pull/25706/files
tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp callhttps://github.com/nodejs/node/pull/25706#top
davidbenhttps://github.com/davidben
nodejs:masterhttps://github.com/nodejs/node/tree/master
davidben:ocsp-mallochttps://github.com/davidben/node/tree/ocsp-malloc
https://github.com/davidben
davidbenhttps://github.com/davidben
Jan 25, 2019https://github.com/nodejs/node/pull/25706#issue-403217740
https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.htmlhttps://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25706
https://github.com/davidben
tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp callhttps://github.com/nodejs/node/pull/25706/commits/8ea19c931d0b5f0a46d7c713dbfc95614ac65dba
8ea19c9https://github.com/nodejs/node/pull/25706/commits/8ea19c931d0b5f0a46d7c713dbfc95614ac65dba
https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.htmlhttps://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Jan 25, 2019https://github.com/nodejs/node/pull/25706#event-2097540579
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jan 25, 2019 https://github.com/nodejs/node/pull/25706#pullrequestreview-196590296
View reviewed changes https://github.com/nodejs/node/pull/25706/files/8ea19c931d0b5f0a46d7c713dbfc95614ac65dba
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Jan 25, 2019https://github.com/nodejs/node/pull/25706#issuecomment-457652885
https://ci.nodejs.org/job/node-test-pull-request/20323/https://ci.nodejs.org/job/node-test-pull-request/20323/
Please reload this pagehttps://github.com/nodejs/node/pull/25706
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Jan 25, 2019 https://github.com/nodejs/node/pull/25706#pullrequestreview-196618180
View reviewed changes https://github.com/nodejs/node/pull/25706/files/8ea19c931d0b5f0a46d7c713dbfc95614ac65dba
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 25, 2019 https://github.com/nodejs/node/pull/25706#pullrequestreview-196677139
View reviewed changes https://github.com/nodejs/node/pull/25706/files/8ea19c931d0b5f0a46d7c713dbfc95614ac65dba
https://github.com/davidben
davidbenhttps://github.com/davidben
Jan 27, 2019https://github.com/nodejs/node/pull/25706#issuecomment-457934034
https://ci.nodejs.org/job/node-test-pull-request/20323/https://ci.nodejs.org/job/node-test-pull-request/20323/
Please reload this pagehttps://github.com/nodejs/node/pull/25706
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 28, 2019 https://github.com/nodejs/node/pull/25706#pullrequestreview-196852917
View reviewed changes https://github.com/nodejs/node/pull/25706/files/8ea19c931d0b5f0a46d7c713dbfc95614ac65dba
https://github.com/ofrobots
ofrobotshttps://github.com/ofrobots
Jan 28, 2019https://github.com/nodejs/node/pull/25706#issuecomment-458237053
Please reload this pagehttps://github.com/nodejs/node/pull/25706
@davidbenhttps://github.com/davidben
test-performancehttps://ci.nodejs.org/job/node-test-binary-arm/5704/RUN_SUBSET=2,label=pi1-docker/testReport/junit/(root)/test/sequential_test_performance/
#23291https://github.com/nodejs/node/issues/23291
https://ci.nodejs.org/job/node-test-pull-request/20380/https://ci.nodejs.org/job/node-test-pull-request/20380/
Please reload this pagehttps://github.com/nodejs/node/pull/25706
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 28, 2019https://github.com/nodejs/node/pull/25706#issuecomment-458342597
https://ci.nodejs.org/job/node-test-pull-request/20389/https://ci.nodejs.org/job/node-test-pull-request/20389/
Please reload this pagehttps://github.com/nodejs/node/pull/25706
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 28, 2019https://github.com/nodejs/node/pull/25706#event-2102229781
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Jan 29, 2019https://github.com/nodejs/node/pull/25706#issuecomment-458600647
b530466https://github.com/nodejs/node/commit/b5304662ed23e81948f33d110bb15fc4f3a72cb1
Please reload this pagehttps://github.com/nodejs/node/pull/25706
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Jan 29, 2019https://github.com/nodejs/node/pull/25706#event-2104103610
antsmartianhttps://github.com/antsmartian
Jan 29, 2019 https://github.com/nodejs/node/pull/25706#ref-commit-b530466
https://github.com/davidben
https://github.com/antsmartian
tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp callhttps://github.com/nodejs/node/commit/b5304662ed23e81948f33d110bb15fc4f3a72cb1
b530466https://github.com/nodejs/node/commit/b5304662ed23e81948f33d110bb15fc4f3a72cb1
https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.htmlhttps://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html
#25706https://github.com/nodejs/node/pull/25706
targoshttps://github.com/targos
Jan 29, 2019 https://github.com/nodejs/node/pull/25706#ref-commit-d5b2135
https://github.com/davidben
https://github.com/targos
tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp callhttps://github.com/nodejs/node/commit/d5b2135dde1663364a12e8c6e76c86310b2874da
d5b2135https://github.com/nodejs/node/commit/d5b2135dde1663364a12e8c6e76c86310b2874da
https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.htmlhttps://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html
#25706https://github.com/nodejs/node/pull/25706
https://github.com/targos
targoshttps://github.com/targos
Jan 29, 2019 https://github.com/nodejs/node/pull/25706#ref-pullrequest-404502468
v11.9.0 proposal #25802 https://github.com/nodejs/node/pull/25802
zcbenzhttps://github.com/zcbenz
Mar 27, 2019 https://github.com/nodejs/node/pull/25706#ref-commit-6883f92
https://github.com/davidben
https://github.com/zcbenz
tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp callhttps://github.com/electron/node/commit/6883f921ab6dbbcef015cccb460f87484cde490a
6883f92https://github.com/electron/node/commit/6883f921ab6dbbcef015cccb460f87484cde490a
https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.htmlhttps://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html
nodejs/node#25706https://github.com/nodejs/node/pull/25706
deepak1556https://github.com/deepak1556
Jul 10, 2019 https://github.com/nodejs/node/pull/25706#ref-commit-9027c0f
https://github.com/davidben
https://github.com/deepak1556
tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp callhttps://github.com/electron/node/commit/9027c0ff04908103bdf2650fb01464db45db2448
9027c0fhttps://github.com/electron/node/commit/9027c0ff04908103bdf2650fb01464db45db2448
https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.htmlhttps://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html
nodejs/node#25706https://github.com/nodejs/node/pull/25706
deepak1556https://github.com/deepak1556
Jul 29, 2019 https://github.com/nodejs/node/pull/25706#ref-commit-08853ee
https://github.com/davidben
https://github.com/deepak1556
tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp callhttps://github.com/electron/node/commit/08853ee7a1c1b3400a0fe2cfb2fc42794c11323a
08853eehttps://github.com/electron/node/commit/08853ee7a1c1b3400a0fe2cfb2fc42794c11323a
https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.htmlhttps://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html
nodejs/node#25706https://github.com/nodejs/node/pull/25706
deepak1556https://github.com/deepak1556
Jul 30, 2019 https://github.com/nodejs/node/pull/25706#ref-commit-5efd0aa
https://github.com/davidben
https://github.com/deepak1556
tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp callhttps://github.com/electron/node/commit/5efd0aa3997f7e9ceaeacd653e6b5785f05c10fc
5efd0aahttps://github.com/electron/node/commit/5efd0aa3997f7e9ceaeacd653e6b5785f05c10fc
https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.htmlhttps://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html
nodejs/node#25706https://github.com/nodejs/node/pull/25706
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25706
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/25706/files/8ea19c931d0b5f0a46d7c713dbfc95614ac65dba
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/25706/files/8ea19c931d0b5f0a46d7c713dbfc95614ac65dba
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/25706/files/8ea19c931d0b5f0a46d7c713dbfc95614ac65dba
https://github.com/ofrobots
ofrobots https://github.com/ofrobots
https://github.com/nodejs/node/pull/25706/files/8ea19c931d0b5f0a46d7c713dbfc95614ac65dba
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/25706
https://github.com/davidben
https://github.com/ofrobots
https://github.com/addaleax
https://github.com/antsmartian
https://github.com/sam-github
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.