René's URL Explorer Experiment


Title: test: remove s_client from test-tls-ci-reneg-attack by Trott · Pull Request #25700 · nodejs/node · GitHub

Open Graph Title: test: remove s_client from test-tls-ci-reneg-attack by Trott · Pull Request #25700 · nodejs/node

X Title: test: remove s_client from test-tls-ci-reneg-attack by Trott · Pull Request #25700 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Rewrite test-tls-ci-reneg-attack to use tls.renegotiate() instead of external (and potentially unpredictable/quirky/buggy) s_client. Refs: #25676 (comment) This test is currently broken (due to a q...

X Description: Rewrite test-tls-ci-reneg-attack to use tls.renegotiate() instead of external (and potentially unpredictable/quirky/buggy) s_client. Refs: #25676 (comment) This test is currently broken (due to a q...

Opengraph URL: https://github.com/nodejs/node/pull/25700

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e2ea5733-d1b6-cd58-13eb-0c826c5c703b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D36:6DEFE:3CDA44:5034A2:6991E186
html-safe-nonce415d7bbd94bf1459a648efe6254481dfd22d5e0626c7fa2642df938b29190fd4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDM2OjZERUZFOjNDREE0NDo1MDM0QTI6Njk5MUUxODYiLCJ2aXNpdG9yX2lkIjoiNDQ2Mjk0Nzg5MjUzNDA0MzAxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb89956d0b2525c916562f3e693f608b1c9727c92360a7183db5a89e041d0bfe6
hovercard-subject-tagpull_request:247694168
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25700/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9e017c3fbc587d7b3e8b32d04a40312a7092ef593124535a5231b4f0c55e1ebc/nodejs/node/pull/25700
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9e017c3fbc587d7b3e8b32d04a40312a7092ef593124535a5231b4f0c55e1ebc/nodejs/node/pull/25700
og:image:altRewrite test-tls-ci-reneg-attack to use tls.renegotiate() instead of external (and potentially unpredictable/quirky/buggy) s_client. Refs: #25676 (comment) This test is currently broken (due to a q...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25700#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25700
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25700
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25700
Reloadhttps://github.com/nodejs/node/pull/25700
Reloadhttps://github.com/nodejs/node/pull/25700
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25700
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:rm-clienthttps://github.com/Trott/io.js/tree/rm-client
Conversationhttps://github.com/nodejs/node/pull/25700
Commits1 (1)https://github.com/nodejs/node/pull/25700/commits
Checkshttps://github.com/nodejs/node/pull/25700/checks
Files changedhttps://github.com/nodejs/node/pull/25700/files
test: remove s_client from test-tls-ci-reneg-attackhttps://github.com/nodejs/node/pull/25700#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:rm-clienthttps://github.com/Trott/io.js/tree/rm-client
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 25, 2019https://github.com/nodejs/node/pull/25700#issue-403181356
#25676 (comment)https://github.com/nodejs/node/pull/25676#issuecomment-457307881
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25700
https://github.com/Trott
Trotthttps://github.com/Trott
bnoordhuishttps://github.com/bnoordhuis
sam-githubhttps://github.com/sam-github
shigekihttps://github.com/shigeki
January 25, 2019 14:33https://github.com/nodejs/node/pull/25700#event-2097319935
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jan 25, 2019https://github.com/nodejs/node/pull/25700#event-2097320123
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 25, 2019https://github.com/nodejs/node/pull/25700#issuecomment-457591204
@Trotthttps://github.com/Trott
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2385/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2385/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25700
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/0612d49ef92f06117986f69bb37ab749bef17f22..585e158ae3e42b0589174e19bdfe67ce8a2df1ee
0612d49https://github.com/nodejs/node/commit/0612d49ef92f06117986f69bb37ab749bef17f22
585e158https://github.com/nodejs/node/commit/585e158ae3e42b0589174e19bdfe67ce8a2df1ee
Compare https://github.com/nodejs/node/compare/0612d49ef92f06117986f69bb37ab749bef17f22..585e158ae3e42b0589174e19bdfe67ce8a2df1ee
January 25, 2019 14:35https://github.com/nodejs/node/pull/25700#event-2097323767
https://github.com/Trott
test: remove s_client from test-tls-ci-reneg-attackhttps://github.com/nodejs/node/pull/25700/commits/9197808ed308e768ec802b7e2ffb90107c927b08
9197808https://github.com/nodejs/node/pull/25700/commits/9197808ed308e768ec802b7e2ffb90107c927b08
nodejs#25676 (comment)https://github.com/nodejs/node/pull/25676#issuecomment-457307881
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/585e158ae3e42b0589174e19bdfe67ce8a2df1ee..9197808ed308e768ec802b7e2ffb90107c927b08
585e158https://github.com/nodejs/node/commit/585e158ae3e42b0589174e19bdfe67ce8a2df1ee
9197808https://github.com/nodejs/node/commit/9197808ed308e768ec802b7e2ffb90107c927b08
Compare https://github.com/nodejs/node/compare/585e158ae3e42b0589174e19bdfe67ce8a2df1ee..9197808ed308e768ec802b7e2ffb90107c927b08
January 25, 2019 14:38https://github.com/nodejs/node/pull/25700#event-2097330154
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jan 25, 2019 https://github.com/nodejs/node/pull/25700#pullrequestreview-196602798
View reviewed changes https://github.com/nodejs/node/pull/25700/files/9197808ed308e768ec802b7e2ffb90107c927b08
sam-githubhttps://github.com/sam-github
https://github.com/nodejs/node/pull/25700#pullrequestreview-196602798
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25700
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 26, 2019https://github.com/nodejs/node/pull/25700#issuecomment-457793253
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2397/https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2397/
https://ci.nodejs.org/job/node-test-commit-custom-suites/840/https://ci.nodejs.org/job/node-test-commit-custom-suites/840/
Please reload this pagehttps://github.com/nodejs/node/pull/25700
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
flaky-test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test
Jan 26, 2019https://github.com/nodejs/node/pull/25700#event-2098641342
test: refactor test-*-ci-reneg-attack.js #25660 https://github.com/nodejs/node/pull/25660
test: fix renegotiation tests in pummel #25668 https://github.com/nodejs/node/pull/25668
test: fix test-https-ci-reneg-attack #25676 https://github.com/nodejs/node/pull/25676
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 26, 2019 https://github.com/nodejs/node/pull/25700#pullrequestreview-196781208
View reviewed changes https://github.com/nodejs/node/pull/25700/files/9197808ed308e768ec802b7e2ffb90107c927b08
test/pummel/test-tls-ci-reneg-attack.jshttps://github.com/nodejs/node/pull/25700/files/9197808ed308e768ec802b7e2ffb90107c927b08#diff-157c6d962fd09e50060375dcc68cffacb99583cfb92bfc4de1a9462f7de64b8f
bnoordhuishttps://github.com/bnoordhuis
Jan 26, 2019https://github.com/nodejs/node/pull/25700#discussion_r251192772
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25700
Trotthttps://github.com/Trott
Jan 27, 2019 https://github.com/nodejs/node/pull/25700#ref-commit-c421619
https://github.com/Trott
test: remove s_client from test-tls-ci-reneg-attackhttps://github.com/Trott/io.js/commit/c4216194be1b6856b9d02999ea0adc25cc036804
c421619https://github.com/Trott/io.js/commit/c4216194be1b6856b9d02999ea0adc25cc036804
nodejs#25676 (comment)https://github.com/nodejs/node/pull/25676#issuecomment-457307881
nodejs#25700https://github.com/nodejs/node/pull/25700
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 27, 2019https://github.com/nodejs/node/pull/25700#issuecomment-457936260
c421619https://github.com/nodejs/node/commit/c4216194be1b6856b9d02999ea0adc25cc036804
Please reload this pagehttps://github.com/nodejs/node/pull/25700
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 27, 2019https://github.com/nodejs/node/pull/25700#event-2099416721
addaleaxhttps://github.com/addaleax
Jan 28, 2019 https://github.com/nodejs/node/pull/25700#ref-commit-271126a
https://github.com/Trott
https://github.com/addaleax
test: remove s_client from test-tls-ci-reneg-attackhttps://github.com/nodejs/node/commit/271126ad3b6d0d94aac654e9216ac0dad396056e
271126ahttps://github.com/nodejs/node/commit/271126ad3b6d0d94aac654e9216ac0dad396056e
#25676 (comment)https://github.com/nodejs/node/pull/25676#issuecomment-457307881
#25700https://github.com/nodejs/node/pull/25700
https://github.com/targos
targoshttps://github.com/targos
Jan 29, 2019 https://github.com/nodejs/node/pull/25700#ref-pullrequest-404502468
v11.9.0 proposal #25802 https://github.com/nodejs/node/pull/25802
BethGriggshttps://github.com/BethGriggs
Apr 16, 2019 https://github.com/nodejs/node/pull/25700#ref-commit-a87c605
https://github.com/Trott
https://github.com/BethGriggs
test: remove s_client from test-tls-ci-reneg-attackhttps://github.com/nodejs/node/commit/a87c605e1c922d9550ddd60e417530a9438d9584
a87c605https://github.com/nodejs/node/commit/a87c605e1c922d9550ddd60e417530a9438d9584
#25676 (comment)https://github.com/nodejs/node/pull/25676#issuecomment-457307881
#25700https://github.com/nodejs/node/pull/25700
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
May 1, 2019 https://github.com/nodejs/node/pull/25700#ref-pullrequest-439147711
v10.16.0 proposal #27514 https://github.com/nodejs/node/pull/27514
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#315 https://github.com/beevelop/docker-android-nodejs/issues/315
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#316 https://github.com/beevelop/docker-android-nodejs/issues/316
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#317 https://github.com/beevelop/docker-android-nodejs/issues/317
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#318 https://github.com/beevelop/docker-android-nodejs/issues/318
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#319 https://github.com/beevelop/docker-android-nodejs/issues/319
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:51https://github.com/nodejs/node/pull/25700#event-5890971901
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25700
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/25700/files/9197808ed308e768ec802b7e2ffb90107c927b08
https://github.com/shigeki
shigeki https://github.com/shigeki
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/25700/files/9197808ed308e768ec802b7e2ffb90107c927b08
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
flaky-test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/25700
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/sam-github
https://github.com/bnoordhuis
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.