| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:86c831b0-297a-fbf0-76b4-e4479ff74274 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AFDE:3EE845:347F478:47DFD8E:6A4F1341 |
| html-safe-nonce | 8858b61b7d194490ad873af6489ebb559a4732b25e89415054ad9cb885e8e3df |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkRFOjNFRTg0NTozNDdGNDc4OjQ3REZEOEU6NkE0RjEzNDEiLCJ2aXNpdG9yX2lkIjoiMjEyMzI4Mzg4NzM1NDcyNDQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0638a4ea9f38ff8645690f9bb88999a276e0eb454d1d6e888db6a9f1933988cc |
| hovercard-subject-tag | pull_request:247413721 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25683/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/89373c139d2f2d6f94819beefc142ad33ecff6f275a91dc4027e7d09c94a2131/nodejs/node/pull/25683 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/89373c139d2f2d6f94819beefc142ad33ecff6f275a91dc4027e7d09c94a2131/nodejs/node/pull/25683 |
| og:image:alt | V8 is going to require full support for C++14.
/cc @hashseed @nodejs/v8 @nodejs/build
I don't actually know if there is a version 5.1.0. Happy to put another higher number. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25683#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25683 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25683 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25683 |
| Reload | https://github.com/nodejs/node/pull/25683 |
| Reload | https://github.com/nodejs/node/pull/25683 |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
966
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| targos | https://github.com/targos |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| targos:gcc-5 | https://github.com/targos/node/tree/gcc-5 |
| Conversation | https://github.com/nodejs/node/pull/25683 |
| Commits1 (1) | https://github.com/nodejs/node/pull/25683/commits |
| Checks | https://github.com/nodejs/node/pull/25683/checks |
| Files changed | https://github.com/nodejs/node/pull/25683/files |
| meta: bump minimal supported GCC version to 5 | https://github.com/nodejs/node/pull/25683#top |
| targos | https://github.com/targos |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| targos:gcc-5 | https://github.com/targos/node/tree/gcc-5 |
|
| https://github.com/targos |
| targos | https://github.com/targos |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25683#issue-402815064 |
| @hashseed | https://github.com/hashseed |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
|
| https://github.com/targos |
| meta: bump minimal supported GCC version to 5 | https://github.com/nodejs/node/pull/25683/commits/e8a2d3e9de2be8a28ae3c3f1a73dc087bd77dd02 |
| e8a2d3e | https://github.com/nodejs/node/pull/25683/commits/e8a2d3e9de2be8a28ae3c3f1a73dc087bd77dd02 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25683#issuecomment-457282848 |
| @targos | https://github.com/targos |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2371/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2371/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25683#event-2095133395 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25683#event-2095133987 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25683#issuecomment-457283137 |
| https://github.com/nodejs/node/blob/master/BUILDING.md#supported-platforms-1 | https://github.com/nodejs/node/blob/master/BUILDING.md#supported-platforms-1 |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25683#issuecomment-457285341 |
| nodejs/build#1543 | https://github.com/nodejs/build/issues/1543 |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25683#issuecomment-457289411 |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/25683#ref-pullrequest-402825221 |
|
meta: update note about building on smartOS 16
#25684
| https://github.com/nodejs/node/pull/25684 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25683#issuecomment-457293264 |
| /BUILDING.md@master#supported-platforms-1 | https://github.com/nodejs/node/blob/master/BUILDING.md#supported-platforms-1 |
| #25684 | https://github.com/nodejs/node/pull/25684 |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25683#issuecomment-457293482 |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25683#issuecomment-457318722 |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
| https://github.com/ebraminio |
| ebraminio | https://github.com/ebraminio |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/25683#ref-issue-393764533 |
|
C++11: Modernize codebase
harfbuzz/harfbuzz#1509
| https://github.com/harfbuzz/harfbuzz/issues/1509 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25683#issuecomment-457352645 |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 4, 2019
| https://github.com/nodejs/node/pull/25683#ref-commit-000788e |
|
| https://github.com/refack |
|
| https://github.com/BridgeAR |
| meta: update note about building on smartOS 16 | https://github.com/BridgeAR/node/commit/000788ec23c584c3ded71dae5cab057de0f416bd |
| 000788e | https://github.com/BridgeAR/node/commit/000788ec23c584c3ded71dae5cab057de0f416bd |
| nodejs#25684 | https://github.com/nodejs/node/pull/25684 |
| nodejs#25683 | https://github.com/nodejs/node/pull/25683 |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 4, 2019
| https://github.com/nodejs/node/pull/25683#ref-commit-74b9807 |
|
| https://github.com/refack |
|
| https://github.com/BridgeAR |
| meta: update note about building on smartOS 16 | https://github.com/nodejs/node/commit/74b98079d9c2309c335b0872d0703b406bd353b4 |
| 74b9807 | https://github.com/nodejs/node/commit/74b98079d9c2309c335b0872d0703b406bd353b4 |
| #25684 | https://github.com/nodejs/node/pull/25684 |
| #25683 | https://github.com/nodejs/node/pull/25683 |
| BridgeAR | https://github.com/BridgeAR |
|
Mar 5, 2019
| https://github.com/nodejs/node/pull/25683#ref-commit-b25694d |
|
| https://github.com/refack |
|
| https://github.com/BridgeAR |
| meta: update note about building on smartOS 16 | https://github.com/nodejs/node/commit/b25694d7adfc7cbb18cbe98e9ca0850b2bac10c0 |
| b25694d | https://github.com/nodejs/node/commit/b25694d7adfc7cbb18cbe98e9ca0850b2bac10c0 |
| #25684 | https://github.com/nodejs/node/pull/25684 |
| #25683 | https://github.com/nodejs/node/pull/25683 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Mar 21, 2019 | https://github.com/nodejs/node/pull/25683#issuecomment-475420824 |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Mar 21, 2019 | https://github.com/nodejs/node/pull/25683#issuecomment-475427407 |
| #26714 | https://github.com/nodejs/node/pull/26714 |
| #26719 | https://github.com/nodejs/node/pull/26719 |
| @targos | https://github.com/targos |
| #26719 | https://github.com/nodejs/node/pull/26719 |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Mar 21, 2019 | https://github.com/nodejs/node/pull/25683#issuecomment-475432731 |
| @richardlau | https://github.com/richardlau |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Mar 21, 2019 | https://github.com/nodejs/node/pull/25683#event-2221251659 |
| https://github.com/targos |
| targos | https://github.com/targos |
| October 17, 2020 12:55 | https://github.com/nodejs/node/pull/25683#event-3889203064 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25683 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Please reload this page | https://github.com/nodejs/node/pull/25683 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/refack |
|
| https://github.com/ofrobots |
|
| https://github.com/mscdex |
|
| https://github.com/mhdawson |
|
| https://github.com/BridgeAR |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |