René's URL Explorer Experiment


Title: dns: use IDNA 2008 to encode non-ascii hostnames by bnoordhuis · Pull Request #25679 · nodejs/node · GitHub

Open Graph Title: dns: use IDNA 2008 to encode non-ascii hostnames by bnoordhuis · Pull Request #25679 · nodejs/node

X Title: dns: use IDNA 2008 to encode non-ascii hostnames by bnoordhuis · Pull Request #25679 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Before this commit, Node.js left it up to the system resolver or c-ares. Leaving it to the system resolver introduces platform differences because: some support IDNA 2008 some only IDNA 2003 (glib...

X Description: Before this commit, Node.js left it up to the system resolver or c-ares. Leaving it to the system resolver introduces platform differences because: some support IDNA 2008 some only IDNA 2003 (glib...

Opengraph URL: https://github.com/nodejs/node/pull/25679

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:93c170b3-288d-20c4-7478-feb7b999e67e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA64A:1D0BAD:16DC378:1D75818:69925548
html-safe-nonceb5d6e8d268c489a6e58da63171dbb3f846db7eca6b96b52e9b61b9dc1b91a870
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjRBOjFEMEJBRDoxNkRDMzc4OjFENzU4MTg6Njk5MjU1NDgiLCJ2aXNpdG9yX2lkIjoiNjkzOTcwMzAwMDY2ODcyMjUwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac233072e25dded5f335677bf7eceed7daf5a1ec174c27764b174a551a63f51b0c
hovercard-subject-tagpull_request:247231927
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25679/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f45dce3e81bb765b6f1ee0efd562b4b1e99e49bfbe9b5f35e63dd28e90a527cd/nodejs/node/pull/25679
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f45dce3e81bb765b6f1ee0efd562b4b1e99e49bfbe9b5f35e63dd28e90a527cd/nodejs/node/pull/25679
og:image:altBefore this commit, Node.js left it up to the system resolver or c-ares. Leaving it to the system resolver introduces platform differences because: some support IDNA 2008 some only IDNA 2003 (glib...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25679#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25679
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25679
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25679
Reloadhttps://github.com/nodejs/node/pull/25679
Reloadhttps://github.com/nodejs/node/pull/25679
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25679
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 718 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix25558https://github.com/bnoordhuis/io.js/tree/fix25558
Conversationhttps://github.com/nodejs/node/pull/25679
Commits1 (1)https://github.com/nodejs/node/pull/25679/commits
Checkshttps://github.com/nodejs/node/pull/25679/checks
Files changedhttps://github.com/nodejs/node/pull/25679/files
dns: use IDNA 2008 to encode non-ascii hostnameshttps://github.com/nodejs/node/pull/25679#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix25558https://github.com/bnoordhuis/io.js/tree/fix25558
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 24, 2019https://github.com/nodejs/node/pull/25679#issue-402582218
CVE-2016-8625https://github.com/advisories/GHSA-33h3-8669-hjwx
https://github.com/nodejs-private/security/issues/97https://github.com/nodejs-private/security/issues/97
@santigimenohttps://github.com/santigimeno
#25559https://github.com/nodejs/node/pull/25559
Please reload this pagehttps://github.com/nodejs/node/pull/25679
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 24, 2019https://github.com/nodejs/node/pull/25679#issuecomment-457100420
@bnoordhuishttps://github.com/bnoordhuis
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2369/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2369/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25679
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jan 24, 2019https://github.com/nodejs/node/pull/25679#event-2093725639
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 24, 2019 https://github.com/nodejs/node/pull/25679#ref-pullrequest-400645167
dns: idna encode hostnames before resolution #25559 https://github.com/nodejs/node/pull/25559
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
Jan 24, 2019 https://github.com/nodejs/node/pull/25679#pullrequestreview-195895560
View reviewed changes https://github.com/nodejs/node/pull/25679/files
santigimenohttps://github.com/santigimeno
https://github.com/nodejs/node/pull/25679#pullrequestreview-195895560
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
herehttps://github.com/nodejs/node/blob/79a2772fc197d2da8e8a72199da4e1e07072af13/lib/dns.js#L218-L222
Please reload this pagehttps://github.com/nodejs/node/pull/25679
https://github.com/saghul
saghulhttps://github.com/saghul
Jan 24, 2019 https://github.com/nodejs/node/pull/25679#pullrequestreview-195934014
View reviewed changes https://github.com/nodejs/node/pull/25679/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 24, 2019 https://github.com/nodejs/node/pull/25679#pullrequestreview-195978331
View reviewed changes https://github.com/nodejs/node/pull/25679/files
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 24, 2019https://github.com/nodejs/node/pull/25679#issuecomment-457167263
Please reload this pagehttps://github.com/nodejs/node/pull/25679
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 24, 2019 https://github.com/nodejs/node/pull/25679#pullrequestreview-195999822
View reviewed changes https://github.com/nodejs/node/pull/25679/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 24, 2019 https://github.com/nodejs/node/pull/25679#pullrequestreview-196021043
View reviewed changes https://github.com/nodejs/node/pull/25679/files
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
Jan 24, 2019https://github.com/nodejs/node/pull/25679#issuecomment-457197511
https://github.com/nodejs/node/blob/master/lib/url.js#L385https://github.com/nodejs/node/blob/master/lib/url.js#L385
could potentially throwhttps://github.com/nodejs/node/pull/25559#discussion_r248983272
Please reload this pagehttps://github.com/nodejs/node/pull/25679
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 24, 2019 https://github.com/nodejs/node/pull/25679#ref-issue-400613739
DNS resolution fails for internationalized domain names #25558 https://github.com/nodejs/node/issues/25558
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jan 24, 2019 https://github.com/nodejs/node/pull/25679#pullrequestreview-196182208
View reviewed changes https://github.com/nodejs/node/pull/25679/files
test/internet/test-dns-idna2008.jshttps://github.com/nodejs/node/pull/25679/files#diff-93047936f5435bc670192489b073d5e973c1a641e53c262dbddb8cc3aa2dd6b7
TimothyGuhttps://github.com/TimothyGu
Jan 24, 2019https://github.com/nodejs/node/pull/25679#discussion_r250724516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25679
https://github.com/bnoordhuis
dns: use IDNA 2008 to encode non-ascii hostnameshttps://github.com/nodejs/node/pull/25679/commits/e3ddd7200080451af47ad71e5f797eaf27ee4810
e3ddd72https://github.com/nodejs/node/pull/25679/commits/e3ddd7200080451af47ad71e5f797eaf27ee4810
CVE-2016-8625https://github.com/advisories/GHSA-33h3-8669-hjwx
nodejs-private/security#97https://github.com/nodejs-private/security/issues/97
nodejs#25558https://github.com/nodejs/node/issues/25558
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/2409ae250bb9ea0e5b7dc36e4320a83a0cee9169..e3ddd7200080451af47ad71e5f797eaf27ee4810
2409ae2https://github.com/nodejs/node/commit/2409ae250bb9ea0e5b7dc36e4320a83a0cee9169
e3ddd72https://github.com/nodejs/node/commit/e3ddd7200080451af47ad71e5f797eaf27ee4810
Compare https://github.com/nodejs/node/compare/2409ae250bb9ea0e5b7dc36e4320a83a0cee9169..e3ddd7200080451af47ad71e5f797eaf27ee4810
January 28, 2019 09:26https://github.com/nodejs/node/pull/25679#event-2100196985
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 28, 2019https://github.com/nodejs/node/pull/25679#issuecomment-458053813
https://ci.nodejs.org/job/node-test-pull-request/20370/https://ci.nodejs.org/job/node-test-pull-request/20370/
Please reload this pagehttps://github.com/nodejs/node/pull/25679
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 28, 2019https://github.com/nodejs/node/pull/25679#issuecomment-458275108
f399b01https://github.com/nodejs/node/commit/f399b01dc4dbb47f678301aea6f476527889b959
Please reload this pagehttps://github.com/nodejs/node/pull/25679
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 28, 2019https://github.com/nodejs/node/pull/25679#event-2101779393
addaleaxhttps://github.com/addaleax
Jan 28, 2019 https://github.com/nodejs/node/pull/25679#ref-commit-f399b01
https://github.com/bnoordhuis
https://github.com/addaleax
dns: use IDNA 2008 to encode non-ascii hostnameshttps://github.com/nodejs/node/commit/f399b01dc4dbb47f678301aea6f476527889b959
f399b01https://github.com/nodejs/node/commit/f399b01dc4dbb47f678301aea6f476527889b959
CVE-2016-8625https://github.com/advisories/GHSA-33h3-8669-hjwx
https://github.com/nodejs-private/security/issues/97https://github.com/nodejs-private/security/issues/97
#25558https://github.com/nodejs/node/issues/25558
#25679https://github.com/nodejs/node/pull/25679
addaleaxhttps://github.com/addaleax
Jan 28, 2019 https://github.com/nodejs/node/pull/25679#ref-commit-c82f244
https://github.com/bnoordhuis
https://github.com/addaleax
dns: use IDNA 2008 to encode non-ascii hostnameshttps://github.com/nodejs/node/commit/c82f2445e5f5e8b387992e4e0e0ed99ab3e93012
c82f244https://github.com/nodejs/node/commit/c82f2445e5f5e8b387992e4e0e0ed99ab3e93012
CVE-2016-8625https://github.com/advisories/GHSA-33h3-8669-hjwx
https://github.com/nodejs-private/security/issues/97https://github.com/nodejs-private/security/issues/97
#25558https://github.com/nodejs/node/issues/25558
#25679https://github.com/nodejs/node/pull/25679
https://github.com/targos
targoshttps://github.com/targos
Jan 29, 2019 https://github.com/nodejs/node/pull/25679#ref-pullrequest-404502468
v11.9.0 proposal #25802 https://github.com/nodejs/node/pull/25802
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 1, 2019https://github.com/nodejs/node/pull/25679#issuecomment-459745937
https://ci.nodejs.org/job/node-test-commit-custom-suites/855/default/consolehttps://ci.nodejs.org/job/node-test-commit-custom-suites/855/default/console
https://ci.nodejs.org/job/node-test-commit-custom-suites/852/default/consolehttps://ci.nodejs.org/job/node-test-commit-custom-suites/852/default/console
Please reload this pagehttps://github.com/nodejs/node/pull/25679
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 1, 2019https://github.com/nodejs/node/pull/25679#issuecomment-459747061
Please reload this pagehttps://github.com/nodejs/node/pull/25679
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 1, 2019 https://github.com/nodejs/node/pull/25679#ref-issue-405733997
investigate flaky internet/test-dns-idna2008 test #25870 https://github.com/nodejs/node/issues/25870
https://github.com/Ayase-252
Ayase-252https://github.com/Ayase-252
Jun 24, 2021 https://github.com/nodejs/node/pull/25679#ref-issue-929148744
dnsPromises Resolver with IDN certain subdomains #39139 https://github.com/nodejs/node/issues/39139
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25679
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/25679/files/e135b6b1dfe1ec1c0e2d146c0c50ef61319f2f1e
https://github.com/santigimeno
santigimeno https://github.com/santigimeno
https://github.com/nodejs/node/pull/25679/files/e135b6b1dfe1ec1c0e2d146c0c50ef61319f2f1e
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/25679/files/2409ae250bb9ea0e5b7dc36e4320a83a0cee9169
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/25679/files/2409ae250bb9ea0e5b7dc36e4320a83a0cee9169
https://github.com/saghul
saghul https://github.com/saghul
https://github.com/nodejs/node/pull/25679/files/e135b6b1dfe1ec1c0e2d146c0c50ef61319f2f1e
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/25679/files/2409ae250bb9ea0e5b7dc36e4320a83a0cee9169
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/25679
https://github.com/bnoordhuis
https://github.com/nodejs-github-bot
https://github.com/santigimeno
https://github.com/addaleax
https://github.com/Trott
https://github.com/saghul
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.