| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ef367ee3-3de1-7e62-18db-5af9eca81e03 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DD6E:1A6069:72D927:924D20:699135A0 |
| html-safe-nonce | 55649cfaabc9bceb8c0bf55cd61ff3eddf96fffa7f56ecf075ebdb45fbdef66b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDZFOjFBNjA2OTo3MkQ5Mjc6OTI0RDIwOjY5OTEzNUEwIiwidmlzaXRvcl9pZCI6IjgzOTIxNTUxNDIyNDY0NDY0OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 47da8071bba9e289a4d82a297a55565af57d36a806ecc886bb22014abd90f1f1 |
| hovercard-subject-tag | pull_request:247208924 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25677/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6b8260b85a5785590d63d24d75e15196b677aab847977aa0638a88586af3256b/nodejs/node/pull/25677 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6b8260b85a5785590d63d24d75e15196b677aab847977aa0638a88586af3256b/nodejs/node/pull/25677 |
| og:image:alt | Fix test/pummel/test-exec.js which broke as a result of
e47f972
(#24951).
(Until very recently, pummel tests were not run at all in CI and
currently only run nightly on master.)
Checklist
make ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25677#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25677 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25677 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25677 |
| Reload | https://github.com/nodejs/node/pull/25677 |
| Reload | https://github.com/nodejs/node/pull/25677 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25677 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
710
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:fix-test-exec | https://github.com/Trott/io.js/tree/fix-test-exec |
| Conversation | https://github.com/nodejs/node/pull/25677 |
| Commits1 (1) | https://github.com/nodejs/node/pull/25677/commits |
| Checks | https://github.com/nodejs/node/pull/25677/checks |
| Files changed | https://github.com/nodejs/node/pull/25677/files |
| test: fix pummel/test-exec | https://github.com/nodejs/node/pull/25677#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:fix-test-exec | https://github.com/Trott/io.js/tree/fix-test-exec |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25677#issue-402551941 |
| e47f972 | https://github.com/nodejs/node/commit/e47f972d6851b3196b3b2ba611929f25a5fcadb6 |
| #24951 | https://github.com/nodejs/node/pull/24951 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25677 |
|
| https://github.com/Trott |
| test: fix pummel/test-exec | https://github.com/nodejs/node/pull/25677/commits/d78f29db390c8d6b44167819d4ddd817cea4b153 |
| d78f29d | https://github.com/nodejs/node/pull/25677/commits/d78f29db390c8d6b44167819d4ddd817cea4b153 |
| e47f972 | https://github.com/Trott/io.js/commit/e47f972d6851b3196b3b2ba611929f25a5fcadb6 |
| nodejs#24951 | https://github.com/nodejs/node/pull/24951 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25677#issuecomment-457074698 |
| @Trott | https://github.com/Trott |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2367/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2367/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25677 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25677#event-2093553759 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Fishrock123 | https://github.com/Fishrock123 |
| January 24, 2019 05:46 | https://github.com/nodejs/node/pull/25677#event-2093553838 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/25677#pullrequestreview-195880099 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25677/files/d78f29db390c8d6b44167819d4ddd817cea4b153 |
| Fishrock123 | https://github.com/Fishrock123 |
| https://github.com/nodejs/node/pull/25677#pullrequestreview-195880099 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25677 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25677#event-2093658635 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25677#issuecomment-457090567 |
| Please reload this page | https://github.com/nodejs/node/pull/25677 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/25677#pullrequestreview-195901451 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25677/files/d78f29db390c8d6b44167819d4ddd817cea4b153 |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/25677#pullrequestreview-195909759 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25677/files/d78f29db390c8d6b44167819d4ddd817cea4b153 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/25677#pullrequestreview-196021375 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25677/files/d78f29db390c8d6b44167819d4ddd817cea4b153 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25677#issuecomment-457212666 |
| Please reload this page | https://github.com/nodejs/node/pull/25677 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25677#event-2094590384 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/25677#pullrequestreview-196068468 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25677/files/d78f29db390c8d6b44167819d4ddd817cea4b153 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25677#issuecomment-457342823 |
| Please reload this page | https://github.com/nodejs/node/pull/25677 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 24, 2019 | https://github.com/nodejs/node/pull/25677#event-2095549597 |
| Trott | https://github.com/Trott |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/25677#ref-commit-0c6b5ce |
|
| https://github.com/Trott |
| test: fix pummel/test-exec | https://github.com/Trott/io.js/commit/0c6b5cea424476d93c98030bcba0ba2b7f95302d |
| 0c6b5ce | https://github.com/Trott/io.js/commit/0c6b5cea424476d93c98030bcba0ba2b7f95302d |
| e47f972 | https://github.com/Trott/io.js/commit/e47f972d6851b3196b3b2ba611929f25a5fcadb6 |
| nodejs#24951 | https://github.com/nodejs/node/pull/24951 |
| nodejs#25677 | https://github.com/nodejs/node/pull/25677 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/25677#ref-commit-a9ffce9 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: fix pummel/test-exec | https://github.com/nodejs/node/commit/a9ffce908dddf679166a7c4bd08b9ea801cca774 |
| a9ffce9 | https://github.com/nodejs/node/commit/a9ffce908dddf679166a7c4bd08b9ea801cca774 |
| e47f972 | https://github.com/nodejs/node/commit/e47f972d6851b3196b3b2ba611929f25a5fcadb6 |
| #24951 | https://github.com/nodejs/node/pull/24951 |
| #25677 | https://github.com/nodejs/node/pull/25677 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/25677#ref-pullrequest-402909465 |
|
v11.8.0 proposal
#25687
| https://github.com/nodejs/node/pull/25687 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 29, 2019
| https://github.com/nodejs/node/pull/25677#ref-commit-befb57a |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| test: fix pummel/test-exec | https://github.com/nodejs/node/commit/befb57ac732c64fff0a0aace69ecf024992c2a36 |
| befb57a | https://github.com/nodejs/node/commit/befb57ac732c64fff0a0aace69ecf024992c2a36 |
| e47f972 | https://github.com/nodejs/node/commit/e47f972d6851b3196b3b2ba611929f25a5fcadb6 |
| #24951 | https://github.com/nodejs/node/pull/24951 |
| #25677 | https://github.com/nodejs/node/pull/25677 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
May 1, 2019
| https://github.com/nodejs/node/pull/25677#ref-pullrequest-439147711 |
|
v10.16.0 proposal
#27514
| https://github.com/nodejs/node/pull/27514 |
| BethGriggs | https://github.com/BethGriggs |
|
May 10, 2019
| https://github.com/nodejs/node/pull/25677#ref-commit-043b9be |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| test: fix pummel/test-exec | https://github.com/nodejs/node/commit/043b9beaab134c2adcc7dddfaa0e401b95ef9857 |
| 043b9be | https://github.com/nodejs/node/commit/043b9beaab134c2adcc7dddfaa0e401b95ef9857 |
| e47f972 | https://github.com/nodejs/node/commit/e47f972d6851b3196b3b2ba611929f25a5fcadb6 |
| #24951 | https://github.com/nodejs/node/pull/24951 |
| #25677 | https://github.com/nodejs/node/pull/25677 |
| MylesBorins | https://github.com/MylesBorins |
|
May 16, 2019
| https://github.com/nodejs/node/pull/25677#ref-commit-5d69e69 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: fix pummel/test-exec | https://github.com/nodejs/node/commit/5d69e69b38c0ddf21b95a58d50a75d8d401f7c31 |
| 5d69e69 | https://github.com/nodejs/node/commit/5d69e69b38c0ddf21b95a58d50a75d8d401f7c31 |
| e47f972 | https://github.com/nodejs/node/commit/e47f972d6851b3196b3b2ba611929f25a5fcadb6 |
| #24951 | https://github.com/nodejs/node/pull/24951 |
| #25677 | https://github.com/nodejs/node/pull/25677 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#315
| https://github.com/beevelop/docker-android-nodejs/issues/315 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#316
| https://github.com/beevelop/docker-android-nodejs/issues/316 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#317
| https://github.com/beevelop/docker-android-nodejs/issues/317 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#318
| https://github.com/beevelop/docker-android-nodejs/issues/318 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#319
| https://github.com/beevelop/docker-android-nodejs/issues/319 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:50 | https://github.com/nodejs/node/pull/25677#event-5890971618 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25677 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/25677/files/d78f29db390c8d6b44167819d4ddd817cea4b153 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/25677/files/d78f29db390c8d6b44167819d4ddd817cea4b153 |
|
| https://github.com/danbev |
|
danbev
| https://github.com/danbev |
|
| https://github.com/nodejs/node/pull/25677/files/d78f29db390c8d6b44167819d4ddd817cea4b153 |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs/node/pull/25677/files/d78f29db390c8d6b44167819d4ddd817cea4b153 |
|
| https://github.com/antsmartian |
|
antsmartian
| https://github.com/antsmartian |
|
| https://github.com/nodejs/node/pull/25677/files/d78f29db390c8d6b44167819d4ddd817cea4b153 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/25677 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danbev |
|
| https://github.com/Fishrock123 |
|
| https://github.com/antsmartian |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |