René's URL Explorer Experiment


Title: src: ensure no more platform foreground tasks after Deinit by addaleax · Pull Request #25653 · nodejs/node · GitHub

Open Graph Title: src: ensure no more platform foreground tasks after Deinit by addaleax · Pull Request #25653 · nodejs/node

X Title: src: ensure no more platform foreground tasks after Deinit by addaleax · Pull Request #25653 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Node first calls Isolate::Dispose, then NodePlatform::UnregisterIsolate. This again calls PerIsolatePlatformData::Shutdown, which (before this patch) called FlushForegroundTasksInternal, which migh...

X Description: Node first calls Isolate::Dispose, then NodePlatform::UnregisterIsolate. This again calls PerIsolatePlatformData::Shutdown, which (before this patch) called FlushForegroundTasksInternal, which migh...

Opengraph URL: https://github.com/nodejs/node/pull/25653

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:40990b2c-6b8e-61da-524b-3ddc2de8b682
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC28:BCEB:1966064:20C4901:69926EF6
html-safe-nonce744906bd583f8cf8fab67e195c53c392dbdbfb1c5c43811a42ba0ef9d862748e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzI4OkJDRUI6MTk2NjA2NDoyMEM0OTAxOjY5OTI2RUY2IiwidmlzaXRvcl9pZCI6IjI3MDU0NjkzNjQwMjc2ODI1NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac78bab876f2cd49d7f5e18430d5c9c423ec43a855c5b94c9651770a4a859d4803
hovercard-subject-tagpull_request:246800379
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25653/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8796607241134e3a1da1a28957bf5bd02690acc24ca21ddaeaf8d612de3ea539/nodejs/node/pull/25653
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8796607241134e3a1da1a28957bf5bd02690acc24ca21ddaeaf8d612de3ea539/nodejs/node/pull/25653
og:image:altNode first calls Isolate::Dispose, then NodePlatform::UnregisterIsolate. This again calls PerIsolatePlatformData::Shutdown, which (before this patch) called FlushForegroundTasksInternal, which migh...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25653#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25653
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25653
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25653
Reloadhttps://github.com/nodejs/node/pull/25653
Reloadhttps://github.com/nodejs/node/pull/25653
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25653
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:pick-v8-platform-deinithttps://github.com/addaleax/node/tree/pick-v8-platform-deinit
Conversationhttps://github.com/nodejs/node/pull/25653
Commits1 (1)https://github.com/nodejs/node/pull/25653/commits
Checkshttps://github.com/nodejs/node/pull/25653/checks
Files changedhttps://github.com/nodejs/node/pull/25653/files
src: ensure no more platform foreground tasks after Deinithttps://github.com/nodejs/node/pull/25653#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:pick-v8-platform-deinithttps://github.com/addaleax/node/tree/pick-v8-platform-deinit
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 23, 2019https://github.com/nodejs/node/pull/25653#issue-402017252
v8#86https://github.com/v8/node/pull/86
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25653
https://github.com/backes
https://github.com/addaleax
src: ensure no more platform foreground tasks after Deinithttps://github.com/nodejs/node/pull/25653/commits/e2282ffb012c9d8c2bb07a1c90ef90dcfd7dc70b
e2282ffhttps://github.com/nodejs/node/pull/25653/commits/e2282ffb012c9d8c2bb07a1c90ef90dcfd7dc70b
v8#86https://github.com/v8/node/pull/86
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 23, 2019https://github.com/nodejs/node/pull/25653#issuecomment-456620641
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2349/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2349/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25653
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jan 23, 2019https://github.com/nodejs/node/pull/25653#event-2090349973
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 23, 2019https://github.com/nodejs/node/pull/25653#issuecomment-456620721
https://ci.nodejs.org/job/node-test-pull-request/20272/https://ci.nodejs.org/job/node-test-pull-request/20272/
Please reload this pagehttps://github.com/nodejs/node/pull/25653
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jan 23, 2019 https://github.com/nodejs/node/pull/25653#pullrequestreview-195300539
View reviewed changes https://github.com/nodejs/node/pull/25653/files/e2282ffb012c9d8c2bb07a1c90ef90dcfd7dc70b
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 23, 2019 https://github.com/nodejs/node/pull/25653#pullrequestreview-195349032
View reviewed changes https://github.com/nodejs/node/pull/25653/files/e2282ffb012c9d8c2bb07a1c90ef90dcfd7dc70b
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 24, 2019https://github.com/nodejs/node/pull/25653#issuecomment-457310940
https://ci.nodejs.org/job/node-test-pull-request/20303/https://ci.nodejs.org/job/node-test-pull-request/20303/
Please reload this pagehttps://github.com/nodejs/node/pull/25653
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 27, 2019https://github.com/nodejs/node/pull/25653#issuecomment-457926577
bafd808https://github.com/nodejs/node/commit/bafd80883ce2b7ac8f92f31119243af1473269f3
Please reload this pagehttps://github.com/nodejs/node/pull/25653
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 27, 2019https://github.com/nodejs/node/pull/25653#event-2099362846
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
January 27, 2019 15:19https://github.com/nodejs/node/pull/25653#event-2099362877
addaleaxhttps://github.com/addaleax
Jan 27, 2019 https://github.com/nodejs/node/pull/25653#ref-commit-bafd808
https://github.com/backes
https://github.com/addaleax
src: ensure no more platform foreground tasks after Deinithttps://github.com/nodejs/node/commit/bafd80883ce2b7ac8f92f31119243af1473269f3
bafd808https://github.com/nodejs/node/commit/bafd80883ce2b7ac8f92f31119243af1473269f3
v8#86https://github.com/v8/node/pull/86
#25653https://github.com/nodejs/node/pull/25653
addaleaxhttps://github.com/addaleax
Jan 28, 2019 https://github.com/nodejs/node/pull/25653#ref-commit-b113332
https://github.com/backes
https://github.com/addaleax
src: ensure no more platform foreground tasks after Deinithttps://github.com/nodejs/node/commit/b113332daf1147ffe58597f1087c04a7e35c420b
b113332https://github.com/nodejs/node/commit/b113332daf1147ffe58597f1087c04a7e35c420b
v8#86https://github.com/v8/node/pull/86
#25653https://github.com/nodejs/node/pull/25653
https://github.com/targos
targoshttps://github.com/targos
Jan 29, 2019 https://github.com/nodejs/node/pull/25653#ref-pullrequest-404502468
v11.9.0 proposal #25802 https://github.com/nodejs/node/pull/25802
BethGriggshttps://github.com/BethGriggs
Mar 27, 2019 https://github.com/nodejs/node/pull/25653#ref-commit-49674f7
https://github.com/backes
https://github.com/BethGriggs
src: ensure no more platform foreground tasks after Deinithttps://github.com/MylesBorins/node/commit/49674f7983b0fa7ed8c1837d9a5234154715e24b
49674f7https://github.com/MylesBorins/node/commit/49674f7983b0fa7ed8c1837d9a5234154715e24b
v8#86https://github.com/v8/node/pull/86
nodejs#25653https://github.com/nodejs/node/pull/25653
BethGriggshttps://github.com/BethGriggs
Mar 28, 2019 https://github.com/nodejs/node/pull/25653#ref-commit-a92286d
https://github.com/backes
https://github.com/BethGriggs
src: ensure no more platform foreground tasks after Deinithttps://github.com/nodejs/node/commit/a92286d6daa11fc280b47d904d27c4b61d5e7ad2
a92286dhttps://github.com/nodejs/node/commit/a92286d6daa11fc280b47d904d27c4b61d5e7ad2
v8#86https://github.com/v8/node/pull/86
#26048https://github.com/nodejs/node/pull/26048
#25653https://github.com/nodejs/node/pull/25653
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
May 1, 2019 https://github.com/nodejs/node/pull/25653#ref-pullrequest-439147711
v10.16.0 proposal #27514 https://github.com/nodejs/node/pull/27514
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#315 https://github.com/beevelop/docker-android-nodejs/issues/315
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#316 https://github.com/beevelop/docker-android-nodejs/issues/316
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#317 https://github.com/beevelop/docker-android-nodejs/issues/317
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#318 https://github.com/beevelop/docker-android-nodejs/issues/318
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#319 https://github.com/beevelop/docker-android-nodejs/issues/319
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 17, 2019 https://github.com/nodejs/node/pull/25653#ref-pullrequest-494577353
src: discard remaining foreground tasks on platform shutdown #29587 https://github.com/nodejs/node/pull/29587
addaleaxhttps://github.com/addaleax
Sep 17, 2019 https://github.com/nodejs/node/pull/25653#ref-commit-e0dceb4
https://github.com/addaleax
src: discard remaining foreground tasks on platform shutdownhttps://github.com/addaleax/node/commit/e0dceb434581aacc4d4bc6c717e6c9a4c64866a0
e0dceb4https://github.com/addaleax/node/commit/e0dceb434581aacc4d4bc6c717e6c9a4c64866a0
nodejs#25653https://github.com/nodejs/node/pull/25653
nodejs#28870 (comment)https://github.com/nodejs/node/pull/28870#issuecomment-531908090
Trotthttps://github.com/Trott
Sep 23, 2019 https://github.com/nodejs/node/pull/25653#ref-commit-54c4139
https://github.com/addaleax
https://github.com/Trott
src: discard remaining foreground tasks on platform shutdownhttps://github.com/nodejs/node/commit/54c4139efd6a2063c5c20d5483935cd2ad4946fd
54c4139https://github.com/nodejs/node/commit/54c4139efd6a2063c5c20d5483935cd2ad4946fd
#25653https://github.com/nodejs/node/pull/25653
#28870 (comment)https://github.com/nodejs/node/pull/28870#issuecomment-531908090
#29587https://github.com/nodejs/node/pull/29587
targoshttps://github.com/targos
Sep 23, 2019 https://github.com/nodejs/node/pull/25653#ref-commit-e98b1f8
https://github.com/addaleax
https://github.com/targos
src: discard remaining foreground tasks on platform shutdownhttps://github.com/nodejs/node/commit/e98b1f8e3331870d097877b7c52e4a5e7cd1c0d8
e98b1f8https://github.com/nodejs/node/commit/e98b1f8e3331870d097877b7c52e4a5e7cd1c0d8
#25653https://github.com/nodejs/node/pull/25653
#28870 (comment)https://github.com/nodejs/node/pull/28870#issuecomment-531908090
#29587https://github.com/nodejs/node/pull/29587
BridgeARhttps://github.com/BridgeAR
Sep 25, 2019 https://github.com/nodejs/node/pull/25653#ref-commit-6f8ef2c
https://github.com/addaleax
https://github.com/BridgeAR
src: discard remaining foreground tasks on platform shutdownhttps://github.com/nodejs/node/commit/6f8ef2cbab647dd9a7d2e0080299a927f0afba7b
6f8ef2chttps://github.com/nodejs/node/commit/6f8ef2cbab647dd9a7d2e0080299a927f0afba7b
#25653https://github.com/nodejs/node/pull/25653
#28870 (comment)https://github.com/nodejs/node/pull/28870#issuecomment-531908090
#29587https://github.com/nodejs/node/pull/29587
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
v8 platform https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20platform%22
Feb 18, 2020https://github.com/nodejs/node/pull/25653#event-3048594713
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25653
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/25653/files/e2282ffb012c9d8c2bb07a1c90ef90dcfd7dc70b
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/25653/files/e2282ffb012c9d8c2bb07a1c90ef90dcfd7dc70b
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
v8 platform https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20platform%22
Please reload this pagehttps://github.com/nodejs/node/pull/25653
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/cjihrig
https://github.com/devsnek
https://github.com/backes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.