René's URL Explorer Experiment


Title: report: do not use `uv_default_loop()` as fallback by addaleax · Pull Request #25652 · nodejs/node · GitHub

Open Graph Title: report: do not use `uv_default_loop()` as fallback by addaleax · Pull Request #25652 · nodejs/node

X Title: report: do not use `uv_default_loop()` as fallback by addaleax · Pull Request #25652 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Not seeing an associated Environment is a rare condition anyway, but using uv_default_loop() as a fallback is not thread-safe. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes ...

X Description: Not seeing an associated Environment is a rare condition anyway, but using uv_default_loop() as a fallback is not thread-safe. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes ...

Opengraph URL: https://github.com/nodejs/node/pull/25652

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:86b9bcdc-6245-29a8-b17c-748c0f18e665
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB92C:42ABE:1D56A1:268376:6991D7FD
html-safe-nonced87b890f4a87408fd4cc2f158a7db3f48de5aa156eb54406aa30c92e6226da93
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTJDOjQyQUJFOjFENTZBMToyNjgzNzY6Njk5MUQ3RkQiLCJ2aXNpdG9yX2lkIjoiNjc3MzI3OTE5ODQwNjYyOTM3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac18e99b1615694950507bf3c832634a7fb6aabead96207f1b1bb5912d73f84ff7
hovercard-subject-tagpull_request:246794916
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25652/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/38cd71b32697f30f897ba45a17674b24d2847731e4b8d8cdf713318ff96ea31f/nodejs/node/pull/25652
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/38cd71b32697f30f897ba45a17674b24d2847731e4b8d8cdf713318ff96ea31f/nodejs/node/pull/25652
og:image:altNot seeing an associated Environment is a rare condition anyway, but using uv_default_loop() as a fallback is not thread-safe. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25652#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25652
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25652
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25652
Reloadhttps://github.com/nodejs/node/pull/25652
Reloadhttps://github.com/nodejs/node/pull/25652
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25652
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:report-no-uv-default-loophttps://github.com/addaleax/node/tree/report-no-uv-default-loop
Conversationhttps://github.com/nodejs/node/pull/25652
Commits1 (1)https://github.com/nodejs/node/pull/25652/commits
Checkshttps://github.com/nodejs/node/pull/25652/checks
Files changedhttps://github.com/nodejs/node/pull/25652/files
report: do not use uv_default_loop() as fallbackhttps://github.com/nodejs/node/pull/25652#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:report-no-uv-default-loophttps://github.com/addaleax/node/tree/report-no-uv-default-loop
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 23, 2019https://github.com/nodejs/node/pull/25652#issue-402009936
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25652
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
gireeshpunathilhttps://github.com/gireeshpunathil
January 23, 2019 00:05https://github.com/nodejs/node/pull/25652#event-2090306364
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 23, 2019https://github.com/nodejs/node/pull/25652#issuecomment-456613809
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2348/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2348/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25652
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jan 23, 2019https://github.com/nodejs/node/pull/25652#event-2090306441
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
report https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areport
Jan 23, 2019https://github.com/nodejs/node/pull/25652#event-2090306565
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 23, 2019https://github.com/nodejs/node/pull/25652#issuecomment-456618640
https://ci.nodejs.org/job/node-test-pull-request/20271/https://ci.nodejs.org/job/node-test-pull-request/20271/
Please reload this pagehttps://github.com/nodejs/node/pull/25652
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jan 23, 2019 https://github.com/nodejs/node/pull/25652#pullrequestreview-195301362
View reviewed changes https://github.com/nodejs/node/pull/25652/files
src/node_report.cchttps://github.com/nodejs/node/pull/25652/files#diff-16cddcd719418092bf9f602309598657f14d1160548cb2803ab98a16328a4f3d
richardlauhttps://github.com/richardlau
Jan 23, 2019https://github.com/nodejs/node/pull/25652#discussion_r250017837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25652
addaleaxhttps://github.com/addaleax
Jan 23, 2019https://github.com/nodejs/node/pull/25652#discussion_r250138384
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@richardlauhttps://github.com/richardlau
Please reload this pagehttps://github.com/nodejs/node/pull/25652
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 23, 2019 https://github.com/nodejs/node/pull/25652#pullrequestreview-195348388
View reviewed changes https://github.com/nodejs/node/pull/25652/files
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jan 23, 2019 https://github.com/nodejs/node/pull/25652#pullrequestreview-195515170
View reviewed changes https://github.com/nodejs/node/pull/25652/files
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jan 23, 2019https://github.com/nodejs/node/pull/25652#issuecomment-456801636
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/25652
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 23, 2019https://github.com/nodejs/node/pull/25652#issuecomment-456808366
@gireeshpunathilhttps://github.com/gireeshpunathil
Please reload this pagehttps://github.com/nodejs/node/pull/25652
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jan 24, 2019https://github.com/nodejs/node/pull/25652#issuecomment-457056202
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/25652
https://github.com/addaleax
report: do not use uv_default_loop() as fallbackhttps://github.com/nodejs/node/pull/25652/commits/0542913603ab44a5c623eff85c566f85c4a77c74
0542913https://github.com/nodejs/node/pull/25652/commits/0542913603ab44a5c623eff85c566f85c4a77c74
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/0bfd3bc558f5c2932a1386215623a22bb58e7b35..0542913603ab44a5c623eff85c566f85c4a77c74
0bfd3bchttps://github.com/nodejs/node/commit/0bfd3bc558f5c2932a1386215623a22bb58e7b35
0542913https://github.com/nodejs/node/commit/0542913603ab44a5c623eff85c566f85c4a77c74
Compare https://github.com/nodejs/node/compare/0bfd3bc558f5c2932a1386215623a22bb58e7b35..0542913603ab44a5c623eff85c566f85c4a77c74
January 24, 2019 18:43https://github.com/nodejs/node/pull/25652#event-2095324240
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 24, 2019https://github.com/nodejs/node/pull/25652#event-2095324361
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 24, 2019https://github.com/nodejs/node/pull/25652#issuecomment-457310601
https://ci.nodejs.org/job/node-test-pull-request/20302/https://ci.nodejs.org/job/node-test-pull-request/20302/
Please reload this pagehttps://github.com/nodejs/node/pull/25652
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 24, 2019https://github.com/nodejs/node/pull/25652#event-2095327114
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 25, 2019https://github.com/nodejs/node/pull/25652#issuecomment-457709369
https://ci.nodejs.org/job/node-test-pull-request/20333/https://ci.nodejs.org/job/node-test-pull-request/20333/
Please reload this pagehttps://github.com/nodejs/node/pull/25652
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 26, 2019https://github.com/nodejs/node/pull/25652#issuecomment-457867197
https://ci.nodejs.org/job/node-test-pull-request/20342/https://ci.nodejs.org/job/node-test-pull-request/20342/
Please reload this pagehttps://github.com/nodejs/node/pull/25652
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 27, 2019https://github.com/nodejs/node/pull/25652#issuecomment-457926926
bb774b1https://github.com/nodejs/node/commit/bb774b1554ed7ad7e7b6d588ef5002382afb8183
Please reload this pagehttps://github.com/nodejs/node/pull/25652
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 27, 2019https://github.com/nodejs/node/pull/25652#event-2099364647
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
January 27, 2019 15:24https://github.com/nodejs/node/pull/25652#event-2099364755
addaleaxhttps://github.com/addaleax
Jan 27, 2019 https://github.com/nodejs/node/pull/25652#ref-commit-bb774b1
https://github.com/addaleax
report: do not use uv_default_loop() as fallbackhttps://github.com/nodejs/node/commit/bb774b1554ed7ad7e7b6d588ef5002382afb8183
bb774b1https://github.com/nodejs/node/commit/bb774b1554ed7ad7e7b6d588ef5002382afb8183
#25652https://github.com/nodejs/node/pull/25652
addaleaxhttps://github.com/addaleax
Jan 28, 2019 https://github.com/nodejs/node/pull/25652#ref-commit-14bce1e
https://github.com/addaleax
report: do not use uv_default_loop() as fallbackhttps://github.com/nodejs/node/commit/14bce1ea5abc4f42c7be66124d51e9c0ebe6a358
14bce1ehttps://github.com/nodejs/node/commit/14bce1ea5abc4f42c7be66124d51e9c0ebe6a358
#25652https://github.com/nodejs/node/pull/25652
https://github.com/targos
targoshttps://github.com/targos
Jan 29, 2019 https://github.com/nodejs/node/pull/25652#ref-pullrequest-404502468
v11.9.0 proposal #25802 https://github.com/nodejs/node/pull/25802
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
May 16, 2019https://github.com/nodejs/node/pull/25652#event-2345414822
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25652
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/25652/files/0bfd3bc558f5c2932a1386215623a22bb58e7b35
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/25652/files/0bfd3bc558f5c2932a1386215623a22bb58e7b35
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/25652/files/0bfd3bc558f5c2932a1386215623a22bb58e7b35
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
report https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areport
Please reload this pagehttps://github.com/nodejs/node/pull/25652
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/gireeshpunathil
https://github.com/Trott
https://github.com/cjihrig
https://github.com/richardlau
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.