| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:30f78217-506a-4281-e5a3-b3acefc0ab5c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DE78:3E6EAA:2630AB7:34D862E:6A4EED47 |
| html-safe-nonce | 27921f086d0619e1f83e1a4cb5f74304e1c95d638fea4c75adce25275a59feea |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTc4OjNFNkVBQToyNjMwQUI3OjM0RDg2MkU6NkE0RUVENDciLCJ2aXNpdG9yX2lkIjoiNzI3OTg3MTAxNjE4Mzk4MzQzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e95a69ecb52f4a8c09f08e449e0c166f191473bc61659bd5a8802e7ce4e7061e |
| hovercard-subject-tag | pull_request:246595201 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/25639 |
| twitter:image | https://opengraph.githubassets.com/16af527f63876a521932db47763f158f4d17a005b4c097dd9faddd3dcdf90e0c/nodejs/node/pull/25639 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/16af527f63876a521932db47763f158f4d17a005b4c097dd9faddd3dcdf90e0c/nodejs/node/pull/25639 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 00d04d6b867d2f16ab50bebae8ccc56e07c8988b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25639#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25639 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25639 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25639 |
| Reload | https://github.com/nodejs/node/pull/25639 |
| Reload | https://github.com/nodejs/node/pull/25639 |
| Please reload this page | https://github.com/nodejs/node/pull/25639 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25639 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:ignore-py-fixtures | https://github.com/joyeecheung/node/tree/ignore-py-fixtures |
| Conversation | https://github.com/nodejs/node/pull/25639 |
| Commits1 (1) | https://github.com/nodejs/node/pull/25639/commits |
| Checks | https://github.com/nodejs/node/pull/25639/checks |
| Files changed | https://github.com/nodejs/node/pull/25639/files |
| build: do not lint python scripts under test/fixtures | https://github.com/nodejs/node/pull/25639#top |
| refack | https://github.com/refack |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:ignore-py-fixtures | https://github.com/joyeecheung/node/tree/ignore-py-fixtures |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Jan 22, 2019 | https://github.com/nodejs/node/pull/25639#issue-401752299 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25639 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| refack | https://github.com/refack |
| January 22, 2019 12:57 | https://github.com/nodejs/node/pull/25639#event-2088703165 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 22, 2019 | https://github.com/nodejs/node/pull/25639#issuecomment-456389874 |
| @joyeecheung | https://github.com/joyeecheung |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2339/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2339/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25639 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Jan 22, 2019 | https://github.com/nodejs/node/pull/25639#event-2088703302 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jan 22, 2019
| https://github.com/nodejs/node/pull/25639#pullrequestreview-195016849 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25639/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jan 22, 2019
| https://github.com/nodejs/node/pull/25639#pullrequestreview-195056336 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25639/files |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 22, 2019
| https://github.com/nodejs/node/pull/25639#pullrequestreview-195062830 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25639/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jan 22, 2019
| https://github.com/nodejs/node/pull/25639#pullrequestreview-195082209 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25639/files |
| https://github.com/refack |
| refack | https://github.com/refack |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Jan 22, 2019 | https://github.com/nodejs/node/pull/25639#event-2089326497 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Jan 22, 2019 | https://github.com/nodejs/node/pull/25639#issuecomment-456469768 |
| Please reload this page | https://github.com/nodejs/node/pull/25639 |
| nodejs/build#1631 | https://github.com/nodejs/build/issues/1631 |
| #25614 | https://github.com/nodejs/node/pull/25614 |
| Please reload this page | https://github.com/nodejs/node/pull/25639 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Jan 22, 2019
| https://github.com/nodejs/node/pull/25639#pullrequestreview-195111752 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25639/files |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Jan 22, 2019
| https://github.com/nodejs/node/pull/25639#ref-pullrequest-401439476 |
|
build,python: update flake8 rules
#25614
| https://github.com/nodejs/node/pull/25614 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Jan 22, 2019
| https://github.com/nodejs/node/pull/25639#pullrequestreview-195122005 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25639/files |
|
| https://github.com/joyeecheung |
|
| https://github.com/refack |
| build: do not lint python scripts under test/fixtures | https://github.com/nodejs/node/pull/25639/commits/715df64b467469d669f4db2b0824851168479be5 |
| 715df64 | https://github.com/nodejs/node/pull/25639/commits/715df64b467469d669f4db2b0824851168479be5 |
| nodejs#25639 | https://github.com/nodejs/node/pull/25639 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/27652086f4d0ad33b0062a6f399647dba332d4da..715df64b467469d669f4db2b0824851168479be5 |
| 2765208 | https://github.com/nodejs/node/commit/27652086f4d0ad33b0062a6f399647dba332d4da |
| 715df64 | https://github.com/nodejs/node/commit/715df64b467469d669f4db2b0824851168479be5 |
|
Compare
| https://github.com/nodejs/node/compare/27652086f4d0ad33b0062a6f399647dba332d4da..715df64b467469d669f4db2b0824851168479be5 |
| January 22, 2019 17:47 | https://github.com/nodejs/node/pull/25639#event-2089504036 |
| https://github.com/refack |
| refack | https://github.com/refack |
| 715df64 | https://github.com/nodejs/node/commit/715df64b467469d669f4db2b0824851168479be5 |
| Jan 22, 2019 | https://github.com/nodejs/node/pull/25639#event-2089507429 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Jan 23, 2019
| https://github.com/nodejs/node/pull/25639#ref-issue-389803430 |
|
Can 'make lint-py PYTHON=python3' be a manditory Jenkins test?
nodejs/build#1631
| https://github.com/nodejs/build/issues/1631 |
| addaleax | https://github.com/addaleax |
|
Jan 23, 2019
| https://github.com/nodejs/node/pull/25639#ref-commit-28894af |
|
| https://github.com/joyeecheung |
|
| https://github.com/addaleax |
| build: do not lint python scripts under test/fixtures | https://github.com/nodejs/node/commit/28894af90255e9790648da5ffb23fd786f86c056 |
| 28894af | https://github.com/nodejs/node/commit/28894af90255e9790648da5ffb23fd786f86c056 |
| #25639 | https://github.com/nodejs/node/pull/25639 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/25639#ref-pullrequest-402909465 |
|
v11.8.0 proposal
#25687
| https://github.com/nodejs/node/pull/25687 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 29, 2019
| https://github.com/nodejs/node/pull/25639#ref-commit-b9e8760 |
|
| https://github.com/joyeecheung |
|
| https://github.com/BethGriggs |
| build: do not lint python scripts under test/fixtures | https://github.com/nodejs/node/commit/b9e876045d1f705014dc1f8aa733713fad4cb3da |
| b9e8760 | https://github.com/nodejs/node/commit/b9e876045d1f705014dc1f8aa733713fad4cb3da |
| #25639 | https://github.com/nodejs/node/pull/25639 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
May 1, 2019
| https://github.com/nodejs/node/pull/25639#ref-pullrequest-439147711 |
|
v10.16.0 proposal
#27514
| https://github.com/nodejs/node/pull/27514 |
| BethGriggs | https://github.com/BethGriggs |
|
May 10, 2019
| https://github.com/nodejs/node/pull/25639#ref-commit-9e3ef92 |
|
| https://github.com/joyeecheung |
|
| https://github.com/BethGriggs |
| build: do not lint python scripts under test/fixtures | https://github.com/nodejs/node/commit/9e3ef92861cbc0480a089f1d181dd9e2ee64670c |
| 9e3ef92 | https://github.com/nodejs/node/commit/9e3ef92861cbc0480a089f1d181dd9e2ee64670c |
| #25639 | https://github.com/nodejs/node/pull/25639 |
| MylesBorins | https://github.com/MylesBorins |
|
May 16, 2019
| https://github.com/nodejs/node/pull/25639#ref-commit-6348d71 |
|
| https://github.com/joyeecheung |
|
| https://github.com/MylesBorins |
| build: do not lint python scripts under test/fixtures | https://github.com/nodejs/node/commit/6348d71a8acff13b09451b1496c1617b812654f9 |
| 6348d71 | https://github.com/nodejs/node/commit/6348d71a8acff13b09451b1496c1617b812654f9 |
| #25639 | https://github.com/nodejs/node/pull/25639 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#315
| https://github.com/beevelop/docker-android-nodejs/issues/315 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#316
| https://github.com/beevelop/docker-android-nodejs/issues/316 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#317
| https://github.com/beevelop/docker-android-nodejs/issues/317 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#318
| https://github.com/beevelop/docker-android-nodejs/issues/318 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#319
| https://github.com/beevelop/docker-android-nodejs/issues/319 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25639 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/25639/files/27652086f4d0ad33b0062a6f399647dba332d4da |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/25639/files/27652086f4d0ad33b0062a6f399647dba332d4da |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/25639/files/27652086f4d0ad33b0062a6f399647dba332d4da |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/25639/files/27652086f4d0ad33b0062a6f399647dba332d4da |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/25639/files/27652086f4d0ad33b0062a6f399647dba332d4da |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/25639/files/27652086f4d0ad33b0062a6f399647dba332d4da |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Please reload this page | https://github.com/nodejs/node/pull/25639 |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/refack |
|
| https://github.com/bnoordhuis |
|
| https://github.com/thefourtheye |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |