René's URL Explorer Experiment


Title: src,test: fix JSON escaping in node-report by lundibundi · Pull Request #25626 · nodejs/node · GitHub

Open Graph Title: src,test: fix JSON escaping in node-report by lundibundi · Pull Request #25626 · nodejs/node

X Title: src,test: fix JSON escaping in node-report by lundibundi · Pull Request #25626 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Previously only simple escape sequences were handled (i.e. \n, \t, r etc.). This commit adds escaping of other control symbols in the range of 0x00 to 0x20. Also, this replaces multiple find+replac...

X Description: Previously only simple escape sequences were handled (i.e. \n, \t, r etc.). This commit adds escaping of other control symbols in the range of 0x00 to 0x20. Also, this replaces multiple find+replac...

Opengraph URL: https://github.com/nodejs/node/pull/25626

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:36ce0860-7ca5-ef0b-597d-70809a313a83
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE05A:1AF714:1D1E5F4:24F1292:69919C38
html-safe-nonce9f4986d3cc27013088a5ce23d3e595e193b5350474c09b306e048b649109fea2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDVBOjFBRjcxNDoxRDFFNUY0OjI0RjEyOTI6Njk5MTlDMzgiLCJ2aXNpdG9yX2lkIjoiNjU4MzYwMDE0OTY5MTQ3Mjk1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc88027e992ef665e2bd31c26fb4a2c14519f237d8c976d8b8f65da69466fa0bf
hovercard-subject-tagpull_request:246416872
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25626/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c7d017c57b0956a1ee92f62664c09ec64fc064e388efa6b3df5766f4f0099b73/nodejs/node/pull/25626
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c7d017c57b0956a1ee92f62664c09ec64fc064e388efa6b3df5766f4f0099b73/nodejs/node/pull/25626
og:image:altPreviously only simple escape sequences were handled (i.e. \n, \t, r etc.). This commit adds escaping of other control symbols in the range of 0x00 to 0x20. Also, this replaces multiple find+replac...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelundibundi
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25626#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25626
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25626
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25626
Reloadhttps://github.com/nodejs/node/pull/25626
Reloadhttps://github.com/nodejs/node/pull/25626
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25626
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
lundibundihttps://github.com/lundibundi
nodejs:masterhttps://github.com/nodejs/node/tree/master
lundibundi:fix-json-escapinghttps://github.com/lundibundi/node/tree/fix-json-escaping
Conversationhttps://github.com/nodejs/node/pull/25626
Commits3 (3)https://github.com/nodejs/node/pull/25626/commits
Checkshttps://github.com/nodejs/node/pull/25626/checks
Files changedhttps://github.com/nodejs/node/pull/25626/files
src,test: fix JSON escaping in node-reporthttps://github.com/nodejs/node/pull/25626#top
lundibundihttps://github.com/lundibundi
nodejs:masterhttps://github.com/nodejs/node/tree/master
lundibundi:fix-json-escapinghttps://github.com/lundibundi/node/tree/fix-json-escaping
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Jan 21, 2019https://github.com/nodejs/node/pull/25626#issue-401515783
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25626
https://github.com/lundibundi
src,test: fix JSON escaping in node-reporthttps://github.com/nodejs/node/pull/25626/commits/52a14fec844683bb5d4658562be51184b0314807
52a14fehttps://github.com/nodejs/node/pull/25626/commits/52a14fec844683bb5d4658562be51184b0314807
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jan 21, 2019https://github.com/nodejs/node/pull/25626#event-2087348708
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 21, 2019https://github.com/nodejs/node/pull/25626#issuecomment-456203207
@lundibundihttps://github.com/lundibundi
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2332/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2332/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25626
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Jan 21, 2019https://github.com/nodejs/node/pull/25626#event-2087348795
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Jan 21, 2019https://github.com/nodejs/node/pull/25626#issuecomment-456203434
Please reload this pagehttps://github.com/nodejs/node/pull/25626
https://ci.nodejs.org/job/node-test-pull-request/20244/https://ci.nodejs.org/job/node-test-pull-request/20244/
Please reload this pagehttps://github.com/nodejs/node/pull/25626
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019 https://github.com/nodejs/node/pull/25626#pullrequestreview-194767526
View reviewed changes https://github.com/nodejs/node/pull/25626/files/52a14fec844683bb5d4658562be51184b0314807
src/node_report_utils.cchttps://github.com/nodejs/node/pull/25626/files/52a14fec844683bb5d4658562be51184b0314807#diff-bb0e5d4e93328197ec29fdbf3caaa7749fe51582d305309f62a236e54b73f260
Please reload this pagehttps://github.com/nodejs/node/pull/25626
src/node_report_utils.cchttps://github.com/nodejs/node/pull/25626/files/52a14fec844683bb5d4658562be51184b0314807#diff-bb0e5d4e93328197ec29fdbf3caaa7749fe51582d305309f62a236e54b73f260
Please reload this pagehttps://github.com/nodejs/node/pull/25626
test/cctest/test_report_util.cchttps://github.com/nodejs/node/pull/25626/files/52a14fec844683bb5d4658562be51184b0314807#diff-34b406c7271f33653190b9916da68ebd381f08116ae69c0bc91ad697297b1e7a
Please reload this pagehttps://github.com/nodejs/node/pull/25626
https://github.com/lundibundi
fixup! src,test: fix JSON escaping in node-reporthttps://github.com/nodejs/node/pull/25626/commits/8f775a02fed2ce443e96e029499a9dafed310efb
8f775a0https://github.com/nodejs/node/pull/25626/commits/8f775a02fed2ce443e96e029499a9dafed310efb
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Jan 21, 2019https://github.com/nodejs/node/pull/25626#issuecomment-456217761
Please reload this pagehttps://github.com/nodejs/node/pull/25626
https://ci.nodejs.org/job/node-test-pull-request/20251/https://ci.nodejs.org/job/node-test-pull-request/20251/
Please reload this pagehttps://github.com/nodejs/node/pull/25626
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 21, 2019https://github.com/nodejs/node/pull/25626#event-2087449878
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jan 22, 2019 https://github.com/nodejs/node/pull/25626#pullrequestreview-194799468
View reviewed changes https://github.com/nodejs/node/pull/25626/files/8f775a02fed2ce443e96e029499a9dafed310efb
https://github.com/lundibundi
fixup! src,test: fix JSON escaping in node-reporthttps://github.com/nodejs/node/pull/25626/commits/741526112ca9706126bec528e97746a71a772980
7415261https://github.com/nodejs/node/pull/25626/commits/741526112ca9706126bec528e97746a71a772980
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Jan 22, 2019https://github.com/nodejs/node/pull/25626#issuecomment-456363342
Please reload this pagehttps://github.com/nodejs/node/pull/25626
https://ci.nodejs.org/job/node-test-pull-request/20257/https://ci.nodejs.org/job/node-test-pull-request/20257/
Please reload this pagehttps://github.com/nodejs/node/pull/25626
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
report https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areport
Jan 22, 2019https://github.com/nodejs/node/pull/25626#event-2090248391
https://github.com/danbev
danbevhttps://github.com/danbev
Jan 25, 2019https://github.com/nodejs/node/pull/25626#issuecomment-457481493
80441c8https://github.com/nodejs/node/commit/80441c8086aa5d5d74d93b5c6b779eab734149d4
Please reload this pagehttps://github.com/nodejs/node/pull/25626
https://github.com/danbev
danbevhttps://github.com/danbev
Jan 25, 2019https://github.com/nodejs/node/pull/25626#event-2096477777
danbevhttps://github.com/danbev
Jan 25, 2019 https://github.com/nodejs/node/pull/25626#ref-commit-80441c8
https://github.com/lundibundi
https://github.com/danbev
src,test: fix JSON escaping in node-reporthttps://github.com/nodejs/node/commit/80441c8086aa5d5d74d93b5c6b779eab734149d4
80441c8https://github.com/nodejs/node/commit/80441c8086aa5d5d74d93b5c6b779eab734149d4
#25626https://github.com/nodejs/node/pull/25626
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Jan 25, 2019 https://github.com/nodejs/node/pull/25626#ref-pullrequest-400716354
src: Add new perf flags in NODE_OPTIONS #25565 https://github.com/nodejs/node/pull/25565
addaleaxhttps://github.com/addaleax
Jan 28, 2019 https://github.com/nodejs/node/pull/25626#ref-commit-4b43eea
https://github.com/lundibundi
https://github.com/addaleax
src,test: fix JSON escaping in node-reporthttps://github.com/nodejs/node/commit/4b43eeaf9a4528a21e69029d241b6760af8c9660
4b43eeahttps://github.com/nodejs/node/commit/4b43eeaf9a4528a21e69029d241b6760af8c9660
#25626https://github.com/nodejs/node/pull/25626
https://github.com/targos
targoshttps://github.com/targos
Jan 29, 2019 https://github.com/nodejs/node/pull/25626#ref-pullrequest-404502468
v11.9.0 proposal #25802 https://github.com/nodejs/node/pull/25802
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Aug 11, 2020 https://github.com/nodejs/node/pull/25626#ref-pullrequest-677227479
[Snyk] Upgrade: gatsby, gatsby-image, gatsby-plugin-catch-links, gatsby-plugin-manifest, gatsby-plugin-no-sourcemaps, gatsby-plugin-offline, gatsby-plugin-react-helmet, gatsby-plugin-sharp, gatsby-plugin-styled-components, gatsby-remark-autolink-headers, gatsby-remark-prismjs, gatsby-source-filesystem, gatsby-transformer-remark radiumrasheed/node#4 https://github.com/radiumrasheed/node/pull/4
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25626
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/25626/files/52a14fec844683bb5d4658562be51184b0314807
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/25626/files/8f775a02fed2ce443e96e029499a9dafed310efb
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
report https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areport
Please reload this pagehttps://github.com/nodejs/node/pull/25626
https://github.com/lundibundi
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/addaleax
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.