René's URL Explorer Experiment


Title: src: avoid race condition in tracing code by addaleax · Pull Request #25624 · nodejs/node · GitHub

Open Graph Title: src: avoid race condition in tracing code by addaleax · Pull Request #25624 · nodejs/node

X Title: src: avoid race condition in tracing code by addaleax · Pull Request #25624 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: json_trace_writer_ is protected by stream_mutex_, but one access to it was not guarded by a lock on said mutex. Refs: #25512 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes co...

X Description: json_trace_writer_ is protected by stream_mutex_, but one access to it was not guarded by a lock on said mutex. Refs: #25512 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes co...

Opengraph URL: https://github.com/nodejs/node/pull/25624

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ea0f5680-d145-bc21-23e8-32baf012a57c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD2E:26836F:E39E2F:125C63F:69923A61
html-safe-noncec30d5233b80679e73b33c97e59835f15f1fb7a5057f28de7b4dd1a8582e5bc08
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDJFOjI2ODM2RjpFMzlFMkY6MTI1QzYzRjo2OTkyM0E2MSIsInZpc2l0b3JfaWQiOiI1MzMyMzkxNzEwMzAwNzE5MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac84aacb345dc5719320671a34065520d91607a8cb6177c343ad58dbab78651be5
hovercard-subject-tagpull_request:246415810
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25624/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4a20f6ad3e3d18a4cc1343037c57c28b4c817ae2236a68a0163bf37a161701bc/nodejs/node/pull/25624
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4a20f6ad3e3d18a4cc1343037c57c28b4c817ae2236a68a0163bf37a161701bc/nodejs/node/pull/25624
og:image:altjson_trace_writer_ is protected by stream_mutex_, but one access to it was not guarded by a lock on said mutex. Refs: #25512 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes co...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25624#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25624
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25624
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25624
Reloadhttps://github.com/nodejs/node/pull/25624
Reloadhttps://github.com/nodejs/node/pull/25624
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25624
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 715 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:tracing-racehttps://github.com/addaleax/node/tree/tracing-race
Conversationhttps://github.com/nodejs/node/pull/25624
Commits2 (2)https://github.com/nodejs/node/pull/25624/commits
Checkshttps://github.com/nodejs/node/pull/25624/checks
Files changedhttps://github.com/nodejs/node/pull/25624/files
src: avoid race condition in tracing codehttps://github.com/nodejs/node/pull/25624#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:tracing-racehttps://github.com/addaleax/node/tree/tracing-race
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019https://github.com/nodejs/node/pull/25624#issue-401514409
#25512https://github.com/nodejs/node/issues/25512
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25624
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
trace_events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atrace_events
Jan 21, 2019https://github.com/nodejs/node/pull/25624#event-2087341149
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 21, 2019https://github.com/nodejs/node/pull/25624#issuecomment-456202124
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2331/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2331/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25624
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jan 21, 2019https://github.com/nodejs/node/pull/25624#event-2087341249
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019 https://github.com/nodejs/node/pull/25624#ref-issue-399237102
Windows CI failures: parallel/test-trace-events-fs-sync #25512 https://github.com/nodejs/node/issues/25512
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Jan 21, 2019 https://github.com/nodejs/node/pull/25624#pullrequestreview-194767061
View reviewed changes https://github.com/nodejs/node/pull/25624/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 21, 2019 https://github.com/nodejs/node/pull/25624#pullrequestreview-194780646
View reviewed changes https://github.com/nodejs/node/pull/25624/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019https://github.com/nodejs/node/pull/25624#issuecomment-456216008
https://ci.nodejs.org/job/node-stress-single-test/2142/https://ci.nodejs.org/job/node-stress-single-test/2142/
https://ci.nodejs.org/job/node-test-pull-request/20250/https://ci.nodejs.org/job/node-test-pull-request/20250/
Please reload this pagehttps://github.com/nodejs/node/pull/25624
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 21, 2019https://github.com/nodejs/node/pull/25624#event-2087437048
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jan 21, 2019 https://github.com/nodejs/node/pull/25624#pullrequestreview-194793593
View reviewed changes https://github.com/nodejs/node/pull/25624/files
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 22, 2019 https://github.com/nodejs/node/pull/25624#pullrequestreview-195021927
View reviewed changes https://github.com/nodejs/node/pull/25624/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/25624#pullrequestreview-195021927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25624
src/tracing/node_trace_writer.cchttps://github.com/nodejs/node/pull/25624/files#diff-ed2625bb1ce45c4a735fe7986921665128df9f82247cd61045948c3cbfcf2c42
bnoordhuishttps://github.com/bnoordhuis
Jan 22, 2019https://github.com/nodejs/node/pull/25624#discussion_r249792627
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25624
addaleaxhttps://github.com/addaleax
Jan 27, 2019https://github.com/nodejs/node/pull/25624#discussion_r251243755
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25624
addaleaxhttps://github.com/addaleax
January 27, 2019 17:02https://github.com/nodejs/node/pull/25624#commits-pushed-9d65ad3
https://github.com/addaleax
src: avoid race condition in tracing codehttps://github.com/nodejs/node/pull/25624/commits/9d65ad3ef4884cb888fd83fabdcc2276554742e3
9d65ad3https://github.com/nodejs/node/pull/25624/commits/9d65ad3ef4884cb888fd83fabdcc2276554742e3
nodejs#25512https://github.com/nodejs/node/issues/25512
https://github.com/addaleax
fixup! src: avoid race condition in tracing codehttps://github.com/nodejs/node/pull/25624/commits/acabd3e937df0686c5a80cbd8e3fdd3c92178644
acabd3ehttps://github.com/nodejs/node/pull/25624/commits/acabd3e937df0686c5a80cbd8e3fdd3c92178644
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 27, 2019https://github.com/nodejs/node/pull/25624#issuecomment-457931524
Please reload this pagehttps://github.com/nodejs/node/pull/25624
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/faf7361206a961deb72d81d304986deedaeea54c..acabd3e937df0686c5a80cbd8e3fdd3c92178644
faf7361https://github.com/nodejs/node/commit/faf7361206a961deb72d81d304986deedaeea54c
acabd3ehttps://github.com/nodejs/node/commit/acabd3e937df0686c5a80cbd8e3fdd3c92178644
Compare https://github.com/nodejs/node/compare/faf7361206a961deb72d81d304986deedaeea54c..acabd3e937df0686c5a80cbd8e3fdd3c92178644
January 27, 2019 16:18https://github.com/nodejs/node/pull/25624#event-2099389363
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 27, 2019https://github.com/nodejs/node/pull/25624#issuecomment-457931562
https://ci.nodejs.org/job/node-test-pull-request/20352/https://ci.nodejs.org/job/node-test-pull-request/20352/
Please reload this pagehttps://github.com/nodejs/node/pull/25624
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 27, 2019https://github.com/nodejs/node/pull/25624#issuecomment-457947758
06da364https://github.com/nodejs/node/commit/06da364be2d576e9d225ba13d803ebbc0284cfb9
Please reload this pagehttps://github.com/nodejs/node/pull/25624
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 27, 2019https://github.com/nodejs/node/pull/25624#event-2099482528
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
January 27, 2019 19:44https://github.com/nodejs/node/pull/25624#event-2099482582
addaleaxhttps://github.com/addaleax
Jan 27, 2019 https://github.com/nodejs/node/pull/25624#ref-commit-06da364
https://github.com/addaleax
src: avoid race condition in tracing codehttps://github.com/nodejs/node/commit/06da364be2d576e9d225ba13d803ebbc0284cfb9
06da364https://github.com/nodejs/node/commit/06da364be2d576e9d225ba13d803ebbc0284cfb9
#25512https://github.com/nodejs/node/issues/25512
#25624https://github.com/nodejs/node/pull/25624
addaleaxhttps://github.com/addaleax
Jan 28, 2019 https://github.com/nodejs/node/pull/25624#ref-commit-797111a
https://github.com/addaleax
src: avoid race condition in tracing codehttps://github.com/nodejs/node/commit/797111a69b3810e5036c8d50683136c739f69435
797111ahttps://github.com/nodejs/node/commit/797111a69b3810e5036c8d50683136c739f69435
#25512https://github.com/nodejs/node/issues/25512
#25624https://github.com/nodejs/node/pull/25624
https://github.com/targos
targoshttps://github.com/targos
Jan 29, 2019 https://github.com/nodejs/node/pull/25624#ref-pullrequest-404502468
v11.9.0 proposal #25802 https://github.com/nodejs/node/pull/25802
BethGriggshttps://github.com/BethGriggs
Apr 16, 2019 https://github.com/nodejs/node/pull/25624#ref-commit-5cd96b3
https://github.com/addaleax
https://github.com/BethGriggs
src: avoid race condition in tracing codehttps://github.com/nodejs/node/commit/5cd96b367b831cfdebe68200de0f4caeb2699154
5cd96b3https://github.com/nodejs/node/commit/5cd96b367b831cfdebe68200de0f4caeb2699154
#25512https://github.com/nodejs/node/issues/25512
#25624https://github.com/nodejs/node/pull/25624
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
May 1, 2019 https://github.com/nodejs/node/pull/25624#ref-pullrequest-439147711
v10.16.0 proposal #27514 https://github.com/nodejs/node/pull/27514
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#315 https://github.com/beevelop/docker-android-nodejs/issues/315
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#316 https://github.com/beevelop/docker-android-nodejs/issues/316
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#317 https://github.com/beevelop/docker-android-nodejs/issues/317
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#318 https://github.com/beevelop/docker-android-nodejs/issues/318
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#319 https://github.com/beevelop/docker-android-nodejs/issues/319
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25624
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/25624/files/faf7361206a961deb72d81d304986deedaeea54c
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/25624/files/faf7361206a961deb72d81d304986deedaeea54c
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/25624/files/faf7361206a961deb72d81d304986deedaeea54c
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/nodejs/node/pull/25624/files/faf7361206a961deb72d81d304986deedaeea54c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
trace_events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atrace_events
Please reload this pagehttps://github.com/nodejs/node/pull/25624
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/cjihrig
https://github.com/richardlau
https://github.com/lundibundi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.