| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:28918205-cf58-1e08-878a-e47ae67e75f1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8630:29EB19:E5889F:135A005:6A4D83BF |
| html-safe-nonce | cf2192b979b9c97d2b2c6d00f8e2de56bbb14cec5c5a3958a5caa562e5963ad0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjMwOjI5RUIxOTpFNTg4OUY6MTM1QTAwNTo2QTREODNCRiIsInZpc2l0b3JfaWQiOiIzODYzOTAwMzAxMjQxNTU4MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fe48ee5a3a1b672b49bfe128e925ed11de504071e5cccc678d8e765619793a14 |
| hovercard-subject-tag | pull_request:43401547 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2559/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a66ee20e96a6f78da9417ec3a0a45d8ca1cfb0c97ad2d19d2895cc6155dd1bf2/nodejs/node/pull/2559 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a66ee20e96a6f78da9417ec3a0a45d8ca1cfb0c97ad2d19d2895cc6155dd1bf2/nodejs/node/pull/2559 |
| og:image:alt | Instead of recommending 0 as the magic value to set max listeners to unlimited, recommend Infinity.
This paves the way for 0 as a magic value eventually being deprecated and finally removed
origina... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasonkarns |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6702a58b419a792226bd21ef0fb1bcb318bbcaa3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/2559#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2559 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2559 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/2559 |
| Reload | https://github.com/nodejs/node/pull/2559 |
| Reload | https://github.com/nodejs/node/pull/2559 |
| Please reload this page | https://github.com/nodejs/node/pull/2559 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/2559 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
963
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| jasonkarns | https://github.com/jasonkarns |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasonkarns:document-emitter-setmaxlisteners-infinity | https://github.com/jasonkarns/node/tree/document-emitter-setmaxlisteners-infinity |
| Conversation | https://github.com/nodejs/node/pull/2559 |
| Commits2 (2) | https://github.com/nodejs/node/pull/2559/commits |
| Checks | https://github.com/nodejs/node/pull/2559/checks |
| Files changed | https://github.com/nodejs/node/pull/2559/files |
| doc: Infinity for emitter.setMaxListeners | https://github.com/nodejs/node/pull/2559#top |
| jasonkarns | https://github.com/jasonkarns |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasonkarns:document-emitter-setmaxlisteners-infinity | https://github.com/jasonkarns/node/tree/document-emitter-setmaxlisteners-infinity |
|
| https://github.com/jasonkarns |
| jasonkarns | https://github.com/jasonkarns |
| Aug 26, 2015 | https://github.com/nodejs/node/pull/2559#issue-103270382 |
| nodejs/node-v0.x-archive#22987 | https://github.com/nodejs/node-v0.x-archive/issues/22987 |
| nodejs/node-v0.x-archive#25269 | https://github.com/nodejs/node-v0.x-archive/pull/25269 |
| Please reload this page | https://github.com/nodejs/node/pull/2559 |
|
| https://github.com/jasonkarns |
| doc: Infinity for emitter.setMaxListeners | https://github.com/nodejs/node/pull/2559/commits/353646ff61911f101402ad9e69529d3ad80ac19d |
| 353646f | https://github.com/nodejs/node/pull/2559/commits/353646ff61911f101402ad9e69529d3ad80ac19d |
| nodejs/node-v0.x-archive#22987 | https://github.com/nodejs/node-v0.x-archive/issues/22987 |
| https://github.com/jasonkarns |
| jasonkarns | https://github.com/jasonkarns |
|
Aug 26, 2015
| https://github.com/nodejs/node/pull/2559#ref-pullrequest-74456293 |
|
documentation: emitter.setMaxListeners(Infinity)
nodejs/node-v0.x-archive#25269
| https://github.com/nodejs/node-v0.x-archive/pull/25269 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Aug 26, 2015 | https://github.com/nodejs/node/pull/2559#issuecomment-135020932 |
| Please reload this page | https://github.com/nodejs/node/pull/2559 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Aug 26, 2015 | https://github.com/nodejs/node/pull/2559#event-392871976 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 26, 2015 | https://github.com/nodejs/node/pull/2559#issuecomment-135077597 |
| Please reload this page | https://github.com/nodejs/node/pull/2559 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| force-pushed | https://github.com/nodejs/node/compare/11c25c28e266dd89ce6744ed7a23f2576c1bb103..ba02bd02e91773be161e03a9ed67745fba8f22db |
| 11c25c2 | https://github.com/nodejs/node/commit/11c25c28e266dd89ce6744ed7a23f2576c1bb103 |
| ba02bd0 | https://github.com/nodejs/node/commit/ba02bd02e91773be161e03a9ed67745fba8f22db |
|
Compare
| https://github.com/nodejs/node/compare/11c25c28e266dd89ce6744ed7a23f2576c1bb103..ba02bd02e91773be161e03a9ed67745fba8f22db |
| September 6, 2015 11:55 | https://github.com/nodejs/node/pull/2559#event-402153289 |
| https://github.com/chrisdickinson |
| chrisdickinson | https://github.com/chrisdickinson |
| Sep 9, 2015 | https://github.com/nodejs/node/pull/2559#issuecomment-138803182 |
| Please reload this page | https://github.com/nodejs/node/pull/2559 |
|
| https://github.com/jasonkarns |
| document that 0 is acceptable as well, but not preferred | https://github.com/nodejs/node/pull/2559/commits/97324b8c99b750c19d011c6588316ac6a146ac6c |
| 97324b8 | https://github.com/nodejs/node/pull/2559/commits/97324b8c99b750c19d011c6588316ac6a146ac6c |
| https://github.com/jasonkarns |
| jasonkarns | https://github.com/jasonkarns |
| Sep 9, 2015 | https://github.com/nodejs/node/pull/2559#issuecomment-138909897 |
| @chrisdickinson | https://github.com/chrisdickinson |
| Please reload this page | https://github.com/nodejs/node/pull/2559 |
| https://github.com/brendanashworth |
| brendanashworth | https://github.com/brendanashworth |
| Sep 15, 2015 | https://github.com/nodejs/node/pull/2559#issuecomment-140269841 |
| Please reload this page | https://github.com/nodejs/node/pull/2559 |
| silverwind | https://github.com/silverwind |
|
Oct 9, 2015
| https://github.com/nodejs/node/pull/2559#ref-commit-775c01e |
|
| https://github.com/jasonkarns |
|
| https://github.com/silverwind |
| doc: recommend Infinity on emitter.setMaxListeners | https://github.com/nodejs/node/commit/775c01e3aa0610112b1e7348dad8873cb8245fe5 |
| 775c01e | https://github.com/nodejs/node/commit/775c01e3aa0610112b1e7348dad8873cb8245fe5 |
| #2559 | https://github.com/nodejs/node/pull/2559 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Oct 9, 2015 | https://github.com/nodejs/node/pull/2559#issuecomment-146932412 |
| 775c01e | https://github.com/nodejs/node/commit/775c01e3aa0610112b1e7348dad8873cb8245fe5 |
| Please reload this page | https://github.com/nodejs/node/pull/2559 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Oct 9, 2015 | https://github.com/nodejs/node/pull/2559#event-431627404 |
| https://github.com/jasonkarns |
| jasonkarns | https://github.com/jasonkarns |
| October 9, 2015 17:45 | https://github.com/nodejs/node/pull/2559#event-431667596 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Oct 10, 2015 | https://github.com/nodejs/node/pull/2559#event-432158921 |
| jasnell | https://github.com/jasnell |
|
Oct 10, 2015
| https://github.com/nodejs/node/pull/2559#ref-commit-0cfc6d3 |
|
| https://github.com/jasonkarns |
|
| https://github.com/jasnell |
| doc: recommend Infinity on emitter.setMaxListeners | https://github.com/nodejs/node/commit/0cfc6d39caf94e10530bc55130f6fdf271055698 |
| 0cfc6d3 | https://github.com/nodejs/node/commit/0cfc6d39caf94e10530bc55130f6fdf271055698 |
| #2559 | https://github.com/nodejs/node/pull/2559 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 10, 2015 | https://github.com/nodejs/node/pull/2559#issuecomment-147111728 |
| 0cfc6d3 | https://github.com/nodejs/node/commit/0cfc6d39caf94e10530bc55130f6fdf271055698 |
| Please reload this page | https://github.com/nodejs/node/pull/2559 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
lts-landed-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-landed-on-v4.x |
| Oct 10, 2015 | https://github.com/nodejs/node/pull/2559#event-432159689 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 10, 2015
| https://github.com/nodejs/node/pull/2559#ref-pullrequest-110375513 |
|
Release proposal: v4.2.0 'Argon' (LTS)
#3258
| https://github.com/nodejs/node/pull/3258 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Nov 16, 2015 | https://github.com/nodejs/node/pull/2559#event-465802006 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2559 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Please reload this page | https://github.com/nodejs/node/pull/2559 |
|
| https://github.com/jasonkarns |
|
| https://github.com/cjihrig |
|
| https://github.com/targos |
|
| https://github.com/chrisdickinson |
|
| https://github.com/brendanashworth |
|
| https://github.com/silverwind |
|
| https://github.com/jasnell |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |