René's URL Explorer Experiment


Title: src: restrict unloading addons to Worker threads by addaleax · Pull Request #25577 · nodejs/node · GitHub

Open Graph Title: src: restrict unloading addons to Worker threads by addaleax · Pull Request #25577 · nodejs/node

X Title: src: restrict unloading addons to Worker threads by addaleax · Pull Request #25577 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Unloading native addons from the main thread was an (presumably unintended) significant breaking change, because addons may rely on their memory being available after an Environment exits. This pat...

X Description: Unloading native addons from the main thread was an (presumably unintended) significant breaking change, because addons may rely on their memory being available after an Environment exits. This pat...

Opengraph URL: https://github.com/nodejs/node/pull/25577

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:746d70df-0f21-e44d-e613-46dc86a8bbff
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8DE:18BA88:729A168:A101A6D:6A50095F
html-safe-noncef1db045bb2073edc049c767a1da7bd389b06c54546b4460b4673602dc5e4a5ef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOERFOjE4QkE4ODo3MjlBMTY4OkExMDFBNkQ6NkE1MDA5NUYiLCJ2aXNpdG9yX2lkIjoiMjU3MDczNzkxNTAwMTgzMzgyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac178d39979416f6d0eba9686c2a89239320315417a07b4e2dd1085744d65a5a53
hovercard-subject-tagpull_request:246004184
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25577/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f437672dc7696eebde2b5e19bad38e3d78daf3747fcca5641eee704d13a76189/nodejs/node/pull/25577
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f437672dc7696eebde2b5e19bad38e3d78daf3747fcca5641eee704d13a76189/nodejs/node/pull/25577
og:image:altUnloading native addons from the main thread was an (presumably unintended) significant breaking change, because addons may rely on their memory being available after an Environment exits. This pat...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None56eec25a3430492dd6ec2a480eb33256a0da5192d5714b0db4f5ab5f33203d94
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release93a615b89b7dcbdb6b678f4772931ecc28ada82a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25577#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25577
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25577
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25577
Reloadhttps://github.com/nodejs/node/pull/25577
Reloadhttps://github.com/nodejs/node/pull/25577
Please reload this pagehttps://github.com/nodejs/node/pull/25577
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25577
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 977 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:addon-unload-main-threadhttps://github.com/addaleax/node/tree/addon-unload-main-thread
Conversationhttps://github.com/nodejs/node/pull/25577
Commits2 (2)https://github.com/nodejs/node/pull/25577/commits
Checkshttps://github.com/nodejs/node/pull/25577/checks
Files changedhttps://github.com/nodejs/node/pull/25577/files
src: restrict unloading addons to Worker threadshttps://github.com/nodejs/node/pull/25577#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:addon-unload-main-threadhttps://github.com/addaleax/node/tree/addon-unload-main-thread
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 18, 2019https://github.com/nodejs/node/pull/25577#issue-400930376
#23319https://github.com/nodejs/node/pull/23319
#24861https://github.com/nodejs/node/pull/24861
#23319https://github.com/nodejs/node/pull/23319
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25577
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
gabrielschulhofhttps://github.com/gabrielschulhof
January 18, 2019 23:46https://github.com/nodejs/node/pull/25577#event-2084188164
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 18, 2019https://github.com/nodejs/node/pull/25577#issuecomment-455723292
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2296/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2296/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25577
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jan 18, 2019https://github.com/nodejs/node/pull/25577#event-2084188226
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
Jan 18, 2019https://github.com/nodejs/node/pull/25577#event-2084188559
v11.7.0 proposal #25537 https://github.com/nodejs/node/pull/25537
src: unload native addons when the environment is destroyed #24861 https://github.com/nodejs/node/pull/24861
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 18, 2019https://github.com/nodejs/node/pull/25577#issuecomment-455723922
Please reload this pagehttps://github.com/nodejs/node/pull/25577
https://ci.nodejs.org/job/node-test-pull-request/20205/https://ci.nodejs.org/job/node-test-pull-request/20205/
@MylesBorinshttps://github.com/MylesBorins
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/25577
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Jan 18, 2019https://github.com/nodejs/node/pull/25577#event-2084192478
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 19, 2019 https://github.com/nodejs/node/pull/25577#pullrequestreview-194370351
View reviewed changes https://github.com/nodejs/node/pull/25577/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Jan 21, 2019https://github.com/nodejs/node/pull/25577#event-2086466819
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019https://github.com/nodejs/node/pull/25577#issuecomment-456112067
Please reload this pagehttps://github.com/nodejs/node/pull/25577
https://github.com/refack
refackhttps://github.com/refack
Jan 21, 2019 https://github.com/nodejs/node/pull/25577#pullrequestreview-194708940
View reviewed changes https://github.com/nodejs/node/pull/25577/files
https://github.com/refack
refackhttps://github.com/refack
stale reviewhttps://github.com/nodejs/node/pull/25577#pullrequestreview-194708940
January 21, 2019 17:46https://github.com/nodejs/node/pull/25577#event-2087006899
https://github.com/danbev
danbevhttps://github.com/danbev
Jan 22, 2019 https://github.com/nodejs/node/pull/25577#pullrequestreview-194831633
View reviewed changes https://github.com/nodejs/node/pull/25577/files
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 22, 2019 https://github.com/nodejs/node/pull/25577#pullrequestreview-195033840
View reviewed changes https://github.com/nodejs/node/pull/25577/files
src/env.cchttps://github.com/nodejs/node/pull/25577/files#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58
Please reload this pagehttps://github.com/nodejs/node/pull/25577
test/addons/worker-addon/binding.cchttps://github.com/nodejs/node/pull/25577/files#diff-036225db1df1c53166c18fb21fffb10e1d4d3e6dcf59d659c7822c594a1136e8
Please reload this pagehttps://github.com/nodejs/node/pull/25577
addaleaxhttps://github.com/addaleax
January 22, 2019 23:13https://github.com/nodejs/node/pull/25577#commits-pushed-0934abd
https://github.com/addaleax
src: restrict unloading addons to Worker threadshttps://github.com/nodejs/node/pull/25577/commits/0934abdb28ccdeac13ac00ce0ea33941340bbb2c
0934abdhttps://github.com/nodejs/node/pull/25577/commits/0934abdb28ccdeac13ac00ce0ea33941340bbb2c
nodejs#23319https://github.com/nodejs/node/pull/23319
nodejs#24861https://github.com/nodejs/node/pull/24861
nodejs#23319https://github.com/nodejs/node/pull/23319
https://github.com/addaleax
fixup! src: restrict unloading addons to Worker threadshttps://github.com/nodejs/node/pull/25577/commits/d7d409ad6eae7a5f332b7fd4ad2bd0d1912c7b1b
d7d409ahttps://github.com/nodejs/node/pull/25577/commits/d7d409ad6eae7a5f332b7fd4ad2bd0d1912c7b1b
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/a6186f8b032f268de12de3845db993e848043102..d7d409ad6eae7a5f332b7fd4ad2bd0d1912c7b1b
a6186f8https://github.com/nodejs/node/commit/a6186f8b032f268de12de3845db993e848043102
d7d409ahttps://github.com/nodejs/node/commit/d7d409ad6eae7a5f332b7fd4ad2bd0d1912c7b1b
Compare https://github.com/nodejs/node/compare/a6186f8b032f268de12de3845db993e848043102..d7d409ad6eae7a5f332b7fd4ad2bd0d1912c7b1b
January 22, 2019 22:16https://github.com/nodejs/node/pull/25577#event-2090118595
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 22, 2019https://github.com/nodejs/node/pull/25577#issuecomment-456584688
@bnoordhuishttps://github.com/bnoordhuis
https://ci.nodejs.org/job/node-test-pull-request/20268/https://ci.nodejs.org/job/node-test-pull-request/20268/
Please reload this pagehttps://github.com/nodejs/node/pull/25577
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 22, 2019https://github.com/nodejs/node/pull/25577#event-2090120395
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 23, 2019https://github.com/nodejs/node/pull/25577#issuecomment-456614598
Please reload this pagehttps://github.com/nodejs/node/pull/25577
https://ci.nodejs.org/job/node-test-commit-windows-fanned/24153/https://ci.nodejs.org/job/node-test-commit-windows-fanned/24153/
Please reload this pagehttps://github.com/nodejs/node/pull/25577
https://github.com/danbev
danbevhttps://github.com/danbev
Jan 23, 2019https://github.com/nodejs/node/pull/25577#issuecomment-456668307
ef1c639https://github.com/nodejs/node/commit/ef1c639db562f103a66fb5c09e098540347c599f
Please reload this pagehttps://github.com/nodejs/node/pull/25577
https://github.com/danbev
danbevhttps://github.com/danbev
Jan 23, 2019https://github.com/nodejs/node/pull/25577#event-2090640428
danbevhttps://github.com/danbev
Jan 23, 2019 https://github.com/nodejs/node/pull/25577#ref-commit-ef1c639
https://github.com/addaleax
https://github.com/danbev
src: restrict unloading addons to Worker threadshttps://github.com/nodejs/node/commit/ef1c639db562f103a66fb5c09e098540347c599f
ef1c639https://github.com/nodejs/node/commit/ef1c639db562f103a66fb5c09e098540347c599f
#23319https://github.com/nodejs/node/pull/23319
#25577https://github.com/nodejs/node/pull/25577
#24861https://github.com/nodejs/node/pull/24861
#23319https://github.com/nodejs/node/pull/23319
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
January 23, 2019 16:05https://github.com/nodejs/node/pull/25577#event-2092091850
addaleaxhttps://github.com/addaleax
Jan 23, 2019 https://github.com/nodejs/node/pull/25577#ref-commit-55768c0
https://github.com/addaleax
src: restrict unloading addons to Worker threadshttps://github.com/nodejs/node/commit/55768c0079d8381b464b99507b6c7f123729a6e6
55768c0https://github.com/nodejs/node/commit/55768c0079d8381b464b99507b6c7f123729a6e6
#23319https://github.com/nodejs/node/pull/23319
#25577https://github.com/nodejs/node/pull/25577
#24861https://github.com/nodejs/node/pull/24861
#23319https://github.com/nodejs/node/pull/23319
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 24, 2019 https://github.com/nodejs/node/pull/25577#ref-pullrequest-402909465
v11.8.0 proposal #25687 https://github.com/nodejs/node/pull/25687
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 21, 2019 https://github.com/nodejs/node/pull/25577#ref-pullrequest-411247567
worker: improve integration with native addons (take II) #26175 https://github.com/nodejs/node/pull/26175
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25577
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/25577/files/a6186f8b032f268de12de3845db993e848043102
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/25577/files/a6186f8b032f268de12de3845db993e848043102
https://github.com/gabrielschulhof
gabrielschulhof https://github.com/gabrielschulhof
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/25577/files/a6186f8b032f268de12de3845db993e848043102
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/25577/files/a6186f8b032f268de12de3845db993e848043102
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/25577
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/refack
https://github.com/bnoordhuis
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.