René's URL Explorer Experiment


Title: WIP still fixing up [v10.x backport] n-api: handle reference delete before finalize by mhdawson · Pull Request #25572 · nodejs/node · GitHub

Open Graph Title: WIP still fixing up [v10.x backport] n-api: handle reference delete before finalize by mhdawson · Pull Request #25572 · nodejs/node

X Title: WIP still fixing up [v10.x backport] n-api: handle reference delete before finalize by mhdawson · Pull Request #25572 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Original PR: #24494

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Original PR: #24494

Opengraph URL: https://github.com/nodejs/node/pull/25572

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5891dee5-b464-0a71-1397-7e89c249cd80
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA3A0:108F59:7CD876:AC3038:6A4F3E90
html-safe-nonce97305ef931c87a5adda1ac1fb74e8bbf365eb08e7c6a58354e51976e012ed7ee
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0EwOjEwOEY1OTo3Q0Q4NzY6QUMzMDM4OjZBNEYzRTkwIiwidmlzaXRvcl9pZCI6IjY5Nzk5MDU1MTY5NDE2MzYwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb55dd4058bf69ca38ac10ab043bf60ce2b6d92afad88500024340220da8d4abc
hovercard-subject-tagpull_request:245963981
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25572/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/59e2fa0bee138ae0af29a898334d6a8fd972528263b5702ca4d36a01c4658ef3/nodejs/node/pull/25572
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/59e2fa0bee138ae0af29a898334d6a8fd972528263b5702ca4d36a01c4658ef3/nodejs/node/pull/25572
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines Original PR: #24494
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhdawson
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25572#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25572
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25572
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25572
Reloadhttps://github.com/nodejs/node/pull/25572
Reloadhttps://github.com/nodejs/node/pull/25572
Please reload this pagehttps://github.com/nodejs/node/pull/25572
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25572
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 971 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mhdawsonhttps://github.com/mhdawson
nodejs:v8.xhttps://github.com/nodejs/node/tree/v8.x
mhdawson:backport-24494-to-v8.xhttps://github.com/mhdawson/io.js/tree/backport-24494-to-v8.x
Conversationhttps://github.com/nodejs/node/pull/25572
Commits13 (13)https://github.com/nodejs/node/pull/25572/commits
Checkshttps://github.com/nodejs/node/pull/25572/checks
Files changedhttps://github.com/nodejs/node/pull/25572/files
WIP still fixing up [v10.x backport] n-api: handle reference delete before finalizehttps://github.com/nodejs/node/pull/25572#top
mhdawsonhttps://github.com/mhdawson
nodejs:v8.xhttps://github.com/nodejs/node/tree/v8.x
mhdawson:backport-24494-to-v8.xhttps://github.com/mhdawson/io.js/tree/backport-24494-to-v8.x
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 18, 2019https://github.com/nodejs/node/pull/25572#issue-400878284
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
#24494https://github.com/nodejs/node/pull/24494
Please reload this pagehttps://github.com/nodejs/node/pull/25572
psmarshallhttps://github.com/psmarshall
December 26, 2018 11:19https://github.com/nodejs/node/pull/25572#commits-pushed-8810051
https://github.com/psmarshall
https://github.com/MylesBorins
deps: cherry-pickhttps://github.com/nodejs/node/pull/25572/commits/881005110f13c711da03e2a7c4d60a400608842d
525b396https://github.com/mhdawson/io.js/commit/525b396427d82f52b8b19483e8a4e9f8548c02b7
from V8 upstreamhttps://github.com/nodejs/node/pull/25572/commits/881005110f13c711da03e2a7c4d60a400608842d
8810051https://github.com/nodejs/node/pull/25572/commits/881005110f13c711da03e2a7c4d60a400608842d
https://chromium-review.googlesource.com/1256763https://chromium-review.googlesource.com/1256763
nodejs#56336https://github.com/nodejs/node/pull/56336
v8/v8@525b396https://github.com/v8/v8/commit/525b39619548b4e7fbf48934acb18d3f209321db
nodejs#25041https://github.com/nodejs/node/pull/25041
https://github.com/jbunton-atlassian
https://github.com/MylesBorins
doc: update the http.request.setTimeout docs to be accuratehttps://github.com/nodejs/node/pull/25572/commits/3af7528ac399e77eca40b2d00a39afb8dc935b95
3af7528https://github.com/nodejs/node/pull/25572/commits/3af7528ac399e77eca40b2d00a39afb8dc935b95
nodejs#8895https://github.com/nodejs/node/pull/8895
nodejs#25123https://github.com/nodejs/node/pull/25123
https://github.com/addaleax
test: fix test-repl-envvarshttps://github.com/nodejs/node/pull/25572/commits/48da8bea1f8722236134d73c994424dcfcf04a75
48da8behttps://github.com/nodejs/node/pull/25572/commits/48da8bea1f8722236134d73c994424dcfcf04a75
180f865https://github.com/mhdawson/io.js/commit/180f86507d496b11aa35b2df4594629a92cce329
nodejs#21451https://github.com/nodejs/node/issues/21451
nodejs/build#1377https://github.com/nodejs/build/issues/1377
nodejs#25219https://github.com/nodejs/node/pull/25219
nodejs#25226https://github.com/nodejs/node/pull/25226
https://github.com/MylesBorins
n-api: add API for asynchronous functionshttps://github.com/nodejs/node/pull/25572/commits/64f232cc7867af7f66bd4c1f8e09fdf383ab7218
64f232chttps://github.com/nodejs/node/pull/25572/commits/64f232cc7867af7f66bd4c1f8e09fdf383ab7218
nodejs/help#1035https://github.com/nodejs/help/issues/1035
nodejs#20964https://github.com/nodejs/node/issues/20964
nodejs#13512https://github.com/nodejs/node/issues/13512
nodejs#25002https://github.com/nodejs/node/pull/25002
nodejs#17887https://github.com/nodejs/node/pull/17887
https://github.com/cjihrig
https://github.com/MylesBorins
n-api: fix compiler warninghttps://github.com/nodejs/node/pull/25572/commits/ca8ba15fe8ede81ed74fd882af4a3cda28e51354
ca8ba15https://github.com/nodejs/node/pull/25572/commits/ca8ba15fe8ede81ed74fd882af4a3cda28e51354
nodejs#21597https://github.com/nodejs/node/pull/21597
nodejs#17887https://github.com/nodejs/node/pull/17887
nodejs#25002https://github.com/nodejs/node/pull/25002
https://github.com/MylesBorins
n-api: guard against cond null dereferencehttps://github.com/nodejs/node/pull/25572/commits/7b68d89552788e9bb2197fa956d87e8d91dc1169
7b68d89https://github.com/nodejs/node/pull/25572/commits/7b68d89552788e9bb2197fa956d87e8d91dc1169
nodejs/help#1387https://github.com/nodejs/help/issues/1387
nodejs#21871https://github.com/nodejs/node/pull/21871
nodejs#25002https://github.com/nodejs/node/pull/25002
https://github.com/mhdawson
https://github.com/MylesBorins
src: fix may be uninitialized warning in n-apihttps://github.com/nodejs/node/pull/25572/commits/c275534d9359b09e11d0fb396d0857af18830c15
c275534https://github.com/nodejs/node/pull/25572/commits/c275534d9359b09e11d0fb396d0857af18830c15
nodejs#25002https://github.com/nodejs/node/pull/25002
nodejs#21898https://github.com/nodejs/node/pull/21898
https://github.com/MylesBorins
n-api: remove idle_running from TsFnhttps://github.com/nodejs/node/pull/25572/commits/311e1f1553a101b7541fa65babf8a8d7a0b51393
311e1f1https://github.com/nodejs/node/pull/25572/commits/311e1f1553a101b7541fa65babf8a8d7a0b51393
nodejs#25002https://github.com/nodejs/node/pull/25002
nodejs#22520https://github.com/nodejs/node/pull/22520
https://github.com/MylesBorins
n-api: clean up thread-safe functionhttps://github.com/nodejs/node/pull/25572/commits/a0fa1018c752105858c8ea90dc830b60c7115202
a0fa101https://github.com/nodejs/node/pull/25572/commits/a0fa1018c752105858c8ea90dc830b60c7115202
nodejs#25002https://github.com/nodejs/node/pull/25002
nodejs#22259https://github.com/nodejs/node/pull/22259
https://github.com/MylesBorins
doc: fix optional parameters in n-api.mdhttps://github.com/nodejs/node/pull/25572/commits/ffbfe34899270daae7250cff9f9b2e727f873226
ffbfe34https://github.com/nodejs/node/pull/25572/commits/ffbfe34899270daae7250cff9f9b2e727f873226
nodejs#25002https://github.com/nodejs/node/pull/25002
nodejs#22998https://github.com/nodejs/node/pull/22998
https://github.com/danbev
https://github.com/MylesBorins
n-api: add missing handle scopeshttps://github.com/nodejs/node/pull/25572/commits/cffe85cd77cd2cb6d7a4735f474eda0897524b6d
cffe85chttps://github.com/nodejs/node/pull/25572/commits/cffe85cd77cd2cb6d7a4735f474eda0897524b6d
https://github.com/v8/v8/blob/2ef0aa662fe907a1b36ac1abe7d77ad2bcd27733https://github.com/v8/v8/blob/2ef0aa662fe907a1b36ac1abe7d77ad2bcd27733
nodejs#25002https://github.com/nodejs/node/pull/25002
nodejs#24011https://github.com/nodejs/node/pull/24011
https://github.com/gireeshpunathil
https://github.com/MylesBorins
test: mark test_threadsafe_function/test as flakyhttps://github.com/nodejs/node/pull/25572/commits/b44bd887875475dada837c3ab4ae7b1762df22af
b44bd88https://github.com/nodejs/node/pull/25572/commits/b44bd887875475dada837c3ab4ae7b1762df22af
nodejs#23621https://github.com/nodejs/node/issues/23621
nodejs#25002https://github.com/nodejs/node/pull/25002
nodejs#24714https://github.com/nodejs/node/pull/24714
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 18, 2019https://github.com/nodejs/node/pull/25572#issuecomment-455678117
@mhdawsonhttps://github.com/mhdawson
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2291/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2291/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25572
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Jan 18, 2019https://github.com/nodejs/node/pull/25572#event-2083871539
https://github.com/mhdawson
n-api: handle reference delete before finalizehttps://github.com/nodejs/node/pull/25572/commits/4f1aeb3355f608f3ce34136020b35d17303bbd61
4f1aeb3https://github.com/nodejs/node/pull/25572/commits/4f1aeb3355f608f3ce34136020b35d17303bbd61
nodejs/node-addon-api#393https://github.com/nodejs/node-addon-api/issues/393
nodejs#25572https://github.com/nodejs/node/pull/25572
nodejs#24494https://github.com/nodejs/node/pull/24494
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
January 18, 2019 20:36https://github.com/nodejs/node/pull/25572#event-2083881807
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 18, 2019https://github.com/nodejs/node/pull/25572#event-2083882681
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
January 18, 2019 20:38https://github.com/nodejs/node/pull/25572#event-2083885661
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 18, 2019https://github.com/nodejs/node/pull/25572#event-2083890723
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 18, 2019https://github.com/nodejs/node/pull/25572#event-2083892153
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 18, 2019https://github.com/nodejs/node/pull/25572#event-2083895632
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
January 18, 2019 20:44https://github.com/nodejs/node/pull/25572#event-2083896344
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
January 18, 2019 20:44https://github.com/nodejs/node/pull/25572#event-2083896972
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 18, 2019https://github.com/nodejs/node/pull/25572#issuecomment-455681949
Please reload this pagehttps://github.com/nodejs/node/pull/25572
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 18, 2019https://github.com/nodejs/node/pull/25572#event-2083897942
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 18, 2019 https://github.com/nodejs/node/pull/25572#ref-pullrequest-400890957
[v10.x backport] n-api: handle reference delete before finalize #25574 https://github.com/nodejs/node/pull/25574
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
September 30, 2019 13:13https://github.com/nodejs/node/pull/25572#event-2673210672
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25572
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/25572
https://github.com/mhdawson
https://github.com/nodejs-github-bot
https://github.com/psmarshall
https://github.com/jbunton-atlassian
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/danbev
https://github.com/gireeshpunathil
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.