René's URL Explorer Experiment


Title: test: revert fail `coverage` target if tests fail" by mhdawson · Pull Request #25543 · nodejs/node · GitHub

Open Graph Title: test: revert fail `coverage` target if tests fail" by mhdawson · Pull Request #25543 · nodejs/node

X Title: test: revert fail `coverage` target if tests fail" by mhdawson · Pull Request #25543 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit f216d5b. Seems like it breaks the nightly job so reverting until we figure that out. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows...

X Description: This reverts commit f216d5b. Seems like it breaks the nightly job so reverting until we figure that out. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows...

Opengraph URL: https://github.com/nodejs/node/pull/25543

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:60fd5fd2-4434-4da1-303a-a52284eb0344
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F0C:FDB96:5D5D0E:7C8300:6A518E93
html-safe-noncea210b02b59ec43a99595a485a52e9e9ac791ee597c4ff8c81874ceb9e85ce8ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjBDOkZEQjk2OjVENUQwRTo3QzgzMDA6NkE1MThFOTMiLCJ2aXNpdG9yX2lkIjoiODU5OTY4NDAxOTIyMTc5NDQ1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb5bbf361c50c15772d4903d7b461462f8d82963e982f22fb07ce6ba9584f57bd
hovercard-subject-tagpull_request:245302930
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25543/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/399f89cb094908a9f2fd76edb44e5b48c07e5709d84d31d565d6dcf9bb8f355d/nodejs/node/pull/25543
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/399f89cb094908a9f2fd76edb44e5b48c07e5709d84d31d565d6dcf9bb8f355d/nodejs/node/pull/25543
og:image:altThis reverts commit f216d5b. Seems like it breaks the nightly job so reverting until we figure that out. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhdawson
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25543#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25543
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25543
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25543
Reloadhttps://github.com/nodejs/node/pull/25543
Reloadhttps://github.com/nodejs/node/pull/25543
Please reload this pagehttps://github.com/nodejs/node/pull/25543
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25543
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 981 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mhdawsonhttps://github.com/mhdawson
nodejs:masterhttps://github.com/nodejs/node/tree/master
mhdawson:revertcovhttps://github.com/mhdawson/io.js/tree/revertcov
Conversationhttps://github.com/nodejs/node/pull/25543
Commits1 (1)https://github.com/nodejs/node/pull/25543/commits
Checkshttps://github.com/nodejs/node/pull/25543/checks
Files changedhttps://github.com/nodejs/node/pull/25543/files
test: revert fail coverage target if tests fail"https://github.com/nodejs/node/pull/25543#top
mhdawsonhttps://github.com/mhdawson
nodejs:masterhttps://github.com/nodejs/node/tree/master
mhdawson:revertcovhttps://github.com/mhdawson/io.js/tree/revertcov
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 16, 2019https://github.com/nodejs/node/pull/25543#issue-400012007
Please reload this pagehttps://github.com/nodejs/node/pull/25543
f216d5bhttps://github.com/nodejs/node/commit/f216d5bbb1595f2fbed29517ba87b80e8c02f3c0
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
test: revert fail coverage target if tests fail"https://github.com/nodejs/node/pull/25543/commits/adbad47c842b35ab6d91b0a94b35036946130737
adbad47https://github.com/nodejs/node/pull/25543/commits/adbad47c842b35ab6d91b0a94b35036946130737
f216d5bhttps://github.com/mhdawson/io.js/commit/f216d5bbb1595f2fbed29517ba87b80e8c02f3c0
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 16, 2019https://github.com/nodejs/node/pull/25543#issuecomment-454955266
@mhdawsonhttps://github.com/mhdawson
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2271/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2271/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Jan 16, 2019https://github.com/nodejs/node/pull/25543#event-2078645270
https://github.com/mscdex
mscdexhttps://github.com/mscdex
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jan 16, 2019https://github.com/nodejs/node/pull/25543#event-2078647774
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 16, 2019https://github.com/nodejs/node/pull/25543#issuecomment-454969178
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 16, 2019https://github.com/nodejs/node/pull/25543#event-2078736929
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 16, 2019https://github.com/nodejs/node/pull/25543#issuecomment-454969587
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 16, 2019 https://github.com/nodejs/node/pull/25543#ref-issue-399905308
Nightly coverage report outdated nodejs/nodejs.org#1988 https://github.com/nodejs/nodejs.org/issues/1988
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jan 17, 2019https://github.com/nodejs/node/pull/25543#event-2080400164
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455192252
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Jan 17, 2019https://github.com/nodejs/node/pull/25543#event-2080403014
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 17, 2019 https://github.com/nodejs/node/pull/25543#pullrequestreview-193654096
View reviewed changes https://github.com/nodejs/node/pull/25543/files/adbad47c842b35ab6d91b0a94b35036946130737
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455192782
https://ci.nodejs.org/job/node-test-pull-request/20181/https://ci.nodejs.org/job/node-test-pull-request/20181/
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 17, 2019 https://github.com/nodejs/node/pull/25543#pullrequestreview-193686503
View reviewed changes https://github.com/nodejs/node/pull/25543/files/adbad47c842b35ab6d91b0a94b35036946130737
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455228807
https://ci.nodejs.org/job/node-test-commit-linux-coverage-daily/2/https://ci.nodejs.org/job/node-test-commit-linux-coverage-daily/2/
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455237344
https://ci.nodejs.org/view/Node.js%20Daily/job/node-test-commit-linux-coverage/3/https://ci.nodejs.org/view/Node.js%20Daily/job/node-test-commit-linux-coverage/3/
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455238307
Please reload this pagehttps://github.com/nodejs/node/pull/25543
#25512https://github.com/nodejs/node/issues/25512
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455238630
https://ci.nodejs.org/job/node-test-pull-request/20186/https://ci.nodejs.org/job/node-test-pull-request/20186/
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Jan 17, 2019https://github.com/nodejs/node/pull/25543#event-2080759821
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455239822
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455240285
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455243328
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455244072
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://ci.nodejs.org/job/node-test-commit-linux-coverage-daily/2/https://ci.nodejs.org/job/node-test-commit-linux-coverage-daily/2/
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455261909
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455266341
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455268539
1375af2https://github.com/nodejs/node/commit/1375af204a30d1885b9e8bf79725cbd223707439
Please reload this pagehttps://github.com/nodejs/node/pull/25543
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019 https://github.com/nodejs/node/pull/25543#ref-commit-1375af2
https://github.com/mhdawson
test: revert fail coverage target if tests fail"https://github.com/nodejs/node/commit/1375af204a30d1885b9e8bf79725cbd223707439
1375af2https://github.com/nodejs/node/commit/1375af204a30d1885b9e8bf79725cbd223707439
f216d5bhttps://github.com/nodejs/node/commit/f216d5bbb1595f2fbed29517ba87b80e8c02f3c0
#25543https://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 17, 2019https://github.com/nodejs/node/pull/25543#event-2081025064
https://github.com/refack
refackhttps://github.com/refack
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455277135
Please reload this pagehttps://github.com/nodejs/node/pull/25543
#25432https://github.com/nodejs/node/pull/25432
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/refack
refackhttps://github.com/refack
Jan 17, 2019https://github.com/nodejs/node/pull/25543#issuecomment-455280744
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/refack
refackhttps://github.com/refack
Jan 17, 2019 https://github.com/nodejs/node/pull/25543#ref-pullrequest-393277747
test: switch to native v8 coverage #25157 https://github.com/nodejs/node/pull/25157
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#302 https://github.com/beevelop/docker-android-nodejs/issues/302
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#275 https://github.com/beevelop/docker-nodejs/issues/275
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#276 https://github.com/beevelop/docker-nodejs/issues/276
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#303 https://github.com/beevelop/docker-android-nodejs/issues/303
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#277 https://github.com/beevelop/docker-nodejs/issues/277
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#304 https://github.com/beevelop/docker-android-nodejs/issues/304
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#278 https://github.com/beevelop/docker-nodejs/issues/278
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#305 https://github.com/beevelop/docker-android-nodejs/issues/305
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#279 https://github.com/beevelop/docker-nodejs/issues/279
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#306 https://github.com/beevelop/docker-android-nodejs/issues/306
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
September 30, 2019 13:13https://github.com/nodejs/node/pull/25543#event-2673210643
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25543
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/25543/files/adbad47c842b35ab6d91b0a94b35036946130737
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/25543/files/adbad47c842b35ab6d91b0a94b35036946130737
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Please reload this pagehttps://github.com/nodejs/node/pull/25543
https://github.com/mhdawson
https://github.com/nodejs-github-bot
https://github.com/BridgeAR
https://github.com/refack
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/mscdex
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.