| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:57d7a6e3-c127-a0a7-a693-b4b2a43cdd08 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BFDC:136ED2:1B4A5C0:2302ABE:6990F15B |
| html-safe-nonce | 659d1ba51020e440c8be0b085538fbcd4d264d9a96e3b9d74a60bc13a76ee3c5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkRDOjEzNkVEMjoxQjRBNUMwOjIzMDJBQkU6Njk5MEYxNUIiLCJ2aXNpdG9yX2lkIjoiNjQxMDYyOTg2ODA4MjQ5MTczOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 591b0aab467a804aceb244d6d7ded433b35bfacd8c41dcfcb9c9619348ffcf7d |
| hovercard-subject-tag | pull_request:244886462 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25521/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c213b9e878369938b26645c658e797e5e7e1c50e88923d5ed880f96591985bd0/nodejs/node/pull/25521 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c213b9e878369938b26645c658e797e5e7e1c50e88923d5ed880f96591985bd0/nodejs/node/pull/25521 |
| og:image:alt | #17604 refactored the gyp files
so that -blibpath: on AIX was only set if node_shared=="true".
Restore the setting for non-shared builds.
Fixes: #25444
PR-URL: #25447
Reviewed-By: Gireesh... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | richardlau |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25521#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25521 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25521 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25521 |
| Reload | https://github.com/nodejs/node/pull/25521 |
| Reload | https://github.com/nodejs/node/pull/25521 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25521 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
705
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| richardlau | https://github.com/richardlau |
| nodejs:v8.x-staging | https://github.com/nodejs/node/tree/v8.x-staging |
| richardlau:restore-aix-blibpath-8 | https://github.com/richardlau/node-1/tree/restore-aix-blibpath-8 |
| Conversation | https://github.com/nodejs/node/pull/25521 |
| Commits1 (1) | https://github.com/nodejs/node/pull/25521/commits |
| Checks | https://github.com/nodejs/node/pull/25521/checks |
| Files changed | https://github.com/nodejs/node/pull/25521/files |
| [v8.x backport] build: set -blibpath: for AIX | https://github.com/nodejs/node/pull/25521#top |
| richardlau | https://github.com/richardlau |
| nodejs:v8.x-staging | https://github.com/nodejs/node/tree/v8.x-staging |
| richardlau:restore-aix-blibpath-8 | https://github.com/richardlau/node-1/tree/restore-aix-blibpath-8 |
|
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jan 15, 2019 | https://github.com/nodejs/node/pull/25521#issue-399465864 |
| #17604 | https://github.com/nodejs/node/pull/17604 |
| #25444 | https://github.com/nodejs/node/issues/25444 |
| #25447 | https://github.com/nodejs/node/pull/25447 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25521 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x |
| Jan 15, 2019 | https://github.com/nodejs/node/pull/25521#event-2075334683 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 15, 2019 | https://github.com/nodejs/node/pull/25521#issuecomment-454489870 |
| @richardlau | https://github.com/richardlau |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2255/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2255/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25521 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| force-pushed | https://github.com/nodejs/node/compare/f2f5eb3b67488651d974d8ddc20c321d7c27c39d..ff1be85e3c14f2aa3a75133f6d51d9212170c2f8 |
| f2f5eb3 | https://github.com/nodejs/node/commit/f2f5eb3b67488651d974d8ddc20c321d7c27c39d |
| ff1be85 | https://github.com/nodejs/node/commit/ff1be85e3c14f2aa3a75133f6d51d9212170c2f8 |
|
Compare
| https://github.com/nodejs/node/compare/f2f5eb3b67488651d974d8ddc20c321d7c27c39d..ff1be85e3c14f2aa3a75133f6d51d9212170c2f8 |
| January 15, 2019 18:02 | https://github.com/nodejs/node/pull/25521#event-2075337637 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jan 15, 2019
| https://github.com/nodejs/node/pull/25521#ref-pullrequest-398365605 |
|
build: set -blibpath: for AIX
#25447
| https://github.com/nodejs/node/pull/25447 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jan 15, 2019 | https://github.com/nodejs/node/pull/25521#issuecomment-454492070 |
| https://ci.nodejs.org/job/node-test-pull-request/20146/ | https://ci.nodejs.org/job/node-test-pull-request/20146/ |
| Please reload this page | https://github.com/nodejs/node/pull/25521 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jan 15, 2019
| https://github.com/nodejs/node/pull/25521#ref-issue-395743652 |
|
[Tracking] Additional semver minor to 8.x during maintenance
nodejs/Release#405
| https://github.com/nodejs/Release/issues/405 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jan 15, 2019
| https://github.com/nodejs/node/pull/25521#pullrequestreview-192796174 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25521/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/25521#pullrequestreview-192796174 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25521 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
aix
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaix |
|
regression
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aregression |
| Jan 15, 2019 | https://github.com/nodejs/node/pull/25521#event-2075424398 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Jan 15, 2019
| https://github.com/nodejs/node/pull/25521#pullrequestreview-192835517 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25521/files |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Jan 16, 2019
| https://github.com/nodejs/node/pull/25521#ref-issue-399662052 |
|
CI failures: 20190110 - 20190116
nodejs/reliability#20
| https://github.com/nodejs/reliability/issues/20 |
| https://github.com/gdams |
| gdams | https://github.com/gdams |
|
Jan 16, 2019
| https://github.com/nodejs/node/pull/25521#pullrequestreview-193138238 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25521/files |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 16, 2019
| https://github.com/nodejs/node/pull/25521#pullrequestreview-193269399 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25521/files |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| force-pushed | https://github.com/nodejs/node/compare/03e2a8210d3d4fd9de1473b3465c6b6d378faaf6..d4b6643ac333863efd417732ac641582e1a6211d |
| 03e2a82 | https://github.com/nodejs/node/commit/03e2a8210d3d4fd9de1473b3465c6b6d378faaf6 |
| d4b6643 | https://github.com/nodejs/node/commit/d4b6643ac333863efd417732ac641582e1a6211d |
|
Compare
| https://github.com/nodejs/node/compare/03e2a8210d3d4fd9de1473b3465c6b6d378faaf6..d4b6643ac333863efd417732ac641582e1a6211d |
| February 28, 2019 12:40 | https://github.com/nodejs/node/pull/25521#event-2170927171 |
|
| https://github.com/richardlau |
| build: set -blibpath: for AIX | https://github.com/nodejs/node/pull/25521/commits/30be5ef70e7fb99d54754ee2064e906e4a1ae7d7 |
| 30be5ef | https://github.com/nodejs/node/pull/25521/commits/30be5ef70e7fb99d54754ee2064e906e4a1ae7d7 |
| nodejs#17604 | https://github.com/nodejs/node/pull/17604 |
| nodejs#25444 | https://github.com/nodejs/node/issues/25444 |
| nodejs#25521 | https://github.com/nodejs/node/pull/25521 |
| nodejs#25447 | https://github.com/nodejs/node/pull/25447 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| force-pushed | https://github.com/nodejs/node/compare/ff1be85e3c14f2aa3a75133f6d51d9212170c2f8..30be5ef70e7fb99d54754ee2064e906e4a1ae7d7 |
| ff1be85 | https://github.com/nodejs/node/commit/ff1be85e3c14f2aa3a75133f6d51d9212170c2f8 |
| 30be5ef | https://github.com/nodejs/node/commit/30be5ef70e7fb99d54754ee2064e906e4a1ae7d7 |
|
Compare
| https://github.com/nodejs/node/compare/ff1be85e3c14f2aa3a75133f6d51d9212170c2f8..30be5ef70e7fb99d54754ee2064e906e4a1ae7d7 |
| March 6, 2019 20:50 | https://github.com/nodejs/node/pull/25521#event-2185363609 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Mar 6, 2019 | https://github.com/nodejs/node/pull/25521#issuecomment-470271727 |
| https://ci.nodejs.org/job/node-test-pull-request/21281/ | https://ci.nodejs.org/job/node-test-pull-request/21281/ |
| Please reload this page | https://github.com/nodejs/node/pull/25521 |
|
[v6.x backport] build: set -blibpath: for AIX
#26478
| https://github.com/nodejs/node/pull/26478 |
|
Final 6.x release before EOL? [Discussion]
nodejs/Release#414
| https://github.com/nodejs/Release/issues/414 |
| BethGriggs | https://github.com/BethGriggs |
|
Mar 19, 2019
| https://github.com/nodejs/node/pull/25521#ref-commit-e936907 |
|
| https://github.com/richardlau |
|
| https://github.com/BethGriggs |
| build: set -blibpath: for AIX | https://github.com/nodejs/node/commit/e9369073d949979e51cee03a61f82c5c4f604e10 |
| e936907 | https://github.com/nodejs/node/commit/e9369073d949979e51cee03a61f82c5c4f604e10 |
| #17604 | https://github.com/nodejs/node/pull/17604 |
| #25444 | https://github.com/nodejs/node/issues/25444 |
| #25521 | https://github.com/nodejs/node/pull/25521 |
| #25447 | https://github.com/nodejs/node/pull/25447 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Mar 19, 2019 | https://github.com/nodejs/node/pull/25521#issuecomment-474568154 |
| Please reload this page | https://github.com/nodejs/node/pull/25521 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Mar 19, 2019 | https://github.com/nodejs/node/pull/25521#event-2214925746 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25521 |
|
| https://github.com/BethGriggs |
|
BethGriggs
| https://github.com/BethGriggs |
|
| https://github.com/nodejs/node/pull/25521/files/ff1be85e3c14f2aa3a75133f6d51d9212170c2f8 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/25521/files/ff1be85e3c14f2aa3a75133f6d51d9212170c2f8 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/25521/files/ff1be85e3c14f2aa3a75133f6d51d9212170c2f8 |
|
| https://github.com/gdams |
|
gdams
| https://github.com/gdams |
|
| https://github.com/nodejs/node/pull/25521/files/ff1be85e3c14f2aa3a75133f6d51d9212170c2f8 |
|
aix
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaix |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
regression
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aregression |
| Please reload this page | https://github.com/nodejs/node/pull/25521 |
|
| https://github.com/richardlau |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/BethGriggs |
|
| https://github.com/sam-github |
|
| https://github.com/mhdawson |
|
| https://github.com/gdams |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |