René's URL Explorer Experiment


Title: tls: do not free cert in `.getCertificate()` by addaleax · Pull Request #25490 · nodejs/node · GitHub

Open Graph Title: tls: do not free cert in `.getCertificate()` by addaleax · Pull Request #25490 · nodejs/node

X Title: tls: do not free cert in `.getCertificate()` by addaleax · Pull Request #25490 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The documentation of SSL_get_certificate states that it returns an internal pointer that must not be freed by the caller. Therefore, using a smart pointer to take ownership is incorrect. Refs: http...

X Description: The documentation of SSL_get_certificate states that it returns an internal pointer that must not be freed by the caller. Therefore, using a smart pointer to take ownership is incorrect. Refs: http...

Opengraph URL: https://github.com/nodejs/node/pull/25490

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:66704a8c-39f0-666f-3704-766cbdd85b0c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA882:D0CCD:D8BDE0:125AA91:6A5215E2
html-safe-noncede9f913ccc05a71003dbe224ffdbab543d95b87fdf5ab526453a3661fde1cf90
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODgyOkQwQ0NEOkQ4QkRFMDoxMjVBQTkxOjZBNTIxNUUyIiwidmlzaXRvcl9pZCI6IjIxNjYwNDkzNDYwMDAzOTM2OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac10315783ef54174f02b0ce1272cb8b38146170f49659051562c0b13a83891a7b
hovercard-subject-tagpull_request:244410436
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25490/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b676f41c880f66f1fa617d9cb216675fa8790e72faaafe4164f8511980b0cad8/nodejs/node/pull/25490
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b676f41c880f66f1fa617d9cb216675fa8790e72faaafe4164f8511980b0cad8/nodejs/node/pull/25490
og:image:altThe documentation of SSL_get_certificate states that it returns an internal pointer that must not be freed by the caller. Therefore, using a smart pointer to take ownership is incorrect. Refs: http...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25490#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25490
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25490
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25490
Reloadhttps://github.com/nodejs/node/pull/25490
Reloadhttps://github.com/nodejs/node/pull/25490
Please reload this pagehttps://github.com/nodejs/node/pull/25490
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25490
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 983 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:get-certificate-nofreehttps://github.com/addaleax/node/tree/get-certificate-nofree
Conversationhttps://github.com/nodejs/node/pull/25490
Commits1 (1)https://github.com/nodejs/node/pull/25490/commits
Checkshttps://github.com/nodejs/node/pull/25490/checks
Files changedhttps://github.com/nodejs/node/pull/25490/files
tls: do not free cert in .getCertificate()https://github.com/nodejs/node/pull/25490#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:get-certificate-nofreehttps://github.com/addaleax/node/tree/get-certificate-nofree
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2019https://github.com/nodejs/node/pull/25490#issue-398845920
https://man.openbsd.org/SSL_get_certificate.3https://man.openbsd.org/SSL_get_certificate.3
#24261https://github.com/nodejs/node/pull/24261
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25490
https://github.com/addaleax
tls: do not free cert in .getCertificate()https://github.com/nodejs/node/pull/25490/commits/7611f1b7d22bbcfcc4a7ef81638a4fca2fd7cad1
7611f1bhttps://github.com/nodejs/node/pull/25490/commits/7611f1b7d22bbcfcc4a7ef81638a4fca2fd7cad1
https://man.openbsd.org/SSL_get_certificate.3https://man.openbsd.org/SSL_get_certificate.3
nodejs#24261https://github.com/nodejs/node/pull/24261
https://github.com/nodejs-private/security/issues/217https://github.com/nodejs-private/security/issues/217
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 14, 2019https://github.com/nodejs/node/pull/25490#issuecomment-453972975
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/25490
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Jan 14, 2019https://github.com/nodejs/node/pull/25490#event-2071507418
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2019 https://github.com/nodejs/node/pull/25490#ref-pullrequest-378934147
tls: get the local certificate after tls handshake #24261 https://github.com/nodejs/node/pull/24261
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Jan 14, 2019https://github.com/nodejs/node/pull/25490#event-2071514060
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2019https://github.com/nodejs/node/pull/25490#issuecomment-453977584
https://ci.nodejs.org/job/node-test-pull-request/20103/https://ci.nodejs.org/job/node-test-pull-request/20103/
Please reload this pagehttps://github.com/nodejs/node/pull/25490
https://github.com/danbev
danbevhttps://github.com/danbev
Jan 14, 2019 https://github.com/nodejs/node/pull/25490#pullrequestreview-192118372
View reviewed changes https://github.com/nodejs/node/pull/25490/files/7611f1b7d22bbcfcc4a7ef81638a4fca2fd7cad1
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 14, 2019 https://github.com/nodejs/node/pull/25490#pullrequestreview-192148283
View reviewed changes https://github.com/nodejs/node/pull/25490/files/7611f1b7d22bbcfcc4a7ef81638a4fca2fd7cad1
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 14, 2019 https://github.com/nodejs/node/pull/25490#pullrequestreview-192239154
View reviewed changes https://github.com/nodejs/node/pull/25490/files/7611f1b7d22bbcfcc4a7ef81638a4fca2fd7cad1
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jan 14, 2019 https://github.com/nodejs/node/pull/25490#pullrequestreview-192300224
View reviewed changes https://github.com/nodejs/node/pull/25490/files/7611f1b7d22bbcfcc4a7ef81638a4fca2fd7cad1
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2019https://github.com/nodejs/node/pull/25490#issuecomment-454113589
https://ci.nodejs.org/job/node-test-pull-request/20117/https://ci.nodejs.org/job/node-test-pull-request/20117/
Please reload this pagehttps://github.com/nodejs/node/pull/25490
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 14, 2019https://github.com/nodejs/node/pull/25490#event-2072599639
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 14, 2019 https://github.com/nodejs/node/pull/25490#pullrequestreview-192364437
View reviewed changes https://github.com/nodejs/node/pull/25490/files/7611f1b7d22bbcfcc4a7ef81638a4fca2fd7cad1
CI failures: 20190110 - 20190116 nodejs/reliability#20 https://github.com/nodejs/reliability/issues/20
Investigate flaky known_issues/test-vm-timeout-escape-queuemicrotask #25529 https://github.com/nodejs/node/issues/25529
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019https://github.com/nodejs/node/pull/25490#issuecomment-456098746
https://ci.nodejs.org/job/node-test-pull-request/20229/https://ci.nodejs.org/job/node-test-pull-request/20229/
Please reload this pagehttps://github.com/nodejs/node/pull/25490
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019https://github.com/nodejs/node/pull/25490#issuecomment-456177505
e888f66https://github.com/nodejs/node/commit/e888f667f5acae55b4604e101f0570e08da8236a
Please reload this pagehttps://github.com/nodejs/node/pull/25490
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019https://github.com/nodejs/node/pull/25490#event-2087169213
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
January 21, 2019 19:27https://github.com/nodejs/node/pull/25490#event-2087169394
addaleaxhttps://github.com/addaleax
Jan 21, 2019 https://github.com/nodejs/node/pull/25490#ref-commit-e888f66
https://github.com/addaleax
tls: do not free cert in .getCertificate()https://github.com/nodejs/node/commit/e888f667f5acae55b4604e101f0570e08da8236a
e888f66https://github.com/nodejs/node/commit/e888f667f5acae55b4604e101f0570e08da8236a
https://man.openbsd.org/SSL_get_certificate.3https://man.openbsd.org/SSL_get_certificate.3
#24261https://github.com/nodejs/node/pull/24261
https://github.com/nodejs-private/security/issues/217https://github.com/nodejs-private/security/issues/217
#25490https://github.com/nodejs/node/pull/25490
addaleaxhttps://github.com/addaleax
Jan 23, 2019 https://github.com/nodejs/node/pull/25490#ref-commit-c3409f5
https://github.com/addaleax
tls: do not free cert in .getCertificate()https://github.com/nodejs/node/commit/c3409f57fd420527cc79efb16b958a0b87055256
c3409f5https://github.com/nodejs/node/commit/c3409f57fd420527cc79efb16b958a0b87055256
https://man.openbsd.org/SSL_get_certificate.3https://man.openbsd.org/SSL_get_certificate.3
#24261https://github.com/nodejs/node/pull/24261
https://github.com/nodejs-private/security/issues/217https://github.com/nodejs-private/security/issues/217
#25490https://github.com/nodejs/node/pull/25490
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 24, 2019 https://github.com/nodejs/node/pull/25490#ref-pullrequest-402909465
v11.8.0 proposal #25687 https://github.com/nodejs/node/pull/25687
zcbenzhttps://github.com/zcbenz
Mar 27, 2019 https://github.com/nodejs/node/pull/25490#ref-commit-afbc0fd
https://github.com/addaleax
https://github.com/zcbenz
tls: do not free cert in .getCertificate()https://github.com/electron/node/commit/afbc0fd497d5633df3180d3aa78821db85525256
afbc0fdhttps://github.com/electron/node/commit/afbc0fd497d5633df3180d3aa78821db85525256
https://man.openbsd.org/SSL_get_certificate.3https://man.openbsd.org/SSL_get_certificate.3
nodejs/node#24261https://github.com/nodejs/node/pull/24261
https://github.com/nodejs-private/security/issues/217https://github.com/nodejs-private/security/issues/217
nodejs/node#25490https://github.com/nodejs/node/pull/25490
sam-githubhttps://github.com/sam-github
Apr 29, 2019 https://github.com/nodejs/node/pull/25490#ref-commit-8c7406f
https://github.com/addaleax
https://github.com/sam-github
tls: do not free cert in .getCertificate()https://github.com/sam-github/node/commit/8c7406f1d1a5a2a4073a1e41914ebaeb5d30c4eb
8c7406fhttps://github.com/sam-github/node/commit/8c7406f1d1a5a2a4073a1e41914ebaeb5d30c4eb
https://man.openbsd.org/SSL_get_certificate.3https://man.openbsd.org/SSL_get_certificate.3
nodejs#24261https://github.com/nodejs/node/pull/24261
https://github.com/nodejs-private/security/issues/217https://github.com/nodejs-private/security/issues/217
nodejs#25490https://github.com/nodejs/node/pull/25490
[Snyk] Fix for 2 vulnerabilities kissofire/node#17 https://github.com/kissofire/node/pull/17
[Snyk] Fix for 2 vulnerabilities ron-a20/node#14 https://github.com/ron-a20/node/pull/14
[Snyk] Fix for 2 vulnerabilities sitedata/node#6 https://github.com/sitedata/node/pull/6
[Snyk] Fix for 2 vulnerabilities meghasfdc/node#17 https://github.com/meghasfdc/node/pull/17
[Snyk] Fix for 2 vulnerabilities 137717unity/node#7 https://github.com/137717unity/node/pull/7
[Snyk] Fix for 2 vulnerabilities Rednickle/node-1#2 https://github.com/Rednickle/node-1/pull/2
[Snyk] Fix for 3 vulnerabilities turkdevops/node#2 https://github.com/turkdevops/node/pull/2
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Oct 29, 2020 https://github.com/nodejs/node/pull/25490#ref-pullrequest-732099539
[Snyk] Security upgrade gatsby from 2.18.18 to 2.23.20 Rednickle/node-1#4 https://github.com/Rednickle/node-1/pull/4
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25490
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/25490/files/7611f1b7d22bbcfcc4a7ef81638a4fca2fd7cad1
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/25490/files/7611f1b7d22bbcfcc4a7ef81638a4fca2fd7cad1
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/25490/files/7611f1b7d22bbcfcc4a7ef81638a4fca2fd7cad1
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/25490/files/7611f1b7d22bbcfcc4a7ef81638a4fca2fd7cad1
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/25490/files/7611f1b7d22bbcfcc4a7ef81638a4fca2fd7cad1
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/25490
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/sam-github
https://github.com/danbev
https://github.com/jasnell
https://github.com/lpinca
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.