René's URL Explorer Experiment


Title: src: remove outdated `Neuter()` call in `node_buffer.cc` by addaleax · Pull Request #25479 · nodejs/node · GitHub

Open Graph Title: src: remove outdated `Neuter()` call in `node_buffer.cc` by addaleax · Pull Request #25479 · nodejs/node

X Title: src: remove outdated `Neuter()` call in `node_buffer.cc` by addaleax · Pull Request #25479 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This call was introduced in 827ee49 to avoid a crash in a later Neuter() call that has later been removed in ebbbc5a, rendering the original call unnecessary. Refs: #3624 Refs: #5204 Checklist ...

X Description: This call was introduced in 827ee49 to avoid a crash in a later Neuter() call that has later been removed in ebbbc5a, rendering the original call unnecessary. Refs: #3624 Refs: #5204 Checklist ...

Opengraph URL: https://github.com/nodejs/node/pull/25479

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:81fabcb3-b404-885b-4ca7-4131e9ba3f0b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC1C:1A5EFF:BE340D:1032927:6A569E6D
html-safe-nonce5d6fcf8acedab4b265c80f6d77b91d517254759d954d6067def244e6d921a7d5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzFDOjFBNUVGRjpCRTM0MEQ6MTAzMjkyNzo2QTU2OUU2RCIsInZpc2l0b3JfaWQiOiI0NDQ2Njc2NTI0OTEwMTU3NDIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacced1f00eb1fdaab5749d2054d92934b444e517bb79b1f7cfadb58780eb0bef07
hovercard-subject-tagpull_request:244304968
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25479/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1e3aae2a4d360fa8c835fac69f6a3090bb443fba8d1e288570dbc75bd69fa46f/nodejs/node/pull/25479
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1e3aae2a4d360fa8c835fac69f6a3090bb443fba8d1e288570dbc75bd69fa46f/nodejs/node/pull/25479
og:image:altThis call was introduced in 827ee49 to avoid a crash in a later Neuter() call that has later been removed in ebbbc5a, rendering the original call unnecessary. Refs: #3624 Refs: #5204 Checklist ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None647a25f437e2f54eccdd162bd007c8ae70f4235c4125dba0f4518747cc8b9615
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release05adb86a60ce3d701e556eded3ab26300ec6bcc4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25479#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25479
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25479
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25479
Reloadhttps://github.com/nodejs/node/pull/25479
Reloadhttps://github.com/nodejs/node/pull/25479
Please reload this pagehttps://github.com/nodejs/node/pull/25479
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25479
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:no-neuterhttps://github.com/addaleax/node/tree/no-neuter
Conversationhttps://github.com/nodejs/node/pull/25479
Commits1 (1)https://github.com/nodejs/node/pull/25479/commits
Checkshttps://github.com/nodejs/node/pull/25479/checks
Files changedhttps://github.com/nodejs/node/pull/25479/files
src: remove outdated Neuter() call in node_buffer.cchttps://github.com/nodejs/node/pull/25479#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:no-neuterhttps://github.com/addaleax/node/tree/no-neuter
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 13, 2019https://github.com/nodejs/node/pull/25479#issue-398699574
827ee49https://github.com/nodejs/node/commit/827ee498e332e316421f565c5f763f347f81274c
ebbbc5ahttps://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589
#3624https://github.com/nodejs/node/pull/3624
#5204https://github.com/nodejs/node/pull/5204
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25479
https://github.com/addaleax
src: remove outdated Neuter() call in node_buffer.cchttps://github.com/nodejs/node/pull/25479/commits/98da4cc75cd6af1d3895df453c48a1877e9f2f2b
98da4cchttps://github.com/nodejs/node/pull/25479/commits/98da4cc75cd6af1d3895df453c48a1877e9f2f2b
827ee49https://github.com/addaleax/node/commit/827ee498e332e316421f565c5f763f347f81274c
ebbbc5ahttps://github.com/addaleax/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589
nodejs#3624https://github.com/nodejs/node/pull/3624
nodejs#5204https://github.com/nodejs/node/pull/5204
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 13, 2019https://github.com/nodejs/node/pull/25479#issuecomment-453865847
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/25479
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jan 13, 2019https://github.com/nodejs/node/pull/25479#event-2070719757
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2019https://github.com/nodejs/node/pull/25479#issuecomment-454067882
https://ci.nodejs.org/job/node-test-pull-request/20109/https://ci.nodejs.org/job/node-test-pull-request/20109/
Please reload this pagehttps://github.com/nodejs/node/pull/25479
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Jan 14, 2019 https://github.com/nodejs/node/pull/25479#pullrequestreview-192272315
View reviewed changes https://github.com/nodejs/node/pull/25479/files/98da4cc75cd6af1d3895df453c48a1877e9f2f2b
CI failures: 20190110 - 20190116 nodejs/reliability#20 https://github.com/nodejs/reliability/issues/20
Investigate flaky known_issues/test-vm-timeout-escape-queuemicrotask #25529 https://github.com/nodejs/node/issues/25529
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 21, 2019https://github.com/nodejs/node/pull/25479#event-2086585650
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019https://github.com/nodejs/node/pull/25479#issuecomment-456098473
https://ci.nodejs.org/job/node-test-pull-request/20228/https://ci.nodejs.org/job/node-test-pull-request/20228/
Please reload this pagehttps://github.com/nodejs/node/pull/25479
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019https://github.com/nodejs/node/pull/25479#issuecomment-456179407
30f4568https://github.com/nodejs/node/commit/30f45683aaeb1d4917fff7bc7cb2937ee89f0082
Please reload this pagehttps://github.com/nodejs/node/pull/25479
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 21, 2019https://github.com/nodejs/node/pull/25479#event-2087182489
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
January 21, 2019 19:35https://github.com/nodejs/node/pull/25479#event-2087182610
addaleaxhttps://github.com/addaleax
Jan 21, 2019 https://github.com/nodejs/node/pull/25479#ref-commit-30f4568
https://github.com/addaleax
src: remove outdated Neuter() call in node_buffer.cchttps://github.com/nodejs/node/commit/30f45683aaeb1d4917fff7bc7cb2937ee89f0082
30f4568https://github.com/nodejs/node/commit/30f45683aaeb1d4917fff7bc7cb2937ee89f0082
827ee49https://github.com/nodejs/node/commit/827ee498e332e316421f565c5f763f347f81274c
ebbbc5ahttps://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589
#3624https://github.com/nodejs/node/pull/3624
#5204https://github.com/nodejs/node/pull/5204
#25479https://github.com/nodejs/node/pull/25479
targoshttps://github.com/targos
Jan 24, 2019 https://github.com/nodejs/node/pull/25479#ref-commit-dbecc82
https://github.com/addaleax
https://github.com/targos
src: remove outdated Neuter() call in node_buffer.cchttps://github.com/nodejs/node/commit/dbecc8252493d347b16f3ccbb859ec02a0601a83
dbecc82https://github.com/nodejs/node/commit/dbecc8252493d347b16f3ccbb859ec02a0601a83
827ee49https://github.com/nodejs/node/commit/827ee498e332e316421f565c5f763f347f81274c
ebbbc5ahttps://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589
#3624https://github.com/nodejs/node/pull/3624
#5204https://github.com/nodejs/node/pull/5204
#25479https://github.com/nodejs/node/pull/25479
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 24, 2019 https://github.com/nodejs/node/pull/25479#ref-pullrequest-402909465
v11.8.0 proposal #25687 https://github.com/nodejs/node/pull/25687
BethGriggshttps://github.com/BethGriggs
Apr 29, 2019 https://github.com/nodejs/node/pull/25479#ref-commit-1d2d3f3
https://github.com/addaleax
https://github.com/BethGriggs
src: remove outdated Neuter() call in node_buffer.cchttps://github.com/nodejs/node/commit/1d2d3f3946fce389e40ff7fde8b052500f482fe6
1d2d3f3https://github.com/nodejs/node/commit/1d2d3f3946fce389e40ff7fde8b052500f482fe6
827ee49https://github.com/nodejs/node/commit/827ee498e332e316421f565c5f763f347f81274c
ebbbc5ahttps://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589
#3624https://github.com/nodejs/node/pull/3624
#5204https://github.com/nodejs/node/pull/5204
#25479https://github.com/nodejs/node/pull/25479
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
May 1, 2019 https://github.com/nodejs/node/pull/25479#ref-pullrequest-439147711
v10.16.0 proposal #27514 https://github.com/nodejs/node/pull/27514
BethGriggshttps://github.com/BethGriggs
May 10, 2019 https://github.com/nodejs/node/pull/25479#ref-commit-f71c55b
https://github.com/addaleax
https://github.com/BethGriggs
src: remove outdated Neuter() call in node_buffer.cchttps://github.com/nodejs/node/commit/f71c55b7f21de64fdc643fb09be9ba91c8ad9e67
f71c55bhttps://github.com/nodejs/node/commit/f71c55b7f21de64fdc643fb09be9ba91c8ad9e67
827ee49https://github.com/nodejs/node/commit/827ee498e332e316421f565c5f763f347f81274c
ebbbc5ahttps://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589
#3624https://github.com/nodejs/node/pull/3624
#5204https://github.com/nodejs/node/pull/5204
#25479https://github.com/nodejs/node/pull/25479
MylesBorinshttps://github.com/MylesBorins
May 16, 2019 https://github.com/nodejs/node/pull/25479#ref-commit-cd4a932
https://github.com/addaleax
https://github.com/MylesBorins
src: remove outdated Neuter() call in node_buffer.cchttps://github.com/nodejs/node/commit/cd4a932af3645e537d6af12e70a7acd67961232f
cd4a932https://github.com/nodejs/node/commit/cd4a932af3645e537d6af12e70a7acd67961232f
827ee49https://github.com/nodejs/node/commit/827ee498e332e316421f565c5f763f347f81274c
ebbbc5ahttps://github.com/nodejs/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589
#3624https://github.com/nodejs/node/pull/3624
#5204https://github.com/nodejs/node/pull/5204
#25479https://github.com/nodejs/node/pull/25479
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#315 https://github.com/beevelop/docker-android-nodejs/issues/315
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#316 https://github.com/beevelop/docker-android-nodejs/issues/316
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#317 https://github.com/beevelop/docker-android-nodejs/issues/317
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#318 https://github.com/beevelop/docker-android-nodejs/issues/318
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#319 https://github.com/beevelop/docker-android-nodejs/issues/319
deepak1556https://github.com/deepak1556
Jul 10, 2019 https://github.com/nodejs/node/pull/25479#ref-commit-e13e8fe
https://github.com/addaleax
https://github.com/deepak1556
src: remove outdated Neuter() call in node_buffer.cchttps://github.com/electron/node/commit/e13e8fe0bff67de3c600096ae0c1818b22a082a8
e13e8fehttps://github.com/electron/node/commit/e13e8fe0bff67de3c600096ae0c1818b22a082a8
827ee49https://github.com/electron/node/commit/827ee498e332e316421f565c5f763f347f81274c
ebbbc5ahttps://github.com/electron/node/commit/ebbbc5a790db6900653ad9c697c60861dc518589
nodejs/node#3624https://github.com/nodejs/node/pull/3624
nodejs/node#5204https://github.com/nodejs/node/pull/5204
nodejs/node#25479https://github.com/nodejs/node/pull/25479
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25479
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/25479/files/98da4cc75cd6af1d3895df453c48a1877e9f2f2b
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/25479
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/apapirovski
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.