René's URL Explorer Experiment


Title: build,test: fail `coverage` target if tests fail by refack · Pull Request #25432 · nodejs/node · GitHub

Open Graph Title: build,test: fail `coverage` target if tests fail by refack · Pull Request #25432 · nodejs/node

X Title: build,test: fail `coverage` target if tests fail by refack · Pull Request #25432 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Part of fix for #24966 Make the coverage-test target fail if running the tests fail. This way we get early warning that something is borked and we don't publish spurious results. /CC @nodejs/bu...

X Description: Part of fix for #24966 Make the coverage-test target fail if running the tests fail. This way we get early warning that something is borked and we don't publish spurious results. /CC @nodej...

Opengraph URL: https://github.com/nodejs/node/pull/25432

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2fbf5076-def4-518d-a92c-4789f29bdf53
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA8A:1C739F:AF6A54:EA36FB:6A51A30A
html-safe-nonce6c323cc1b9cec38b4b0ab52c3cf1e7d4d96beabf77445fb3fdaebbe2da3e6a17
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQThBOjFDNzM5RjpBRjZBNTQ6RUEzNkZCOjZBNTFBMzBBIiwidmlzaXRvcl9pZCI6IjcxNTgzNTk5NDQ2MzQ0MDk3MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac68c92afe14393319e44c7961722a6909a9f451da0365c8736fb75a195baccf9a
hovercard-subject-tagpull_request:243731439
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25432/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e948ff898b9ed128ace30c0a47446eb80553a1c078742acf50067bb6baffde11/nodejs/node/pull/25432
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e948ff898b9ed128ace30c0a47446eb80553a1c078742acf50067bb6baffde11/nodejs/node/pull/25432
og:image:altPart of fix for #24966 Make the coverage-test target fail if running the tests fail. This way we get early warning that something is borked and we don't publish spurious results. /CC @nodejs/bu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerefack
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25432#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25432
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25432
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25432
Reloadhttps://github.com/nodejs/node/pull/25432
Reloadhttps://github.com/nodejs/node/pull/25432
Please reload this pagehttps://github.com/nodejs/node/pull/25432
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25432
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 982 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:race-safe-coveragehttps://github.com/refack/node/tree/race-safe-coverage
Conversationhttps://github.com/nodejs/node/pull/25432
Commits1 (1)https://github.com/nodejs/node/pull/25432/commits
Checkshttps://github.com/nodejs/node/pull/25432/checks
Files changedhttps://github.com/nodejs/node/pull/25432/files
build,test: fail coverage target if tests failhttps://github.com/nodejs/node/pull/25432#top
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:race-safe-coveragehttps://github.com/refack/node/tree/race-safe-coverage
https://github.com/refack
refackhttps://github.com/refack
Jan 10, 2019https://github.com/nodejs/node/pull/25432#issue-397887214
#24966https://github.com/nodejs/node/issues/24966
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25432
https://github.com/refack
build,test: fail coverage target if tests failhttps://github.com/nodejs/node/pull/25432/commits/bef94ff2eca35180fd7408abec6633d39171fa7a
bef94ffhttps://github.com/nodejs/node/pull/25432/commits/bef94ff2eca35180fd7408abec6633d39171fa7a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 10, 2019https://github.com/nodejs/node/pull/25432#issuecomment-453140154
@refackhttps://github.com/refack
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2220/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2220/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25432
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Jan 10, 2019https://github.com/nodejs/node/pull/25432#event-2066205033
https://github.com/refack
refackhttps://github.com/refack
coverage https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acoverage
Jan 10, 2019https://github.com/nodejs/node/pull/25432#event-2066205766
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 10, 2019 https://github.com/nodejs/node/pull/25432#pullrequestreview-191399581
View reviewed changes https://github.com/nodejs/node/pull/25432/files/bef94ff2eca35180fd7408abec6633d39171fa7a
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 10, 2019 https://github.com/nodejs/node/pull/25432#pullrequestreview-191410264
View reviewed changes https://github.com/nodejs/node/pull/25432/files/bef94ff2eca35180fd7408abec6633d39171fa7a
mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/25432
https://github.com/nodejs/node/pull/25432#pullrequestreview-191410264
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25432
https://github.com/danbev
danbevhttps://github.com/danbev
Jan 15, 2019https://github.com/nodejs/node/pull/25432#issuecomment-454288276
f216d5bhttps://github.com/nodejs/node/commit/f216d5bbb1595f2fbed29517ba87b80e8c02f3c0
Please reload this pagehttps://github.com/nodejs/node/pull/25432
https://github.com/danbev
danbevhttps://github.com/danbev
Jan 15, 2019https://github.com/nodejs/node/pull/25432#event-2073788890
pullhttps://github.com/apps/pull
Jan 15, 2019 https://github.com/nodejs/node/pull/25432#ref-commit-f216d5b
https://github.com/refack
https://github.com/danbev
build,test: fail coverage target if tests failhttps://github.com/shakir-abdo/node/commit/f216d5bbb1595f2fbed29517ba87b80e8c02f3c0
f216d5bhttps://github.com/shakir-abdo/node/commit/f216d5bbb1595f2fbed29517ba87b80e8c02f3c0
nodejs#25432https://github.com/nodejs/node/pull/25432
addaleaxhttps://github.com/addaleax
Jan 15, 2019 https://github.com/nodejs/node/pull/25432#ref-commit-736349c
https://github.com/refack
https://github.com/addaleax
build,test: fail coverage target if tests failhttps://github.com/nodejs/node/commit/736349c7e3dd281cbe80109f43395082b11824df
736349chttps://github.com/nodejs/node/commit/736349c7e3dd281cbe80109f43395082b11824df
#25432https://github.com/nodejs/node/pull/25432
https://github.com/refack
refackhttps://github.com/refack
January 15, 2019 21:02https://github.com/nodejs/node/pull/25432#event-2075765048
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 16, 2019 https://github.com/nodejs/node/pull/25432#ref-pullrequest-399868555
v11.7.0 proposal #25537 https://github.com/nodejs/node/pull/25537
BridgeARhttps://github.com/BridgeAR
Jan 16, 2019 https://github.com/nodejs/node/pull/25432#ref-commit-155741f
https://github.com/refack
https://github.com/BridgeAR
build,test: fail coverage target if tests failhttps://github.com/BridgeAR/node/commit/155741f067ba928bd9e660433fccd00ba6bb9d85
155741fhttps://github.com/BridgeAR/node/commit/155741f067ba928bd9e660433fccd00ba6bb9d85
nodejs#25432https://github.com/nodejs/node/pull/25432
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Jan 17, 2019https://github.com/nodejs/node/pull/25432#event-2080655627
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 17, 2019https://github.com/nodejs/node/pull/25432#issuecomment-455226031
Please reload this pagehttps://github.com/nodejs/node/pull/25432
https://github.com/refack
refackhttps://github.com/refack
Jan 17, 2019 https://github.com/nodejs/node/pull/25432#ref-pullrequest-400012007
test: revert fail coverage target if tests fail" #25543 https://github.com/nodejs/node/pull/25543
https://github.com/refack
refackhttps://github.com/refack
Feb 1, 2019 https://github.com/nodejs/node/pull/25432#ref-issue-405033764
Expanding tests run in coverage job nodejs/build#1676 https://github.com/nodejs/build/issues/1676
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#302 https://github.com/beevelop/docker-android-nodejs/issues/302
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#275 https://github.com/beevelop/docker-nodejs/issues/275
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#276 https://github.com/beevelop/docker-nodejs/issues/276
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#303 https://github.com/beevelop/docker-android-nodejs/issues/303
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#277 https://github.com/beevelop/docker-nodejs/issues/277
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#304 https://github.com/beevelop/docker-android-nodejs/issues/304
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#278 https://github.com/beevelop/docker-nodejs/issues/278
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#305 https://github.com/beevelop/docker-android-nodejs/issues/305
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#279 https://github.com/beevelop/docker-nodejs/issues/279
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#306 https://github.com/beevelop/docker-android-nodejs/issues/306
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25432
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/25432/files/bef94ff2eca35180fd7408abec6633d39171fa7a
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/25432/files/bef94ff2eca35180fd7408abec6633d39171fa7a
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
coverage https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acoverage
Please reload this pagehttps://github.com/nodejs/node/pull/25432
https://github.com/refack
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/BridgeAR
https://github.com/lpinca
https://github.com/mhdawson
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.