René's URL Explorer Experiment


Title: src: simplify NativeModule caching and remove redudant data by joyeecheung · Pull Request #25352 · nodejs/node · GitHub

Open Graph Title: src: simplify NativeModule caching and remove redudant data by joyeecheung · Pull Request #25352 · nodejs/node

X Title: src: simplify NativeModule caching and remove redudant data by joyeecheung · Pull Request #25352 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Remove NativeModule._source - the compilation is now entirely done in C++ and process.binding('natives') is implemented directly in the binding loader so there is no need to store additiona...

X Description: Remove NativeModule._source - the compilation is now entirely done in C++ and process.binding('natives') is implemented directly in the binding loader so there is no need to store a...

Opengraph URL: https://github.com/nodejs/node/pull/25352

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fba95e89-e5a5-e758-38d8-f7e2eac675ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1B2:633B1:56CB28A:7A202D7:6A4FA917
html-safe-nonce42d0c6f9d74cbbff94852ffd2944873f99221ec6d6296a29d7758eecf5442ad5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUIyOjYzM0IxOjU2Q0IyOEE6N0EyMDJENzo2QTRGQTkxNyIsInZpc2l0b3JfaWQiOiI2ODg1MzA4MzQ3OTc4ODUyNjMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac28e85f3c1c0512c6737ac9339b4a48f4b71cd974070d3c4751cc2561b0eb59e3
hovercard-subject-tagpull_request:242445974
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25352/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/005a7261ecb077723bcd24380903c1a33332d0250a26f949afd15a306dcc77dc/nodejs/node/pull/25352
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/005a7261ecb077723bcd24380903c1a33332d0250a26f949afd15a306dcc77dc/nodejs/node/pull/25352
og:image:altRemove NativeModule._source - the compilation is now entirely done in C++ and process.binding('natives') is implemented directly in the binding loader so there is no need to store additiona...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25352#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25352
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25352
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25352
Reloadhttps://github.com/nodejs/node/pull/25352
Reloadhttps://github.com/nodejs/node/pull/25352
Please reload this pagehttps://github.com/nodejs/node/pull/25352
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25352
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 972 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:refactor-nativehttps://github.com/joyeecheung/node/tree/refactor-native
Conversationhttps://github.com/nodejs/node/pull/25352
Commits2 (2)https://github.com/nodejs/node/pull/25352/commits
Checkshttps://github.com/nodejs/node/pull/25352/checks
Files changedhttps://github.com/nodejs/node/pull/25352/files
src: simplify NativeModule caching and remove redudant datahttps://github.com/nodejs/node/pull/25352#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:refactor-nativehttps://github.com/joyeecheung/node/tree/refactor-native
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 5, 2019https://github.com/nodejs/node/pull/25352#issue-396175287
Please reload this pagehttps://github.com/nodejs/node/pull/25352
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25352
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 5, 2019https://github.com/nodejs/node/pull/25352#issuecomment-451665798
@joyeecheunghttps://github.com/joyeecheung
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2144/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2144/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25352
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jan 5, 2019https://github.com/nodejs/node/pull/25352#event-2055929343
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jan 5, 2019https://github.com/nodejs/node/pull/25352#issuecomment-451666346
Please reload this pagehttps://github.com/nodejs/node/pull/25352
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 5, 2019https://github.com/nodejs/node/pull/25352#issuecomment-451666463
https://ci.nodejs.org/job/node-test-pull-request/19943/https://ci.nodejs.org/job/node-test-pull-request/19943/
Please reload this pagehttps://github.com/nodejs/node/pull/25352
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 5, 2019 https://github.com/nodejs/node/pull/25352#pullrequestreview-189600195
View reviewed changes https://github.com/nodejs/node/pull/25352/files
benchmark/fixtures/require-cachable.jshttps://github.com/nodejs/node/pull/25352/files#diff-245b4dfc6db38447c6a8d5a50278b21e9dd30db1d16f57653883c75e981816fc
Please reload this pagehttps://github.com/nodejs/node/pull/25352
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 6, 2019 https://github.com/nodejs/node/pull/25352#ref-pullrequest-396217904
modules: significantly improve require performance #25362 https://github.com/nodejs/node/pull/25362
joyeecheunghttps://github.com/joyeecheung
January 9, 2019 23:13https://github.com/nodejs/node/pull/25352#commits-pushed-794327b
https://github.com/joyeecheung
src: simplify NativeModule caching and remove redudant datahttps://github.com/nodejs/node/pull/25352/commits/794327b89f25feb6ddc054cff21e7637a84b1589
794327bhttps://github.com/nodejs/node/pull/25352/commits/794327b89f25feb6ddc054cff21e7637a84b1589
https://github.com/joyeecheung
fixup! src: simplify NativeModule caching and remove redudant datahttps://github.com/nodejs/node/pull/25352/commits/ffaf3899991560ec9e00302a79b85d61fbdddb5a
ffaf389https://github.com/nodejs/node/pull/25352/commits/ffaf3899991560ec9e00302a79b85d61fbdddb5a
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/9f0bbce979c6e1b948ac944dfca5dc2707df0daa..ffaf3899991560ec9e00302a79b85d61fbdddb5a
9f0bbcehttps://github.com/nodejs/node/commit/9f0bbce979c6e1b948ac944dfca5dc2707df0daa
ffaf389https://github.com/nodejs/node/commit/ffaf3899991560ec9e00302a79b85d61fbdddb5a
Compare https://github.com/nodejs/node/compare/9f0bbce979c6e1b948ac944dfca5dc2707df0daa..ffaf3899991560ec9e00302a79b85d61fbdddb5a
January 9, 2019 15:45https://github.com/nodejs/node/pull/25352#event-2063438024
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 9, 2019https://github.com/nodejs/node/pull/25352#issuecomment-452743652
https://ci.nodejs.org/job/node-test-pull-request/20025/https://ci.nodejs.org/job/node-test-pull-request/20025/
Please reload this pagehttps://github.com/nodejs/node/pull/25352
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 12, 2019https://github.com/nodejs/node/pull/25352#event-2070064617
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 12, 2019https://github.com/nodejs/node/pull/25352#issuecomment-453759471
92e95f1https://github.com/nodejs/node/commit/92e95f17b64838d4cf77343c1a814d4ebd795217
Please reload this pagehttps://github.com/nodejs/node/pull/25352
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 12, 2019https://github.com/nodejs/node/pull/25352#event-2070152992
joyeecheunghttps://github.com/joyeecheung
Jan 12, 2019 https://github.com/nodejs/node/pull/25352#ref-commit-92e95f1
https://github.com/joyeecheung
src: simplify NativeModule caching and remove redundant datahttps://github.com/nodejs/node/commit/92e95f17b64838d4cf77343c1a814d4ebd795217
92e95f1https://github.com/nodejs/node/commit/92e95f17b64838d4cf77343c1a814d4ebd795217
#25352https://github.com/nodejs/node/pull/25352
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 12, 2019 https://github.com/nodejs/node/pull/25352#ref-pullrequest-398386341
module: isolate paths expecting to only use non-internals #25449 https://github.com/nodejs/node/pull/25449
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backport-requested-v11.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v11.x
Jan 15, 2019https://github.com/nodejs/node/pull/25352#event-2076026369
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 15, 2019https://github.com/nodejs/node/pull/25352#issuecomment-454587528
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/25352
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 16, 2019https://github.com/nodejs/node/pull/25352#issuecomment-454797254
Please reload this pagehttps://github.com/nodejs/node/pull/25352
Please reload this pagehttps://github.com/nodejs/node/pull/25352
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
backported-to-v11.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v11.x
backport-requested-v11.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v11.x
Jan 16, 2019https://github.com/nodejs/node/pull/25352#event-2077534728
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 16, 2019https://github.com/nodejs/node/pull/25352#issuecomment-454807388
#25481https://github.com/nodejs/node/pull/25481
Please reload this pagehttps://github.com/nodejs/node/pull/25352
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 16, 2019 https://github.com/nodejs/node/pull/25352#ref-pullrequest-398704379
src: remove unused variable #25481 https://github.com/nodejs/node/pull/25481
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 23, 2019https://github.com/nodejs/node/pull/25352#issuecomment-456913777
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/25352
https://github.com/targos
targoshttps://github.com/targos
Feb 6, 2019 https://github.com/nodejs/node/pull/25352#ref-issue-397151697
Help wanted: Backporting to v11.x #25403 https://github.com/nodejs/node/issues/25403
antsmartianhttps://github.com/antsmartian
Feb 6, 2019 https://github.com/nodejs/node/pull/25352#ref-commit-7dd4e41
https://github.com/joyeecheung
https://github.com/antsmartian
src: simplify NativeModule caching and remove redundant datahttps://github.com/antsmartian/node/commit/7dd4e41fe52b9d340a4cfc63ea07d965e2c4864b
7dd4e41https://github.com/antsmartian/node/commit/7dd4e41fe52b9d340a4cfc63ea07d965e2c4864b
nodejs#25352https://github.com/nodejs/node/pull/25352
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Feb 6, 2019 https://github.com/nodejs/node/pull/25352#ref-pullrequest-407327565
[v11.x backport] src: simplify NativeModule caching and remove redundant data #25964 https://github.com/nodejs/node/pull/25964
addaleaxhttps://github.com/addaleax
Feb 9, 2019 https://github.com/nodejs/node/pull/25352#ref-commit-b280d90
https://github.com/joyeecheung
https://github.com/addaleax
src: simplify NativeModule caching and remove redundant datahttps://github.com/nodejs/node/commit/b280d9027990c9618dba45c50bb829da158a3db0
b280d90https://github.com/nodejs/node/commit/b280d9027990c9618dba45c50bb829da158a3db0
#25964https://github.com/nodejs/node/pull/25964
#25352https://github.com/nodejs/node/pull/25352
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backported-to-v11.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v11.x
backport-requested-v11.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v11.x
Feb 9, 2019https://github.com/nodejs/node/pull/25352#event-2128453318
https://github.com/targos
targoshttps://github.com/targos
Feb 14, 2019 https://github.com/nodejs/node/pull/25352#ref-pullrequest-410304430
v11.10.0 proposal #26098 https://github.com/nodejs/node/pull/26098
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-nodejs#263 https://github.com/beevelop/docker-nodejs/issues/263
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#286 https://github.com/beevelop/docker-android-nodejs/issues/286
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#287 https://github.com/beevelop/docker-android-nodejs/issues/287
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#288 https://github.com/beevelop/docker-android-nodejs/issues/288
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#289 https://github.com/beevelop/docker-android-nodejs/issues/289
2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#290 https://github.com/beevelop/docker-android-nodejs/issues/290
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25352
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/25352/files/9f0bbce979c6e1b948ac944dfca5dc2707df0daa
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/25352
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/mscdex
https://github.com/addaleax
https://github.com/BridgeAR
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.