René's URL Explorer Experiment


Title: test: make spawnSync() test robust by Trott · Pull Request #2535 · nodejs/node · GitHub

Open Graph Title: test: make spawnSync() test robust by Trott · Pull Request #2535 · nodejs/node

X Title: test: make spawnSync() test robust by Trott · Pull Request #2535 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The test had checked that a timer fired within a period after spawnSync() returns. The result was a test that sometimes was flaky. Because there's no guarantee of how long a timer will take bef...

X Description: The test had checked that a timer fired within a period after spawnSync() returns. The result was a test that sometimes was flaky. Because there's no guarantee of how long a timer will take...

Opengraph URL: https://github.com/nodejs/node/pull/2535

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:51f8ec46-2e06-c477-1e9b-2e6094eaf5ce
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA06:1EEA:2B019F7:3DA813D:6A4FA992
html-safe-noncea6ae34a7843aeeba93cab3862d49bd1da280c7b0d30f6b9a3b09cb55ecc54ec9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTA2OjFFRUE6MkIwMTlGNzozREE4MTNEOjZBNEZBOTkyIiwidmlzaXRvcl9pZCI6IjI2MzEzMTYyODQzOTU3OTAyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb2df94e607c04a26b279fd26008921e1367f93ed3194778891f0379f4b9676fe
hovercard-subject-tagpull_request:43249296
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2535/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/927bedd7782e9b4b4e4569c95307fdb95bd4c6248bfecd8735338f2d344d839b/nodejs/node/pull/2535
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/927bedd7782e9b4b4e4569c95307fdb95bd4c6248bfecd8735338f2d344d839b/nodejs/node/pull/2535
og:image:altThe test had checked that a timer fired within a period after spawnSync() returns. The result was a test that sometimes was flaky. Because there's no guarantee of how long a timer will take bef...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/2535#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2535
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2535
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/2535
Reloadhttps://github.com/nodejs/node/pull/2535
Reloadhttps://github.com/nodejs/node/pull/2535
Please reload this pagehttps://github.com/nodejs/node/pull/2535
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/2535
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 972 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:flaky-test-spawnsynchttps://github.com/Trott/io.js/tree/flaky-test-spawnsync
Conversationhttps://github.com/nodejs/node/pull/2535
Commits1 (1)https://github.com/nodejs/node/pull/2535/commits
Checkshttps://github.com/nodejs/node/pull/2535/checks
Files changedhttps://github.com/nodejs/node/pull/2535/files
test: make spawnSync() test robusthttps://github.com/nodejs/node/pull/2535#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:flaky-test-spawnsynchttps://github.com/Trott/io.js/tree/flaky-test-spawnsync
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 25, 2015https://github.com/nodejs/node/pull/2535#issue-102947584
#2470https://github.com/nodejs/node/issues/2470
Please reload this pagehttps://github.com/nodejs/node/pull/2535
https://github.com/Trott
Trotthttps://github.com/Trott
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Aug 25, 2015https://github.com/nodejs/node/pull/2535#event-391311319
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 25, 2015https://github.com/nodejs/node/pull/2535#issuecomment-134473168
Please reload this pagehttps://github.com/nodejs/node/pull/2535
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 25, 2015https://github.com/nodejs/node/pull/2535#issuecomment-134473498
https://jenkins-iojs.nodesource.com/job/node-test-pull-request/150/https://jenkins-iojs.nodesource.com/job/node-test-pull-request/150/
Please reload this pagehttps://github.com/nodejs/node/pull/2535
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 25, 2015https://github.com/nodejs/node/pull/2535#issuecomment-134562809
Please reload this pagehttps://github.com/nodejs/node/pull/2535
https://github.com/Trott
test: make spawnSync() test robusthttps://github.com/nodejs/node/pull/2535/commits/afbda2c124d118ba1e77b56e81721d96343ccaee
afbda2chttps://github.com/nodejs/node/pull/2535/commits/afbda2c124d118ba1e77b56e81721d96343ccaee
nodejs#2470https://github.com/nodejs/node/issues/2470
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/a928db9692ba196020a870abed19347e48258bc5..afbda2c124d118ba1e77b56e81721d96343ccaee
a928db9https://github.com/nodejs/node/commit/a928db9692ba196020a870abed19347e48258bc5
afbda2chttps://github.com/nodejs/node/commit/afbda2c124d118ba1e77b56e81721d96343ccaee
Compare https://github.com/nodejs/node/compare/a928db9692ba196020a870abed19347e48258bc5..afbda2c124d118ba1e77b56e81721d96343ccaee
August 25, 2015 14:38https://github.com/nodejs/node/pull/2535#event-391734082
Trotthttps://github.com/Trott
Aug 25, 2015 https://github.com/nodejs/node/pull/2535#ref-commit-7e63eb7
https://github.com/Trott
test: make spawnSync() test robusthttps://github.com/nodejs/node/commit/7e63eb7762309487b6681ebff7f24b9fa6f40637
7e63eb7https://github.com/nodejs/node/commit/7e63eb7762309487b6681ebff7f24b9fa6f40637
#2535https://github.com/nodejs/node/pull/2535
#2470https://github.com/nodejs/node/issues/2470
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 25, 2015https://github.com/nodejs/node/pull/2535#issuecomment-134608560
7e63eb7https://github.com/nodejs/node/commit/7e63eb7762309487b6681ebff7f24b9fa6f40637
Please reload this pagehttps://github.com/nodejs/node/pull/2535
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 25, 2015https://github.com/nodejs/node/pull/2535#event-391735968
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 25, 2015 https://github.com/nodejs/node/pull/2535#ref-issue-102225689
Investigate flaky test test-child-process-spawnsync #2470 https://github.com/nodejs/node/issues/2470
Trotthttps://github.com/Trott
Aug 26, 2015 https://github.com/nodejs/node/pull/2535#ref-commit-856baf4
https://github.com/Trott
https://github.com/rvagg
test: make spawnSync() test robusthttps://github.com/nodejs/node/commit/856baf4c67015c612167aa016046667ab9d18677
856baf4https://github.com/nodejs/node/commit/856baf4c67015c612167aa016046667ab9d18677
#2535https://github.com/nodejs/node/pull/2535
#2470https://github.com/nodejs/node/issues/2470
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 27, 2015 https://github.com/nodejs/node/pull/2535#ref-issue-103387409
test failures on smartos while running in parallel #2567 https://github.com/nodejs/node/issues/2567
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Aug 29, 2015 https://github.com/nodejs/node/pull/2535#ref-issue-103815442
Release proposal: v3.3.0 #2607 https://github.com/nodejs/node/issues/2607
https://github.com/rvagg
rvagghttps://github.com/rvagg
Sep 2, 2015 https://github.com/nodejs/node/pull/2535#ref-pullrequest-104406383
Release proposal: v3.3.0 #2640 https://github.com/nodejs/node/pull/2640
jsonnhttps://github.com/jsonn
Sep 9, 2015 https://github.com/nodejs/node/pull/2535#ref-commit-33b3766
Update to 4.0.0https://github.com/jsonn/pkgsrc/commit/33b3766530c9de4a54b95c97cc3f1c4dfc57c845
33b3766https://github.com/jsonn/pkgsrc/commit/33b3766530c9de4a54b95c97cc3f1c4dfc57c845
https://github.com/Trott
Trotthttps://github.com/Trott
January 9, 2022 22:02https://github.com/nodejs/node/pull/2535#event-5862810234
https://github.com/leonardoadame
leonardoadamehttps://github.com/leonardoadame
Dec 19, 2023 https://github.com/nodejs/node/pull/2535#ref-pullrequest-2049423408
[Snyk] Fix for 4 vulnerabilities leonardoadame/node#583 https://github.com/leonardoadame/node/pull/583
https://github.com/ryan-ally
ryan-allyhttps://github.com/ryan-ally
Dec 19, 2023 https://github.com/nodejs/node/pull/2535#ref-pullrequest-2049592429
[Snyk] Fix for 6 vulnerabilities ryan-ally/node#98 https://github.com/ryan-ally/node/pull/98
https://github.com/aliscco
alisccohttps://github.com/aliscco
Dec 20, 2023 https://github.com/nodejs/node/pull/2535#ref-pullrequest-2049810358
[Snyk] Fix for 6 vulnerabilities aliscco/alisco-node#1174 https://github.com/aliscco/alisco-node/pull/1174
https://github.com/baby636
baby636https://github.com/baby636
Dec 20, 2023 https://github.com/nodejs/node/pull/2535#ref-pullrequest-2049907560
[Snyk] Fix for 6 vulnerabilities baby636/node#124 https://github.com/baby636/node/pull/124
[Snyk] Fix for 6 vulnerabilities MaxMood96/node#40 https://github.com/MaxMood96/node/pull/40
[Snyk] Fix for 6 vulnerabilities Mement-Mori/node#36 https://github.com/Mement-Mori/node/pull/36
mskhttps://github.com/msk
May 11, 2026 https://github.com/nodejs/node/pull/2535#ref-commit-e40913a
https://github.com/ryoon
Update to 4.0.0https://github.com/msk/pkgsrc/commit/e40913a84d8a2f34a1cfb92bd22db143bc1e0c52
e40913ahttps://github.com/msk/pkgsrc/commit/e40913a84d8a2f34a1cfb92bd22db143bc1e0c52
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2535
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/2535
https://github.com/Trott
https://github.com/bnoordhuis
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.