| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:acaabd6c-13a3-0c95-1d34-326820306b0a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D1DA:177F6A:2BA968A:3D2A6AF:6A50DD26 |
| html-safe-nonce | 5208820fa3e88fd5871acf5423fcf9f369ec9cf57890994df66f8ed8007d896b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMURBOjE3N0Y2QToyQkE5NjhBOjNEMkE2QUY6NkE1MEREMjYiLCJ2aXNpdG9yX2lkIjoiNzAwODg4NzMyMTcyNzY1NTIwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e656508eb2d3c1532daca9951a77ed0f365d679405c3108101f9ed14499667d4 |
| hovercard-subject-tag | pull_request:241390354 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25258/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/98cdc4e6eb5730aca8a8df1caed25aa98d304225272fd9fa3d4595044b0c7c04/nodejs/node/pull/25258 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/98cdc4e6eb5730aca8a8df1caed25aa98d304225272fd9fa3d4595044b0c7c04/nodejs/node/pull/25258 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines
Re: #24861 (c... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | 72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 17290b65caabb92b271e0949d1bf147b63deab41 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25258#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25258 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25258 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25258 |
| Reload | https://github.com/nodejs/node/pull/25258 |
| Reload | https://github.com/nodejs/node/pull/25258 |
| Please reload this page | https://github.com/nodejs/node/pull/25258 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25258 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
979
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:v11.x-staging | https://github.com/nodejs/node/tree/v11.x-staging |
| gabrielschulhof:backport-24861-to-v11.x | https://github.com/gabrielschulhof/node/tree/backport-24861-to-v11.x |
| Conversation | https://github.com/nodejs/node/pull/25258 |
| Commits2 (2) | https://github.com/nodejs/node/pull/25258/commits |
| Checks | https://github.com/nodejs/node/pull/25258/checks |
| Files changed | https://github.com/nodejs/node/pull/25258/files |
| [v11.x-backport] Backport 24861 to v11.x | https://github.com/nodejs/node/pull/25258#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:v11.x-staging | https://github.com/nodejs/node/tree/v11.x-staging |
| gabrielschulhof:backport-24861-to-v11.x | https://github.com/gabrielschulhof/node/tree/backport-24861-to-v11.x |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 28, 2018 | https://github.com/nodejs/node/pull/25258#issue-394712202 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| #24861 (comment) | https://github.com/nodejs/node/pull/24861#event-2046977683 |
| Please reload this page | https://github.com/nodejs/node/pull/25258 |
| addaleax | https://github.com/addaleax |
| December 28, 2018 11:30 | https://github.com/nodejs/node/pull/25258#commits-pushed-1c2b202 |
|
| https://github.com/addaleax |
| test,doc: add tests and docs for addon unloading | https://github.com/nodejs/node/pull/25258/commits/1c2b202227d0ccf34455f075fdcfb9f31c424f3b |
| 1c2b202 | https://github.com/nodejs/node/pull/25258/commits/1c2b202227d0ccf34455f075fdcfb9f31c424f3b |
| nodejs#23319 | https://github.com/nodejs/node/pull/23319 |
| nodejs#24861 | https://github.com/nodejs/node/pull/24861 |
| src: unload addons when environment quits | https://github.com/nodejs/node/pull/25258/commits/fdf2e3c1155ced426c1f721d768107ab85858c62 |
| fdf2e3c | https://github.com/nodejs/node/pull/25258/commits/fdf2e3c1155ced426c1f721d768107ab85858c62 |
| nodejs#23319 | https://github.com/nodejs/node/pull/23319 |
| nodejs#24861 | https://github.com/nodejs/node/pull/24861 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 28, 2018 | https://github.com/nodejs/node/pull/25258#issuecomment-450421033 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2095/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2095/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25258 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
v11.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av11.x |
| Dec 28, 2018 | https://github.com/nodejs/node/pull/25258#event-2047678177 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Dec 29, 2018 | https://github.com/nodejs/node/pull/25258#issuecomment-450472251 |
| Please reload this page | https://github.com/nodejs/node/pull/25258 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 31, 2018 | https://github.com/nodejs/node/pull/25258#issuecomment-450685433 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/25258 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 31, 2018 | https://github.com/nodejs/node/pull/25258#issuecomment-450693337 |
| https://ci.nodejs.org/job/node-test-pull-request/19899/ | https://ci.nodejs.org/job/node-test-pull-request/19899/ |
| Please reload this page | https://github.com/nodejs/node/pull/25258 |
| targos | https://github.com/targos |
|
Jan 1, 2019
| https://github.com/nodejs/node/pull/25258#ref-commit-95353c7 |
|
| https://github.com/addaleax |
|
| https://github.com/targos |
| test,doc: add tests and docs for addon unloading | https://github.com/nodejs/node/commit/95353c7c207866a738196e6381b7ccf6e2c87773 |
| 95353c7 | https://github.com/nodejs/node/commit/95353c7c207866a738196e6381b7ccf6e2c87773 |
| #23319 | https://github.com/nodejs/node/pull/23319 |
| #25258 | https://github.com/nodejs/node/pull/25258 |
| #24861 | https://github.com/nodejs/node/pull/24861 |
| targos | https://github.com/targos |
|
Jan 1, 2019
| https://github.com/nodejs/node/pull/25258#ref-commit-d718625 |
|
| https://github.com/targos |
| src: unload addons when environment quits | https://github.com/nodejs/node/commit/d7186252df043bdb693b47f34898e39a32b2c70a |
| d718625 | https://github.com/nodejs/node/commit/d7186252df043bdb693b47f34898e39a32b2c70a |
| #23319 | https://github.com/nodejs/node/pull/23319 |
| #25258 | https://github.com/nodejs/node/pull/25258 |
| #24861 | https://github.com/nodejs/node/pull/24861 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jan 1, 2019 | https://github.com/nodejs/node/pull/25258#issuecomment-450736778 |
| 95353c7 | https://github.com/nodejs/node/commit/95353c7c207866a738196e6381b7ccf6e2c87773 |
| d718625 | https://github.com/nodejs/node/commit/d7186252df043bdb693b47f34898e39a32b2c70a |
| Please reload this page | https://github.com/nodejs/node/pull/25258 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jan 1, 2019 | https://github.com/nodejs/node/pull/25258#event-2049488443 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jan 3, 2019 | https://github.com/nodejs/node/pull/25258#issuecomment-451248211 |
| Please reload this page | https://github.com/nodejs/node/pull/25258 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 18, 2019
| https://github.com/nodejs/node/pull/25258#ref-pullrequest-399868555 |
|
v11.7.0 proposal
#25537
| https://github.com/nodejs/node/pull/25537 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 18, 2019 | https://github.com/nodejs/node/pull/25258#issuecomment-455722960 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/25258 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| June 14, 2019 23:51 | https://github.com/nodejs/node/pull/25258#event-2415099489 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25258 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/25258 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/targos |
|
| https://github.com/MylesBorins |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |