| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ee1264b5-71b3-fbda-d279-53253119af83 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D994:4F8A:1BDC498:26023CC:6A4F138C |
| html-safe-nonce | a56a5d532129c6116208223361e7c904cfd66af409814ea35dee75fdf14bdedb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTk0OjRGOEE6MUJEQzQ5ODoyNjAyM0NDOjZBNEYxMzhDIiwidmlzaXRvcl9pZCI6IjU3Mjg5Nzk3Nzg5NjAwMzY3NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0d3c6e4598475bd9151ed7b88023d8990bca168d232c5e854b94425f612a1eda |
| hovercard-subject-tag | pull_request:240659222 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25188/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/069dfa423a4db6fa0c3c11d39cf884a90d683aaba9d3504133ef3698a1b3891a/nodejs/node/pull/25188 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/069dfa423a4db6fa0c3c11d39cf884a90d683aaba9d3504133ef3698a1b3891a/nodejs/node/pull/25188 |
| og:image:alt | Tests in pummel seem to break often and stay broken because they don't
get run in CI. In preparation for running pummel tests in CI once a day,
this fixes test-tls-session-timeout. key and cert... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25188#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25188 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25188 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25188 |
| Reload | https://github.com/nodejs/node/pull/25188 |
| Reload | https://github.com/nodejs/node/pull/25188 |
| Please reload this page | https://github.com/nodejs/node/pull/25188 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25188 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
967
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:fix-pummel-1 | https://github.com/Trott/io.js/tree/fix-pummel-1 |
| Conversation | https://github.com/nodejs/node/pull/25188 |
| Commits2 (2) | https://github.com/nodejs/node/pull/25188/commits |
| Checks | https://github.com/nodejs/node/pull/25188/checks |
| Files changed | https://github.com/nodejs/node/pull/25188/files |
| test: fix test-tls-session-timeout | https://github.com/nodejs/node/pull/25188#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:fix-pummel-1 | https://github.com/Trott/io.js/tree/fix-pummel-1 |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 23, 2018 | https://github.com/nodejs/node/pull/25188#issue-393712506 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25188 |
|
| https://github.com/Trott |
| test: fix test-tls-session-timeout | https://github.com/nodejs/node/pull/25188/commits/f183551526ab5f26a235a59a7f7f501e84787e76 |
| f183551 | https://github.com/nodejs/node/pull/25188/commits/f183551526ab5f26a235a59a7f7f501e84787e76 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 23, 2018 | https://github.com/nodejs/node/pull/25188#issuecomment-449605820 |
| @Trott | https://github.com/Trott |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2044/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2044/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25188 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Dec 23, 2018 | https://github.com/nodejs/node/pull/25188#event-2042299666 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 23, 2018 | https://github.com/nodejs/node/pull/25188#issuecomment-449605823 |
| Please reload this page | https://github.com/nodejs/node/pull/25188 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 23, 2018 | https://github.com/nodejs/node/pull/25188#issuecomment-449605829 |
| Please reload this page | https://github.com/nodejs/node/pull/25188 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Dec 23, 2018
| https://github.com/nodejs/node/pull/25188#pullrequestreview-187609135 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25188/files/f183551526ab5f26a235a59a7f7f501e84787e76 |
| test/pummel/test-tls-session-timeout.js | https://github.com/nodejs/node/pull/25188/files/f183551526ab5f26a235a59a7f7f501e84787e76#diff-2b60036b846e0be33b8f018de1a02cca117ea47604aa6795e7d8ff93d7555b5a |
| Please reload this page | https://github.com/nodejs/node/pull/25188 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Dec 23, 2018
| https://github.com/nodejs/node/pull/25188#pullrequestreview-187609824 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25188/files/f183551526ab5f26a235a59a7f7f501e84787e76 |
|
| https://github.com/Trott |
| fixup! test: fix test-tls-session-timeout | https://github.com/nodejs/node/pull/25188/commits/962ef6e4c0505d00e788ef972a25531bc3382f52 |
| 962ef6e | https://github.com/nodejs/node/pull/25188/commits/962ef6e4c0505d00e788ef972a25531bc3382f52 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 24, 2018 | https://github.com/nodejs/node/pull/25188#issuecomment-449756281 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2058/ | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2058/ |
| Please reload this page | https://github.com/nodejs/node/pull/25188 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 25, 2018 | https://github.com/nodejs/node/pull/25188#issuecomment-449806108 |
| 9391638 | https://github.com/nodejs/node/commit/9391638f88ee33f94686be8bf44d698b767d2b66 |
| Please reload this page | https://github.com/nodejs/node/pull/25188 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 25, 2018 | https://github.com/nodejs/node/pull/25188#event-2043555207 |
| Trott | https://github.com/Trott |
|
Dec 25, 2018
| https://github.com/nodejs/node/pull/25188#ref-commit-9391638 |
|
| https://github.com/Trott |
| test: fix test-tls-session-timeout | https://github.com/Trott/io.js/commit/9391638f88ee33f94686be8bf44d698b767d2b66 |
| 9391638 | https://github.com/Trott/io.js/commit/9391638f88ee33f94686be8bf44d698b767d2b66 |
| nodejs#25188 | https://github.com/nodejs/node/pull/25188 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 25, 2018
| https://github.com/nodejs/node/pull/25188#ref-commit-9c2e97e |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: fix test-tls-session-timeout | https://github.com/nodejs/node/commit/9c2e97e421e8f7dd4958609472f7dbd4c54b7ef0 |
| 9c2e97e | https://github.com/nodejs/node/commit/9c2e97e421e8f7dd4958609472f7dbd4c54b7ef0 |
| #25188 | https://github.com/nodejs/node/pull/25188 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 25, 2018
| https://github.com/nodejs/node/pull/25188#ref-pullrequest-393620382 |
|
v11.6.0 proposal
#25175
| https://github.com/nodejs/node/pull/25175 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 26, 2018
| https://github.com/nodejs/node/pull/25188#ref-commit-45d4851 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: fix test-tls-session-timeout | https://github.com/nodejs/node/commit/45d48510bd4dcc4de27ce4b7c6811336b775abd8 |
| 45d4851 | https://github.com/nodejs/node/commit/45d48510bd4dcc4de27ce4b7c6811336b775abd8 |
| #25188 | https://github.com/nodejs/node/pull/25188 |
| refack | https://github.com/refack |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/25188#ref-commit-dd5b0a8 |
|
| https://github.com/Trott |
|
| https://github.com/refack |
| test: fix test-tls-session-timeout | https://github.com/refack/node/commit/dd5b0a874ab03cd88ae1d059ba7a3fa53aee3532 |
| dd5b0a8 | https://github.com/refack/node/commit/dd5b0a874ab03cd88ae1d059ba7a3fa53aee3532 |
| nodejs#25188 | https://github.com/nodejs/node/pull/25188 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 17, 2019
| https://github.com/nodejs/node/pull/25188#ref-commit-421750f |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| test: fix test-tls-session-timeout | https://github.com/nodejs/node/commit/421750f4e6d8c205befb0e491905f74615c279f8 |
| 421750f | https://github.com/nodejs/node/commit/421750f4e6d8c205befb0e491905f74615c279f8 |
| #25188 | https://github.com/nodejs/node/pull/25188 |
| BethGriggs | https://github.com/BethGriggs |
|
Apr 28, 2019
| https://github.com/nodejs/node/pull/25188#ref-commit-fb977e7 |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| test: fix test-tls-session-timeout | https://github.com/nodejs/node/commit/fb977e7c43182afaab02451a9b107847667e8db2 |
| fb977e7 | https://github.com/nodejs/node/commit/fb977e7c43182afaab02451a9b107847667e8db2 |
| #25188 | https://github.com/nodejs/node/pull/25188 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
May 1, 2019
| https://github.com/nodejs/node/pull/25188#ref-pullrequest-439147711 |
|
v10.16.0 proposal
#27514
| https://github.com/nodejs/node/pull/27514 |
| BethGriggs | https://github.com/BethGriggs |
|
May 10, 2019
| https://github.com/nodejs/node/pull/25188#ref-commit-51f440f |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| test: fix test-tls-session-timeout | https://github.com/nodejs/node/commit/51f440f82fa790eae2e8dcc6ea70f873f8b686b1 |
| 51f440f | https://github.com/nodejs/node/commit/51f440f82fa790eae2e8dcc6ea70f873f8b686b1 |
| #25188 | https://github.com/nodejs/node/pull/25188 |
| MylesBorins | https://github.com/MylesBorins |
|
May 16, 2019
| https://github.com/nodejs/node/pull/25188#ref-commit-6014b47 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: fix test-tls-session-timeout | https://github.com/nodejs/node/commit/6014b476c3f001ee2a4f0e37493c5639ceae5cef |
| 6014b47 | https://github.com/nodejs/node/commit/6014b476c3f001ee2a4f0e37493c5639ceae5cef |
| #25188 | https://github.com/nodejs/node/pull/25188 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#315
| https://github.com/beevelop/docker-android-nodejs/issues/315 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#316
| https://github.com/beevelop/docker-android-nodejs/issues/316 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#317
| https://github.com/beevelop/docker-android-nodejs/issues/317 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#318
| https://github.com/beevelop/docker-android-nodejs/issues/318 |
|
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs
beevelop/docker-android-nodejs#319
| https://github.com/beevelop/docker-android-nodejs/issues/319 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:50 | https://github.com/nodejs/node/pull/25188#event-5890971168 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25188 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/25188/files/f183551526ab5f26a235a59a7f7f501e84787e76 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/25188/files/f183551526ab5f26a235a59a7f7f501e84787e76 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/25188 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |