| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8746a80b-d4f3-a943-a503-8f34f303e260 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B834:34D244:2FE0938:431BF85:6A4F7CC2 |
| html-safe-nonce | 175c51a000cdae2f9edada34ce5f4d1a3c141874a143a3108cc0291ebd52b244 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODM0OjM0RDI0NDoyRkUwOTM4OjQzMUJGODU6NkE0RjdDQzIiLCJ2aXNpdG9yX2lkIjoiNDkwNDg1NzYxNDUwMjgyMTA1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c203ffc5a108a2542ac2096b7ade4f99432b087085f655ce4a9545e626ce774a |
| hovercard-subject-tag | pull_request:240559828 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25171/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/997a86c502e1ce11c2606364e5f06e8e3a50c01296f5389bf2beed607824ef85/nodejs/node/pull/25171 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/997a86c502e1ce11c2606364e5f06e8e3a50c01296f5389bf2beed607824ef85/nodejs/node/pull/25171 |
| og:image:alt | backport of #24811
Did not backport 436f4de (not applicable to legacy option parser)
632f263 needed to be recreated from scratch PTAL... comments inline about major differences |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MylesBorins |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25171#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25171 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25171 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25171 |
| Reload | https://github.com/nodejs/node/pull/25171 |
| Reload | https://github.com/nodejs/node/pull/25171 |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| MylesBorins | https://github.com/MylesBorins |
| nodejs:v8.x-staging | https://github.com/nodejs/node/tree/v8.x-staging |
| MylesBorins:header-option-backport-8.x | https://github.com/MylesBorins/node/tree/header-option-backport-8.x |
| Conversation | https://github.com/nodejs/node/pull/25171 |
| Commits2 (2) | https://github.com/nodejs/node/pull/25171/commits |
| Checks | https://github.com/nodejs/node/pull/25171/checks |
| Files changed | https://github.com/nodejs/node/pull/25171/files |
| [v8.x] cli: add --max-http-header-size flag | https://github.com/nodejs/node/pull/25171#top |
| MylesBorins | https://github.com/MylesBorins |
| nodejs:v8.x-staging | https://github.com/nodejs/node/tree/v8.x-staging |
| MylesBorins:header-option-backport-8.x | https://github.com/MylesBorins/node/tree/header-option-backport-8.x |
|
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#issue-393568222 |
| #24811 | https://github.com/nodejs/node/pull/24811 |
| 436f4de | https://github.com/nodejs/node/commit/436f4de38f511508710eb1492f4d23a9f427e7f7 |
| 632f263 | https://github.com/nodejs/node/commit/632f2633249dc0f295e9d2abab33baaf0f75ce6f |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| deps: cherry-pick http_parser_set_max_header_size | https://github.com/nodejs/node/pull/25171/commits/74e376d78d6118f9dc5448a43b220c29457094e7 |
| 74e376d | https://github.com/nodejs/node/pull/25171/commits/74e376d78d6118f9dc5448a43b220c29457094e7 |
| nodejs#24811 | https://github.com/nodejs/node/pull/24811 |
| nodejs#24692 | https://github.com/nodejs/node/issues/24692 |
| nodejs/http-parser#453 | https://github.com/nodejs/http-parser/pull/453 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#issuecomment-449478946 |
| @MylesBorins | https://github.com/MylesBorins |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2030/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2030/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av8.x |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#event-2041507049 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| addaleax | https://github.com/addaleax |
| mcollina | https://github.com/mcollina |
| December 21, 2018 19:33 | https://github.com/nodejs/node/pull/25171#event-2041507057 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25171#pullrequestreview-187514410 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25171/files |
| doc/node.1 | https://github.com/nodejs/node/pull/25171/files#diff-6319d8667880c119404aad5631a45e33a1ee70a4201282049872ac9d5d6f9295 |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#discussion_r243673659 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| src/node.cc | https://github.com/nodejs/node/pull/25171/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#discussion_r243673721 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| src/node.h | https://github.com/nodejs/node/pull/25171/files#diff-7c19dd5fd5584cd4a8111f4c82a9f49f4aa1bdb9470ad11daa90f3d394a23b4e |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| src/node_config.cc | https://github.com/nodejs/node/pull/25171/files#diff-53943e9637cbf19a6176e5b3610954b224857fbf209f9cbf9f97f03f7739a43f |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#discussion_r243673953 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| addaleax | https://github.com/addaleax |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#discussion_r243674910 |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#discussion_r243684937 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| src/node_http_parser.cc | https://github.com/nodejs/node/pull/25171/files#diff-bbcf7a115fe4680f3a7c076a487c89bd4ce935e7d2a726cfcb3f69331705e25e |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#discussion_r243674005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| test/sequential/test-http-max-http-headers.js | https://github.com/nodejs/node/pull/25171/files#diff-e8fe3db8479ec998bc6697ae9eca14f779c9c0773d024c7f49300924f3f1a699 |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#discussion_r243674126 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/174cf773ba9df7224b625d28e73fb5dcd10c9b6c..92ab0e028a86e4d32942fbe2b4fc6ae3927acb8b |
| 174cf77 | https://github.com/nodejs/node/commit/174cf773ba9df7224b625d28e73fb5dcd10c9b6c |
| 92ab0e0 | https://github.com/nodejs/node/commit/92ab0e028a86e4d32942fbe2b4fc6ae3927acb8b |
|
Compare
| https://github.com/nodejs/node/compare/174cf773ba9df7224b625d28e73fb5dcd10c9b6c..92ab0e028a86e4d32942fbe2b4fc6ae3927acb8b |
| December 21, 2018 19:39 | https://github.com/nodejs/node/pull/25171#event-2041517217 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25171#pullrequestreview-187516177 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25171/files |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25171#ref-pullrequest-386926191 |
|
cli: add --max-http-header-size flag
#24811
| https://github.com/nodejs/node/pull/24811 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#issuecomment-449484588 |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/92ab0e028a86e4d32942fbe2b4fc6ae3927acb8b..73b53e1f798398a797195472009c631516849cf7 |
| 92ab0e0 | https://github.com/nodejs/node/commit/92ab0e028a86e4d32942fbe2b4fc6ae3927acb8b |
| 73b53e1 | https://github.com/nodejs/node/commit/73b53e1f798398a797195472009c631516849cf7 |
|
Compare
| https://github.com/nodejs/node/compare/92ab0e028a86e4d32942fbe2b4fc6ae3927acb8b..73b53e1f798398a797195472009c631516849cf7 |
| December 21, 2018 20:25 | https://github.com/nodejs/node/pull/25171#event-2041595854 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#issuecomment-449490179 |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| https://ci.nodejs.org/job/node-test-pull-request/19726/ | https://ci.nodejs.org/job/node-test-pull-request/19726/ |
| https://ci.nodejs.org/job/node-test-pull-request/19727/ | https://ci.nodejs.org/job/node-test-pull-request/19727/ |
| arm failure | https://ci.nodejs.org/job/node-test-binary-arm/5070/RUN_SUBSET=1,label=pi3-docker/testReport/junit/(root)/test/parallel_test_http2_compat_serverresponse_settimeout/ |
| https://ci.nodejs.org/job/node-test-commit-arm-fanned/5329/ | https://ci.nodejs.org/job/node-test-commit-arm-fanned/5329/ |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
|
| https://github.com/cjihrig |
|
| https://github.com/mcollina |
|
| https://github.com/MylesBorins |
| cli: add --max-http-header-size flag | https://github.com/nodejs/node/pull/25171/commits/bc2d3db2556136e229af116917e58bf6d900e7a6 |
| bc2d3db | https://github.com/nodejs/node/pull/25171/commits/bc2d3db2556136e229af116917e58bf6d900e7a6 |
| nodejs#24811 | https://github.com/nodejs/node/pull/24811 |
| nodejs#24692 | https://github.com/nodejs/node/issues/24692 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/73b53e1f798398a797195472009c631516849cf7..bc2d3db2556136e229af116917e58bf6d900e7a6 |
| 73b53e1 | https://github.com/nodejs/node/commit/73b53e1f798398a797195472009c631516849cf7 |
| bc2d3db | https://github.com/nodejs/node/commit/bc2d3db2556136e229af116917e58bf6d900e7a6 |
|
Compare
| https://github.com/nodejs/node/compare/73b53e1f798398a797195472009c631516849cf7..bc2d3db2556136e229af116917e58bf6d900e7a6 |
| December 21, 2018 20:39 | https://github.com/nodejs/node/pull/25171#event-2041614575 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25171#ref-pullrequest-393587525 |
|
[v6.x] cli: add --max-http-header-size flag
#25173
| https://github.com/nodejs/node/pull/25173 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25171#ref-commit-d05760f |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| deps: cherry-pick http_parser_set_max_header_size | https://github.com/nodejs/node/commit/d05760f035d74db2f98d77ba70de6a43a34722e1 |
| d05760f | https://github.com/nodejs/node/commit/d05760f035d74db2f98d77ba70de6a43a34722e1 |
| #25171 | https://github.com/nodejs/node/pull/25171 |
| #24811 | https://github.com/nodejs/node/pull/24811 |
| #24692 | https://github.com/nodejs/node/issues/24692 |
| nodejs/http-parser#453 | https://github.com/nodejs/http-parser/pull/453 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25171#ref-commit-d6c029d |
|
| https://github.com/cjihrig |
|
| https://github.com/mcollina |
|
| https://github.com/MylesBorins |
| cli: add --max-http-header-size flag | https://github.com/nodejs/node/commit/d6c029dbb92dff0b966d38b68d7b6d56e74e2ad4 |
| d6c029d | https://github.com/nodejs/node/commit/d6c029dbb92dff0b966d38b68d7b6d56e74e2ad4 |
| #25171 | https://github.com/nodejs/node/pull/25171 |
| #24811 | https://github.com/nodejs/node/pull/24811 |
| #24692 | https://github.com/nodejs/node/issues/24692 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#issuecomment-449519953 |
| 3812a99...d6c029d | https://github.com/nodejs/node/compare/3812a9953a46ecb0b71e6028c266710e54509e62...d6c029dbb92dff0b966d38b68d7b6d56e74e2ad4 |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#event-2041804452 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25171#pullrequestreview-187561766 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25171/files/bc2d3db2556136e229af116917e58bf6d900e7a6 |
| src/node.cc | https://github.com/nodejs/node/pull/25171/files/bc2d3db2556136e229af116917e58bf6d900e7a6#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a |
| mcollina | https://github.com/mcollina |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25171#discussion_r243710609 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25171#ref-commit-c713b4f |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| deps: cherry-pick http_parser_set_max_header_size | https://github.com/nodejs/node/commit/c713b4f599f3573de5af062f1b6f82944bf281ba |
| c713b4f | https://github.com/nodejs/node/commit/c713b4f599f3573de5af062f1b6f82944bf281ba |
| #25171 | https://github.com/nodejs/node/pull/25171 |
| #24811 | https://github.com/nodejs/node/pull/24811 |
| #24692 | https://github.com/nodejs/node/issues/24692 |
| nodejs/http-parser#453 | https://github.com/nodejs/http-parser/pull/453 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25171#ref-commit-665d415 |
|
| https://github.com/cjihrig |
|
| https://github.com/mcollina |
|
| https://github.com/MylesBorins |
| cli: add --max-http-header-size flag | https://github.com/nodejs/node/commit/665d415a102066d1844265eafceec8f51b3c4cc6 |
| 665d415 | https://github.com/nodejs/node/commit/665d415a102066d1844265eafceec8f51b3c4cc6 |
| #25171 | https://github.com/nodejs/node/pull/25171 |
| #24811 | https://github.com/nodejs/node/pull/24811 |
| #24692 | https://github.com/nodejs/node/issues/24692 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 22, 2018
| https://github.com/nodejs/node/pull/25171#ref-commit-4fb5a1b |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| deps: cherry-pick http_parser_set_max_header_size | https://github.com/nodejs/node/commit/4fb5a1be2fa5dd8a70be9d5b85da512eb4cedac5 |
| 4fb5a1b | https://github.com/nodejs/node/commit/4fb5a1be2fa5dd8a70be9d5b85da512eb4cedac5 |
| #25171 | https://github.com/nodejs/node/pull/25171 |
| #24811 | https://github.com/nodejs/node/pull/24811 |
| #24692 | https://github.com/nodejs/node/issues/24692 |
| nodejs/http-parser#453 | https://github.com/nodejs/http-parser/pull/453 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 22, 2018
| https://github.com/nodejs/node/pull/25171#ref-commit-693e362 |
|
| https://github.com/cjihrig |
|
| https://github.com/mcollina |
|
| https://github.com/MylesBorins |
| cli: add --max-http-header-size flag | https://github.com/nodejs/node/commit/693e362175cf50dfa90dff5343a5870dee54ff5f |
| 693e362 | https://github.com/nodejs/node/commit/693e362175cf50dfa90dff5343a5870dee54ff5f |
| #25171 | https://github.com/nodejs/node/pull/25171 |
| #24811 | https://github.com/nodejs/node/pull/24811 |
| #24692 | https://github.com/nodejs/node/issues/24692 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25171 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/25171/files/bc2d3db2556136e229af116917e58bf6d900e7a6 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/25171/files/174cf773ba9df7224b625d28e73fb5dcd10c9b6c |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/25171 |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |