| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:77ca090a-7305-0cd3-8622-4dc24a679a49 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B2BC:1EEA:16F2FE8:20A3B2A:6A4F694A |
| html-safe-nonce | 6d9454b4bd7fbae725ad87d288404330f2be4a4559d2f2b6a5e8ca2f6db69bfe |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkJDOjFFRUE6MTZGMkZFODoyMEEzQjJBOjZBNEY2OTRBIiwidmlzaXRvcl9pZCI6IjU2MTE2MDEyOTkxNzI3MTQ4MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6051b84dfb9f079bd1d8b54344a8decad10215f1a90c24c85b0128fd661851cd |
| hovercard-subject-tag | pull_request:240538673 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25167/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5e032f716fcaf0413cbcb625d9b53eb042190e99cd7d82951083fe8e8fe11b15/nodejs/node/pull/25167 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5e032f716fcaf0413cbcb625d9b53eb042190e99cd7d82951083fe8e8fe11b15/nodejs/node/pull/25167 |
| og:image:alt | This is a big change set but one that can be broken down into many smaller pull requests for easier review if necessary.
This adds common.relaunchWithFlags() along with two useful-but-not-strictly-... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25167#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25167 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25167 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25167 |
| Reload | https://github.com/nodejs/node/pull/25167 |
| Reload | https://github.com/nodejs/node/pull/25167 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
971
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:flags | https://github.com/Trott/io.js/tree/flags |
| Conversation | https://github.com/nodejs/node/pull/25167 |
| Commits40 (40) | https://github.com/nodejs/node/pull/25167/commits |
| Checks | https://github.com/nodejs/node/pull/25167/checks |
| Files changed | https://github.com/nodejs/node/pull/25167/files |
| test,tools: move Flags: comment processing from Python to JavaScript | https://github.com/nodejs/node/pull/25167#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:flags | https://github.com/Trott/io.js/tree/flags |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25167#issue-393540931 |
| Suggestion: New Python & GYP strategic initiative or working group TSC#642 | https://github.com/nodejs/TSC/issues/642 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-449454454 |
| @Trott | https://github.com/Trott |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2027/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2027/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25167#event-2041338998 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-449455568 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-449459087 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/f718069076f228e8bbdd1ead48f8287d9761a866..8c05e2cfb83654050d3fb36c70dec41b38fb22dd |
| f718069 | https://github.com/nodejs/node/commit/f718069076f228e8bbdd1ead48f8287d9761a866 |
| 8c05e2c | https://github.com/nodejs/node/commit/8c05e2cfb83654050d3fb36c70dec41b38fb22dd |
|
Compare
| https://github.com/nodejs/node/compare/f718069076f228e8bbdd1ead48f8287d9761a866..8c05e2cfb83654050d3fb36c70dec41b38fb22dd |
| December 21, 2018 19:34 | https://github.com/nodejs/node/pull/25167#event-2041508427 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-449479286 |
| https://ci.nodejs.org/job/node-test-pull-request/19724/ | https://ci.nodejs.org/job/node-test-pull-request/19724/ |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25167#pullrequestreview-187516744 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25167/files |
| doc/guides/writing-tests.md | https://github.com/nodejs/node/pull/25167/files#diff-3f15d4bee56a731494b667bd58f86f186b129a4439c29b03785c6826a8ce931e |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| doc/guides/writing-tests.md | https://github.com/nodejs/node/pull/25167/files#diff-3f15d4bee56a731494b667bd58f86f186b129a4439c29b03785c6826a8ce931e |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| doc/guides/writing-tests.md | https://github.com/nodejs/node/pull/25167/files#diff-3f15d4bee56a731494b667bd58f86f186b129a4439c29b03785c6826a8ce931e |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/c8db3b7ec2fbe7c8705977d19d67f22ea6bc93ad..6d4ecb68c16555cb4b3c20ecb48e9b9e139ed19b |
| c8db3b7 | https://github.com/nodejs/node/commit/c8db3b7ec2fbe7c8705977d19d67f22ea6bc93ad |
| 6d4ecb6 | https://github.com/nodejs/node/commit/6d4ecb68c16555cb4b3c20ecb48e9b9e139ed19b |
|
Compare
| https://github.com/nodejs/node/compare/c8db3b7ec2fbe7c8705977d19d67f22ea6bc93ad..6d4ecb68c16555cb4b3c20ecb48e9b9e139ed19b |
| December 21, 2018 21:18 | https://github.com/nodejs/node/pull/25167#event-2041670247 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-449500831 |
| https://ci.nodejs.org/job/node-test-pull-request/19729/ | https://ci.nodejs.org/job/node-test-pull-request/19729/ |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/6d4ecb68c16555cb4b3c20ecb48e9b9e139ed19b..fc8324d4be21ebd226f548c0f63f8744e0046e95 |
| 6d4ecb6 | https://github.com/nodejs/node/commit/6d4ecb68c16555cb4b3c20ecb48e9b9e139ed19b |
| fc8324d | https://github.com/nodejs/node/commit/fc8324d4be21ebd226f548c0f63f8744e0046e95 |
|
Compare
| https://github.com/nodejs/node/compare/6d4ecb68c16555cb4b3c20ecb48e9b9e139ed19b..fc8324d4be21ebd226f548c0f63f8744e0046e95 |
| December 22, 2018 01:51 | https://github.com/nodejs/node/pull/25167#event-2041912300 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 22, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-449536644 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://ci.nodejs.org/job/node-test-pull-request/19736/ | https://ci.nodejs.org/job/node-test-pull-request/19736/ |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Dec 22, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-449537806 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 22, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-449570816 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/4bac563b5b6e6cff0e280b24e8ef05f211a0a9b1..7a7fd9dfb1c98ce279e6e358a052f9dbb61396aa |
| 4bac563 | https://github.com/nodejs/node/commit/4bac563b5b6e6cff0e280b24e8ef05f211a0a9b1 |
| 7a7fd9d | https://github.com/nodejs/node/commit/7a7fd9dfb1c98ce279e6e358a052f9dbb61396aa |
|
Compare
| https://github.com/nodejs/node/compare/4bac563b5b6e6cff0e280b24e8ef05f211a0a9b1..7a7fd9dfb1c98ce279e6e358a052f9dbb61396aa |
| December 27, 2018 16:34 | https://github.com/nodejs/node/pull/25167#event-2046148218 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 27, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-450186094 |
| @richardlau | https://github.com/richardlau |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 27, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-450214611 |
| https://ci.nodejs.org/job/node-test-pull-request/19844/ | https://ci.nodejs.org/job/node-test-pull-request/19844/ |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/7a7fd9dfb1c98ce279e6e358a052f9dbb61396aa..d79b58b59c6517e92b111a328e03709a7a677f7b |
| 7a7fd9d | https://github.com/nodejs/node/commit/7a7fd9dfb1c98ce279e6e358a052f9dbb61396aa |
| d79b58b | https://github.com/nodejs/node/commit/d79b58b59c6517e92b111a328e03709a7a677f7b |
|
Compare
| https://github.com/nodejs/node/compare/7a7fd9dfb1c98ce279e6e358a052f9dbb61396aa..d79b58b59c6517e92b111a328e03709a7a677f7b |
| December 27, 2018 20:15 | https://github.com/nodejs/node/pull/25167#event-2046388448 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 27, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-450223365 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://ci.nodejs.org/job/node-test-pull-request/19845/ | https://ci.nodejs.org/job/node-test-pull-request/19845/ |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 27, 2018
| https://github.com/nodejs/node/pull/25167#pullrequestreview-188174249 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25167/files |
| BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/25167#pullrequestreview-188174249 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| test/common/index.js | https://github.com/nodejs/node/pull/25167/files#diff-f75d7f53e0dbb5033126f9e985a67109aecee73364c6f41e6e2c125178ab48bb |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| test/common/index.js | https://github.com/nodejs/node/pull/25167/files#diff-f75d7f53e0dbb5033126f9e985a67109aecee73364c6f41e6e2c125178ab48bb |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| test/common/index.js | https://github.com/nodejs/node/pull/25167/files#diff-f75d7f53e0dbb5033126f9e985a67109aecee73364c6f41e6e2c125178ab48bb |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| test/common/index.js | https://github.com/nodejs/node/pull/25167/files#diff-f75d7f53e0dbb5033126f9e985a67109aecee73364c6f41e6e2c125178ab48bb |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| test/parallel/test-buffer-of-no-deprecation.js | https://github.com/nodejs/node/pull/25167/files#diff-347beea9554f9922abbb83d5517619ada64de91b7ec1e3814d8da5beba6d3f8c |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| test/sequential/test-inspector-overwrite-config.js | https://github.com/nodejs/node/pull/25167/files#diff-57af3cf6d5bcdecd83ea0cb8027b1f31f720fc97a1d1a87d0180eccd96263ba8 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| test/common/index.js | https://github.com/nodejs/node/pull/25167/files#diff-f75d7f53e0dbb5033126f9e985a67109aecee73364c6f41e6e2c125178ab48bb |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| test/es-module/test-esm-loader-invalid-format.mjs | https://github.com/nodejs/node/pull/25167/files#diff-243174376f103573ab73526ca9142c62c73a3c5ab32a302a16966494e4246734 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| Dec 27, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-450235105 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 27, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-450252064 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/d79b58b59c6517e92b111a328e03709a7a677f7b..a9dd2918f6f510b2620320632b93d28dd6ec677a |
| d79b58b | https://github.com/nodejs/node/commit/d79b58b59c6517e92b111a328e03709a7a677f7b |
| a9dd291 | https://github.com/nodejs/node/commit/a9dd2918f6f510b2620320632b93d28dd6ec677a |
|
Compare
| https://github.com/nodejs/node/compare/d79b58b59c6517e92b111a328e03709a7a677f7b..a9dd2918f6f510b2620320632b93d28dd6ec677a |
| December 28, 2018 00:01 | https://github.com/nodejs/node/pull/25167#event-2046572430 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Dec 29, 2018 | https://github.com/nodejs/node/pull/25167#issuecomment-450457413 |
| @Trott | https://github.com/Trott |
| #24876 | https://github.com/nodejs/node/pull/24876 |
| #25256 | https://github.com/nodejs/node/pull/25256 |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/5c6a4c56857bee2b9e0d9b2b23f9c027fff302c8..4381c4d1b50065db7d0ea914dfcf789110e66a9b |
| 5c6a4c5 | https://github.com/nodejs/node/commit/5c6a4c56857bee2b9e0d9b2b23f9c027fff302c8 |
| 4381c4d | https://github.com/nodejs/node/commit/4381c4d1b50065db7d0ea914dfcf789110e66a9b |
|
Compare
| https://github.com/nodejs/node/compare/5c6a4c56857bee2b9e0d9b2b23f9c027fff302c8..4381c4d1b50065db7d0ea914dfcf789110e66a9b |
| December 31, 2018 03:37 | https://github.com/nodejs/node/pull/25167#event-2048650422 |
| Trott | https://github.com/Trott |
| January 4, 2019 11:42 | https://github.com/nodejs/node/pull/25167#commits-pushed-2078385 |
|
| https://github.com/Trott |
| test: use common.relaunchWithFlags() for --expose-externalize-string | https://github.com/nodejs/node/pull/25167/commits/207838551922c0bc3e5879699e0c7a654bcf8e54 |
| 2078385 | https://github.com/nodejs/node/pull/25167/commits/207838551922c0bc3e5879699e0c7a654bcf8e54 |
|
| https://github.com/Trott |
| test: use common.relaunchWithFlags() for --allow-natives-syntax | https://github.com/nodejs/node/pull/25167/commits/ed8e54b06553e4d83cf21041101adfda420ccb59 |
| ed8e54b | https://github.com/nodejs/node/pull/25167/commits/ed8e54b06553e4d83cf21041101adfda420ccb59 |
|
| https://github.com/Trott |
| test: use common.relaunchWithFlags() for --tls-v1.* flags | https://github.com/nodejs/node/pull/25167/commits/2429547cdf830ea65cd9dbff2acc18716948c809 |
| 2429547 | https://github.com/nodejs/node/pull/25167/commits/2429547cdf830ea65cd9dbff2acc18716948c809 |
|
| https://github.com/Trott |
| test: remove unneeded use of --no-deprecation | https://github.com/nodejs/node/pull/25167/commits/1dce939516d75173760c0825152da00b4064954d |
| 1dce939 | https://github.com/nodejs/node/pull/25167/commits/1dce939516d75173760c0825152da00b4064954d |
|
| https://github.com/Trott |
| test: use common.relaunchWithFlags() for --preserve-symlinks | https://github.com/nodejs/node/pull/25167/commits/4817b2b9b55101b69f6e079f24c650bf51771473 |
| 4817b2b | https://github.com/nodejs/node/pull/25167/commits/4817b2b9b55101b69f6e079f24c650bf51771473 |
|
| https://github.com/Trott |
| test: use common.relaunchWithFlags() for special-case --expose-internals | https://github.com/nodejs/node/pull/25167/commits/3a5b5d74ddf23884edca3b8b726c08a827394529 |
| 3a5b5d7 | https://github.com/nodejs/node/pull/25167/commits/3a5b5d74ddf23884edca3b8b726c08a827394529 |
|
| https://github.com/Trott |
| test: use common.relaunchWithFlags() for --abort-on-uncaught-exception | https://github.com/nodejs/node/pull/25167/commits/6eecd132999462ce414a47f0b96917d8082c75e7 |
| 6eecd13 | https://github.com/nodejs/node/pull/25167/commits/6eecd132999462ce414a47f0b96917d8082c75e7 |
|
| https://github.com/Trott |
| test: use common.relaunchWithFlags() for --title | https://github.com/nodejs/node/pull/25167/commits/35e141cd53a690ba5de661a7cee0d1562b2365f6 |
| 35e141c | https://github.com/nodejs/node/pull/25167/commits/35e141cd53a690ba5de661a7cee0d1562b2365f6 |
|
| https://github.com/Trott |
| test: use common.relaunchWithFlags for --experimental-repl-await | https://github.com/nodejs/node/pull/25167/commits/33a7f0fde7325b1067cdc63f98aff3bd024d7856 |
| 33a7f0f | https://github.com/nodejs/node/pull/25167/commits/33a7f0fde7325b1067cdc63f98aff3bd024d7856 |
|
| https://github.com/Trott |
| test: use common.relaunchWithFlags() for --use-bundled-ca | https://github.com/nodejs/node/pull/25167/commits/3c5cd682a77d3db8a3ce5cd3f9f2f770fdabbdc7 |
| 3c5cd68 | https://github.com/nodejs/node/pull/25167/commits/3c5cd682a77d3db8a3ce5cd3f9f2f770fdabbdc7 |
|
| https://github.com/Trott |
| test: use common.relaunchWithFlags() for --experimental-vm-modules | https://github.com/nodejs/node/pull/25167/commits/e9ff344e223d53ee755f439f5a9c13768495ad64 |
| e9ff344 | https://github.com/nodejs/node/pull/25167/commits/e9ff344e223d53ee755f439f5a9c13768495ad64 |
|
| https://github.com/Trott |
| test: use common.relaunchWithFlags() for --max-old-space-size | https://github.com/nodejs/node/pull/25167/commits/c66200307f59ccd36ea4f79e11410690e883dd62 |
| c662003 | https://github.com/nodejs/node/pull/25167/commits/c66200307f59ccd36ea4f79e11410690e883dd62 |
|
| https://github.com/Trott |
| test: use common.relaunchWithFlags() for --require | https://github.com/nodejs/node/pull/25167/commits/482ef236a36b171f1a421fe614b122531d9480ea |
| 482ef23 | https://github.com/nodejs/node/pull/25167/commits/482ef236a36b171f1a421fe614b122531d9480ea |
|
| https://github.com/Trott |
| test: remove check for Flags: in common module | https://github.com/nodejs/node/pull/25167/commits/ad858a9d8a72416556215a52384a960830fc3b6c |
| ad858a9 | https://github.com/nodejs/node/pull/25167/commits/ad858a9d8a72416556215a52384a960830fc3b6c |
|
| https://github.com/Trott |
| test: remove Flags: functionality from Python test runner | https://github.com/nodejs/node/pull/25167/commits/97b210183b8b35c53591970ee346b17b21ce2bac |
| 97b2101 | https://github.com/nodejs/node/pull/25167/commits/97b210183b8b35c53591970ee346b17b21ce2bac |
|
| https://github.com/Trott |
| test: implement common.requireFlags() | https://github.com/nodejs/node/pull/25167/commits/2fbf88fe43cb88afcf02e50e6391432d385fe437 |
| 2fbf88f | https://github.com/nodejs/node/pull/25167/commits/2fbf88fe43cb88afcf02e50e6391432d385fe437 |
|
| https://github.com/Trott |
| test: wrap common.requireFlags() with common.exposeInternals() | https://github.com/nodejs/node/pull/25167/commits/7bb8b4783275de25e7886253e77f1887ecae595d |
| 7bb8b47 | https://github.com/nodejs/node/pull/25167/commits/7bb8b4783275de25e7886253e77f1887ecae595d |
|
| https://github.com/Trott |
| test: remove common.exposeInternals() | https://github.com/nodejs/node/pull/25167/commits/ec18dcd1cb261e98dbe2165c28039970b052495b |
| ec18dcd | https://github.com/nodejs/node/pull/25167/commits/ec18dcd1cb261e98dbe2165c28039970b052495b |
|
| https://github.com/Trott |
| test: remove common.experimentalWorker() | https://github.com/nodejs/node/pull/25167/commits/3c8c66ed1907462aaa4a3b82591512c624f613ce |
| 3c8c66e | https://github.com/nodejs/node/pull/25167/commits/3c8c66ed1907462aaa4a3b82591512c624f613ce |
|
| https://github.com/Trott |
| test: remove common.relaunchWithFlags() | https://github.com/nodejs/node/pull/25167/commits/f9a3f5db19b54e7440c1355e2cf2dd6c27f4d510 |
| f9a3f5d | https://github.com/nodejs/node/pull/25167/commits/f9a3f5db19b54e7440c1355e2cf2dd6c27f4d510 |
|
| https://github.com/Trott |
| test: remove unnecessary logic around requireFlags() calls | https://github.com/nodejs/node/pull/25167/commits/d4eb09d39fc36901573b509739c46f79e219de36 |
| d4eb09d | https://github.com/nodejs/node/pull/25167/commits/d4eb09d39fc36901573b509739c46f79e219de36 |
|
| https://github.com/Trott |
| test: revise signature for common.requireFlags() | https://github.com/nodejs/node/pull/25167/commits/cec4d0ebc6ec123c410accf9eb85d0f53f38ba19 |
| cec4d0e | https://github.com/nodejs/node/pull/25167/commits/cec4d0ebc6ec123c410accf9eb85d0f53f38ba19 |
|
| https://github.com/Trott |
| fixup on experimental worker flag | https://github.com/nodejs/node/pull/25167/commits/7b50eb6562a7f15fc2aa97cc9199b09c9f234a90 |
| 7b50eb6 | https://github.com/nodejs/node/pull/25167/commits/7b50eb6562a7f15fc2aa97cc9199b09c9f234a90 |
|
| https://github.com/Trott |
| test: improve worker_threads handling in common.requireFlags() | https://github.com/nodejs/node/pull/25167/commits/e716c0a9e6bfee61a70074dc85f44a075fa525b3 |
| e716c0a | https://github.com/nodejs/node/pull/25167/commits/e716c0a9e6bfee61a70074dc85f44a075fa525b3 |
|
| https://github.com/Trott |
| test: check for errors after in requireFlags() | https://github.com/nodejs/node/pull/25167/commits/539d365c92d4de2b315c060c4ce7a87aebf33a33 |
| 539d365 | https://github.com/nodejs/node/pull/25167/commits/539d365c92d4de2b315c060c4ce7a87aebf33a33 |
|
| https://github.com/Trott |
| test: refactor test-inspector-overwrite-config.js | https://github.com/nodejs/node/pull/25167/commits/ac1913b5a61ccd9d64bc3886d961c3bec54ae874 |
| ac1913b | https://github.com/nodejs/node/pull/25167/commits/ac1913b5a61ccd9d64bc3886d961c3bec54ae874 |
|
| https://github.com/Trott |
| test: short-circuit requireFlags() when cluster worker | https://github.com/nodejs/node/pull/25167/commits/bdcbdae7b7223d4fe57fa8d897a4fe8b99b5bbf5 |
| bdcbdae | https://github.com/nodejs/node/pull/25167/commits/bdcbdae7b7223d4fe57fa8d897a4fe8b99b5bbf5 |
|
| https://github.com/Trott |
| test: simplify flags logic for esm tests | https://github.com/nodejs/node/pull/25167/commits/146681b76c8102c2cfc6a65b130b17dbb2b2d777 |
| 146681b | https://github.com/nodejs/node/pull/25167/commits/146681b76c8102c2cfc6a65b130b17dbb2b2d777 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/c1d3e14d626801454f1f9fb180ddf4f507882a09..146681b76c8102c2cfc6a65b130b17dbb2b2d777 |
| c1d3e14 | https://github.com/nodejs/node/commit/c1d3e14d626801454f1f9fb180ddf4f507882a09 |
| 146681b | https://github.com/nodejs/node/commit/146681b76c8102c2cfc6a65b130b17dbb2b2d777 |
|
Compare
| https://github.com/nodejs/node/compare/c1d3e14d626801454f1f9fb180ddf4f507882a09..146681b76c8102c2cfc6a65b130b17dbb2b2d777 |
| January 4, 2019 19:42 | https://github.com/nodejs/node/pull/25167#event-2055217787 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 4, 2019 | https://github.com/nodejs/node/pull/25167#event-2055438122 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25167 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/25167/files/d79b58b59c6517e92b111a328e03709a7a677f7b |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/25167/files/f718069076f228e8bbdd1ead48f8287d9761a866 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/25167 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/richardlau |
|
| https://github.com/devsnek |
|
| https://github.com/BridgeAR |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |