René's URL Explorer Experiment


Title: buffer: simplify code by BridgeAR · Pull Request #25151 · nodejs/node · GitHub

Open Graph Title: buffer: simplify code by BridgeAR · Pull Request #25151 · nodejs/node

X Title: buffer: simplify code by BridgeAR · Pull Request #25151 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This refactors some code for simplicity. It also removes a call indirection used in the buffers custom inspect function. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests ...

X Description: This refactors some code for simplicity. It also removes a call indirection used in the buffers custom inspect function. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests ...

Opengraph URL: https://github.com/nodejs/node/pull/25151

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9e458f29-c3cb-3ea1-6c07-c9be202ad9fd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC93E:397AD8:10FD1BD:16FB936:6A4F0BA9
html-safe-noncea3fde36471af27cb8d714cff449a2f6527986da7e8100aa8b1b858dafba65404
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTNFOjM5N0FEODoxMEZEMUJEOjE2RkI5MzY6NkE0RjBCQTkiLCJ2aXNpdG9yX2lkIjoiNTc4MzAxOTM4ODE5MDc4ODUyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6b99e0a13a5c06b2865a106f47093a12b92d7e49a88126803f8ec597c1393dd2
hovercard-subject-tagpull_request:240235722
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25151/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4332d407335d0f9ea784b8748c43baf602f0c6bcd610053372006a5edad880bd/nodejs/node/pull/25151
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4332d407335d0f9ea784b8748c43baf602f0c6bcd610053372006a5edad880bd/nodejs/node/pull/25151
og:image:altThis refactors some code for simplicity. It also removes a call indirection used in the buffers custom inspect function. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25151#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25151
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25151
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25151
Reloadhttps://github.com/nodejs/node/pull/25151
Reloadhttps://github.com/nodejs/node/pull/25151
Please reload this pagehttps://github.com/nodejs/node/pull/25151
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25151
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 966 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:simplify-buffer-codehttps://github.com/BridgeAR/node/tree/simplify-buffer-code
Conversationhttps://github.com/nodejs/node/pull/25151
Commits1 (1)https://github.com/nodejs/node/pull/25151/commits
Checkshttps://github.com/nodejs/node/pull/25151/checks
Files changedhttps://github.com/nodejs/node/pull/25151/files
buffer: simplify codehttps://github.com/nodejs/node/pull/25151#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:simplify-buffer-codehttps://github.com/BridgeAR/node/tree/simplify-buffer-code
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 20, 2018https://github.com/nodejs/node/pull/25151#issue-393128024
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25151
https://github.com/BridgeAR
buffer: simplify codehttps://github.com/nodejs/node/pull/25151/commits/e3674726443fe2818144e9e9f08f86933d7b72c2
e367472https://github.com/nodejs/node/pull/25151/commits/e3674726443fe2818144e9e9f08f86933d7b72c2
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 20, 2018 https://github.com/nodejs/node/pull/25151#pullrequestreview-187111537
View reviewed changes https://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/25151#pullrequestreview-187111537
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25151
lib/buffer.jshttps://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
Please reload this pagehttps://github.com/nodejs/node/pull/25151
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 20, 2018 https://github.com/nodejs/node/pull/25151#pullrequestreview-187115103
View reviewed changes https://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2
lib/buffer.jshttps://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
mscdexhttps://github.com/mscdex
Dec 20, 2018https://github.com/nodejs/node/pull/25151#discussion_r243363864
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25151
BridgeARhttps://github.com/BridgeAR
Dec 20, 2018https://github.com/nodejs/node/pull/25151#discussion_r243372308
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25151
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 20, 2018 https://github.com/nodejs/node/pull/25151#pullrequestreview-187115533
View reviewed changes https://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2
lib/buffer.jshttps://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
mscdexhttps://github.com/mscdex
Dec 20, 2018https://github.com/nodejs/node/pull/25151#discussion_r243364191
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25151
BridgeARhttps://github.com/BridgeAR
Dec 23, 2018https://github.com/nodejs/node/pull/25151#discussion_r243769880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25151
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 20, 2018 https://github.com/nodejs/node/pull/25151#pullrequestreview-187130901
View reviewed changes https://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 20, 2018 https://github.com/nodejs/node/pull/25151#pullrequestreview-187174407
View reviewed changes https://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2
https://github.com/shisama
shisamahttps://github.com/shisama
Dec 22, 2018 https://github.com/nodejs/node/pull/25151#pullrequestreview-187591930
View reviewed changes https://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 23, 2018https://github.com/nodejs/node/pull/25151#issuecomment-449649621
Please reload this pagehttps://github.com/nodejs/node/pull/25151
https://ci.nodejs.org/job/node-test-pull-request/19760/https://ci.nodejs.org/job/node-test-pull-request/19760/
Please reload this pagehttps://github.com/nodejs/node/pull/25151
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 23, 2018https://github.com/nodejs/node/pull/25151#event-2042538664
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Dec 23, 2018 https://github.com/nodejs/node/pull/25151#pullrequestreview-187627964
View reviewed changes https://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 24, 2018https://github.com/nodejs/node/pull/25151#issuecomment-449705271
65d8179https://github.com/nodejs/node/commit/65d8179b0d10b4a53564d360c21d0260ec4b1686
Please reload this pagehttps://github.com/nodejs/node/pull/25151
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 24, 2018https://github.com/nodejs/node/pull/25151#event-2042884549
BridgeARhttps://github.com/BridgeAR
Dec 24, 2018 https://github.com/nodejs/node/pull/25151#ref-commit-65d8179
https://github.com/BridgeAR
buffer: simplify codehttps://github.com/BridgeAR/node/commit/65d8179b0d10b4a53564d360c21d0260ec4b1686
65d8179https://github.com/BridgeAR/node/commit/65d8179b0d10b4a53564d360c21d0260ec4b1686
nodejs#25151https://github.com/nodejs/node/pull/25151
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/25151#ref-commit-508cbaa
https://github.com/BridgeAR
https://github.com/MylesBorins
buffer: simplify codehttps://github.com/nodejs/node/commit/508cbaa1c3b84ae94e576aa5e9521d5e9bb43d09
508cbaahttps://github.com/nodejs/node/commit/508cbaa1c3b84ae94e576aa5e9521d5e9bb43d09
#25151https://github.com/nodejs/node/pull/25151
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/25151#ref-pullrequest-393620382
v11.6.0 proposal #25175 https://github.com/nodejs/node/pull/25175
MylesBorinshttps://github.com/MylesBorins
Dec 26, 2018 https://github.com/nodejs/node/pull/25151#ref-commit-c6bfa66
https://github.com/BridgeAR
https://github.com/MylesBorins
buffer: simplify codehttps://github.com/nodejs/node/commit/c6bfa66b2e16dc5c700b7e844053ed3433fa7c44
c6bfa66https://github.com/nodejs/node/commit/c6bfa66b2e16dc5c700b7e844053ed3433fa7c44
#25151https://github.com/nodejs/node/pull/25151
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/25151#ref-commit-b8107e0
https://github.com/BridgeAR
https://github.com/refack
buffer: simplify codehttps://github.com/refack/node/commit/b8107e0f2a1dc2c944675fbea6289248d9d55aa6
b8107e0https://github.com/refack/node/commit/b8107e0f2a1dc2c944675fbea6289248d9d55aa6
nodejs#25151https://github.com/nodejs/node/pull/25151
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 11:46https://github.com/nodejs/node/pull/25151#event-2962650801
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25151
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2
https://github.com/shisama
shisama https://github.com/shisama
https://github.com/nodejs/node/pull/25151/files/e3674726443fe2818144e9e9f08f86933d7b72c2
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Please reload this pagehttps://github.com/nodejs/node/pull/25151
https://github.com/BridgeAR
https://github.com/mscdex
https://github.com/jasnell
https://github.com/addaleax
https://github.com/shisama
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.