René's URL Explorer Experiment


Title: Remove StreamBase templating by maclover7 · Pull Request #25142 · nodejs/node · GitHub

Open Graph Title: Remove StreamBase templating by maclover7 · Pull Request #25142 · nodejs/node

X Title: Remove StreamBase templating by maclover7 · Pull Request #25142 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: First attempt at trying to remove the templating in shared StreamBase methods. This approach casts directly to StreamBase via an internal field. Unfortunately, I keep hitting linker errors when try...

X Description: First attempt at trying to remove the templating in shared StreamBase methods. This approach casts directly to StreamBase via an internal field. Unfortunately, I keep hitting linker errors when try...

Opengraph URL: https://github.com/nodejs/node/pull/25142

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:09f79c3c-499e-a959-0470-69031d9f683d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA9EE:196F8D:291F67:354338:69927F9B
html-safe-noncea1dda4b99732cd1cb81a1f0d5d8a6703003799df8a560c739ea612d49a74e9b0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUVFOjE5NkY4RDoyOTFGNjc6MzU0MzM4OjY5OTI3RjlCIiwidmlzaXRvcl9pZCI6IjQ4MjgwMDY0MjAzMzgzNDM4MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0abd288afc82110d188e67d8f54981fddb37e048814893a2991e16210c05e7c7
hovercard-subject-tagpull_request:239993155
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25142/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/93657385ccdfc01c01063bcd38ff0f9a47872a181aa68584d72ee3e15fe5be35/nodejs/node/pull/25142
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/93657385ccdfc01c01063bcd38ff0f9a47872a181aa68584d72ee3e15fe5be35/nodejs/node/pull/25142
og:image:altFirst attempt at trying to remove the templating in shared StreamBase methods. This approach casts directly to StreamBase via an internal field. Unfortunately, I keep hitting linker errors when try...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemaclover7
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25142#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25142
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25142
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25142
Reloadhttps://github.com/nodejs/node/pull/25142
Reloadhttps://github.com/nodejs/node/pull/25142
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25142
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
maclover7https://github.com/maclover7
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/25142
Commits8 (8)https://github.com/nodejs/node/pull/25142/commits
Checkshttps://github.com/nodejs/node/pull/25142/checks
Files changedhttps://github.com/nodejs/node/pull/25142/files
Remove StreamBase templatinghttps://github.com/nodejs/node/pull/25142#top
maclover7https://github.com/maclover7
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 19, 2018https://github.com/nodejs/node/pull/25142#issue-392800823
Please reload this pagehttps://github.com/nodejs/node/pull/25142
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 19, 2018https://github.com/nodejs/node/pull/25142#issuecomment-448765146
@maclover7https://github.com/maclover7
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2010/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2010/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Dec 19, 2018https://github.com/nodejs/node/pull/25142#event-2036946022
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 19, 2018 https://github.com/nodejs/node/pull/25142#pullrequestreview-186777534
View reviewed changes https://github.com/nodejs/node/pull/25142/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/25142#pullrequestreview-186777534
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25142
src/stream_base-inl.hhttps://github.com/nodejs/node/pull/25142/files#diff-15f75d5d5482fbed0b2b2dadfdc8fd42152247ae731de46c2448855387b324a0
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 19, 2018 https://github.com/nodejs/node/pull/25142#pullrequestreview-186779069
View reviewed changes https://github.com/nodejs/node/pull/25142/files
src/stream_base-inl.hhttps://github.com/nodejs/node/pull/25142/files#diff-15f75d5d5482fbed0b2b2dadfdc8fd42152247ae731de46c2448855387b324a0
addaleaxhttps://github.com/addaleax
Dec 19, 2018https://github.com/nodejs/node/pull/25142#discussion_r243099225
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25142
joyeecheunghttps://github.com/joyeecheung
Dec 19, 2018https://github.com/nodejs/node/pull/25142#discussion_r243099544
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 19, 2018https://github.com/nodejs/node/pull/25142#issuecomment-448790290
@addaleaxhttps://github.com/addaleax
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 19, 2018 https://github.com/nodejs/node/pull/25142#pullrequestreview-186797699
View reviewed changes https://github.com/nodejs/node/pull/25142/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/25142#pullrequestreview-186797699
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 19, 2018https://github.com/nodejs/node/pull/25142#issuecomment-448793103
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2013/https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2013/
https://ci.nodejs.org/job/node-test-pull-request/19687/https://ci.nodejs.org/job/node-test-pull-request/19687/
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 20, 2018 https://github.com/nodejs/node/pull/25142#pullrequestreview-187062815
View reviewed changes https://github.com/nodejs/node/pull/25142/files
https://github.com/maclover7
maclover7https://github.com/maclover7
Dec 21, 2018https://github.com/nodejs/node/pull/25142#issuecomment-449188303
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 7, 2019https://github.com/nodejs/node/pull/25142#issuecomment-452114224
https://ci.nodejs.org/job/node-test-pull-request/19979/https://ci.nodejs.org/job/node-test-pull-request/19979/
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 7, 2019https://github.com/nodejs/node/pull/25142#event-2058864590
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 9, 2019https://github.com/nodejs/node/pull/25142#issuecomment-452526109
@maclover7https://github.com/maclover7
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 13, 2019https://github.com/nodejs/node/pull/25142#issuecomment-453851502
@maclover7https://github.com/maclover7
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 7, 2019https://github.com/nodejs/node/pull/25142#issuecomment-470497050
@maclover7https://github.com/maclover7
Please reload this pagehttps://github.com/nodejs/node/pull/25142
maclover7https://github.com/maclover7
March 7, 2019 16:54https://github.com/nodejs/node/pull/25142#commits-pushed-1475c36
https://github.com/maclover7
https://github.com/addaleax
src: remove templating from StreamBasehttps://github.com/nodejs/node/pull/25142/commits/1475c36854aec8a65a535ae97a9c4e5ef8bfd010
1475c36https://github.com/nodejs/node/pull/25142/commits/1475c36854aec8a65a535ae97a9c4e5ef8bfd010
https://github.com/maclover7
https://github.com/addaleax
src: add method helper functionhttps://github.com/nodejs/node/pull/25142/commits/2af477e8ab5cc6924924f2d0d74da81493b2829e
2af477ehttps://github.com/nodejs/node/pull/25142/commits/2af477e8ab5cc6924924f2d0d74da81493b2829e
https://github.com/maclover7
https://github.com/addaleax
fixup: move some .inl-h methods to .cc to compilehttps://github.com/nodejs/node/pull/25142/commits/181741a26fb1101f1bcaa5dbb00b3febc276a06e
181741ahttps://github.com/nodejs/node/pull/25142/commits/181741a26fb1101f1bcaa5dbb00b3febc276a06e
https://github.com/maclover7
https://github.com/addaleax
fixup: introduce StreamBase::AddMethodhttps://github.com/nodejs/node/pull/25142/commits/4ee6a61c2487e32f88a1db0a2a02742709ed6b35
4ee6a61https://github.com/nodejs/node/pull/25142/commits/4ee6a61c2487e32f88a1db0a2a02742709ed6b35
https://github.com/maclover7
https://github.com/addaleax
fixup: run c++ stylerhttps://github.com/nodejs/node/pull/25142/commits/52bd501f241b3582e48a8b2b7a20f1a395d47b8c
52bd501https://github.com/nodejs/node/pull/25142/commits/52bd501f241b3582e48a8b2b7a20f1a395d47b8c
https://github.com/maclover7
https://github.com/addaleax
fixup: combine on one linehttps://github.com/nodejs/node/pull/25142/commits/d384a6f1d4afb9607ca19550e4368ebba5dc1b77
d384a6fhttps://github.com/nodejs/node/pull/25142/commits/d384a6f1d4afb9607ca19550e4368ebba5dc1b77
https://github.com/maclover7
https://github.com/addaleax
fixup: use platformTimeout to try and resolve timeout issuehttps://github.com/nodejs/node/pull/25142/commits/2fd91816e8c5dcf936390713c5f7e56d51e38a91
2fd9181https://github.com/nodejs/node/pull/25142/commits/2fd91816e8c5dcf936390713c5f7e56d51e38a91
https://github.com/addaleax
fixup: fix StreamBase::FromObjecthttps://github.com/nodejs/node/pull/25142/commits/4411b720c9fb9267325805f71781381355715c4d
4411b72https://github.com/nodejs/node/pull/25142/commits/4411b720c9fb9267325805f71781381355715c4d
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 7, 2019https://github.com/nodejs/node/pull/25142#issuecomment-470586342
@jasnellhttps://github.com/jasnell
https://ci.nodejs.org/job/node-test-pull-request/21304/https://ci.nodejs.org/job/node-test-pull-request/21304/
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 7, 2019https://github.com/nodejs/node/pull/25142#issuecomment-470665241
https://ci.nodejs.org/job/node-test-pull-request/21313/https://ci.nodejs.org/job/node-test-pull-request/21313/
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 7, 2019 https://github.com/nodejs/node/pull/25142#pullrequestreview-212055724
View reviewed changes https://github.com/nodejs/node/pull/25142/files/4411b720c9fb9267325805f71781381355715c4d
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 8, 2019https://github.com/nodejs/node/pull/25142#issuecomment-470847801
4697e1bhttps://github.com/nodejs/node/commit/4697e1b0d792f50863bbbcad25a95b84e6746501
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 8, 2019https://github.com/nodejs/node/pull/25142#event-2189480177
addaleaxhttps://github.com/addaleax
Mar 8, 2019 https://github.com/nodejs/node/pull/25142#ref-commit-4697e1b
https://github.com/maclover7
https://github.com/addaleax
src: remove templating from StreamBasehttps://github.com/nodejs/node/commit/4697e1b0d792f50863bbbcad25a95b84e6746501
4697e1bhttps://github.com/nodejs/node/commit/4697e1b0d792f50863bbbcad25a95b84e6746501
#25142https://github.com/nodejs/node/pull/25142
addaleaxhttps://github.com/addaleax
Mar 8, 2019 https://github.com/nodejs/node/pull/25142#ref-commit-7888115
https://github.com/addaleax
lib,src: remove usage of _externalStreamhttps://github.com/addaleax/node/commit/78881156b0b87e0ff370266112b8f3cb7b308113
7888115https://github.com/addaleax/node/commit/78881156b0b87e0ff370266112b8f3cb7b308113
4697e1bhttps://github.com/addaleax/node/commit/4697e1b0d792f50863bbbcad25a95b84e6746501
nodejs#25142https://github.com/nodejs/node/pull/25142
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 8, 2019 https://github.com/nodejs/node/pull/25142#ref-pullrequest-418706417
lib,src: remove usage of _externalStream #26510 https://github.com/nodejs/node/pull/26510
danbevhttps://github.com/danbev
Mar 11, 2019 https://github.com/nodejs/node/pull/25142#ref-commit-560466c
https://github.com/addaleax
https://github.com/danbev
lib,src: remove usage of _externalStreamhttps://github.com/nodejs/node/commit/560466c7738c1b66f2a74381bff41bdd7bde1eef
560466chttps://github.com/nodejs/node/commit/560466c7738c1b66f2a74381bff41bdd7bde1eef
4697e1bhttps://github.com/nodejs/node/commit/4697e1b0d792f50863bbbcad25a95b84e6746501
#26510https://github.com/nodejs/node/pull/26510
#25142https://github.com/nodejs/node/pull/25142
BridgeARhttps://github.com/BridgeAR
Mar 12, 2019 https://github.com/nodejs/node/pull/25142#ref-commit-3b06d29
https://github.com/maclover7
https://github.com/BridgeAR
src: remove templating from StreamBasehttps://github.com/BridgeAR/node/commit/3b06d2998447b78145c1fd2cf697822f8e56da08
3b06d29https://github.com/BridgeAR/node/commit/3b06d2998447b78145c1fd2cf697822f8e56da08
nodejs#25142https://github.com/nodejs/node/pull/25142
BridgeARhttps://github.com/BridgeAR
Mar 13, 2019 https://github.com/nodejs/node/pull/25142#ref-commit-ca9bb1f
https://github.com/addaleax
https://github.com/BridgeAR
lib,src: remove usage of _externalStreamhttps://github.com/nodejs/node/commit/ca9bb1f8838f78952abb6bd0aa389ab41bdac2dd
ca9bb1fhttps://github.com/nodejs/node/commit/ca9bb1f8838f78952abb6bd0aa389ab41bdac2dd
4697e1bhttps://github.com/nodejs/node/commit/4697e1b0d792f50863bbbcad25a95b84e6746501
#26510https://github.com/nodejs/node/pull/26510
#25142https://github.com/nodejs/node/pull/25142
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 13, 2019 https://github.com/nodejs/node/pull/25142#ref-pullrequest-420740761
2019-03-14, Version 11.12.0 (Current) #26644 https://github.com/nodejs/node/pull/26644
BridgeARhttps://github.com/BridgeAR
Mar 14, 2019 https://github.com/nodejs/node/pull/25142#ref-commit-d688b8a
https://github.com/maclover7
https://github.com/BridgeAR
src: remove templating from StreamBasehttps://github.com/nodejs/node/commit/d688b8a1321f64bd6e020e3139173d120a254583
d688b8ahttps://github.com/nodejs/node/commit/d688b8a1321f64bd6e020e3139173d120a254583
#25142https://github.com/nodejs/node/pull/25142
BridgeARhttps://github.com/BridgeAR
Mar 14, 2019 https://github.com/nodejs/node/pull/25142#ref-commit-9398d84
https://github.com/addaleax
https://github.com/BridgeAR
lib,src: remove usage of _externalStreamhttps://github.com/nodejs/node/commit/9398d84735e9b62b80208f8a15aa0c310b923476
9398d84https://github.com/nodejs/node/commit/9398d84735e9b62b80208f8a15aa0c310b923476
4697e1bhttps://github.com/nodejs/node/commit/4697e1b0d792f50863bbbcad25a95b84e6746501
#26510https://github.com/nodejs/node/pull/26510
#25142https://github.com/nodejs/node/pull/25142
https://github.com/maclover7
maclover7https://github.com/maclover7
March 16, 2019 02:15https://github.com/nodejs/node/pull/25142#event-2207940672
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25142
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/25142/files/eb3a6941a98d0141ade9d1143596bfb93ee63157
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/25142/files/4411b720c9fb9267325805f71781381355715c4d
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/25142/files/0586b4e3be1193439b1831799a2342788bdb5644
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/25142
https://github.com/maclover7
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/jasnell
https://github.com/joyeecheung
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.