| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d615320f-3654-69e4-c05c-561107d5a5e9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CEEE:3C8683:498991D:67FB37D:6A4FD201 |
| html-safe-nonce | 64538f01922cb16b4e4f1a9ceae3d53220f35411dd4ce69471d7090575a2fa61 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUVFOjNDODY4Mzo0OTg5OTFEOjY3RkIzN0Q6NkE0RkQyMDEiLCJ2aXNpdG9yX2lkIjoiNTExMjIxMjQxMjE0NjExMDk3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 47684a54eae9ba096bac8605e98ff637e986e596f1658257f1bedc184696443b |
| hovercard-subject-tag | pull_request:239599010 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25112/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b26a1a8b458396257969d6db69aa8718005e72fc68f509d6652eb5d15e75bcf9/nodejs/node/pull/25112 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b26a1a8b458396257969d6db69aa8718005e72fc68f509d6652eb5d15e75bcf9/nodejs/node/pull/25112 |
| og:image:alt | Ref: #25027 (comment)
CI: https://ci.nodejs.org/job/node-test-pull-request/19661/ https://ci.nodejs.org/job/node-test-pull-request/19700/
Lint rerun: https://ci.nodejs.org/job/node-test-linter/2447... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ofrobots |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 142593e66413bbae27fd485859993597d5a3b104 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25112#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25112 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25112 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25112 |
| Reload | https://github.com/nodejs/node/pull/25112 |
| Reload | https://github.com/nodejs/node/pull/25112 |
| Please reload this page | https://github.com/nodejs/node/pull/25112 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25112 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| ofrobots | https://github.com/ofrobots |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| ofrobots:fix/10/test-bootstrap-modules | https://github.com/ofrobots/node/tree/fix/10/test-bootstrap-modules |
| Conversation | https://github.com/nodejs/node/pull/25112 |
| Commits2 (2) | https://github.com/nodejs/node/pull/25112/commits |
| Checks | https://github.com/nodejs/node/pull/25112/checks |
| Files changed | https://github.com/nodejs/node/pull/25112/files |
| [10.x] test: fix expectation in test-bootstrap-modules | https://github.com/nodejs/node/pull/25112#top |
| ofrobots | https://github.com/ofrobots |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| ofrobots:fix/10/test-bootstrap-modules | https://github.com/ofrobots/node/tree/fix/10/test-bootstrap-modules |
|
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/25112#issue-392294317 |
| Please reload this page | https://github.com/nodejs/node/pull/25112 |
| #25027 (comment) | https://github.com/nodejs/node/pull/25027#issuecomment-447482946 |
| https://ci.nodejs.org/job/node-test-pull-request/19661/ | https://ci.nodejs.org/job/node-test-pull-request/19661/ |
| https://ci.nodejs.org/job/node-test-pull-request/19700/ | https://ci.nodejs.org/job/node-test-pull-request/19700/ |
| https://ci.nodejs.org/job/node-test-linter/24472/ | https://ci.nodejs.org/job/node-test-linter/24472/ |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25112 |
|
| https://github.com/ofrobots |
| test: fix expectation in test-bootstrap-modules | https://github.com/nodejs/node/pull/25112/commits/16c2b54d088cd69b36b1ac8b6fe1e42d0621e30c |
| 16c2b54 | https://github.com/nodejs/node/pull/25112/commits/16c2b54d088cd69b36b1ac8b6fe1e42d0621e30c |
| nodejs#25027 | https://github.com/nodejs/node/pull/25027 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/25112#issuecomment-448334675 |
| @ofrobots | https://github.com/ofrobots |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1994/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1994/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25112 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/25112#event-2033849681 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/25112#event-2033850745 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
|
Dec 18, 2018
| https://github.com/nodejs/node/pull/25112#ref-pullrequest-390961334 |
|
[10.x] deps: V8: cherry-pick 52a9e67
#25027
| https://github.com/nodejs/node/pull/25027 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/25112#event-2033867220 |
|
| https://github.com/ofrobots |
| [squash] lint-fix | https://github.com/nodejs/node/pull/25112/commits/7279edb4701904c04865ed641663d1fd583b8520 |
| 7279edb | https://github.com/nodejs/node/pull/25112/commits/7279edb4701904c04865ed641663d1fd583b8520 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 19, 2018
| https://github.com/nodejs/node/pull/25112#pullrequestreview-186606341 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25112/files/7279edb4701904c04865ed641663d1fd583b8520 |
| MylesBorins | https://github.com/MylesBorins |
| https://github.com/nodejs/node/pull/25112#pullrequestreview-186606341 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/25112 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Dec 19, 2018
| https://github.com/nodejs/node/pull/25112#pullrequestreview-186609972 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25112/files/7279edb4701904c04865ed641663d1fd583b8520 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Dec 20, 2018 | https://github.com/nodejs/node/pull/25112#issuecomment-449152666 |
| Please reload this page | https://github.com/nodejs/node/pull/25112 |
| codebytere | https://github.com/codebytere |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25112#ref-commit-13fead6 |
|
| https://github.com/ofrobots |
|
| https://github.com/codebytere |
| test: fix expectation in test-bootstrap-modules | https://github.com/nodejs/node/commit/13fead607fc0c21aa486998684910ee0fdc9a0c8 |
| 13fead6 | https://github.com/nodejs/node/commit/13fead607fc0c21aa486998684910ee0fdc9a0c8 |
| #25112 | https://github.com/nodejs/node/pull/25112 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25112#issuecomment-449423901 |
| 13fead6 | https://github.com/nodejs/node/commit/13fead607fc0c21aa486998684910ee0fdc9a0c8 |
| Please reload this page | https://github.com/nodejs/node/pull/25112 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Dec 21, 2018 | https://github.com/nodejs/node/pull/25112#event-2041109358 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25112#ref-commit-659ef78 |
|
| https://github.com/ofrobots |
|
| https://github.com/MylesBorins |
| test: fix expectation in test-bootstrap-modules | https://github.com/nodejs/node/commit/659ef782fdc7bf30ef6cb669622424fbbd9d720a |
| 659ef78 | https://github.com/nodejs/node/commit/659ef782fdc7bf30ef6cb669622424fbbd9d720a |
| #25112 | https://github.com/nodejs/node/pull/25112 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2018
| https://github.com/nodejs/node/pull/25112#ref-pullrequest-393620553 |
|
v10.15.0 proposal
#25176
| https://github.com/nodejs/node/pull/25176 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 22, 2018
| https://github.com/nodejs/node/pull/25112#ref-commit-cb03e4a |
|
| https://github.com/ofrobots |
|
| https://github.com/MylesBorins |
| test: fix expectation in test-bootstrap-modules | https://github.com/nodejs/node/commit/cb03e4af52ef571ac4534c97fb8a2f42d89fba86 |
| cb03e4a | https://github.com/nodejs/node/commit/cb03e4af52ef571ac4534c97fb8a2f42d89fba86 |
| #25112 | https://github.com/nodejs/node/pull/25112 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 22, 2018
| https://github.com/nodejs/node/pull/25112#ref-commit-ba5e25e |
|
| https://github.com/ofrobots |
|
| https://github.com/MylesBorins |
| test: fix expectation in test-bootstrap-modules | https://github.com/nodejs/node/commit/ba5e25eb617313d73c897ea03702f7439f1a54d8 |
| ba5e25e | https://github.com/nodejs/node/commit/ba5e25eb617313d73c897ea03702f7439f1a54d8 |
| #25112 | https://github.com/nodejs/node/pull/25112 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 25, 2018
| https://github.com/nodejs/node/pull/25112#ref-commit-728bc63 |
|
| https://github.com/ofrobots |
|
| https://github.com/MylesBorins |
| test: fix expectation in test-bootstrap-modules | https://github.com/nodejs/node/commit/728bc631e512e0cb325a071ee83c8384c75661ff |
| 728bc63 | https://github.com/nodejs/node/commit/728bc631e512e0cb325a071ee83c8384c75661ff |
| #25112 | https://github.com/nodejs/node/pull/25112 |
|
2018-12-26 Version 10.15.0 'Dubnium' (LTS) @MylesBorins
beevelop/docker-nodejs#254
| https://github.com/beevelop/docker-nodejs/issues/254 |
|
2018-12-26 Version 10.15.0 'Dubnium' (LTS) @MylesBorins
beevelop/docker-android-nodejs#276
| https://github.com/beevelop/docker-android-nodejs/issues/276 |
| MylesBorins | https://github.com/MylesBorins |
|
May 16, 2019
| https://github.com/nodejs/node/pull/25112#ref-commit-4bfb258 |
|
| https://github.com/MylesBorins |
| test: fix expectation in test-bootstrap-modules | https://github.com/MylesBorins/node/commit/4bfb25837bff55f8c62dc1e4c6f4ea31cf1a8ac7 |
| 4bfb258 | https://github.com/MylesBorins/node/commit/4bfb25837bff55f8c62dc1e4c6f4ea31cf1a8ac7 |
| nodejs#27124 | https://github.com/nodejs/node/pull/27124 |
| nodejs#25112 | https://github.com/nodejs/node/pull/25112 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
May 16, 2019
| https://github.com/nodejs/node/pull/25112#ref-pullrequest-444752652 |
|
test: fix expectation in test-bootstrap-modules
#27727
| https://github.com/nodejs/node/pull/27727 |
| MylesBorins | https://github.com/MylesBorins |
|
May 16, 2019
| https://github.com/nodejs/node/pull/25112#ref-commit-d19c2c5 |
|
| https://github.com/MylesBorins |
| test: fix expectation in test-bootstrap-modules | https://github.com/nodejs/node/commit/d19c2c5c6c9b7c87361a8541c3ead406473768d0 |
| d19c2c5 | https://github.com/nodejs/node/commit/d19c2c5c6c9b7c87361a8541c3ead406473768d0 |
| #27124 | https://github.com/nodejs/node/pull/27124 |
| #25112 | https://github.com/nodejs/node/pull/25112 |
| #27727 | https://github.com/nodejs/node/pull/27727 |
| MylesBorins | https://github.com/MylesBorins |
|
May 16, 2019
| https://github.com/nodejs/node/pull/25112#ref-commit-7b76acb |
|
| https://github.com/MylesBorins |
| test: fix expectation in test-bootstrap-modules | https://github.com/nodejs/node/commit/7b76acb6c87b016d815cb32443446f2f7445e6b5 |
| 7b76acb | https://github.com/nodejs/node/commit/7b76acb6c87b016d815cb32443446f2f7445e6b5 |
| #27124 | https://github.com/nodejs/node/pull/27124 |
| #25112 | https://github.com/nodejs/node/pull/25112 |
| #27727 | https://github.com/nodejs/node/pull/27727 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25112 |
|
| https://github.com/codebytere |
|
codebytere
| https://github.com/codebytere |
|
| https://github.com/nodejs/node/pull/25112/files/7279edb4701904c04865ed641663d1fd583b8520 |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
| https://github.com/nodejs/node/pull/25112/files/7279edb4701904c04865ed641663d1fd583b8520 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/25112 |
|
| https://github.com/ofrobots |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/codebytere |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |