| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e7ab7420-804e-e65e-a761-6729d8bf551b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 839E:258BE8:1D7EECE:270BCBD:696AFE3E |
| html-safe-nonce | a33405e0c791799cd92c935d4ae7324f458f3a6dd0bdc6a3229f5b3cd9855b3b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzlFOjI1OEJFODoxRDdFRUNFOjI3MEJDQkQ6Njk2QUZFM0UiLCJ2aXNpdG9yX2lkIjoiMjEwMjc1Mjk1Njk1MDE4MzQ4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 36d547b2f8189143516eb66c7760ce55269f537c1caa25b4752a34ffd67de3ea |
| hovercard-subject-tag | pull_request:239215850 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25090/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c047ca4cf398ef34587a3847f4b53520371fae9ae5d025dba4b8dd7d435f4254/nodejs/node/pull/25090 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c047ca4cf398ef34587a3847f4b53520371fae9ae5d025dba4b8dd7d435f4254/nodejs/node/pull/25090 |
| og:image:alt | This commit adds stricter type checking to the inspectOptions option to the Console constructor.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are incl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25090#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25090 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25090 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25090 |
| Reload | https://github.com/nodejs/node/pull/25090 |
| Reload | https://github.com/nodejs/node/pull/25090 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25090 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/25090 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/25090#issue-comment-box |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:console | https://github.com/cjihrig/node/tree/console |
|
console: improve inspectOptions validation
| https://github.com/nodejs/node/pull/25090#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:console | https://github.com/cjihrig/node/tree/console |
|
Conversation
5
| https://github.com/nodejs/node/pull/25090 |
|
Commits
1
| https://github.com/nodejs/node/pull/25090/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/25090/checks |
|
Files changed
| https://github.com/nodejs/node/pull/25090/files |
| Please reload this page | https://github.com/nodejs/node/pull/25090 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 17, 2018 | https://github.com/nodejs/node/pull/25090#issue-391803337 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25090 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 17, 2018 | https://github.com/nodejs/node/pull/25090#issuecomment-447917926 |
| @cjihrig | https://github.com/cjihrig |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1981/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1981/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25090 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
console
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aconsole |
| Dec 17, 2018 | https://github.com/nodejs/node/pull/25090#event-2030815831 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Dec 17, 2018
| https://github.com/nodejs/node/pull/25090#pullrequestreview-185701866 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25090/files |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Dec 17, 2018
| https://github.com/nodejs/node/pull/25090#pullrequestreview-185758847 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25090/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Dec 17, 2018
| https://github.com/nodejs/node/pull/25090#pullrequestreview-185785545 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25090/files |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
|
Dec 18, 2018
| https://github.com/nodejs/node/pull/25090#pullrequestreview-185893844 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25090/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/25090#issuecomment-448088310 |
| https://ci.nodejs.org/job/node-test-pull-request/19628/ | https://ci.nodejs.org/job/node-test-pull-request/19628/ |
| Please reload this page | https://github.com/nodejs/node/pull/25090 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 18, 2018 | https://github.com/nodejs/node/pull/25090#event-2031967921 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 18, 2018
| https://github.com/nodejs/node/pull/25090#pullrequestreview-186122632 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25090/files |
|
| https://github.com/cjihrig |
| console: improve inspectOptions validation | https://github.com/nodejs/node/pull/25090/commits/bf36f0755c0a41702fe506bcfc90d156030d0497 |
| bf36f07 | https://github.com/nodejs/node/pull/25090/commits/bf36f0755c0a41702fe506bcfc90d156030d0497 |
| nodejs#25090 | https://github.com/nodejs/node/pull/25090 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/575ef02517debaf97e7f6bead0104f833126f45e..bf36f0755c0a41702fe506bcfc90d156030d0497 |
| 575ef02 | https://github.com/nodejs/node/commit/575ef02517debaf97e7f6bead0104f833126f45e |
| bf36f07 | https://github.com/nodejs/node/commit/bf36f0755c0a41702fe506bcfc90d156030d0497 |
|
Compare
| https://github.com/nodejs/node/compare/575ef02517debaf97e7f6bead0104f833126f45e..bf36f0755c0a41702fe506bcfc90d156030d0497 |
| December 19, 2018 17:19 | https://github.com/nodejs/node/pull/25090#event-2036278792 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| bf36f07 | https://github.com/nodejs/node/commit/bf36f0755c0a41702fe506bcfc90d156030d0497 |
| Dec 19, 2018 | https://github.com/nodejs/node/pull/25090#event-2036282742 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| December 19, 2018 17:21 | https://github.com/nodejs/node/pull/25090#event-2036283025 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
v11.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av11.x |
| Dec 25, 2018 | https://github.com/nodejs/node/pull/25090#event-2043585583 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 25, 2018 | https://github.com/nodejs/node/pull/25090#issuecomment-449812039 |
| Please reload this page | https://github.com/nodejs/node/pull/25090 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backport-requested-v11.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v11.x |
|
v11.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av11.x |
| Dec 25, 2018 | https://github.com/nodejs/node/pull/25090#event-2043585823 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jan 1, 2019 | https://github.com/nodejs/node/pull/25090#issuecomment-450730628 |
| #24978 | https://github.com/nodejs/node/pull/24978 |
| Please reload this page | https://github.com/nodejs/node/pull/25090 |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 10, 2019
| https://github.com/nodejs/node/pull/25090#ref-commit-049b24d |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
| console: improve inspectOptions validation | https://github.com/nodejs/node/commit/049b24d3b9af675911b09cad2cbc1b4cc967b9d8 |
| 049b24d | https://github.com/nodejs/node/commit/049b24d3b9af675911b09cad2cbc1b4cc967b9d8 |
| #25090 | https://github.com/nodejs/node/pull/25090 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
backported-to-v11.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v11.x |
|
backport-requested-v11.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v11.x |
| Jan 10, 2019 | https://github.com/nodejs/node/pull/25090#event-2064685351 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Jan 10, 2019 | https://github.com/nodejs/node/pull/25090#issuecomment-452931721 |
| Please reload this page | https://github.com/nodejs/node/pull/25090 |
| addaleax | https://github.com/addaleax |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/25090#ref-commit-272ddb1 |
|
| https://github.com/cjihrig |
|
| https://github.com/addaleax |
| console: improve inspectOptions validation | https://github.com/nodejs/node/commit/272ddb1765f732b119d3d74150b00591a363a56f |
| 272ddb1 | https://github.com/nodejs/node/commit/272ddb1765f732b119d3d74150b00591a363a56f |
| #25090 | https://github.com/nodejs/node/pull/25090 |
| refack | https://github.com/refack |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/25090#ref-commit-5614814 |
|
| https://github.com/cjihrig |
|
| https://github.com/refack |
| console: improve inspectOptions validation | https://github.com/refack/node/commit/56148143e8f0ee9460a20dcffffb99d25a7046e1 |
| 5614814 | https://github.com/refack/node/commit/56148143e8f0ee9460a20dcffffb99d25a7046e1 |
| nodejs#25090 | https://github.com/nodejs/node/pull/25090 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jan 16, 2019
| https://github.com/nodejs/node/pull/25090#ref-pullrequest-399868555 |
|
v11.7.0 proposal
#25537
| https://github.com/nodejs/node/pull/25537 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2019
| https://github.com/nodejs/node/pull/25090#ref-pullrequest-402909465 |
|
v11.8.0 proposal
#25687
| https://github.com/nodejs/node/pull/25687 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
backport-requested-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x |
| Jul 2, 2019 | https://github.com/nodejs/node/pull/25090#event-2454837774 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25090 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/25090/files/575ef02517debaf97e7f6bead0104f833126f45e |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/25090/files/575ef02517debaf97e7f6bead0104f833126f45e |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/25090/files/575ef02517debaf97e7f6bead0104f833126f45e |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/25090/files/575ef02517debaf97e7f6bead0104f833126f45e |
|
| https://github.com/antsmartian |
|
antsmartian
| https://github.com/antsmartian |
|
| https://github.com/nodejs/node/pull/25090/files/575ef02517debaf97e7f6bead0104f833126f45e |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
console
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aconsole |
| Please reload this page | https://github.com/nodejs/node/pull/25090 |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
|
| https://github.com/targos |
|
| https://github.com/BridgeAR |
|
| https://github.com/jasnell |
|
| https://github.com/antsmartian |
|
| https://github.com/lpinca |
|
| https://github.com/BethGriggs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |