René's URL Explorer Experiment


Title: src: handle empty Maybe in uv binding initialize by addaleax · Pull Request #25079 · nodejs/node · GitHub

Open Graph Title: src: handle empty Maybe in uv binding initialize by addaleax · Pull Request #25079 · nodejs/node

X Title: src: handle empty Maybe in uv binding initialize by addaleax · Pull Request #25079 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This can fail when terminating a Worker that loads the uv binding at the same time. Refs: #25061 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follo...

X Description: This can fail when terminating a Worker that loads the uv binding at the same time. Refs: #25061 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follo...

Opengraph URL: https://github.com/nodejs/node/pull/25079

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a844cc3a-a425-7a9a-0e8d-8ff62dffb305
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC3E:1E70:D6019B:125CEE8:6A4ECD0D
html-safe-nonceded52a02d59affed640463ef0a28f95798babb92c9730434fe37fa91d18c02bf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzNFOjFFNzA6RDYwMTlCOjEyNUNFRTg6NkE0RUNEMEQiLCJ2aXNpdG9yX2lkIjoiNzIyODU1OTM3NjkwNjExMjI2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace128a13c2aa13564d8a1b6f3177607bf95d6966fa8bc1dcc598082ab4c5db7ea
hovercard-subject-tagpull_request:239005381
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25079/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/392097ffe97b5fdd46af4eea241c534b9ee927b9dc75658faaebf0e6e9260448/nodejs/node/pull/25079
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/392097ffe97b5fdd46af4eea241c534b9ee927b9dc75658faaebf0e6e9260448/nodejs/node/pull/25079
og:image:altThis can fail when terminating a Worker that loads the uv binding at the same time. Refs: #25061 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25079#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25079
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25079
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25079
Reloadhttps://github.com/nodejs/node/pull/25079
Reloadhttps://github.com/nodejs/node/pull/25079
Please reload this pagehttps://github.com/nodejs/node/pull/25079
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25079
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:uv-binding-map-sethttps://github.com/addaleax/node/tree/uv-binding-map-set
Conversationhttps://github.com/nodejs/node/pull/25079
Commits1 (1)https://github.com/nodejs/node/pull/25079/commits
Checkshttps://github.com/nodejs/node/pull/25079/checks
Files changedhttps://github.com/nodejs/node/pull/25079/files
src: handle empty Maybe in uv binding initializehttps://github.com/nodejs/node/pull/25079#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:uv-binding-map-sethttps://github.com/addaleax/node/tree/uv-binding-map-set
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 17, 2018https://github.com/nodejs/node/pull/25079#issue-391527553
#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25079
https://github.com/addaleax
src: handle empty Maybe in uv binding initializehttps://github.com/nodejs/node/pull/25079/commits/553eb4214be252f238d4c62cb120b682b0b5fa2a
553eb42https://github.com/nodejs/node/pull/25079/commits/553eb4214be252f238d4c62cb120b682b0b5fa2a
nodejs#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
gireeshpunathilhttps://github.com/gireeshpunathil
December 17, 2018 01:24https://github.com/nodejs/node/pull/25079#event-2029148155
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 17, 2018https://github.com/nodejs/node/pull/25079#issuecomment-447695983
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1974/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1974/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25079
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
libuv https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alibuv
Dec 17, 2018https://github.com/nodejs/node/pull/25079#event-2029148169
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 17, 2018 https://github.com/nodejs/node/pull/25079#ref-pullrequest-391395903
src: dispose of V8 platform in process.exit() #25061 https://github.com/nodejs/node/pull/25061
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 17, 2018 https://github.com/nodejs/node/pull/25079#pullrequestreview-185435292
View reviewed changes https://github.com/nodejs/node/pull/25079/files/553eb4214be252f238d4c62cb120b682b0b5fa2a
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 17, 2018 https://github.com/nodejs/node/pull/25079#pullrequestreview-185436400
View reviewed changes https://github.com/nodejs/node/pull/25079/files/553eb4214be252f238d4c62cb120b682b0b5fa2a
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 17, 2018https://github.com/nodejs/node/pull/25079#issuecomment-447719583
Please reload this pagehttps://github.com/nodejs/node/pull/25079
https://ci.nodejs.org/job/node-test-pull-request/19592/https://ci.nodejs.org/job/node-test-pull-request/19592/
Please reload this pagehttps://github.com/nodejs/node/pull/25079
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 17, 2018 https://github.com/nodejs/node/pull/25079#pullrequestreview-185449316
View reviewed changes https://github.com/nodejs/node/pull/25079/files/553eb4214be252f238d4c62cb120b682b0b5fa2a
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 17, 2018 https://github.com/nodejs/node/pull/25079#ref-issue-390527984
exit race between main and worker threads #25007 https://github.com/nodejs/node/issues/25007
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 17, 2018 https://github.com/nodejs/node/pull/25079#pullrequestreview-185594150
View reviewed changes https://github.com/nodejs/node/pull/25079/files/553eb4214be252f238d4c62cb120b682b0b5fa2a
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 17, 2018https://github.com/nodejs/node/pull/25079#event-2030668066
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 19, 2018 https://github.com/nodejs/node/pull/25079#ref-issue-392671852
Investigate test-worker-messageport-transfer-terminate #25134 https://github.com/nodejs/node/issues/25134
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 19, 2018https://github.com/nodejs/node/pull/25079#issuecomment-448659303
67f9582https://github.com/nodejs/node/commit/67f95825e5ad3f80d007613df8b21f4f2819c635
Please reload this pagehttps://github.com/nodejs/node/pull/25079
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 19, 2018https://github.com/nodejs/node/pull/25079#event-2036160283
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
December 19, 2018 16:33https://github.com/nodejs/node/pull/25079#event-2036160525
addaleaxhttps://github.com/addaleax
Dec 19, 2018 https://github.com/nodejs/node/pull/25079#ref-commit-67f9582
https://github.com/addaleax
src: handle empty Maybe in uv binding initializehttps://github.com/nodejs/node/commit/67f95825e5ad3f80d007613df8b21f4f2819c635
67f9582https://github.com/nodejs/node/commit/67f95825e5ad3f80d007613df8b21f4f2819c635
#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
#25134https://github.com/nodejs/node/issues/25134
#25079https://github.com/nodejs/node/pull/25079
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 19, 2018https://github.com/nodejs/node/pull/25079#issuecomment-448733291
Please reload this pagehttps://github.com/nodejs/node/pull/25079
Please reload this pagehttps://github.com/nodejs/node/pull/25079
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 19, 2018https://github.com/nodejs/node/pull/25079#issuecomment-448734749
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/25079
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 19, 2018https://github.com/nodejs/node/pull/25079#issuecomment-448765427
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/25079
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 19, 2018https://github.com/nodejs/node/pull/25079#issuecomment-448767096
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/25079
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/25079#ref-commit-c6388ed
https://github.com/addaleax
https://github.com/MylesBorins
src: handle empty Maybe in uv binding initializehttps://github.com/nodejs/node/commit/c6388edf34394cddce7f4d77d29f0220b411e31a
c6388edhttps://github.com/nodejs/node/commit/c6388edf34394cddce7f4d77d29f0220b411e31a
#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
#25134https://github.com/nodejs/node/issues/25134
#25079https://github.com/nodejs/node/pull/25079
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/25079#ref-pullrequest-393620382
v11.6.0 proposal #25175 https://github.com/nodejs/node/pull/25175
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/25079#ref-commit-04f7d2a
https://github.com/refack
src: handle empty Maybe in uv binding initializehttps://github.com/refack/node/commit/04f7d2a4ea986137bda8bb9b446cfa6778d8f43b
04f7d2ahttps://github.com/refack/node/commit/04f7d2a4ea986137bda8bb9b446cfa6778d8f43b
nodejs#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
nodejs#25134https://github.com/nodejs/node/issues/25134
nodejs#25079https://github.com/nodejs/node/pull/25079
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jul 2, 2019https://github.com/nodejs/node/pull/25079#event-2454833213
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019 https://github.com/nodejs/node/pull/25079#ref-pullrequest-472086140
[backport v10.x] src: handle empty Maybe in uv binding initialize #28832 https://github.com/nodejs/node/pull/28832
https://github.com/Trott
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25079
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 26, 2019 https://github.com/nodejs/node/pull/25079#ref-pullrequest-471984403
[v10.x] doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION #28827 https://github.com/nodejs/node/pull/28827
Trotthttps://github.com/Trott
Jul 26, 2019 https://github.com/nodejs/node/pull/25079#ref-commit-ca4a22e
https://github.com/addaleax
https://github.com/Trott
src: handle empty Maybe in uv binding initializehttps://github.com/Trott/io.js/commit/ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
ca4a22ehttps://github.com/Trott/io.js/commit/ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
nodejs#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
nodejs#25134https://github.com/nodejs/node/issues/25134
nodejs#25079https://github.com/nodejs/node/pull/25079
nodejs#28832https://github.com/nodejs/node/pull/28832
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 26, 2019https://github.com/nodejs/node/pull/25079#issuecomment-515322600
@addaleaxhttps://github.com/addaleax
#28832https://github.com/nodejs/node/pull/28832
Please reload this pagehttps://github.com/nodejs/node/pull/25079
BethGriggshttps://github.com/BethGriggs
Jul 30, 2019 https://github.com/nodejs/node/pull/25079#ref-commit-0339fba
https://github.com/addaleax
https://github.com/BethGriggs
src: handle empty Maybe in uv binding initializehttps://github.com/nodejs/node/commit/0339fba1bb39535517176978815b892ae70882ed
0339fbahttps://github.com/nodejs/node/commit/0339fba1bb39535517176978815b892ae70882ed
#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
#25134https://github.com/nodejs/node/issues/25134
#25079https://github.com/nodejs/node/pull/25079
#28832https://github.com/nodejs/node/pull/28832
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25079
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/25079/files/553eb4214be252f238d4c62cb120b682b0b5fa2a
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/25079/files/553eb4214be252f238d4c62cb120b682b0b5fa2a
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/25079/files/553eb4214be252f238d4c62cb120b682b0b5fa2a
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/25079/files/553eb4214be252f238d4c62cb120b682b0b5fa2a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
libuv https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alibuv
Please reload this pagehttps://github.com/nodejs/node/pull/25079
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/joyeecheung
https://github.com/Trott
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/gireeshpunathil
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.