René's URL Explorer Experiment


Title: vm: reuse validateString of internal/validators by ZYSzys · Pull Request #25074 · nodejs/node · GitHub

Open Graph Title: vm: reuse validateString of internal/validators by ZYSzys · Pull Request #25074 · nodejs/node

X Title: vm: reuse validateString of internal/validators by ZYSzys · Pull Request #25074 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The validateString function in vm.js is just one more judgement which validates whether prop !== undefined than the validateString function in internal/validators: node/lib/vm.js ...

X Description: The validateString function in vm.js is just one more judgement which validates whether prop !== undefined than the validateString function in internal/validators: node/lib/vm.js ...

Opengraph URL: https://github.com/nodejs/node/pull/25074

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:96e4dc1f-bf74-6256-be17-36dbb2476598
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8C6:3C8683:6083264:874C3AF:6A5028B0
html-safe-nonceed9bc8ab216750a564461a2b7006800e22aeb2f54ccf3664c5adc8e46231ed0e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEM2OjNDODY4Mzo2MDgzMjY0Ojg3NEMzQUY6NkE1MDI4QjAiLCJ2aXNpdG9yX2lkIjoiNTQ2MjczOTAxNjg4ODYyNTMyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace8ca0903c4e0a6d4e9c53cfbbdce97341da22c7b4adc1bdbacd737be514f440d
hovercard-subject-tagpull_request:238952155
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25074/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e1af0eeb4e5e5c5354fd19e0089ef6c49554fb1729eaa264c56998df26bab47e/nodejs/node/pull/25074
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e1af0eeb4e5e5c5354fd19e0089ef6c49554fb1729eaa264c56998df26bab47e/nodejs/node/pull/25074
og:image:altThe validateString function in vm.js is just one more judgement which validates whether prop !== undefined than the validateString function in internal/validators: node/lib/vm.js ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameZYSzys
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released90666eaf032b7eb8975a378efe38e37f4ebb96c
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25074#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25074
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25074
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25074
Reloadhttps://github.com/nodejs/node/pull/25074
Reloadhttps://github.com/nodejs/node/pull/25074
Please reload this pagehttps://github.com/nodejs/node/pull/25074
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25074
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 977 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/25074
Commits1 (1)https://github.com/nodejs/node/pull/25074/commits
Checkshttps://github.com/nodejs/node/pull/25074/checks
Files changedhttps://github.com/nodejs/node/pull/25074/files
vm: reuse validateString of internal/validatorshttps://github.com/nodejs/node/pull/25074#top
ZYSzyshttps://github.com/ZYSzys
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Dec 16, 2018https://github.com/nodejs/node/pull/25074#issue-391444556
node/lib/vm.jshttps://github.com/nodejs/node/blob/8f4b924f4a7b37bd16ddff65329c8e96fc5f0f2d/lib/vm.js#L153-L156
8f4b924https://github.com/nodejs/node/commit/8f4b924f4a7b37bd16ddff65329c8e96fc5f0f2d
node/lib/internal/validators.jshttps://github.com/nodejs/node/blob/8f4b924f4a7b37bd16ddff65329c8e96fc5f0f2d/lib/internal/validators.js#L123-L126
8f4b924https://github.com/nodejs/node/commit/8f4b924f4a7b37bd16ddff65329c8e96fc5f0f2d
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25074
https://github.com/ZYSzys
vm: reuse validateString of internal/validatorshttps://github.com/nodejs/node/pull/25074/commits/40ac46a4f0487b905ed0d9743ffc2d763449af3a
40ac46ahttps://github.com/nodejs/node/pull/25074/commits/40ac46a4f0487b905ed0d9743ffc2d763449af3a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Dec 16, 2018https://github.com/nodejs/node/pull/25074#event-2028757332
https://github.com/targos
targoshttps://github.com/targos
Dec 16, 2018 https://github.com/nodejs/node/pull/25074#pullrequestreview-185377935
View reviewed changes https://github.com/nodejs/node/pull/25074/files/40ac46a4f0487b905ed0d9743ffc2d763449af3a
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Dec 16, 2018 https://github.com/nodejs/node/pull/25074#pullrequestreview-185384399
View reviewed changes https://github.com/nodejs/node/pull/25074/files/40ac46a4f0487b905ed0d9743ffc2d763449af3a
antsmartianhttps://github.com/antsmartian
https://github.com/nodejs/node/pull/25074#pullrequestreview-185384399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25074
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Dec 16, 2018https://github.com/nodejs/node/pull/25074#issuecomment-447637240
Please reload this pagehttps://github.com/nodejs/node/pull/25074
https://ci.nodejs.org/job/node-test-pull-request/19581/https://ci.nodejs.org/job/node-test-pull-request/19581/
Please reload this pagehttps://github.com/nodejs/node/pull/25074
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 16, 2018https://github.com/nodejs/node/pull/25074#event-2028825977
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 16, 2018 https://github.com/nodejs/node/pull/25074#pullrequestreview-185401859
View reviewed changes https://github.com/nodejs/node/pull/25074/files/40ac46a4f0487b905ed0d9743ffc2d763449af3a
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 17, 2018 https://github.com/nodejs/node/pull/25074#pullrequestreview-185435846
View reviewed changes https://github.com/nodejs/node/pull/25074/files/40ac46a4f0487b905ed0d9743ffc2d763449af3a
https://github.com/watilde
watildehttps://github.com/watilde
Dec 17, 2018 https://github.com/nodejs/node/pull/25074#pullrequestreview-185623966
View reviewed changes https://github.com/nodejs/node/pull/25074/files/40ac46a4f0487b905ed0d9743ffc2d763449af3a
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 20, 2018https://github.com/nodejs/node/pull/25074#issuecomment-448867975
e5966efhttps://github.com/nodejs/node/commit/e5966ef60c24609c1bd716742836dc40be64db0b
Please reload this pagehttps://github.com/nodejs/node/pull/25074
https://github.com/danbev
danbevhttps://github.com/danbev
Dec 20, 2018https://github.com/nodejs/node/pull/25074#event-2037448466
danbevhttps://github.com/danbev
Dec 20, 2018 https://github.com/nodejs/node/pull/25074#ref-commit-e5966ef
https://github.com/ZYSzys
https://github.com/danbev
vm: reuse validateString of internal/validatorshttps://github.com/nodejs/node/commit/e5966ef60c24609c1bd716742836dc40be64db0b
e5966efhttps://github.com/nodejs/node/commit/e5966ef60c24609c1bd716742836dc40be64db0b
#25074https://github.com/nodejs/node/pull/25074
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
December 20, 2018 04:51https://github.com/nodejs/node/pull/25074#event-2037456652
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/25074#ref-commit-810e6ea
https://github.com/ZYSzys
https://github.com/MylesBorins
vm: reuse validateString of internal/validatorshttps://github.com/nodejs/node/commit/810e6ea4713f064321d0f86d65494582d1f6934a
810e6eahttps://github.com/nodejs/node/commit/810e6ea4713f064321d0f86d65494582d1f6934a
#25074https://github.com/nodejs/node/pull/25074
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/25074#ref-pullrequest-393620382
v11.6.0 proposal #25175 https://github.com/nodejs/node/pull/25175
MylesBorinshttps://github.com/MylesBorins
Dec 26, 2018 https://github.com/nodejs/node/pull/25074#ref-commit-7df59f8
https://github.com/ZYSzys
https://github.com/MylesBorins
vm: reuse validateString of internal/validatorshttps://github.com/nodejs/node/commit/7df59f824b2490512cd104d11f55bf1910d181af
7df59f8https://github.com/nodejs/node/commit/7df59f824b2490512cd104d11f55bf1910d181af
#25074https://github.com/nodejs/node/pull/25074
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/25074#ref-commit-8e7403d
https://github.com/ZYSzys
https://github.com/refack
vm: reuse validateString of internal/validatorshttps://github.com/refack/node/commit/8e7403d1ee716876f3e1360f6657a65b3da9d4d7
8e7403dhttps://github.com/refack/node/commit/8e7403d1ee716876f3e1360f6657a65b3da9d4d7
nodejs#25074https://github.com/nodejs/node/pull/25074
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jul 2, 2019https://github.com/nodejs/node/pull/25074#event-2454849960
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25074
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/25074/files/40ac46a4f0487b905ed0d9743ffc2d763449af3a
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/25074/files/40ac46a4f0487b905ed0d9743ffc2d763449af3a
https://github.com/watilde
watilde https://github.com/watilde
https://github.com/nodejs/node/pull/25074/files/40ac46a4f0487b905ed0d9743ffc2d763449af3a
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/25074/files/40ac46a4f0487b905ed0d9743ffc2d763449af3a
https://github.com/antsmartian
antsmartian https://github.com/antsmartian
https://github.com/nodejs/node/pull/25074/files/40ac46a4f0487b905ed0d9743ffc2d763449af3a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Please reload this pagehttps://github.com/nodejs/node/pull/25074
https://github.com/ZYSzys
https://github.com/antsmartian
https://github.com/danbev
https://github.com/jasnell
https://github.com/lpinca
https://github.com/watilde
https://github.com/targos
https://github.com/BethGriggs
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.