René's URL Explorer Experiment


Title: src: dispose of V8 platform in `process.exit()` by addaleax · Pull Request #25061 · nodejs/node · GitHub

Open Graph Title: src: dispose of V8 platform in `process.exit()` by addaleax · Pull Request #25061 · nodejs/node

X Title: src: dispose of V8 platform in `process.exit()` by addaleax · Pull Request #25061 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is essentially a re-do of #24828, with the addition of also shutting down worker threads before exiting. As pointed out by @Trott, this also is unlikely to fully resolve the issues we were see...

X Description: This is essentially a re-do of #24828, with the addition of also shutting down worker threads before exiting. As pointed out by @Trott, this also is unlikely to fully resolve the issues we were see...

Opengraph URL: https://github.com/nodejs/node/pull/25061

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:990a588a-e1d8-e7ad-8eb7-1ea00bf7dbc1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC5C:2DC8D1:26417BD:3531E5D:6A4F4CB4
html-safe-nonce5dd48ae8bb07685a28c81b945118c0e79a253cab81da9a5c2de455e79916d7d3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzVDOjJEQzhEMToyNjQxN0JEOjM1MzFFNUQ6NkE0RjRDQjQiLCJ2aXNpdG9yX2lkIjoiOTExNzYzNDE1NzE3Mzc1NTA2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4cc76085923f8c4dfe18f1fe85cff556b729a824174115b5795be4f2e3071009
hovercard-subject-tagpull_request:238922139
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25061/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dc7183ccae677dfc33f6c6a96d176f05231c737105ccb1bfc2fe85332ca064de/nodejs/node/pull/25061
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dc7183ccae677dfc33f6c6a96d176f05231c737105ccb1bfc2fe85332ca064de/nodejs/node/pull/25061
og:image:altThis is essentially a re-do of #24828, with the addition of also shutting down worker threads before exiting. As pointed out by @Trott, this also is unlikely to fully resolve the issues we were see...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25061#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25061
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25061
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25061
Reloadhttps://github.com/nodejs/node/pull/25061
Reloadhttps://github.com/nodejs/node/pull/25061
Please reload this pagehttps://github.com/nodejs/node/pull/25061
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25061
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 969 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:tear-down-platformhttps://github.com/addaleax/node/tree/tear-down-platform
Conversationhttps://github.com/nodejs/node/pull/25061
Commits1 (1)https://github.com/nodejs/node/pull/25061/commits
Checkshttps://github.com/nodejs/node/pull/25061/checks
Files changedhttps://github.com/nodejs/node/pull/25061/files
src: dispose of V8 platform in process.exit()https://github.com/nodejs/node/pull/25061#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:tear-down-platformhttps://github.com/addaleax/node/tree/tear-down-platform
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 15, 2018https://github.com/nodejs/node/pull/25061#issue-391395903
#24828https://github.com/nodejs/node/pull/24828
@Trotthttps://github.com/Trott
#24403https://github.com/nodejs/node/issues/24403
#25007https://github.com/nodejs/node/issues/25007
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/addaleax
src: dispose of V8 platform in process.exit()https://github.com/nodejs/node/pull/25061/commits/7b38154baf346642ae98d34696ac0f089b889e64
7b38154https://github.com/nodejs/node/pull/25061/commits/7b38154baf346642ae98d34696ac0f089b889e64
nodejs#24403https://github.com/nodejs/node/issues/24403
nodejs#25007https://github.com/nodejs/node/issues/25007
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
bnoordhuishttps://github.com/bnoordhuis
gireeshpunathilhttps://github.com/gireeshpunathil
joyeecheunghttps://github.com/joyeecheung
December 15, 2018 17:20https://github.com/nodejs/node/pull/25061#event-2028547794
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 15, 2018https://github.com/nodejs/node/pull/25061#issuecomment-447583734
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1960/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1960/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Dec 15, 2018https://github.com/nodejs/node/pull/25061#event-2028547817
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 15, 2018 https://github.com/nodejs/node/pull/25061#ref-issue-390527984
exit race between main and worker threads #25007 https://github.com/nodejs/node/issues/25007
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 16, 2018https://github.com/nodejs/node/pull/25061#issuecomment-447640776
@addaleaxhttps://github.com/addaleax
test casehttps://github.com/nodejs/node/issues/25007#issue-390527984
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 16, 2018https://github.com/nodejs/node/pull/25061#issuecomment-447641902
@gireeshpunathilhttps://github.com/gireeshpunathil
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 16, 2018 https://github.com/nodejs/node/pull/25061#pullrequestreview-185386817
View reviewed changes https://github.com/nodejs/node/pull/25061/files/7b38154baf346642ae98d34696ac0f089b889e64
src/env.cchttps://github.com/nodejs/node/pull/25061/files/7b38154baf346642ae98d34696ac0f089b889e64#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 16, 2018https://github.com/nodejs/node/pull/25061#discussion_r241979840
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25061
addaleaxhttps://github.com/addaleax
Dec 16, 2018https://github.com/nodejs/node/pull/25061#discussion_r241979926
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 16, 2018https://github.com/nodejs/node/pull/25061#issuecomment-447642005
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 16, 2018 https://github.com/nodejs/node/pull/25061#pullrequestreview-185387709
View reviewed changes https://github.com/nodejs/node/pull/25061/files/7b38154baf346642ae98d34696ac0f089b889e64
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 16, 2018https://github.com/nodejs/node/pull/25061#issuecomment-447643843
@gireeshpunathilhttps://github.com/gireeshpunathil
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 16, 2018 https://github.com/nodejs/node/pull/25061#ref-pullrequest-391468423
worker: fix nullptr deref after MessagePort deser failure #25076 https://github.com/nodejs/node/pull/25076
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 16, 2018https://github.com/nodejs/node/pull/25061#issuecomment-447648475
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 16, 2018https://github.com/nodejs/node/pull/25061#issuecomment-447650003
@gireeshpunathilhttps://github.com/gireeshpunathil
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 16, 2018https://github.com/nodejs/node/pull/25061#issuecomment-447654779
Please reload this pagehttps://github.com/nodejs/node/pull/25061
addaleaxhttps://github.com/addaleax
Dec 17, 2018 https://github.com/nodejs/node/pull/25061#ref-commit-553eb42
https://github.com/addaleax
src: handle empty Maybe in uv binding initializehttps://github.com/addaleax/node/commit/553eb4214be252f238d4c62cb120b682b0b5fa2a
553eb42https://github.com/addaleax/node/commit/553eb4214be252f238d4c62cb120b682b0b5fa2a
nodejs#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 17, 2018 https://github.com/nodejs/node/pull/25061#ref-pullrequest-391527553
src: handle empty Maybe in uv binding initialize #25079 https://github.com/nodejs/node/pull/25079
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 17, 2018https://github.com/nodejs/node/pull/25061#issuecomment-447696051
@gireeshpunathilhttps://github.com/gireeshpunathil
#25079https://github.com/nodejs/node/pull/25079
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 17, 2018https://github.com/nodejs/node/pull/25061#issuecomment-447733254
@addaleaxhttps://github.com/addaleax
#25076https://github.com/nodejs/node/pull/25076
#25079https://github.com/nodejs/node/pull/25079
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 17, 2018https://github.com/nodejs/node/pull/25061#issuecomment-447982439
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://ci.nodejs.org/job/node-test-pull-request/19626/https://ci.nodejs.org/job/node-test-pull-request/19626/
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 17, 2018https://github.com/nodejs/node/pull/25061#event-2031268796
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 17, 2018 https://github.com/nodejs/node/pull/25061#pullrequestreview-185854370
View reviewed changes https://github.com/nodejs/node/pull/25061/files/7b38154baf346642ae98d34696ac0f089b889e64
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 18, 2018https://github.com/nodejs/node/pull/25061#issuecomment-448070088
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/Trott
Trotthttps://github.com/Trott
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Dec 18, 2018https://github.com/nodejs/node/pull/25061#event-2031912375
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 18, 2018https://github.com/nodejs/node/pull/25061#issuecomment-448080045
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Dec 18, 2018https://github.com/nodejs/node/pull/25061#issuecomment-448086335
gireeshpunathil@6aba136https://github.com/gireeshpunathil/node/commit/6aba136b1605beb210d8e43f668a39ab8046510f
e273abchttps://github.com/nodejs/node/commit/e273abc01be9f04511e44cacea20c4f4935b970f
9f7e3a4https://github.com/nodejs/node/commit/9f7e3a404096db60438f6dc305b0a5fa4ecddae7
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Dec 18, 2018https://github.com/nodejs/node/pull/25061#event-2031955229
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 18, 2018https://github.com/nodejs/node/pull/25061#issuecomment-448160140
e273abchttps://github.com/nodejs/node/commit/e273abc01be9f04511e44cacea20c4f4935b970f
Please reload this pagehttps://github.com/nodejs/node/pull/25061
test: exit sequence sanity tests #25083 https://github.com/nodejs/node/pull/25083
investigate flaky test-inspector-debug-end on AIX #25047 https://github.com/nodejs/node/issues/25047
Investigate flaky test-child-process-execFile #25029 https://github.com/nodejs/node/issues/25029
Investigate flaky sequential/test-child-process-execsync on AIX #24921 https://github.com/nodejs/node/issues/24921
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Feb 4, 2019 https://github.com/nodejs/node/pull/25061#ref-issue-404773945
Node.js v10.15.0 segfault in BackgroundRunner → CancelableTask::Run → ConcurrentMarking::Run #25814 https://github.com/nodejs/node/issues/25814
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Feb 11, 2019https://github.com/nodejs/node/pull/25061#issuecomment-462225383
#25814https://github.com/nodejs/node/issues/25814
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 11, 2019 https://github.com/nodejs/node/pull/25061#ref-pullrequest-408892814
[v10.x] src: dispose of V8 platform in process.exit() #26048 https://github.com/nodejs/node/pull/26048
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 11, 2019https://github.com/nodejs/node/pull/25061#issuecomment-462417570
@gireeshpunathilhttps://github.com/gireeshpunathil
#26048https://github.com/nodejs/node/pull/26048
Please reload this pagehttps://github.com/nodejs/node/pull/25061
BethGriggshttps://github.com/BethGriggs
Feb 13, 2019 https://github.com/nodejs/node/pull/25061#ref-commit-3c3f350
https://github.com/addaleax
https://github.com/BethGriggs
src: dispose of V8 platform in process.exit()https://github.com/nodejs/node/commit/3c3f350fa4d58eb070903d8703fa02bddca01685
3c3f350https://github.com/nodejs/node/commit/3c3f350fa4d58eb070903d8703fa02bddca01685
#24403https://github.com/nodejs/node/issues/24403
#25007https://github.com/nodejs/node/issues/25007
#26048https://github.com/nodejs/node/pull/26048
#25061https://github.com/nodejs/node/pull/25061
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 19, 2019https://github.com/nodejs/node/pull/25061#issuecomment-465214090
Please reload this pagehttps://github.com/nodejs/node/pull/25061
BethGriggshttps://github.com/BethGriggs
Mar 27, 2019 https://github.com/nodejs/node/pull/25061#ref-commit-25ca9f1
https://github.com/addaleax
https://github.com/BethGriggs
src: dispose of V8 platform in process.exit()https://github.com/MylesBorins/node/commit/25ca9f177bb1208692b296748b3890d2ee15cb18
25ca9f1https://github.com/MylesBorins/node/commit/25ca9f177bb1208692b296748b3890d2ee15cb18
nodejs#24403https://github.com/nodejs/node/issues/24403
nodejs#25007https://github.com/nodejs/node/issues/25007
nodejs#25061https://github.com/nodejs/node/pull/25061
BethGriggshttps://github.com/BethGriggs
Mar 28, 2019 https://github.com/nodejs/node/pull/25061#ref-commit-f4be176
https://github.com/addaleax
https://github.com/BethGriggs
src: dispose of V8 platform in process.exit()https://github.com/nodejs/node/commit/f4be1767a54dd47fbd830a11a1e906829ae02255
f4be176https://github.com/nodejs/node/commit/f4be1767a54dd47fbd830a11a1e906829ae02255
#24403https://github.com/nodejs/node/issues/24403
#25007https://github.com/nodejs/node/issues/25007
#26048https://github.com/nodejs/node/pull/26048
#25061https://github.com/nodejs/node/pull/25061
BethGriggshttps://github.com/BethGriggs
Apr 29, 2019 https://github.com/nodejs/node/pull/25061#ref-commit-df179d7
https://github.com/gireeshpunathil
https://github.com/BethGriggs
test: revoke flaky designation for testshttps://github.com/nodejs/node/commit/df179d7ba86a46122af53627c2a0df0e2d11ac78
df179d7https://github.com/nodejs/node/commit/df179d7ba86a46122af53627c2a0df0e2d11ac78
#25007https://github.com/nodejs/node/issues/25007
#25061https://github.com/nodejs/node/pull/25061
#25611https://github.com/nodejs/node/pull/25611
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
May 1, 2019 https://github.com/nodejs/node/pull/25061#ref-pullrequest-439147711
v10.16.0 proposal #27514 https://github.com/nodejs/node/pull/27514
BethGriggshttps://github.com/BethGriggs
May 10, 2019 https://github.com/nodejs/node/pull/25061#ref-commit-29ed864
https://github.com/gireeshpunathil
https://github.com/BethGriggs
test: revoke flaky designation for testshttps://github.com/nodejs/node/commit/29ed8643bad1387a5fc28fc25f628a0117ef08bb
29ed864https://github.com/nodejs/node/commit/29ed8643bad1387a5fc28fc25f628a0117ef08bb
#25007https://github.com/nodejs/node/issues/25007
#25061https://github.com/nodejs/node/pull/25061
#25611https://github.com/nodejs/node/pull/25611
MylesBorinshttps://github.com/MylesBorins
May 16, 2019 https://github.com/nodejs/node/pull/25061#ref-commit-fbf8e60
https://github.com/gireeshpunathil
https://github.com/MylesBorins
test: revoke flaky designation for testshttps://github.com/nodejs/node/commit/fbf8e60679ca3493a94c02405e23d80214f4d2e6
fbf8e60https://github.com/nodejs/node/commit/fbf8e60679ca3493a94c02405e23d80214f4d2e6
#25007https://github.com/nodejs/node/issues/25007
#25061https://github.com/nodejs/node/pull/25061
#25611https://github.com/nodejs/node/pull/25611
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#315 https://github.com/beevelop/docker-android-nodejs/issues/315
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#316 https://github.com/beevelop/docker-android-nodejs/issues/316
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#317 https://github.com/beevelop/docker-android-nodejs/issues/317
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#318 https://github.com/beevelop/docker-android-nodejs/issues/318
2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#319 https://github.com/beevelop/docker-android-nodejs/issues/319
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 24, 2019 https://github.com/nodejs/node/pull/25061#ref-pullrequest-472086140
[backport v10.x] src: handle empty Maybe in uv binding initialize #28832 https://github.com/nodejs/node/pull/28832
Trotthttps://github.com/Trott
Jul 26, 2019 https://github.com/nodejs/node/pull/25061#ref-commit-ca4a22e
https://github.com/addaleax
https://github.com/Trott
src: handle empty Maybe in uv binding initializehttps://github.com/Trott/io.js/commit/ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
ca4a22ehttps://github.com/Trott/io.js/commit/ca4a22e8d4ae7a6947afb3452e56d2e807e0a635
nodejs#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
nodejs#25134https://github.com/nodejs/node/issues/25134
nodejs#25079https://github.com/nodejs/node/pull/25079
nodejs#28832https://github.com/nodejs/node/pull/28832
BethGriggshttps://github.com/BethGriggs
Jul 30, 2019 https://github.com/nodejs/node/pull/25061#ref-commit-0339fba
https://github.com/addaleax
https://github.com/BethGriggs
src: handle empty Maybe in uv binding initializehttps://github.com/nodejs/node/commit/0339fba1bb39535517176978815b892ae70882ed
0339fbahttps://github.com/nodejs/node/commit/0339fba1bb39535517176978815b892ae70882ed
#25061 (comment)https://github.com/nodejs/node/pull/25061#issuecomment-447648475
#25134https://github.com/nodejs/node/issues/25134
#25079https://github.com/nodejs/node/pull/25079
#28832https://github.com/nodejs/node/pull/28832
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25061
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/25061/files/7b38154baf346642ae98d34696ac0f089b889e64
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/25061/files/7b38154baf346642ae98d34696ac0f089b889e64
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/25061/files/7b38154baf346642ae98d34696ac0f089b889e64
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/25061
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/gireeshpunathil
https://github.com/Trott
https://github.com/MylesBorins
https://github.com/bnoordhuis
https://github.com/joyeecheung
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.