René's URL Explorer Experiment


Title: vm: simplify Script constructor options validation by cjihrig · Pull Request #25054 · nodejs/node · GitHub

Open Graph Title: vm: simplify Script constructor options validation by cjihrig · Pull Request #25054 · nodejs/node

X Title: vm: simplify Script constructor options validation by cjihrig · Pull Request #25054 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit combines two related if statements into an if-else statement. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: This commit combines two related if statements into an if-else statement. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/25054

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d1d86658-7813-8589-f59d-bc01f510cc45
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id91E4:348BD7:3B7F7FB:52A9494:6A4F4D1C
html-safe-nonce63e40ce76df36b81191291ae707f2ee66414e7d50f457ad4d7561a4f3da4992c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUU0OjM0OEJENzozQjdGN0ZCOjUyQTk0OTQ6NkE0RjREMUMiLCJ2aXNpdG9yX2lkIjoiNTgxMjk3NjgxNTE0NTE3NjM0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac70e97bafe8f49040952374edd6e3c042e477dda7e5c9c023a2b16be875842713
hovercard-subject-tagpull_request:238887355
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25054/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/20c28510569330ceae5efbe40d4e2a5746c80896e6b99336559c44d62f9a854a/nodejs/node/pull/25054
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/20c28510569330ceae5efbe40d4e2a5746c80896e6b99336559c44d62f9a854a/nodejs/node/pull/25054
og:image:altThis commit combines two related if statements into an if-else statement. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25054#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25054
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25054
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25054
Reloadhttps://github.com/nodejs/node/pull/25054
Reloadhttps://github.com/nodejs/node/pull/25054
Please reload this pagehttps://github.com/nodejs/node/pull/25054
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25054
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 969 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:elseifhttps://github.com/cjihrig/node/tree/elseif
Conversationhttps://github.com/nodejs/node/pull/25054
Commits1 (1)https://github.com/nodejs/node/pull/25054/commits
Checkshttps://github.com/nodejs/node/pull/25054/checks
Files changedhttps://github.com/nodejs/node/pull/25054/files
vm: simplify Script constructor options validationhttps://github.com/nodejs/node/pull/25054#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:elseifhttps://github.com/cjihrig/node/tree/elseif
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 15, 2018https://github.com/nodejs/node/pull/25054#issue-391338880
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25054
https://github.com/cjihrig
vm: simplify Script constructor options validationhttps://github.com/nodejs/node/pull/25054/commits/7527109eabae44e1eda1281376ff344f23d16d9d
7527109https://github.com/nodejs/node/pull/25054/commits/7527109eabae44e1eda1281376ff344f23d16d9d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 15, 2018https://github.com/nodejs/node/pull/25054#issuecomment-447532752
@cjihrighttps://github.com/cjihrig
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1958/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1958/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25054
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Dec 15, 2018https://github.com/nodejs/node/pull/25054#event-2028286428
https://github.com/targos
targoshttps://github.com/targos
Dec 15, 2018 https://github.com/nodejs/node/pull/25054#pullrequestreview-185345111
View reviewed changes https://github.com/nodejs/node/pull/25054/files/7527109eabae44e1eda1281376ff344f23d16d9d
https://github.com/lpinca
lpincahttps://github.com/lpinca
Dec 15, 2018 https://github.com/nodejs/node/pull/25054#pullrequestreview-185345202
View reviewed changes https://github.com/nodejs/node/pull/25054/files/7527109eabae44e1eda1281376ff344f23d16d9d
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 16, 2018https://github.com/nodejs/node/pull/25054#issuecomment-447661217
https://ci.nodejs.org/job/node-test-pull-request/19586/https://ci.nodejs.org/job/node-test-pull-request/19586/
Please reload this pagehttps://github.com/nodejs/node/pull/25054
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 16, 2018https://github.com/nodejs/node/pull/25054#event-2028955827
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 17, 2018https://github.com/nodejs/node/pull/25054#issuecomment-447717747
Please reload this pagehttps://github.com/nodejs/node/pull/25054
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 17, 2018https://github.com/nodejs/node/pull/25054#event-2029285653
Trotthttps://github.com/Trott
Dec 17, 2018 https://github.com/nodejs/node/pull/25054#ref-commit-52ee55a
https://github.com/cjihrig
https://github.com/Trott
vm: simplify Script constructor options validationhttps://github.com/Trott/io.js/commit/52ee55a06b9c8842045d6fb3b95f06939cc79078
52ee55ahttps://github.com/Trott/io.js/commit/52ee55a06b9c8842045d6fb3b95f06939cc79078
nodejs#25054https://github.com/nodejs/node/pull/25054
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
December 17, 2018 14:02https://github.com/nodejs/node/pull/25054#event-2030327821
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/25054#ref-commit-74e08c0
https://github.com/cjihrig
https://github.com/MylesBorins
vm: simplify Script constructor options validationhttps://github.com/nodejs/node/commit/74e08c0458e6df112394e9f777d468a240c32180
74e08c0https://github.com/nodejs/node/commit/74e08c0458e6df112394e9f777d468a240c32180
#25054https://github.com/nodejs/node/pull/25054
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/25054#ref-pullrequest-393620382
v11.6.0 proposal #25175 https://github.com/nodejs/node/pull/25175
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/25054#ref-commit-360f740
https://github.com/cjihrig
https://github.com/refack
vm: simplify Script constructor options validationhttps://github.com/refack/node/commit/360f7400f66c927872a8004131047030688c9992
360f740https://github.com/refack/node/commit/360f7400f66c927872a8004131047030688c9992
nodejs#25054https://github.com/nodejs/node/pull/25054
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/25054#ref-commit-8d953b7
https://github.com/cjihrig
https://github.com/BethGriggs
vm: simplify Script constructor options validationhttps://github.com/nodejs/node/commit/8d953b7d26544f6e87c15a50f266be34b566e574
8d953b7https://github.com/nodejs/node/commit/8d953b7d26544f6e87c15a50f266be34b566e574
#25054https://github.com/nodejs/node/pull/25054
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Feb 12, 2019https://github.com/nodejs/node/pull/25054#event-2134967865
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/25054#ref-pullrequest-409543286
v10.15.3 proposal #26063 https://github.com/nodejs/node/pull/26063
BethGriggshttps://github.com/BethGriggs
Feb 20, 2019 https://github.com/nodejs/node/pull/25054#ref-commit-aecbe36
https://github.com/cjihrig
https://github.com/BethGriggs
vm: simplify Script constructor options validationhttps://github.com/nodejs/node/commit/aecbe368f742095585e3cfb4f30563b92fa1bb14
aecbe36https://github.com/nodejs/node/commit/aecbe368f742095585e3cfb4f30563b92fa1bb14
#25054https://github.com/nodejs/node/pull/25054
rvagghttps://github.com/rvagg
Feb 28, 2019 https://github.com/nodejs/node/pull/25054#ref-commit-5f2acc0
https://github.com/cjihrig
https://github.com/rvagg
vm: simplify Script constructor options validationhttps://github.com/nodejs/node/commit/5f2acc0cb1cd21fc42d5fbf97ace90023a414b84
5f2acc0https://github.com/nodejs/node/commit/5f2acc0cb1cd21fc42d5fbf97ace90023a414b84
#25054https://github.com/nodejs/node/pull/25054
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25054
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/25054/files/7527109eabae44e1eda1281376ff344f23d16d9d
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/25054/files/7527109eabae44e1eda1281376ff344f23d16d9d
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Please reload this pagehttps://github.com/nodejs/node/pull/25054
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/lpinca
https://github.com/targos
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.