René's URL Explorer Experiment


Title: perf_hooks: make GC tracking state per-Environment by addaleax · Pull Request #25053 · nodejs/node · GitHub

Open Graph Title: perf_hooks: make GC tracking state per-Environment by addaleax · Pull Request #25053 · nodejs/node

X Title: perf_hooks: make GC tracking state per-Environment by addaleax · Pull Request #25053 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Otherwise this is global state that may be subject to race conditions e.g. when running perf_hooks inside of Worker threads. Tracking the GC type is removed entirely since the variable was unused. ...

X Description: Otherwise this is global state that may be subject to race conditions e.g. when running perf_hooks inside of Worker threads. Tracking the GC type is removed entirely since the variable was unused. ...

Opengraph URL: https://github.com/nodejs/node/pull/25053

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:53decaf0-d049-5f7c-1e68-0da3453505ad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id919E:3BD8F2:10962B7:166BB5E:6A4EEDC7
html-safe-noncea7e6e5d1451ef15980c131b84a97db06f8cb56c5b99afc17e823b7034b70293c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTlFOjNCRDhGMjoxMDk2MkI3OjE2NkJCNUU6NkE0RUVEQzciLCJ2aXNpdG9yX2lkIjoiODc0Nzk0MzgyNDk2ODMxNDMxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd99ff9c53cc2e13a10ba896574b9feef3e1563b52a843a5a08c1e4730dd8e590
hovercard-subject-tagpull_request:238853740
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25053/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3aadc23ef2f8eb1daaeedf4690a23b7c26e12e3e52d79a04ca3d7e71e15437df/nodejs/node/pull/25053
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3aadc23ef2f8eb1daaeedf4690a23b7c26e12e3e52d79a04ca3d7e71e15437df/nodejs/node/pull/25053
og:image:altOtherwise this is global state that may be subject to race conditions e.g. when running perf_hooks inside of Worker threads. Tracking the GC type is removed entirely since the variable was unused. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release00d04d6b867d2f16ab50bebae8ccc56e07c8988b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25053#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25053
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25053
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25053
Reloadhttps://github.com/nodejs/node/pull/25053
Reloadhttps://github.com/nodejs/node/pull/25053
Please reload this pagehttps://github.com/nodejs/node/pull/25053
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25053
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:perf-per-envhttps://github.com/addaleax/node/tree/perf-per-env
Conversationhttps://github.com/nodejs/node/pull/25053
Commits1 (1)https://github.com/nodejs/node/pull/25053/commits
Checkshttps://github.com/nodejs/node/pull/25053/checks
Files changedhttps://github.com/nodejs/node/pull/25053/files
perf_hooks: make GC tracking state per-Environmenthttps://github.com/nodejs/node/pull/25053#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:perf-per-envhttps://github.com/addaleax/node/tree/perf-per-env
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 14, 2018https://github.com/nodejs/node/pull/25053#issue-391293014
Please reload this pagehttps://github.com/nodejs/node/pull/25053
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25053
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 14, 2018https://github.com/nodejs/node/pull/25053#issuecomment-447491061
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1957/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1957/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25053
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Dec 14, 2018https://github.com/nodejs/node/pull/25053#event-2027986976
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
perf_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperf_hooks
Dec 14, 2018https://github.com/nodejs/node/pull/25053#event-2027987483
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 14, 2018 https://github.com/nodejs/node/pull/25053#pullrequestreview-185303049
View reviewed changes https://github.com/nodejs/node/pull/25053/files
cjihrighttps://github.com/cjihrig
https://github.com/nodejs/node/pull/25053#pullrequestreview-185303049
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/25053
https://github.com/addaleax
perf_hooks: make GC tracking state per-Environmenthttps://github.com/nodejs/node/pull/25053/commits/f1511e4775fb7f2db05d38207af9df1da2043bdd
f1511e4https://github.com/nodejs/node/pull/25053/commits/f1511e4775fb7f2db05d38207af9df1da2043bdd
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/89e0dd5e799aef70d1ea65ac4f6388d82596c848..f1511e4775fb7f2db05d38207af9df1da2043bdd
89e0dd5https://github.com/nodejs/node/commit/89e0dd5e799aef70d1ea65ac4f6388d82596c848
f1511e4https://github.com/nodejs/node/commit/f1511e4775fb7f2db05d38207af9df1da2043bdd
Compare https://github.com/nodejs/node/compare/89e0dd5e799aef70d1ea65ac4f6388d82596c848..f1511e4775fb7f2db05d38207af9df1da2043bdd
December 14, 2018 22:09https://github.com/nodejs/node/pull/25053#event-2028017800
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 14, 2018 https://github.com/nodejs/node/pull/25053#pullrequestreview-185315262
View reviewed changes https://github.com/nodejs/node/pull/25053/files/f1511e4775fb7f2db05d38207af9df1da2043bdd
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 14, 2018https://github.com/nodejs/node/pull/25053#issuecomment-447504101
Please reload this pagehttps://github.com/nodejs/node/pull/25053
https://ci.nodejs.org/job/node-test-pull-request/19547/https://ci.nodejs.org/job/node-test-pull-request/19547/
Please reload this pagehttps://github.com/nodejs/node/pull/25053
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 14, 2018https://github.com/nodejs/node/pull/25053#event-2028096934
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 17, 2018https://github.com/nodejs/node/pull/25053#issuecomment-447703829
8dfd757https://github.com/nodejs/node/commit/8dfd7573372ba49f87f0838191b83ea4c8bd509a
Please reload this pagehttps://github.com/nodejs/node/pull/25053
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 17, 2018https://github.com/nodejs/node/pull/25053#event-2029194955
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
December 17, 2018 02:26https://github.com/nodejs/node/pull/25053#event-2029195106
addaleaxhttps://github.com/addaleax
Dec 17, 2018 https://github.com/nodejs/node/pull/25053#ref-commit-8dfd757
https://github.com/addaleax
perf_hooks: make GC tracking state per-Environmenthttps://github.com/nodejs/node/commit/8dfd7573372ba49f87f0838191b83ea4c8bd509a
8dfd757https://github.com/nodejs/node/commit/8dfd7573372ba49f87f0838191b83ea4c8bd509a
#25053https://github.com/nodejs/node/pull/25053
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/25053#ref-commit-85a1369
https://github.com/addaleax
https://github.com/MylesBorins
perf_hooks: make GC tracking state per-Environmenthttps://github.com/nodejs/node/commit/85a136974e3c32b4aedd7de81960a18a064d4499
85a1369https://github.com/nodejs/node/commit/85a136974e3c32b4aedd7de81960a18a064d4499
#25053https://github.com/nodejs/node/pull/25053
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 25, 2018 https://github.com/nodejs/node/pull/25053#ref-pullrequest-393620382
v11.6.0 proposal #25175 https://github.com/nodejs/node/pull/25175
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/25053#ref-commit-63ee352
https://github.com/refack
perf_hooks: make GC tracking state per-Environmenthttps://github.com/refack/node/commit/63ee352134fe73445c307b887682b02f5e3cc01a
63ee352https://github.com/refack/node/commit/63ee352134fe73445c307b887682b02f5e3cc01a
nodejs#25053https://github.com/nodejs/node/pull/25053
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/25053#ref-commit-33a907d
https://github.com/addaleax
https://github.com/BethGriggs
perf_hooks: make GC tracking state per-Environmenthttps://github.com/nodejs/node/commit/33a907de204d001b00629d48460e9b75df05a313
33a907dhttps://github.com/nodejs/node/commit/33a907de204d001b00629d48460e9b75df05a313
#25053https://github.com/nodejs/node/pull/25053
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v10.x
Feb 12, 2019https://github.com/nodejs/node/pull/25053#event-2134967126
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Feb 12, 2019 https://github.com/nodejs/node/pull/25053#ref-pullrequest-409543286
v10.15.3 proposal #26063 https://github.com/nodejs/node/pull/26063
BethGriggshttps://github.com/BethGriggs
Feb 20, 2019 https://github.com/nodejs/node/pull/25053#ref-commit-0ceab2f
https://github.com/addaleax
https://github.com/BethGriggs
perf_hooks: make GC tracking state per-Environmenthttps://github.com/nodejs/node/commit/0ceab2fa0088bc4d4d4e7b842f763a5d85c25b1f
0ceab2fhttps://github.com/nodejs/node/commit/0ceab2fa0088bc4d4d4e7b842f763a5d85c25b1f
#25053https://github.com/nodejs/node/pull/25053
rvagghttps://github.com/rvagg
Feb 28, 2019 https://github.com/nodejs/node/pull/25053#ref-commit-7f48299
https://github.com/addaleax
https://github.com/rvagg
perf_hooks: make GC tracking state per-Environmenthttps://github.com/nodejs/node/commit/7f482997ccbd5e8de59409d06715f606b4b38ac3
7f48299https://github.com/nodejs/node/commit/7f482997ccbd5e8de59409d06715f606b4b38ac3
#25053https://github.com/nodejs/node/pull/25053
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25053
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/25053/files/f1511e4775fb7f2db05d38207af9df1da2043bdd
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/25053/files/89e0dd5e799aef70d1ea65ac4f6388d82596c848
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
perf_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperf_hooks
Please reload this pagehttps://github.com/nodejs/node/pull/25053
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.