| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7940e5bc-11bc-50d2-ef34-a2db8d3ae7a7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BF10:A6D52:9B7C7A:D391D8:6A4ECCF4 |
| html-safe-nonce | f68d943adfc031633c6ec124d814e2f6c961d442d28d2a308dbebd4c3c2facc3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjEwOkE2RDUyOjlCN0M3QTpEMzkxRDg6NkE0RUNDRjQiLCJ2aXNpdG9yX2lkIjoiMzY1MjUzNjk0MzAzMDIyNjE2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2694762471cc2fb0683abd40042697757ee4e0af42d0e4be9aec80e1f2a8e38d |
| hovercard-subject-tag | pull_request:238851951 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25052/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6a02fa20375d9ecb7614d2f110990cc96827e7db66e5d02f39f461016a028c38/nodejs/node/pull/25052 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6a02fa20375d9ecb7614d2f110990cc96827e7db66e5d02f39f461016a028c38/nodejs/node/pull/25052 |
| og:image:alt | Mark some global variables as const or constexpr.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/25052#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25052 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25052 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/25052 |
| Reload | https://github.com/nodejs/node/pull/25052 |
| Reload | https://github.com/nodejs/node/pull/25052 |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:more-const | https://github.com/addaleax/node/tree/more-const |
| Conversation | https://github.com/nodejs/node/pull/25052 |
| Commits2 (2) | https://github.com/nodejs/node/pull/25052/commits |
| Checks | https://github.com/nodejs/node/pull/25052/checks |
| Files changed | https://github.com/nodejs/node/pull/25052/files |
| src: mark some global state as const | https://github.com/nodejs/node/pull/25052#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:more-const | https://github.com/addaleax/node/tree/more-const |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25052#issue-391290829 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25052#issuecomment-447489202 |
| @addaleax | https://github.com/addaleax |
| https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1956/pipeline | https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1956/pipeline |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25052#event-2027961436 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Dec 14, 2018
| https://github.com/nodejs/node/pull/25052#pullrequestreview-185298157 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25052/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25052#event-2027992789 |
|
| https://github.com/addaleax |
| src: mark some global state as const | https://github.com/nodejs/node/pull/25052/commits/d45047149545351e12c57914f9d1978982953ffa |
| d450471 | https://github.com/nodejs/node/pull/25052/commits/d45047149545351e12c57914f9d1978982953ffa |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/f3c257fac15814ae14a329b1caa442435fe9e1d8..d45047149545351e12c57914f9d1978982953ffa |
| f3c257f | https://github.com/nodejs/node/commit/f3c257fac15814ae14a329b1caa442435fe9e1d8 |
| d450471 | https://github.com/nodejs/node/commit/d45047149545351e12c57914f9d1978982953ffa |
|
Compare
| https://github.com/nodejs/node/compare/f3c257fac15814ae14a329b1caa442435fe9e1d8..d45047149545351e12c57914f9d1978982953ffa |
| December 14, 2018 21:58 | https://github.com/nodejs/node/pull/25052#event-2027993265 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 14, 2018 | https://github.com/nodejs/node/pull/25052#issuecomment-447493300 |
| https://ci.nodejs.org/job/node-test-pull-request/19546/ | https://ci.nodejs.org/job/node-test-pull-request/19546/ |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 15, 2018 | https://github.com/nodejs/node/pull/25052#issuecomment-447529721 |
| https://ci.nodejs.org/job/node-test-pull-request/19551/ | https://ci.nodejs.org/job/node-test-pull-request/19551/ |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Dec 15, 2018
| https://github.com/nodejs/node/pull/25052#pullrequestreview-185339982 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25052/files/d45047149545351e12c57914f9d1978982953ffa |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 15, 2018 | https://github.com/nodejs/node/pull/25052#issuecomment-447538699 |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Dec 15, 2018
| https://github.com/nodejs/node/pull/25052#pullrequestreview-185346814 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25052/files/d45047149545351e12c57914f9d1978982953ffa |
| src/node_file.cc | https://github.com/nodejs/node/pull/25052/files/d45047149545351e12c57914f9d1978982953ffa#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6 |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 15, 2018
| https://github.com/nodejs/node/pull/25052#pullrequestreview-185361475 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25052/files/d45047149545351e12c57914f9d1978982953ffa |
|
| https://github.com/addaleax |
| fixup! src: mark some global state as const | https://github.com/nodejs/node/pull/25052/commits/9084190d2b271d39015fd39f8d51597db37ab742 |
| 9084190 | https://github.com/nodejs/node/pull/25052/commits/9084190d2b271d39015fd39f8d51597db37ab742 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 15, 2018 | https://github.com/nodejs/node/pull/25052#issuecomment-447584804 |
| https://ci.nodejs.org/job/node-test-pull-request/19564/ | https://ci.nodejs.org/job/node-test-pull-request/19564/ |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Dec 15, 2018 | https://github.com/nodejs/node/pull/25052#event-2028552912 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 15, 2018 | https://github.com/nodejs/node/pull/25052#issuecomment-447596616 |
| #25068 | https://github.com/nodejs/node/issues/25068 |
| https://ci.nodejs.org/job/node-test-pull-request/19567/ | https://ci.nodejs.org/job/node-test-pull-request/19567/ |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 16, 2018 | https://github.com/nodejs/node/pull/25052#issuecomment-447607020 |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
| #25070 | https://github.com/nodejs/node/issues/25070 |
| https://ci.nodejs.org/job/node-test-pull-request/19571/ | https://ci.nodejs.org/job/node-test-pull-request/19571/ |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Dec 16, 2018
| https://github.com/nodejs/node/pull/25052#pullrequestreview-185372173 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/25052/files/9084190d2b271d39015fd39f8d51597db37ab742 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 17, 2018 | https://github.com/nodejs/node/pull/25052#issuecomment-447718597 |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 17, 2018 | https://github.com/nodejs/node/pull/25052#event-2029291698 |
| Trott | https://github.com/Trott |
|
Dec 17, 2018
| https://github.com/nodejs/node/pull/25052#ref-commit-18f2bf7 |
|
| https://github.com/addaleax |
|
| https://github.com/Trott |
| src: mark some global state as const | https://github.com/Trott/io.js/commit/18f2bf7f9bd183f7baf08a705035fc99580a2c40 |
| 18f2bf7 | https://github.com/Trott/io.js/commit/18f2bf7f9bd183f7baf08a705035fc99580a2c40 |
| nodejs#25052 | https://github.com/nodejs/node/pull/25052 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 25, 2018
| https://github.com/nodejs/node/pull/25052#ref-commit-09a99c6 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| src: mark some global state as const | https://github.com/nodejs/node/commit/09a99c6834b6e374c798f66ee1389385ee63cd02 |
| 09a99c6 | https://github.com/nodejs/node/commit/09a99c6834b6e374c798f66ee1389385ee63cd02 |
| #25052 | https://github.com/nodejs/node/pull/25052 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 25, 2018
| https://github.com/nodejs/node/pull/25052#ref-pullrequest-393620382 |
|
v11.6.0 proposal
#25175
| https://github.com/nodejs/node/pull/25175 |
| refack | https://github.com/refack |
|
Jan 14, 2019
| https://github.com/nodejs/node/pull/25052#ref-commit-144f5a6 |
|
| https://github.com/refack |
| src: mark some global state as const | https://github.com/refack/node/commit/144f5a626d16acf3fd38260b87629fd0a5a40343 |
| 144f5a6 | https://github.com/refack/node/commit/144f5a626d16acf3fd38260b87629fd0a5a40343 |
| nodejs#25052 | https://github.com/nodejs/node/pull/25052 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
backport-requested-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x |
| Jul 2, 2019 | https://github.com/nodejs/node/pull/25052#event-2454715999 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25052 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/25052/files/d45047149545351e12c57914f9d1978982953ffa |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/25052/files/f3c257fac15814ae14a329b1caa442435fe9e1d8 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/25052/files/9084190d2b271d39015fd39f8d51597db37ab742 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/25052 |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/joyeecheung |
|
| https://github.com/BethGriggs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |