René's URL Explorer Experiment


Title: test: mark test-http2-settings-flood as flaky on Windows by Trott · Pull Request #25048 · nodejs/node · GitHub

Open Graph Title: test: mark test-http2-settings-flood as flaky on Windows by Trott · Pull Request #25048 · nodejs/node

X Title: test: mark test-http2-settings-flood as flaky on Windows by Trott · Pull Request #25048 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Collaborators, 👍 here to fast-track. Refs: #25043 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Collaborators, 👍 here to fast-track. Refs: #25043 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/25048

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:81e1d10c-687c-735f-644b-63e53aaf2545
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB00:1730DB:178943F:21D2D05:6A4F7352
html-safe-nonce94485cc428efd8d9cfd7d968e7c14ad9bb221b28bdad8424fc4bbc406a29e19f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjAwOjE3MzBEQjoxNzg5NDNGOjIxRDJEMDU6NkE0RjczNTIiLCJ2aXNpdG9yX2lkIjoiNjE2ODkxNDY0OTE4MzkwODY5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdccc60a8681376e01236674ed63944757f84cbc55ec379d1e450f49a0c4837bd
hovercard-subject-tagpull_request:238817636
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/25048/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/696fb7e453faff9b9e69b9f6aac73872790ad8661e8968fec57bdba0ecdc63f1/nodejs/node/pull/25048
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/696fb7e453faff9b9e69b9f6aac73872790ad8661e8968fec57bdba0ecdc63f1/nodejs/node/pull/25048
og:image:altCollaborators, 👍 here to fast-track. Refs: #25043 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/25048#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25048
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25048
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/25048
Reloadhttps://github.com/nodejs/node/pull/25048
Reloadhttps://github.com/nodejs/node/pull/25048
Please reload this pagehttps://github.com/nodejs/node/pull/25048
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/25048
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:v8.x-staginghttps://github.com/nodejs/node/tree/v8.x-staging
Trott:mark-flaky-floodhttps://github.com/Trott/io.js/tree/mark-flaky-flood
Conversationhttps://github.com/nodejs/node/pull/25048
Commits7541 (7541)https://github.com/nodejs/node/pull/25048/commits
Checkshttps://github.com/nodejs/node/pull/25048/checks
Files changedhttps://github.com/nodejs/node/pull/25048/files
test: mark test-http2-settings-flood as flaky on Windowshttps://github.com/nodejs/node/pull/25048#top
Trotthttps://github.com/Trott
nodejs:v8.x-staginghttps://github.com/nodejs/node/tree/v8.x-staging
Trott:mark-flaky-floodhttps://github.com/Trott/io.js/tree/mark-flaky-flood
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/25048#issue-391234256
#25043https://github.com/nodejs/node/issues/25043
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/25048
Trotthttps://github.com/Trott
November 26, 2018 18:28https://github.com/nodejs/node/pull/25048#commits-pushed-bb04a8b
https://github.com/Trott
doc: clarify symlink resolution for __filenamehttps://github.com/nodejs/node/pull/25048/commits/bb04a8bbf2dc97ee3e75f985de1b8b6ff4f0619c
bb04a8bhttps://github.com/nodejs/node/pull/25048/commits/bb04a8bbf2dc97ee3e75f985de1b8b6ff4f0619c
nodejs#22602 (comment)https://github.com/nodejs/node/issues/22602#issuecomment-440906602
nodejs#24587https://github.com/nodejs/node/pull/24587
https://github.com/danbev
lib: suppress crypto related env vars in help msghttps://github.com/nodejs/node/pull/25048/commits/567b9f86cc2fa94ea6cd8cf53b5c832081a908d6
567b9f8https://github.com/nodejs/node/pull/25048/commits/567b9f86cc2fa94ea6cd8cf53b5c832081a908d6
399bb3chttps://github.com/Trott/io.js/commit/399bb3c95af821350774c18f469ab700387f38e1
nodejs#24556https://github.com/nodejs/node/pull/24556
https://github.com/cjihrig
https://github.com/danbev
src: simplify uptime and ppid return valueshttps://github.com/nodejs/node/pull/25048/commits/11c17e4bc912af7dd5b6ef47176fcccee9064b50
11c17e4https://github.com/nodejs/node/pull/25048/commits/11c17e4bc912af7dd5b6ef47176fcccee9064b50
nodejs#24562https://github.com/nodejs/node/pull/24562
https://github.com/vsemozhetbyt
lib: fix comment nits in bootstrap\loaders.jshttps://github.com/nodejs/node/pull/25048/commits/1db808ca5f54ac30a47818112f78378c93ef2be6
1db808chttps://github.com/nodejs/node/pull/25048/commits/1db808ca5f54ac30a47818112f78378c93ef2be6
nodejs#24641https://github.com/nodejs/node/pull/24641
https://github.com/tpanthera
https://github.com/Trott
test: replace anonymous closure functions with arrow functionshttps://github.com/nodejs/node/pull/25048/commits/3ec85763f678aff5a962fbcbe76d844a1029e22e
3ec8576https://github.com/nodejs/node/pull/25048/commits/3ec85763f678aff5a962fbcbe76d844a1029e22e
nodejs#24443https://github.com/nodejs/node/pull/24443
https://github.com/mcollina
https://github.com/rvagg
deps,http: http_parser set max header size to 8KBhttps://github.com/nodejs/node/pull/25048/commits/186035243fad247e3955fa0c202987cae99e82db
https://github.com/nodejs/node/commit/186035243fad247e3955fa0c202987cae99e82db#comments
1860352https://github.com/nodejs/node/pull/25048/commits/186035243fad247e3955fa0c202987cae99e82db
CVE-2018-12121https://github.com/advisories/GHSA-2p2c-vwq7-7vg6
nodejs-private/node-private#143https://github.com/nodejs-private/node-private/pull/143
nodejs-private/security#139https://github.com/nodejs-private/security/issues/139
nodejs-private/http-parser-private#2https://github.com/nodejs-private/http-parser-private/pull/2
https://github.com/rvagg
deps,http: llhttp set max header size to 8KBhttps://github.com/nodejs/node/pull/25048/commits/f413f7c9cf5749c231c4b4e667dc2cbab959dd59
f413f7chttps://github.com/nodejs/node/pull/25048/commits/f413f7c9cf5749c231c4b4e667dc2cbab959dd59
CVE-2018-12121https://github.com/advisories/GHSA-2p2c-vwq7-7vg6
nodejs-private/node-private#149https://github.com/nodejs-private/node-private/pull/149
nodejs-private/node-private#143https://github.com/nodejs-private/node-private/pull/143
nodejs-private/node-private#149https://github.com/nodejs-private/node-private/pull/149
https://github.com/indutny
https://github.com/rvagg
http: fix header limit errors and test for llhttphttps://github.com/nodejs/node/pull/25048/commits/af8d9e3972bba423ab0027239062b894030db5c7
af8d9e3https://github.com/nodejs/node/pull/25048/commits/af8d9e3972bba423ab0027239062b894030db5c7
nodejs-private/node-private#143https://github.com/nodejs-private/node-private/pull/143
nodejs-private/node-private#149https://github.com/nodejs-private/node-private/pull/149
https://github.com/rvagg
http: reset headers_nread_ on llhttp parser reusehttps://github.com/nodejs/node/pull/25048/commits/7bfcfc2ffe4940898cf7b70890a55eb91cbdd112
7bfcfc2https://github.com/nodejs/node/pull/25048/commits/7bfcfc2ffe4940898cf7b70890a55eb91cbdd112
nodejs-private/node-private#149https://github.com/nodejs-private/node-private/pull/149
https://github.com/mcollina
https://github.com/rvagg
http,https: protect against slow headers attackhttps://github.com/nodejs/node/pull/25048/commits/ee618a7ab239c98d945c723a4e225bc409151736
ee618a7https://github.com/nodejs/node/pull/25048/commits/ee618a7ab239c98d945c723a4e225bc409151736
CVE-2018-12122https://github.com/advisories/GHSA-6mxm-8w9r-4997
nodejs-private/node-private#144https://github.com/nodejs-private/node-private/pull/144
https://github.com/mcollina
https://github.com/rvagg
url: avoid hostname spoofing w/ javascript protocolhttps://github.com/nodejs/node/pull/25048/commits/b77f699a84219702ccef6387882c0fdcb58529bb
b77f699https://github.com/nodejs/node/pull/25048/commits/b77f699a84219702ccef6387882c0fdcb58529bb
CVE-2018-12123https://github.com/advisories/GHSA-f6m9-hpfw-xjw4
nodejs-private/security#205https://github.com/nodejs-private/security/issues/205
nodejs-private/node-private#145https://github.com/nodejs-private/node-private/pull/145
https://github.com/rvagg
2018-11-27, Version 6.15.0 'Boron' (LTS)https://github.com/nodejs/node/pull/25048/commits/957aeba35211bdadbc3e345639efee11362891a5
957aebahttps://github.com/nodejs/node/pull/25048/commits/957aeba35211bdadbc3e345639efee11362891a5
https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/
CVE-2018-12120https://github.com/advisories/GHSA-8fqw-43x4-4q75
CVE-2018-12121https://github.com/advisories/GHSA-2p2c-vwq7-7vg6
CVE-2018-12122https://github.com/advisories/GHSA-6mxm-8w9r-4997
CVE-2018-12123https://github.com/advisories/GHSA-f6m9-hpfw-xjw4
CVE-2018-12116https://github.com/advisories/GHSA-mfjx-w835-f3w2
CVE-2018-0734https://github.com/advisories/GHSA-93g8-hm6f-hrw3
CVE-2018-5407https://github.com/advisories/GHSA-3rjg-j575-7f6p
nodejs#8106https://github.com/nodejs/node/pull/8106
CVE-2018-12120https://github.com/advisories/GHSA-8fqw-43x4-4q75
CVE-2018-0734https://github.com/advisories/GHSA-93g8-hm6f-hrw3
CVE-2018-5407https://github.com/advisories/GHSA-3rjg-j575-7f6p
CVE-2018-12121https://github.com/advisories/GHSA-2p2c-vwq7-7vg6
CVE-2018-12122https://github.com/advisories/GHSA-6mxm-8w9r-4997
CVE-2018-12116https://github.com/advisories/GHSA-mfjx-w835-f3w2
CVE-2018-12116https://github.com/advisories/GHSA-mfjx-w835-f3w2
CVE-2018-12123https://github.com/advisories/GHSA-f6m9-hpfw-xjw4
nodejs-private/node-private#153https://github.com/nodejs-private/node-private/pull/153
https://github.com/rvagg
2018-11-27, Version 8.14.0 'Carbon' (LTS)https://github.com/nodejs/node/pull/25048/commits/59fdaede521e250186a9f376ddde334898115282
59fdaedhttps://github.com/nodejs/node/pull/25048/commits/59fdaede521e250186a9f376ddde334898115282
https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/
CVE-2018-12121https://github.com/advisories/GHSA-2p2c-vwq7-7vg6
CVE-2018-12122https://github.com/advisories/GHSA-6mxm-8w9r-4997
CVE-2018-12123https://github.com/advisories/GHSA-f6m9-hpfw-xjw4
CVE-2018-12116https://github.com/advisories/GHSA-mfjx-w835-f3w2
CVE-2018-0734https://github.com/advisories/GHSA-93g8-hm6f-hrw3
CVE-2018-5407https://github.com/advisories/GHSA-3rjg-j575-7f6p
CVE-2018-0734https://github.com/advisories/GHSA-93g8-hm6f-hrw3
CVE-2018-5407https://github.com/advisories/GHSA-3rjg-j575-7f6p
CVE-2018-12121https://github.com/advisories/GHSA-2p2c-vwq7-7vg6
CVE-2018-12116https://github.com/advisories/GHSA-mfjx-w835-f3w2
CVE-2018-12116https://github.com/advisories/GHSA-mfjx-w835-f3w2
CVE-2018-12123https://github.com/advisories/GHSA-f6m9-hpfw-xjw4
nodejs-private/node-private#154https://github.com/nodejs-private/node-private/pull/154
https://github.com/rvagg
2018-11-27, Version 10.14.0 'Dubnium' (LTS)https://github.com/nodejs/node/pull/25048/commits/9910cc29bc14160cb4e718e61b87dc6de7cbbfaa
9910cc2https://github.com/nodejs/node/pull/25048/commits/9910cc29bc14160cb4e718e61b87dc6de7cbbfaa
https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/
CVE-2018-12121https://github.com/advisories/GHSA-2p2c-vwq7-7vg6
CVE-2018-12122https://github.com/advisories/GHSA-6mxm-8w9r-4997
CVE-2018-12123https://github.com/advisories/GHSA-f6m9-hpfw-xjw4
CVE-2018-0734https://github.com/advisories/GHSA-93g8-hm6f-hrw3
CVE-2019-0735https://github.com/advisories/GHSA-433w-8772-xfr8
CVE-2018-0734https://github.com/advisories/GHSA-93g8-hm6f-hrw3
CVE-2019-0735https://github.com/advisories/GHSA-433w-8772-xfr8
CVE-2018-12121https://github.com/advisories/GHSA-2p2c-vwq7-7vg6
CVE-2018-12123https://github.com/advisories/GHSA-f6m9-hpfw-xjw4
nodejs-private/node-private#155https://github.com/nodejs-private/node-private/pull/155
https://github.com/rvagg
2018-11-27, Version 11.3.0 (Current)https://github.com/nodejs/node/pull/25048/commits/cc399cf5b2253dd9f3bcdeeff422059d58795d75
cc399cfhttps://github.com/nodejs/node/pull/25048/commits/cc399cf5b2253dd9f3bcdeeff422059d58795d75
https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/
CVE-2018-12121https://github.com/advisories/GHSA-2p2c-vwq7-7vg6
CVE-2018-12122https://github.com/advisories/GHSA-6mxm-8w9r-4997
CVE-2018-12123https://github.com/advisories/GHSA-f6m9-hpfw-xjw4
CVE-2018-0734https://github.com/advisories/GHSA-93g8-hm6f-hrw3
CVE-2019-0735https://github.com/advisories/GHSA-433w-8772-xfr8
CVE-2018-0734https://github.com/advisories/GHSA-93g8-hm6f-hrw3
CVE-2019-0735https://github.com/advisories/GHSA-433w-8772-xfr8
CVE-2018-12121https://github.com/advisories/GHSA-2p2c-vwq7-7vg6
CVE-2018-12123https://github.com/advisories/GHSA-f6m9-hpfw-xjw4
nodejs-private/node-private#156https://github.com/nodejs-private/node-private/pull/156
https://github.com/Trott
tools,doc: fix version picker bug in html.jshttps://github.com/nodejs/node/pull/25048/commits/6f64cda1ee578d121e328756ac7401f0ee8e1d62
6f64cdahttps://github.com/nodejs/node/pull/25048/commits/6f64cda1ee578d121e328756ac7401f0ee8e1d62
nodejs#23979https://github.com/nodejs/node/issues/23979
nodejs#24638https://github.com/nodejs/node/pull/24638
https://github.com/mcollina
https://github.com/Trott
doc: document fs.write limitation with TTYhttps://github.com/nodejs/node/pull/25048/commits/086482da6dc50693c72a25a64774103e6c1a5e1a
086482dhttps://github.com/nodejs/node/pull/25048/commits/086482da6dc50693c72a25a64774103e6c1a5e1a
nodejs#24550https://github.com/nodejs/node/issues/24550
nodejs#24571https://github.com/nodejs/node/pull/24571
https://github.com/Ajido
https://github.com/Trott
test: add test for socket.end callbackhttps://github.com/nodejs/node/pull/25048/commits/628f95503f1964b727ede62c731ce46f1e116af6
628f955https://github.com/nodejs/node/pull/25048/commits/628f95503f1964b727ede62c731ce46f1e116af6
nodejs#24087https://github.com/nodejs/node/pull/24087
nodejs#23937https://github.com/nodejs/node/pull/23937
https://github.com/Trott
test: fix argument order in assert.strictEqualhttps://github.com/nodejs/node/pull/25048/commits/46094e42c362979d69bbad901e8c626d5af29ee1
46094e4https://github.com/nodejs/node/pull/25048/commits/46094e42c362979d69bbad901e8c626d5af29ee1
nodejs#24594https://github.com/nodejs/node/pull/24594
https://github.com/DoiChris
https://github.com/Trott
stream: use arrow function for callbackhttps://github.com/nodejs/node/pull/25048/commits/7bc5300e2be74424347e0072bf22f6fbfe5cd0b9
7bc5300https://github.com/nodejs/node/pull/25048/commits/7bc5300e2be74424347e0072bf22f6fbfe5cd0b9
nodejs#24609https://github.com/nodejs/node/pull/24609
https://github.com/VeysonD
https://github.com/Trott
test: update strictEqual argument orderhttps://github.com/nodejs/node/pull/25048/commits/ec396e42c6e421b31782f2a5fa1561fb5e61fba3
ec396e4https://github.com/nodejs/node/pull/25048/commits/ec396e42c6e421b31782f2a5fa1561fb5e61fba3
nodejs#24622https://github.com/nodejs/node/pull/24622
https://github.com/Trott
doc: revise accepting-modifications in guidehttps://github.com/nodejs/node/pull/25048/commits/7d18e922ab093c9c85b365dbc7fd01984316abc3
7d18e92https://github.com/nodejs/node/pull/25048/commits/7d18e922ab093c9c85b365dbc7fd01984316abc3
nodejs#24650https://github.com/nodejs/node/pull/24650
https://github.com/apoorvanand
https://github.com/Trott
test: use arrow functions in callbackshttps://github.com/nodejs/node/pull/25048/commits/b5c5d206af8fd32f33953d564a151a5a20bfb5b1
b5c5d20https://github.com/nodejs/node/pull/25048/commits/b5c5d206af8fd32f33953d564a151a5a20bfb5b1
nodejs#24441https://github.com/nodejs/node/pull/24441
https://github.com/apapirovski
https://github.com/Trott
process: emit unhandled warning immediatelyhttps://github.com/nodejs/node/pull/25048/commits/3ce9305a705a0ea521a82afb0e4a2bef079d9548
3ce9305https://github.com/nodejs/node/pull/25048/commits/3ce9305a705a0ea521a82afb0e4a2bef079d9548
nodejs#24632https://github.com/nodejs/node/pull/24632
nodejs#24209https://github.com/nodejs/node/issues/24209
https://github.com/susantruong
https://github.com/Trott
n-api,test: remove last argument in assert.strictEqual()https://github.com/nodejs/node/pull/25048/commits/1066b688bf56b490cb46d26d87e7b619037db151
1066b68https://github.com/nodejs/node/pull/25048/commits/1066b688bf56b490cb46d26d87e7b619037db151
nodejs#24584https://github.com/nodejs/node/pull/24584
https://github.com/na9amura
https://github.com/gireeshpunathil
test: fix arguments order in assert.strictEqualhttps://github.com/nodejs/node/pull/25048/commits/a6fdbaf263767e9b7a8db6053ebea0ae44f6f1dc
a6fdbafhttps://github.com/nodejs/node/pull/25048/commits/a6fdbaf263767e9b7a8db6053ebea0ae44f6f1dc
nodejs#24621https://github.com/nodejs/node/pull/24621
https://github.com/gireeshpunathil
lib: convert to Arrow Functionhttps://github.com/nodejs/node/pull/25048/commits/b02cac5b09365d9887596e9c811bb047825c6201
b02cac5https://github.com/nodejs/node/pull/25048/commits/b02cac5b09365d9887596e9c811bb047825c6201
nodejs#24615https://github.com/nodejs/node/pull/24615
https://github.com/sagirk
https://github.com/gireeshpunathil
test: use arrow functionhttps://github.com/nodejs/node/pull/25048/commits/484ad3b10334f21a36d3b439a19032a1d332b8ee
484ad3bhttps://github.com/nodejs/node/pull/25048/commits/484ad3b10334f21a36d3b439a19032a1d332b8ee
nodejs#24482https://github.com/nodejs/node/pull/24482
https://github.com/antsmartian
doc: add antsmartian to collaboratorshttps://github.com/nodejs/node/pull/25048/commits/c3474f511e7ca7fe7fb9182c7f3ce8e3b2e6e577
c3474f5https://github.com/nodejs/node/pull/25048/commits/c3474f511e7ca7fe7fb9182c7f3ce8e3b2e6e577
nodejs#24340https://github.com/nodejs/node/issues/24340
nodejs#24655https://github.com/nodejs/node/pull/24655
nodejs#24340https://github.com/nodejs/node/issues/24340
https://github.com/rvagg
build: only check REPLACEME & DEP...X for releaseshttps://github.com/nodejs/node/pull/25048/commits/89e8fc4520d094281b43d95d60e6c317e056a3a4
89e8fc4https://github.com/nodejs/node/pull/25048/commits/89e8fc4520d094281b43d95d60e6c317e056a3a4
nodejs#24575https://github.com/nodejs/node/pull/24575
nodejs#24551https://github.com/nodejs/node/pull/24551
nodejs#12958https://github.com/nodejs/node/pull/12958
nodejs#12957https://github.com/nodejs/node/pull/12957
nodejs#8325https://github.com/nodejs/node/pull/8325
kjinhttps://github.com/kjin
December 13, 2018 20:48https://github.com/nodejs/node/pull/25048#commits-pushed-49f1db4
https://github.com/kjin
https://github.com/Trott
src: emit 'params' instead of 'data' for NodeTracing.dataCollectedhttps://github.com/nodejs/node/pull/25048/commits/49f1db47e2bb0fa4f2a53f4244639502688a291b
49f1db4https://github.com/nodejs/node/pull/25048/commits/49f1db47e2bb0fa4f2a53f4244639502688a291b
nodejs#24949https://github.com/nodejs/node/pull/24949
https://github.com/BridgeAR
https://github.com/Trott
process: properly close file descriptor on exithttps://github.com/nodejs/node/pull/25048/commits/80ab537ee6fa5513399b86ab439d954387d88772
80ab537https://github.com/nodejs/node/pull/25048/commits/80ab537ee6fa5513399b86ab439d954387d88772
nodejs#24972https://github.com/nodejs/node/pull/24972
https://github.com/nodejs/node/pull/24965/files#r240770314https://github.com/nodejs/node/pull/24965/files#r240770314
https://github.com/Trott
test: increase error information in test-cli-syntax-*https://github.com/nodejs/node/pull/25048/commits/914c49497cd92a9266cf5aaed1f425358d1023cc
914c494https://github.com/nodejs/node/pull/25048/commits/914c49497cd92a9266cf5aaed1f425358d1023cc
nodejs#25021https://github.com/nodejs/node/pull/25021
https://github.com/Trott
test: mark test-child-process-execsync flaky on AIXhttps://github.com/nodejs/node/pull/25048/commits/d0c240f1bea0de25610c0e92be2c81767d7c819f
d0c240fhttps://github.com/nodejs/node/pull/25048/commits/d0c240f1bea0de25610c0e92be2c81767d7c819f
nodejs#24921https://github.com/nodejs/node/issues/24921
nodejs#25031https://github.com/nodejs/node/pull/25031
https://github.com/BridgeAR
util: improve format performancehttps://github.com/nodejs/node/pull/25048/commits/9752fce34d50400f8f4b5cbafbce2161b6e07a45
9752fcehttps://github.com/nodejs/node/pull/25048/commits/9752fce34d50400f8f4b5cbafbce2161b6e07a45
nodejs#24981https://github.com/nodejs/node/pull/24981
https://github.com/Trott
test: mark test-cli-node-options flaky on armhttps://github.com/nodejs/node/pull/25048/commits/adf5083647c3bbe2f0873a3bc6d5614a07468a94
adf5083https://github.com/nodejs/node/pull/25048/commits/adf5083647c3bbe2f0873a3bc6d5614a07468a94
nodejs#25028https://github.com/nodejs/node/issues/25028
nodejs#25032https://github.com/nodejs/node/pull/25032
https://github.com/Rantanen
https://github.com/Trott
lib: ensure readable stream flows to endhttps://github.com/nodejs/node/pull/25048/commits/37a5e01bda104eacca78da31afb9f9ec05da180c
37a5e01https://github.com/nodejs/node/pull/25048/commits/37a5e01bda104eacca78da31afb9f9ec05da180c
nodejs#24915https://github.com/nodejs/node/issues/24915
nodejs#24918https://github.com/nodejs/node/pull/24918
https://github.com/cjihrig
querystring: remove eslint-disablehttps://github.com/nodejs/node/pull/25048/commits/034ec648cad9dee4a67498aa674099ba1bc3c6ac
034ec64https://github.com/nodejs/node/pull/25048/commits/034ec648cad9dee4a67498aa674099ba1bc3c6ac
nodejs#24995https://github.com/nodejs/node/pull/24995
https://github.com/cjihrig
url: remove an eslint-disable commenthttps://github.com/nodejs/node/pull/25048/commits/8ac6c058f9b8fef6ba1a6aaa59d2aa22639a0ac9
8ac6c05https://github.com/nodejs/node/pull/25048/commits/8ac6c058f9b8fef6ba1a6aaa59d2aa22639a0ac9
nodejs#24995https://github.com/nodejs/node/pull/24995
https://github.com/Trott
test: mark test-http2-settings-flood as flaky on Windowshttps://github.com/nodejs/node/pull/25048/commits/818a89c76dd5a2b8ebfad3a3388664027b5e43fb
818a89chttps://github.com/nodejs/node/pull/25048/commits/818a89c76dd5a2b8ebfad3a3388664027b5e43fb
nodejs#25043https://github.com/nodejs/node/issues/25043
https://github.com/Trott
Trotthttps://github.com/Trott
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
flaky-test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Dec 14, 2018https://github.com/nodejs/node/pull/25048#event-2027604904
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 14, 2018https://github.com/nodejs/node/pull/25048#issuecomment-447427473
@Trotthttps://github.com/Trott
https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1952/pipelinehttps://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1952/pipeline
Please reload this pagehttps://github.com/nodejs/node/pull/25048
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/25048#issuecomment-447427572
https://ci.nodejs.org/job/node-test-pull-request/19536/https://ci.nodejs.org/job/node-test-pull-request/19536/
Please reload this pagehttps://github.com/nodejs/node/pull/25048
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/25048#issuecomment-447428290
Please reload this pagehttps://github.com/nodejs/node/pull/25048
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 14, 2018https://github.com/nodejs/node/pull/25048#event-2027610912
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 22, 2018https://github.com/nodejs/node/pull/25048#event-2041961863
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
December 22, 2018 04:46https://github.com/nodejs/node/pull/25048#event-2041961906
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 22, 2018https://github.com/nodejs/node/pull/25048#issuecomment-449545126
2bedbdbhttps://github.com/nodejs/node/commit/2bedbdbe8ae1686b4bbea6681a00bec7644afaef
Please reload this pagehttps://github.com/nodejs/node/pull/25048
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 22, 2018https://github.com/nodejs/node/pull/25048#event-2041962874
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
December 22, 2018 04:50https://github.com/nodejs/node/pull/25048#event-2041962913
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 22, 2018 https://github.com/nodejs/node/pull/25048#ref-pullrequest-393620696
v8.15.0 proposal #25177 https://github.com/nodejs/node/pull/25177
2018-12-26 Version 8.15.0 'Carbon' (LTS) @MylesBorins beevelop/docker-nodejs#253 https://github.com/beevelop/docker-nodejs/issues/253
2018-12-26 Version 8.15.0 'Carbon' (LTS) @MylesBorins beevelop/docker-android-nodejs#275 https://github.com/beevelop/docker-android-nodejs/issues/275
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:50https://github.com/nodejs/node/pull/25048#event-5890970758
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F25048
https://github.com/MylesBorins
MylesBorins https://github.com/MylesBorins
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
flaky-test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Please reload this pagehttps://github.com/nodejs/node/pull/25048
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/MylesBorins
https://github.com/mcollina
https://github.com/rvagg
https://github.com/nareshgnT
https://github.com/danbev
https://github.com/cjihrig
https://github.com/vsemozhetbyt
https://github.com/tpanthera
https://github.com/indutny
https://github.com/Ajido
https://github.com/DoiChris
https://github.com/VeysonD
https://github.com/apoorvanand
https://github.com/apapirovski
https://github.com/susantruong
https://github.com/na9amura
https://github.com/sagirk
https://github.com/antsmartian
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.